Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

(Updated Oct. 10, 2014, 6:04 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and 
Till Toenshoff.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

(Updated Oct. 10, 2014, 6:04 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and 
Till Toenshoff.


Changes
---

Initialize module manager before everything else.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs (updated)
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 26508: Added --module flag for Mesos master.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56183
---

Ship it!


Ship It!

- Niklas Nielsen


On Oct. 9, 2014, 4:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 4:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56157
---



src/master/flags.hpp


Can we include the JSON syntax here instead of '...'?


- Niklas Nielsen


On Oct. 9, 2014, 4:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 4:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Till Toenshoff]

> On Oct. 10, 2014, 1:17 p.m., Till Toenshoff wrote:
> > src/master/flags.hpp, line 319
> > 
> >
> > Seems you should rephrase this towards "path" or adapt the protobuf 
> > within messages.proto to use "file" instead.
> 
> Kapil Arya wrote:
> There is already a review out to update the protobuf :-) 
> https://reviews.apache.org/r/26529/.

Hah, indeed - I should have checked the dependencies first. Thanks for 
clearifying!


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56131
---


On Oct. 9, 2014, 11:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 11:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

> On Oct. 10, 2014, 9:17 a.m., Till Toenshoff wrote:
> > src/master/flags.hpp, line 319
> > 
> >
> > Seems you should rephrase this towards "path" or adapt the protobuf 
> > within messages.proto to use "file" instead.

There is already a review out to update the protobuf :-) 
https://reviews.apache.org/r/26529/.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56131
---


On Oct. 9, 2014, 7:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 7:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56131
---



src/master/flags.hpp


Seems you should rephrase this towards "path" or adapt the protobuf within 
messages.proto to use "file" instead.


- Till Toenshoff


On Oct. 9, 2014, 11:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 11:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

(Updated Oct. 9, 2014, 7:19 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas Nielsen.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs (updated)
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

(Updated Oct. 9, 2014, 6:29 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas Nielsen.


Changes
---

Updated help message.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs (updated)
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

> On Oct. 9, 2014, 2:15 p.m., Niklas Nielsen wrote:
> > src/module/manager.hpp, lines 30-31
> > 
> >
> > Is this just a fly-by style fix?
> > Why include module.hpp here?

module/manager.hpp uses mesos::ModuleBase type which is defined in 
mesos/module.hpp.  Ideally, this should have been part of the original modules 
patch.


- Kapil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56013
---


On Oct. 9, 2014, 3:05 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 3:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

(Updated Oct. 9, 2014, 3:05 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas Nielsen.


Changes
---

Updated help message.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs (updated)
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya

Re: Review Request 26508: Added --module flag for Mesos master.

[Niklas Nielsen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/#review56013
---



src/master/flags.hpp


s/The value could be a/A/ ?



src/master/flags.hpp


.. that will be loaded and accessible to augment mesos subsystems?

Something that describes what happens to the input :-)



src/master/flags.hpp


Or else what? Modules gets overwritten right?

Or maybe just mentioned that you 'must not'?



src/module/manager.hpp


Is this just a fly-by style fix?
Why include module.hpp here?


- Niklas Nielsen


On Oct. 9, 2014, 10:19 a.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26508/
> ---
> 
> (Updated Oct. 9, 2014, 10:19 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas 
> Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Added --module flag for Mesos master.
> 
> 
> Diffs
> -
> 
>   src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
>   src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
>   src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
>   src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
>   src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 
> 
> Diff: https://reviews.apache.org/r/26508/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Review Request 26508: Added --module flag for Mesos master.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26508/
---

Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas Nielsen.


Repository: mesos-git


Description
---

Added --module flag for Mesos master.


Diffs
-

  src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 
  src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee 
  src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea 
  src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 
  src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 

Diff: https://reviews.apache.org/r/26508/diff/


Testing
---

make check


Thanks,

Kapil Arya