Re: Review Request 27116: Fix Libprocess benchmark OSX

2014-10-23 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27116/#review58167
---

Ship it!


Ship It!

- Till Toenshoff


On Oct. 23, 2014, 11:17 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27116/
> ---
> 
> (Updated Oct. 23, 2014, 11:17 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Till Toenshoff.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> pipe2 does not work on osx. 
> Replace with a helper function that sets up the pipes using pipe() and then 
> stout/os::cloexec().
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b 
> 
> Diff: https://reviews.apache.org/r/27116/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>



Review Request 27116: Fix Libprocess benchmark OSX

2014-10-23 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27116/
---

Review request for mesos, Niklas Nielsen and Till Toenshoff.


Repository: mesos-git


Description
---

pipe2 does not work on osx. 
Replace with a helper function that sets up the pipes using pipe() and then 
stout/os::cloexec().


Diffs
-

  3rdparty/libprocess/src/tests/benchmarks.cpp 79a650b 

Diff: https://reviews.apache.org/r/27116/diff/


Testing
---

make check


Thanks,

Joris Van Remoortere