Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-12 Thread Dominic Hamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/#review61071
---



3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4


do you think we should check for std::recursive_mutex separately? I think 
they landed in g++-4.4 at the same time but i can't find a reference to confirm 
it.


- Dominic Hamon


On Nov. 12, 2014, 1:06 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27350/
> ---
> 
> (Updated Nov. 12, 2014, 1:06 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-2009
> https://issues.apache.org/jira/browse/MESOS-2009
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Introduce mutex to the configure check for Libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 
> 
> Diff: https://reviews.apache.org/r/27350/diff/
> 
> 
> Testing
> ---
> 
> make check on gcc-4.4
> make check on gcc-4.9
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-12 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/
---

(Updated Nov. 12, 2014, 9:06 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Changes
---

Remove _ disambiguator as it's not strictly necessary.
Use a capital for the start of comments.


Bugs: MESOS-2009
https://issues.apache.org/jira/browse/MESOS-2009


Repository: mesos-git


Description
---

Introduce mutex to the configure check for Libprocess


Diffs (updated)
-

  3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 

Diff: https://reviews.apache.org/r/27350/diff/


Testing
---

make check on gcc-4.4
make check on gcc-4.9


Thanks,

Joris Van Remoortere

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-12 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/#review61060
---

Ship it!


FYI, let's replace all of 'synchornizable' and 'synchronizer' with just 
std::mutex and std::recursive_mutex. Here's a POC for that: 
https://reviews.apache.org/r/27925.


3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4


Why does this have an _ prefix?



3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4


s/scope/Scope/g

Sentences start with capital letters! ;-)


- Benjamin Hindman


On Nov. 12, 2014, 7:03 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27350/
> ---
> 
> (Updated Nov. 12, 2014, 7:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-2009
> https://issues.apache.org/jira/browse/MESOS-2009
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Introduce mutex to the configure check for Libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 
> 
> Diff: https://reviews.apache.org/r/27350/diff/
> 
> 
> Testing
> ---
> 
> make check on gcc-4.4
> make check on gcc-4.9
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-12 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/#review61034
---

Ship it!


Ship It!

- Niklas Nielsen


On Nov. 12, 2014, 11:03 a.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27350/
> ---
> 
> (Updated Nov. 12, 2014, 11:03 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-2009
> https://issues.apache.org/jira/browse/MESOS-2009
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Introduce mutex to the configure check for Libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 
> 
> Diff: https://reviews.apache.org/r/27350/diff/
> 
> 
> Testing
> ---
> 
> make check on gcc-4.4
> make check on gcc-4.9
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-12 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/
---

(Updated Nov. 12, 2014, 7:03 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Changes
---

Update comment style.


Bugs: MESOS-2009
https://issues.apache.org/jira/browse/MESOS-2009


Repository: mesos-git


Description
---

Introduce mutex to the configure check for Libprocess


Diffs (updated)
-

  3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 

Diff: https://reviews.apache.org/r/27350/diff/


Testing
---

make check on gcc-4.4
make check on gcc-4.9


Thanks,

Joris Van Remoortere

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-11-10 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/#review60644
---



3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4


Slightly non-idiomatic appended comments. Do you have this snip-it from 
somewhere else?


- Niklas Nielsen


On Oct. 29, 2014, 2:45 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27350/
> ---
> 
> (Updated Oct. 29, 2014, 2:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-2009
> https://issues.apache.org/jira/browse/MESOS-2009
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Introduce mutex to the configure check for Libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 
> 
> Diff: https://reviews.apache.org/r/27350/diff/
> 
> 
> Testing
> ---
> 
> make check on gcc-4.4
> make check on gcc-4.9
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 27350: Libprocess: Introduce mutex configure check

2014-10-29 Thread Dominic Hamon 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/#review59050
---

Ship it!


Great! I'll let Ben determine if we want to move the entire codebase over to 
std::mutex.

- Dominic Hamon


On Oct. 29, 2014, 2:45 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27350/
> ---
> 
> (Updated Oct. 29, 2014, 2:45 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Bugs: MESOS-2009
> https://issues.apache.org/jira/browse/MESOS-2009
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> Introduce mutex to the configure check for Libprocess
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 
> 
> Diff: https://reviews.apache.org/r/27350/diff/
> 
> 
> Testing
> ---
> 
> make check on gcc-4.4
> make check on gcc-4.9
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 27350: Libprocess: Introduce mutex configure check

2014-10-29 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27350/
---

Review request for mesos, Benjamin Hindman and Dominic Hamon.


Bugs: MESOS-2009
https://issues.apache.org/jira/browse/MESOS-2009


Repository: mesos-git


Description
---

Introduce mutex to the configure check for Libprocess


Diffs
-

  3rdparty/libprocess/m4/ax_cxx_compile_stdcxx_11.m4 bf2bd19 

Diff: https://reviews.apache.org/r/27350/diff/


Testing
---

make check on gcc-4.4
make check on gcc-4.9


Thanks,

Joris Van Remoortere