Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Nov. 12, 2014, 7:27 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Changes --- Update comment style. Use shared_from_this() to address Nik's concern. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs (updated) - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review61040 --- Ship it! you need me to commit, right? - Dominic Hamon On Nov. 12, 2014, 11:27 a.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Nov. 12, 2014, 11:27 a.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review61057 --- Patch looks great! Reviews applied: [27354, 27356] All tests passed. - Mesos ReviewBot On Nov. 12, 2014, 7:27 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Nov. 12, 2014, 7:27 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review60872 --- Ship it! Ship It! - Dominic Hamon On Oct. 29, 2014, 3:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 3:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review60877 --- What happened with https://reviews.apache.org/r/27351/diff/# ? - Niklas Nielsen On Oct. 29, 2014, 3:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 3:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
On Nov. 11, 2014, 2:34 p.m., Niklas Nielsen wrote: What happened with https://reviews.apache.org/r/27351/diff/# ? i thought i'd seen this somewhere before! pick one, close the other please :) - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review60877 --- On Oct. 29, 2014, 3:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 3:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
On Nov. 11, 2014, 2:34 p.m., Niklas Nielsen wrote: What happened with https://reviews.apache.org/r/27351/diff/# ? Dominic Hamon wrote: i thought i'd seen this somewhere before! pick one, close the other please :) ah, this is mesos. the other is libprocess. - Dominic --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review60877 --- On Oct. 29, 2014, 3:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 3:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
Re: Review Request 27356: Introduce enable_shared_from_this configure check
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/#review59091 --- Patch looks great! Reviews applied: [27354, 27356] All tests passed. - Mesos ReviewBot On Oct. 29, 2014, 10:51 p.m., Joris Van Remoortere wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27356/ --- (Updated Oct. 29, 2014, 10:51 p.m.) Review request for mesos, Benjamin Hindman and Dominic Hamon. Bugs: MESOS-2012 https://issues.apache.org/jira/browse/MESOS-2012 Repository: mesos-git Description --- * Introduce enable_shared_from_this to the configure check * Document availability of enable_shared_from_this in style guide Diffs - docs/mesos-c++-style-guide.md f50354c m4/ax_cxx_compile_stdcxx_11.m4 72a1080 Diff: https://reviews.apache.org/r/27356/diff/ Testing --- make check on gcc-4.4 make check on gcc-4.9 Thanks, Joris Van Remoortere
