Re: Review Request 29333: Add docker_sock to slave flags
On Feb. 15, 2015, 3:01 a.m., Ben Mahler wrote: src/slave/flags.hpp, line 320 https://reviews.apache.org/r/29333/diff/2/?file=824295#file824295line320 Why not docker_socket ? Why not :) - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review72520 --- On Jan. 17, 2015, 1:35 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 17, 2015, 1:35 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp a4498e6 Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated April 7, 2015, 12:44 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos Description --- Add docker_sock to slave flags Diffs (updated) - src/slave/flags.hpp 3da71af Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review72520 --- src/slave/flags.hpp https://reviews.apache.org/r/29333/#comment118583 Why not docker_socket ? - Ben Mahler On Jan. 17, 2015, 1:35 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 17, 2015, 1:35 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp a4498e6 Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review72497 --- Ship it! Ship It! - Till Toenshoff On Jan. 17, 2015, 1:35 a.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 17, 2015, 1:35 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp a4498e6 Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review69544 --- Ship it! Ship It! - Bernd Mathiske On Jan. 16, 2015, 5:35 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 16, 2015, 5:35 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos-git Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp a4498e6 Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 17, 2015, 1:35 a.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos-git Description --- Add docker_sock to slave flags Diffs (updated) - src/slave/flags.hpp a4498e6 Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/#review67658 --- src/slave/flags.hpp https://reviews.apache.org/r/29333/#comment111719 I'd like this to be disambiguated more explicitly, so that Mesos users who are not familiar with docker yet get the general idea easily, too. the CLI - the docker CLI daemon - docker daemon We need - Mesos needs docker CLI - the docker CLI - Bernd Mathiske On Jan. 6, 2015, 2:18 p.m., Timothy Chen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 6, 2015, 2:18 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos-git Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- (Updated Jan. 6, 2015, 10:18 p.m.) Review request for mesos, Benjamin Hindman and Bernd Mathiske. Repository: mesos-git Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
Review Request 29333: Add docker_sock to slave flags
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29333/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Add docker_sock to slave flags Diffs - src/slave/flags.hpp 670997dc3a702cd5edf33f2e5824c5e4dfe4ecef Diff: https://reviews.apache.org/r/29333/diff/ Testing --- make check Thanks, Timothy Chen
