Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-04-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review80151
---


Patch looks great!

Reviews applied: [30263]

All tests passed.

- Mesos ReviewBot


On April 15, 2015, 2:50 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated April 15, 2015, 2:50 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac 868c041 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make distcheck (with and without CRAM-MD5 installed, Linux & OSX)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-04-14 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---

(Updated April 15, 2015, 2:50 a.m.)


Review request for mesos, Alexander Rojas and Cody Maloney.


Changes
---

Fixed OSX distcheck issue.


Bugs: MESOS-2165
https://issues.apache.org/jira/browse/MESOS-2165


Repository: mesos


Description
---

see summary


Diffs (updated)
-

  configure.ac 868c041 

Diff: https://reviews.apache.org/r/30263/diff/


Testing (updated)
---

make distcheck (with and without CRAM-MD5 installed, Linux & OSX)


Thanks,

Till Toenshoff

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-02-16 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review72666
---

Ship it!


Ship It!

- Niklas Nielsen


On Jan. 26, 2015, 3:11 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated Jan. 26, 2015, 3:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac acc685c 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make check (with and without CRAM-MD5 installed)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-27 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69790
---

Ship it!


Ship It!

- Alexander Rojas


On Jan. 26, 2015, 12:11 p.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated Jan. 26, 2015, 12:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac acc685c 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make check (with and without CRAM-MD5 installed)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69599
---


Patch looks great!

Reviews applied: [30263]

All tests passed.

- Mesos ReviewBot


On Jan. 26, 2015, 11:11 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated Jan. 26, 2015, 11:11 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac acc685c 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make check (with and without CRAM-MD5 installed)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-26 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---

(Updated Jan. 26, 2015, 11:11 a.m.)


Review request for mesos, Alexander Rojas and Cody Maloney.


Changes
---

Addressed Alexander's comment.


Bugs: MESOS-2165
https://issues.apache.org/jira/browse/MESOS-2165


Repository: mesos-git


Description
---

see summary


Diffs (updated)
-

  configure.ac acc685c 

Diff: https://reviews.apache.org/r/30263/diff/


Testing
---

make check (with and without CRAM-MD5 installed)


Thanks,

Till Toenshoff

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-26 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69596
---



configure.ac


I don't know if the autotools code needs to have the same standards as the 
mesos code, but if yes, there's a space lacking here.


- Alexander Rojas


On Jan. 26, 2015, 10:55 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated Jan. 26, 2015, 10:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac acc685c 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make check (with and without CRAM-MD5 installed)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-26 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---

(Updated Jan. 26, 2015, 9:55 a.m.)


Review request for mesos, Alexander Rojas and Cody Maloney.


Bugs: MESOS-2165
https://issues.apache.org/jira/browse/MESOS-2165


Repository: mesos-git


Description
---

see summary


Diffs
-

  configure.ac acc685c 

Diff: https://reviews.apache.org/r/30263/diff/


Testing
---

make check (with and without CRAM-MD5 installed)


Thanks,

Till Toenshoff

Re: Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/#review69589
---


Patch looks great!

Reviews applied: [30263]

All tests passed.

- Mesos ReviewBot


On Jan. 26, 2015, 6:24 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30263/
> ---
> 
> (Updated Jan. 26, 2015, 6:24 a.m.)
> 
> 
> Review request for mesos and Cody Maloney.
> 
> 
> Bugs: MESOS-2165
> https://issues.apache.org/jira/browse/MESOS-2165
> 
> 
> Repository: mesos-git
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   configure.ac acc685c 
> 
> Diff: https://reviews.apache.org/r/30263/diff/
> 
> 
> Testing
> ---
> 
> make check (with and without CRAM-MD5 installed)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Review Request 30263: Added test for CRAM-MD5 support of SASL within configuration phase.

2015-01-25 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30263/
---

Review request for mesos and Cody Maloney.


Bugs: MESOS-2165
https://issues.apache.org/jira/browse/MESOS-2165


Repository: mesos-git


Description
---

see summary


Diffs
-

  configure.ac acc685c 

Diff: https://reviews.apache.org/r/30263/diff/


Testing
---

make check (with and without CRAM-MD5 installed)


Thanks,

Till Toenshoff