Re: Review Request 30441: Query string encode / decode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30441/#review70485 --- Ship it! 3rdparty/libprocess/src/http.cpp https://reviews.apache.org/r/30441/#comment115695 What about only splitting maximum of 2 tokens? 3rdparty/libprocess/src/http.cpp https://reviews.apache.org/r/30441/#comment115696 Same line? 3rdparty/libprocess/src/tests/http_tests.cpp https://reviews.apache.org/r/30441/#comment115697 Let's use 'typedef' until we talk about bringing in both ways and decide on one or the other. Also, s/args/HashmapStringString/ (I think that exists in another test as well). - Benjamin Hindman On Jan. 30, 2015, 3:10 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30441/ --- (Updated Jan. 30, 2015, 3:10 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Query string encode / decode Diffs - 3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86 3rdparty/libprocess/src/decoder.hpp 816846436cd8710c476902146c4df06f09aa9da1 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 Diff: https://reviews.apache.org/r/30441/diff/ Testing --- make distcheck on Ubuntu 14.04 for the series Thanks, Cody Maloney
Re: Review Request 30441: Query string encode / decode
On Jan. 31, 2015, 2:26 a.m., Benjamin Hindman wrote: Small fixes, I'll take care of them! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30441/#review70485 --- On Jan. 30, 2015, 3:10 a.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30441/ --- (Updated Jan. 30, 2015, 3:10 a.m.) Review request for mesos and Benjamin Hindman. Repository: mesos-incubating Description --- Query string encode / decode Diffs - 3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86 3rdparty/libprocess/src/decoder.hpp 816846436cd8710c476902146c4df06f09aa9da1 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 Diff: https://reviews.apache.org/r/30441/diff/ Testing --- make distcheck on Ubuntu 14.04 for the series Thanks, Cody Maloney
Review Request 30441: Query string encode / decode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30441/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Description --- Query string encode / decode Diffs - 3rdparty/libprocess/include/process/http.hpp 9cf05acbb724ab9af8010d1788621d37a0e48e86 3rdparty/libprocess/src/decoder.hpp 816846436cd8710c476902146c4df06f09aa9da1 3rdparty/libprocess/src/http.cpp 869b205656fb73edb9f02a1856d10f79ed1349b4 3rdparty/libprocess/src/tests/http_tests.cpp c71a91d516214d20d3df4c220e4a39a070db3260 Diff: https://reviews.apache.org/r/30441/diff/ Testing --- make distcheck on Ubuntu 14.04 for the series Thanks, Cody Maloney
