Re: Review Request 30962: Enabled environment decorator to override.

2015-04-20 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

(Updated April 20, 2015, 1:16 p.m.)


Review request for mesos, Ben Mahler and Kapil Arya.


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/examples/test_hook_module.cpp 2f2da1c5ef85af06c7f366d38ce5b64f39d0076f 
  src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-11 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review79802
---

Ship it!


Ship It!

- Adam B


On April 7, 2015, 5:57 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated April 7, 2015, 5:57 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-07 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

(Updated April 7, 2015, 5:57 p.m.)


Review request for mesos, Ben Mahler and Kapil Arya.


Changes
---

Addressed Adam's and Kapil's comments.


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
  src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-03 Thread Niklas Nielsen 


> On March 30, 2015, 3:28 a.m., Adam B wrote:
> > src/hook/manager.cpp, line 130
> > 
> >
> > And if (result.isNone()), is that really supposed to mean that this 
> > hook didn't want to modify the env, so the HookManager can leave the 
> > environment as is and move onto the next hook? If so, it's probably worth a 
> > comment, if not a LOG(INFO).

Will leave a comment for now :)


- Niklas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review78191
---


On March 13, 2015, 4:04 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated March 13, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-30 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review78191
---



src/hook/manager.cpp


And if (result.isNone()), is that really supposed to mean that this hook 
didn't want to modify the env, so the HookManager can leave the environment as 
is and move onto the next hook? If so, it's probably worth a comment, if not a 
LOG(INFO).


- Adam B


On March 13, 2015, 4:04 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated March 13, 2015, 4:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-17 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review76819
---

Ship it!



src/examples/test_hook_module.cpp


s/MergeFrom/CopyFrom


- Kapil Arya


On March 13, 2015, 7:04 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated March 13, 2015, 7:04 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-13 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

(Updated March 13, 2015, 4:04 p.m.)


Review request for mesos, Ben Mahler and Kapil Arya.


Changes
---

Rebased


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
  src/hook/manager.cpp 7a4cb09bc221af502e867cfb7fff2900b599ff1f 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-26 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

(Updated Feb. 26, 2015, 5:55 p.m.)


Review request for mesos, Ben Mahler and Kapil Arya.


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
  src/hook/manager.cpp 3fd9d5e7f81e3d0ca2aca4091beba4ae555ae7e7 
  src/slave/slave.cpp 9f31fa46304398e8f87b41b55d8f4cfd4aba10b9 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-22 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review73455
---

Ship it!



src/hook/manager.cpp


s/executorInfo/executorInfo_


- Kapil Arya


On Feb. 13, 2015, 6:28 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated Feb. 13, 2015, 6:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
>   src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 
>   src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review73180
---



src/hook/manager.cpp


Same as the parent diff. I think we need to pass `executorInfo_` rather 
than `executorInfo` here?


- Michael Park


On Feb. 13, 2015, 11:28 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated Feb. 13, 2015, 11:28 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
>   src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 
>   src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-13 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

(Updated Feb. 13, 2015, 3:28 p.m.)


Review request for mesos, Ben Mahler and Kapil Arya.


Summary (updated)
-

Enabled environment decorator to override.


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs (updated)
-

  src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
  src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 
  src/slave/slave.cpp ec7ec1356e745bb07484ae1755c9183b038043b3 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-12 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/#review72302
---



src/hook/manager.cpp


Same as the parent diff.  Need to modify executorInfo before calling the 
next hook.


- Kapil Arya


On Feb. 12, 2015, 8:13 p.m., Niklas Nielsen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30962/
> ---
> 
> (Updated Feb. 12, 2015, 8:13 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Kapil Arya.
> 
> 
> Bugs: MESOS-2351
> https://issues.apache.org/jira/browse/MESOS-2351
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary
> 
> 
> Diffs
> -
> 
>   src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
>   src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 
> 
> Diff: https://reviews.apache.org/r/30962/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Review Request 30962: Enabled environment decorator to override.

2015-02-12 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30962/
---

Review request for mesos, Ben Mahler and Kapil Arya.


Bugs: MESOS-2351
https://issues.apache.org/jira/browse/MESOS-2351


Repository: mesos


Description
---

See summary


Diffs
-

  src/examples/test_hook_module.cpp 8faf6850aafcebda7e9f0d1b735d61f7effa842d 
  src/hook/manager.cpp a6938d09851898dd5853d86231c9f9d9db15729b 

Diff: https://reviews.apache.org/r/30962/diff/


Testing
---

make check


Thanks,

Niklas Nielsen