Re: Review Request 32058: Added protobuf-JSON validation

2015-04-16 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review80333
---



3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp


Just as Vinod commented on the JIRA, we might want  to do that differently 
- e.g. by adding a factory.


- Till Toenshoff


On March 16, 2015, 8:02 p.m., Akanksha Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32058/
> ---
> 
> (Updated March 16, 2015, 8:02 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-1194
> https://issues.apache.org/jira/browse/MESOS-1194
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added protobuf-JSON validation
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2c020d98b94995bce862ac3b9c173dd64ed1198d 
> 
> Diff: https://reviews.apache.org/r/32058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>

Re: Review Request 32058: Added protobuf-JSON validation

2015-03-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review76657
---


Patch looks great!

Reviews applied: [32058]

All tests passed.

- Mesos ReviewBot


On March 16, 2015, 8:02 p.m., Akanksha Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32058/
> ---
> 
> (Updated March 16, 2015, 8:02 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-1194
> https://issues.apache.org/jira/browse/MESOS-1194
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added protobuf-JSON validation
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2c020d98b94995bce862ac3b9c173dd64ed1198d 
> 
> Diff: https://reviews.apache.org/r/32058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>

Re: Review Request 32058: Added protobuf-JSON validation

2015-03-16 Thread Akanksha Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/
---

(Updated March 16, 2015, 8:02 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Removed blank lines


Bugs: MESOS-1194
https://issues.apache.org/jira/browse/MESOS-1194


Repository: mesos


Description
---

Added protobuf-JSON validation


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
2c020d98b94995bce862ac3b9c173dd64ed1198d 

Diff: https://reviews.apache.org/r/32058/diff/


Testing
---


Thanks,

Akanksha Agrawal

Re: Review Request 32058: Added protobuf-JSON validation

2015-03-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review76485
---


Patch looks great!

Reviews applied: [32058]

All tests passed.

- Mesos ReviewBot


On March 14, 2015, 12:13 p.m., Akanksha Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32058/
> ---
> 
> (Updated March 14, 2015, 12:13 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-1194
> https://issues.apache.org/jira/browse/MESOS-1194
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added protobuf-JSON validation
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2c020d98b94995bce862ac3b9c173dd64ed1198d 
> 
> Diff: https://reviews.apache.org/r/32058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>

Re: Review Request 32058: Added protobuf-JSON validation

2015-03-14 Thread Akanksha Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/
---

(Updated March 14, 2015, 12:13 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Removed blank lines


Bugs: MESOS-1194
https://issues.apache.org/jira/browse/MESOS-1194


Repository: mesos


Description
---

Added protobuf-JSON validation


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
2c020d98b94995bce862ac3b9c173dd64ed1198d 

Diff: https://reviews.apache.org/r/32058/diff/


Testing
---


Thanks,

Akanksha Agrawal

Re: Review Request 32058: Added protobuf-JSON validation

2015-03-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/#review76439
---


Patch looks great!

Reviews applied: [32058]

All tests passed.

- Mesos ReviewBot


On March 13, 2015, 8:34 p.m., Akanksha Agrawal wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32058/
> ---
> 
> (Updated March 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-1194
> https://issues.apache.org/jira/browse/MESOS-1194
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added protobuf-JSON validation
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
> 2c020d98b94995bce862ac3b9c173dd64ed1198d 
> 
> Diff: https://reviews.apache.org/r/32058/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akanksha Agrawal
> 
>

Review Request 32058: Added protobuf-JSON validation

2015-03-13 Thread Akanksha Agrawal 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32058/
---

Review request for mesos and Till Toenshoff.


Bugs: MESOS-1194
https://issues.apache.org/jira/browse/MESOS-1194


Repository: mesos


Description
---

Added protobuf-JSON validation


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp 
2c020d98b94995bce862ac3b9c173dd64ed1198d 

Diff: https://reviews.apache.org/r/32058/diff/


Testing
---


Thanks,

Akanksha Agrawal