Re: Review Request 32747: libprocess: Place noreturn attribute correctly for C11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32747/ --- (Updated April 13, 2015, 9:20 p.m.) Review request for mesos and Till Toenshoff. Changes --- Update description to include that this is changing a patch to libev, not libprocess itself. Bugs: MESOS-2550 https://issues.apache.org/jira/browse/MESOS-2550 Repository: mesos Description (updated) --- libprocess: Place bundled libev noreturn attribute correctly for C11 The bundled libev uses different noreturn attributes based on whether it is compiled with C11 or not. The C11 codepath places the noreturn attribute in an incorrect (but accepted by GCC) location. Move it to the standard location which is accepted by all supported compilers. Diffs - 3rdparty/libprocess/3rdparty/libev-4.15.patch 2b94532634bf4fb69523cdfa26254de6c537d689 Diff: https://reviews.apache.org/r/32747/diff/ Testing --- See last in series: #32749 Thanks, Cody Maloney
Re: Review Request 32747: libprocess: Place noreturn attribute correctly for C11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32747/ --- (Updated April 13, 2015, 9:01 p.m.) Review request for mesos and Till Toenshoff. Changes --- Add mesos group Bugs: MESOS-2550 https://issues.apache.org/jira/browse/MESOS-2550 Repository: mesos Description --- libprocess: Place noreturn attribute correctly for C11 Diffs - 3rdparty/libprocess/3rdparty/libev-4.15.patch 2b94532634bf4fb69523cdfa26254de6c537d689 Diff: https://reviews.apache.org/r/32747/diff/ Testing --- See last in series: #32749 Thanks, Cody Maloney
Re: Review Request 32747: libprocess: Place noreturn attribute correctly for C11
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32747/#review79942 --- Ship it! Let's add to summary and/or description that we are targetting libev specifically with this patch. - Till Toenshoff On April 13, 2015, 9:01 p.m., Cody Maloney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32747/ --- (Updated April 13, 2015, 9:01 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-2550 https://issues.apache.org/jira/browse/MESOS-2550 Repository: mesos Description --- libprocess: Place noreturn attribute correctly for C11 Diffs - 3rdparty/libprocess/3rdparty/libev-4.15.patch 2b94532634bf4fb69523cdfa26254de6c537d689 Diff: https://reviews.apache.org/r/32747/diff/ Testing --- See last in series: #32749 Thanks, Cody Maloney
