Re: Review Request 32891: Support for entering and configuring a Linux chroot.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/#review79947
---



src/linux/fs.cpp


Copy comments from the other review, can you support `Option 
options` for fs::mount as well?


- Jie Yu


On April 6, 2015, 6 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32891/
> ---
> 
> (Updated April 6, 2015, 6 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-2350
> https://issues.apache.org/jira/browse/MESOS-2350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for entering and configuring a Linux chroot.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
>   src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 
> 
> Diff: https://reviews.apache.org/r/32891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Re: Review Request 32891: Support for entering and configuring a Linux chroot.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/#review79936
---

Ship it!


Could you add a TODO for adding a unit test for fs::enter? You probably can 
construct the new root by copying files from host file systems and do a clone 
using subprocess.


src/linux/fs.hpp


Do you want to expose these functions, or these are just helper functions 
used by fs::enter? Let's not expose these functions until we find a use case.



src/linux/fs.hpp


Can you add some comments (i.e., a short summary) about this interface?

More specifically, you should call out in the comments that this function 
should only be used with mount namespace.



src/linux/fs.cpp


One additional line above.



src/linux/fs.cpp


```
namespace internal {

struct Mount
{
  ...
};

struct Symlink
{
  ...
};

} // namespace internal {
```

Does the above work?



src/linux/fs.cpp


Put '{' to the next line.



src/linux/fs.cpp


Mind putting this function as well as createStandardDevices into internal 
namespace as they are not exposed.



src/linux/fs.cpp


One blank line above.



src/linux/fs.cpp


"/tmp exists in the new root and is writable;..."


- Jie Yu


On April 6, 2015, 6 p.m., Ian Downes wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32891/
> ---
> 
> (Updated April 6, 2015, 6 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.
> 
> 
> Bugs: MESOS-2350
> https://issues.apache.org/jira/browse/MESOS-2350
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support for entering and configuring a Linux chroot.
> 
> 
> Diffs
> -
> 
>   src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
>   src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 
> 
> Diff: https://reviews.apache.org/r/32891/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Review Request 32891: Support for entering and configuring a Linux chroot.

[Ian Downes]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32891/
---

Review request for mesos, Chi Zhang, Jay Buffington, Jie Yu, and James Peach.


Bugs: MESOS-2350
https://issues.apache.org/jira/browse/MESOS-2350


Repository: mesos


Description
---

Support for entering and configuring a Linux chroot.


Diffs
-

  src/linux/fs.hpp d7832a4b3761c48be6c1ccef58a30ee31c70dc1b 
  src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 

Diff: https://reviews.apache.org/r/32891/diff/


Testing
---


Thanks,

Ian Downes