Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-20 Thread Niklas Nielsen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/#review80796
---

Ship it!



docs/engineering-principles-and-practices.md


Long lines :) Do you think it is worth applying the 80 col style? If so, we 
should do a scan.

s/**high quality**, **robust** code/**high quality** and **robust** code/?


- Niklas Nielsen


On April 8, 2015, 5:30 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32999/
> ---
> 
> (Updated April 8, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a document for engineering principles and practices.
> 
> 
> Diffs
> -
> 
>   docs/engineering-principles-and-practices.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32999/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-09 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/#review79520
---

Ship it!


This really is great Ben.


docs/home.md


Should the link have a trailing slash as the others do?


- Till Toenshoff


On April 9, 2015, 12:30 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32999/
> ---
> 
> (Updated April 9, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a document for engineering principles and practices.
> 
> 
> Diffs
> -
> 
>   docs/engineering-principles-and-practices.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32999/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/#review79463
---


Patch looks great!

Reviews applied: [32995, 32996, 32997, 32998, 32999]

All tests passed.

- Mesos ReviewBot


On April 9, 2015, 12:30 a.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32999/
> ---
> 
> (Updated April 9, 2015, 12:30 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a document for engineering principles and practices.
> 
> 
> Diffs
> -
> 
>   docs/engineering-principles-and-practices.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32999/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/#review79461
---

Ship it!


Love it! There are probably more values we can add, but this is a great start.


docs/engineering-principles-and-practices.md


s/allows us identify/allows us to identify/
s/allows to iterate/allows us to iterate/


- Adam B


On April 8, 2015, 5:30 p.m., Ben Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32999/
> ---
> 
> (Updated April 8, 2015, 5:30 p.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a document for engineering principles and practices.
> 
> 
> Diffs
> -
> 
>   docs/engineering-principles-and-practices.md PRE-CREATION 
>   docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 
> 
> Diff: https://reviews.apache.org/r/32999/diff/
> 
> 
> Testing
> ---
> 
> N/A
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Review Request 32999: Added a document for engineering principles and practices.

2015-04-08 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32999/
---

Review request for mesos, Adam B, Benjamin Hindman, Jie Yu, Niklas Nielsen, and 
Vinod Kone.


Repository: mesos


Description
---

Added a document for engineering principles and practices.


Diffs
-

  docs/engineering-principles-and-practices.md PRE-CREATION 
  docs/home.md 6ab61f85aa7d62e0f19267b886dffb4e0aa826ea 

Diff: https://reviews.apache.org/r/32999/diff/


Testing
---

N/A


Thanks,

Ben Mahler