----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33413/ -----------------------------------------------------------
Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone. Bugs: MESOS-2367 https://issues.apache.org/jira/browse/MESOS-2367 Repository: mesos Description ------- Changed the isolator recover interface to take a set of orphan containers detected by the launcher. The idea is to let each isolator only cleanup "unknown" orphans during recovery. The cleanup of "known" orphans are controlled by the containerizer. This patch passes the known orphans to each isolator. The actual cleanup logics will be in the later patches. Diffs ----- include/mesos/slave/isolator.hpp 7cbce426cbf999980eedb0114ee2ae375ba758de src/slave/containerizer/isolator.cpp a6ad1d565348062c80db11b3b27b1c7a0119e319 src/slave/containerizer/isolators/cgroups/cpushare.hpp f72ebb1d52ecd8ab4853f13f386b688db1eece4f src/slave/containerizer/isolators/cgroups/cpushare.cpp 41b2597098a81baffae19fa91d6c9a86cf60d429 src/slave/containerizer/isolators/cgroups/mem.hpp d510bc0f88863fe54d1c892282a41b709098fb11 src/slave/containerizer/isolators/cgroups/mem.cpp a7a83ef9ad4726aa139a92fc7f5917ed687d33f5 src/slave/containerizer/isolators/cgroups/perf_event.hpp 9f35ed0ee2c2d749a329f5cb537c3257a94e5676 src/slave/containerizer/isolators/cgroups/perf_event.cpp 4dfccc51035b234c31a9f73ca67b3bf0fd28441b src/slave/containerizer/isolators/filesystem/shared.hpp 764a45caf3805b3c2f51c167813e8351530dd183 src/slave/containerizer/isolators/filesystem/shared.cpp d5abea2a7948b0d62ab5f3720066d513ee7d9564 src/slave/containerizer/isolators/namespaces/pid.hpp 6a7be802039f29d852edb0463a0748fd7cf71c4c src/slave/containerizer/isolators/namespaces/pid.cpp eb35ae6e34fa46dd38c9a96e69d38a229b3678d3 src/slave/containerizer/isolators/network/port_mapping.hpp 466cd82e69665af217d61392b739b9bba16e1e13 src/slave/containerizer/isolators/network/port_mapping.cpp ccdc44f465f204f674b859c429ba1a6ada51cd88 src/slave/containerizer/isolators/posix.hpp fc31cece3996a723aefeec14c4d2c9cea2db5016 src/slave/containerizer/isolators/posix/disk.hpp 0ccb1738f6501dfa8c285da4fad0d1c9afbf272d src/slave/containerizer/isolators/posix/disk.cpp d2ea3b149fbe997a81e7989dfc0f96d817f2ae8d src/slave/containerizer/mesos/containerizer.hpp ae61a0fcd19f2ba808624312401f020121baf5d4 src/slave/containerizer/mesos/containerizer.cpp e4136095fca55637864f495098189ab3ad8d8fe7 src/tests/isolator.hpp 93537cb7f82ff0e44e0b53b3453fdd4879493435 Diff: https://reviews.apache.org/r/33413/diff/ Testing ------- make check Thanks, Jie Yu