Re: Unzip should work in non interactive mode

2016-03-19 Thread Jie Yu
I can shepherd it. Do you have a patch ready?

- Jie

On Fri, Mar 18, 2016 at 3:13 AM, Tomek Janiszewski 
wrote:

> Hi
>
> Consider situation when deployed zip file is malformed and contains
> duplicated files .
> When fetcher downloads malformed zip file, that contains duplicated files
> (e.g., dist zips generated by gradle) and try to uncompress it, deployment
> hang in staged phase because unzip prompt if file should be replaced. unzip
> should overwrite this file or break with error. I created issue for this
> MESOS-4885
> It looks like easy fix, anyone want to shepherd it?
>
> Best
> Tomek
>


Unzip should work in non interactive mode

2016-03-19 Thread Tomek Janiszewski
Hi

Consider situation when deployed zip file is malformed and contains
duplicated files .
When fetcher downloads malformed zip file, that contains duplicated files
(e.g., dist zips generated by gradle) and try to uncompress it, deployment
hang in staged phase because unzip prompt if file should be replaced. unzip
should overwrite this file or break with error. I created issue for this
MESOS-4885
It looks like easy fix, anyone want to shepherd it?

Best
Tomek


Re: Unzip should work in non interactive mode

2016-03-18 Thread Tomek Janiszewski
Patch is ready https://reviews.apache.org/r/45057/diff/1/

pt., 18.03.2016 o 16:43 użytkownik Jie Yu  napisał:

> I can shepherd it. Do you have a patch ready?
>
> - Jie
>
> On Fri, Mar 18, 2016 at 3:13 AM, Tomek Janiszewski 
> wrote:
>
> > Hi
> >
> > Consider situation when deployed zip file is malformed and contains
> > duplicated files .
> > When fetcher downloads malformed zip file, that contains duplicated files
> > (e.g., dist zips generated by gradle) and try to uncompress it,
> deployment
> > hang in staged phase because unzip prompt if file should be replaced.
> unzip
> > should overwrite this file or break with error. I created issue for this
> > MESOS-4885
> > It looks like easy fix, anyone want to shepherd it?
> >
> > Best
> > Tomek
> >
>