Re: [VOTE] Apache MetaModel release 5.3.2
+1 On Fri, Jan 3, 2020 at 10:41 AM Arjan Seijkens Hagemans wrote: > Hi All, > > Please vote on releasing the following candidate as Apache Metamodel > version 5.3.2. > > The Git tag to be voted on is MetaModel-5.3.2: > > https://gitbox.apache.org/repos/asf?p=metamodel.git;a=commit;h=ec4cd25d6e21d6eb85cc42ca4ba805e0e383488b > > The source artifact to be voted on is: > > https://repository.apache.org/content/repositories/orgapachemetamodel-1043/org/apache/metamodel/MetaModel/5.3.2/MetaModel-5.3.2-source-release.zip > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > https://repository.apache.org/content/repositories/orgapachemetamodel-1043/org/apache/metamodel/MetaModel/5.3.2/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/arjansh.asc > > Release engineer public key id: 750FB127 > > The staging Maven repository for this release can be found at: > http://repository.apache.org/content/repositories/orgapachemetamodel-1043 > > Please vote on releasing this package as Apache MetaModel 5.3.2. > > The vote is open for 72 hours. > > [ ] +1 Release this package as Apache MetaModel 5.3.2 > [ ] -1 Do not release this package because ... > > Thank you in advance for participating. > > Regards, > Arjan Seijkens >
Re: [VOTE] Apache MetaModel release 5.3.1
+1 On Wed, 11 Sep 2019, 16:35 Kasper Sørensen, wrote: > I see that the signature file is now available. And the gpg verification > passes. > > +1 > > Den man. 9. sep. 2019 kl. 23.05 skrev Kasper Sørensen < > i.am.kasper.soren...@gmail.com>: > > > -1 because the referenced committer key file [1] does not seem to exist. > > The apache people site [2] has some info on getting your key registered. > > > > Willing to change my vote once the key file exists and the artifacts > > signature matches it :-) > > > > [1] https://people.apache.org/keys/committer/arjansh.asc > > [2] http://people.apache.org/keys/ > > > > Den man. 9. sep. 2019 kl. 10.24 skrev Lutzen Luinenburg < > > l.luinenb...@humaninference.com>: > > > >> +1 > >> > >> > >> Kind regards, > >> > >> Lútzen Luinenburg > >> Product Development Manager > >> > >> > >> > >> > >> -Original Message- > >> From: Arjan Seijkens Hagemans > >> Sent: Monday, 9 September 2019 10:06 > >> To: dev@metamodel.apache.org > >> Subject: [VOTE] Apache MetaModel release 5.3.1 > >> > >> Hi All, > >> > >> Please vote on releasing the following candidate as Apache Metamodel > >> version 5.3.1. > >> > >> The Git tag to be voted on is MetaModel-5.3.1: > >> > >> > https://gitbox.apache.org/repos/asf?p=metamodel.git;a=commit;h=1c6ab1fdb8f53415b86df05c9ed09b380b9eef61 > >> > >> The source artifact to be voted on is: > >> > >> > http://repository.apache.org/content/repositories/orgapachemetamodel-1042/org/apache/metamodel/MetaModel/5.3.1/MetaModel-5.3.1-source-release.zip > >> > >> Parent directory (including MD5, SHA1 hashes etc.) of the source is: > >> > >> > http://repository.apache.org/content/repositories/orgapachemetamodel-1042/org/apache/metamodel/MetaModel/5.3.1/ > >> > >> Release artifacts are signed with the following key: > >> https://people.apache.org/keys/committer/arjansh.asc > >> > >> Release engineer public key id: 750FB127 > >> > >> The staging Maven repository for this release can be found at: > >> > http://repository.apache.org/content/repositories/orgapachemetamodel-1042 > >> > >> Please vote on releasing this package as Apache MetaModel 5.3.1. > >> > >> The vote is open for 72 hours. > >> > >> [ ] +1 Release this package as Apache MetaModel 5.3.1 [ ] -1 Do not > >> release this package because ... > >> > >> Thank you in advance for participating. > >> > >> Regards, > >> Arjan Seijkens > >> > > >
Re: [VOTE] Apache MetaModel release 5.3.0
+1 On Mon, Apr 1, 2019 at 8:16 PM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > Hi All, > > Please vote on releasing the following candidate as Apache Metamodel > version 5.3.0. > > The Git tag to be voted on is MetaModel-5.3.0: > > https://gitbox.apache.org/repos/asf?p=metamodel.git;a=commit;h=bfc9224f94a48851eeed3f0d43a88c1a1d527f8d > > The source artifact to be voted on is: > > http://repository.apache.org/content/repositories/orgapachemetamodel-1041/org/apache/metamodel/MetaModel/5.3.0/MetaModel-5.3.0-source-release.zip > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > http://repository.apache.org/content/repositories/orgapachemetamodel-1041/org/apache/metamodel/MetaModel/5.3.0/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/kaspersor.asc > > Release engineer public key id: 1FE1C2F5 > > The staging Maven repository for this release can be found at: > http://repository.apache.org/content/repositories/orgapachemetamodel-1041 > > Please vote on releasing this package as Apache MetaModel 5.3.0. > > The vote is open for 72 hours. > > [ ] +1 Release this package as Apache MetaModel 5.3.0 > [ ] -1 Do not release this package because ... > > Thank you in advance for participating. > > Regards, > Kasper Sørensen >
Re: [VOTE] Apache Metamodel release 5.2.1
+1 On Tue, Mar 5, 2019 at 6:11 AM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > Hi All, > > Please vote on releasing the following candidate as Apache Metamodel > version 5.2.1. > > The Git tag to be voted on is MetaModel-5.2.1: > > https://gitbox.apache.org/repos/asf?p=metamodel.git;a=tag;h=387c2f76c6ebb9df8c806de06a491bb0f578e8f1 > > The source artifact to be voted on is: > > https://repository.apache.org/content/repositories/orgapachemetamodel-1040/org/apache/metamodel/MetaModel/5.2.1/MetaModel-5.2.1-source-release.zip > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > https://repository.apache.org/content/repositories/orgapachemetamodel-1040/org/apache/metamodel/MetaModel/5.2.1/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/kaspersor.asc > > Release engineer public key id: 1FE1C2F5 > > The staging Maven repository for this release can be found at: > https://repository.apache.org/content/repositories/orgapachemetamodel-1040 > > Please vote on releasing this package as Apache MetaModel 5.2.1. > > The vote is open for 72 hours. > > [ ] +1 Release this package as Apache MetaModel 5.2.1 > [ ] -1 Do not release this package because ... > > Thank you in advance for participating. > > Regards, > Kasper Sørensen >
Re: [VOTE] Initiate the migration to Apache gitbox
+1 On Tue, Jan 8, 2019 at 8:11 AM Arjan Seijkens wrote: > +1 > > -Original Message- > From: Kasper Sørensen > Sent: Tuesday, January 8, 2019 1:16 AM > To: dev@metamodel.apache.org > Subject: Re: [VOTE] Initiate the migration to Apache gitbox > > +1 > > Den man. 7. jan. 2019 kl. 16.15 skrev Kasper Sørensen < > i.am.kasper.soren...@gmail.com>: > > > Hi all, > > > > As you have maybe seen in the mail thread "[NOTICE] Mandatory > > migration of git repositories to gitbox.apache.org" [1], we need to > > change our Git repository to be hosted by Apache gitbox. This happens > > automatically on Feb 7, but INFRA would like to do it earlier for > > those projects that are capable of doing that. > > > > I think we're ready to do it. Let's have a VOTE for the next 72 hours > > and unless there are compelling reasons to NOT move, we shall let > > INFRA know that we're ready. > > > > Best regards, > > Kasper > > > > [1] > > http://mail-archives.apache.org/mod_mbox/metamodel-dev/201901.mbox/ > > <154652152635.18883.1644020783020365096.gitbox%40gitbox.apache.org> > > >
Re: [VOTE] Apache MetaModel release 5.2.0
+1 On Sat, Dec 8, 2018 at 7:38 PM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > Hi All, > > I've staged a release of Apache Metamodel version 5.2.0 and would like to > call for a vote on releasing it. > > The Git tag to be voted on is MetaModel-5.2.0: > > https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h=6cb8a164b8b1a4b4bccbd5234b7d05525a819ca9 > > The source artifact to be voted on is: > > http://repository.apache.org/content/repositories/orgapachemetamodel-1039/org/apache/metamodel/MetaModel/5.2.0/MetaModel-5.2.0-source-release.zip > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > http://repository.apache.org/content/repositories/orgapachemetamodel-1039/org/apache/metamodel/MetaModel/5.2.0/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/kaspersor.asc > > Release engineer public key id: 1FE1C2F5 > > The staging Maven repository for this release can be found at: > http://repository.apache.org/content/repositories/orgapachemetamodel-1039 > > Please vote on releasing this package as Apache MetaModel 5.2.0. > > The vote is open for 72 hours. > > [ ] +1 Release this package as Apache MetaModel 5.2.0 > [ ] -1 Do not release this package because ... > > Thank you in advance for participating. > > Regards, > Kasper >
Re: [postgres] Insert and Update execution fails if table column name contains Upper case
I do believe that if it should work if the table was created without quotes. It's the other way around that seems to be the issue: Quoted creation making it case-sensitive, and the insert somehow lower-casing column names in the request. I looked at the JDBC driver connection parameters ( https://jdbc.postgresql.org/documentation/head/connect.html#connection-parameters), but it doesn't really lowercase requests. There's a enabled-by-default "column sanitizer", which lower cases column names in the response (which is pretty weird to me, if case sensitive columns are possible, but okay), but nothing the other way. BR, Dennis On Mon, Nov 5, 2018 at 5:43 AM Vijay Kumar Jalagari wrote: > No, table is not created using Metamodel, It was pre-existing table. > > Regards, > Vijay Kumar J > > -Original Message- > From: Kasper Sørensen > Sent: Saturday, November 3, 2018 4:47 AM > To: dev@metamodel.apache.org > Subject: Re: [postgres] Insert and Update execution fails if table column > name contains Upper case > > I don't have much insight. One thought though: Are you doing these > inserts/updates with the same DataContext that you used for creating the > table? Or was the table pre-existing? I'm asking because I guess it could > be related to the CREATE TABLE which defined the column names too. And if > MetaModel is responsible for creating the columns, but maybe not quoting > their names at that time, then I could see a discrepancy occuring when you > try to insert. So is that a possibility? > > Den fre. 2. nov. 2018 kl. 03.05 skrev Dennis Krøger : > > > According to > > > > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p > > ostgresql.org%2Fdocs%2Fcurrent%2Fstatic%2Fsql-syntax-lexical.html%23SQ > > L-SYNTAX-IDENTIFIERS&data=02%7C01%7Cjalagari%40adobe.com%7C8b03788 > > c5d2d41d2334b08d641198126%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7 > > C636767975130637553&sdata=auMPtpWSdGgxRn73RuaUqMBXRw5PbH3CCRXvynKm > > XaM%3D&reserved=0 > > , > > columns are case-insensitive if created without quotes, but > > case-sensitive if created with quotes. > > > > I'm not entirely sure how we're handling that. It's not really a > > difference the table creation classes handles AFAIK, and I suspect we > > don't really expect case-sensitivity in PostgreSQL tables, but it's > > been quite a while for me, so I might remember wrong. > > > > Kasper, do you have some more insight? > > > > BR, > > Dennis > > > > On Fri, Nov 2, 2018 at 10:19 AM Vijay Kumar Jalagari > > wrote: > > > > > Hi, > > > > > > I am using Apache metamodel with data source PostgreSQL 11 and while > > > executing insert(InsertInto) or update statement query is failing if > > table > > > column name contains upper characters. > > > According to logs statement is generating properly but it seems > > postgresql > > > is converting column names to lowercases. > > > > > > Is it know issue? Is there any workaround for resolving it? > > > > > > Logs > > > org.apache.metamodel.jdbc.JdbcUtils Could not execute insert statement: > > > INSERT INTO "public"."employee" > > > (id,name,age,dob,mobileNo,zip,profilePicture,vendor) VALUES > > > (?,?,?,?,?,?,?,?): ERROR: column "mobileno" of relation "employee" > > > does > > not > > > exist > > > Position: 50, Error code=0, SQL state=42703 > > > org.postgresql.util.PSQLException: ERROR: column "mobileno" of > > > relation "employee" does not exist > > > Position: 50 > > > at > > > > > org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExe > > cutorImpl.java:2440) > > > [org.postgresql.jdbc42:42.2.5] > > > at > > > > > org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorI > > mpl.java:2183) > > > [org.postgresql.jdbc42:42.2.5] > > > at > > > > > org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.jav > > a:308) > > > [org.postgresql.jdbc42:42.2.5] > > > at > > > org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:441 > > > ) > > > [org.postgresql.jdbc42:42.2.5] > > > at > > > org.postgresql.jdbc.PgStatement.execute(PgStatement.java:365) > > > [org.postgresql.jdbc42:42.2.5] > > > at > > > > > or
Re: [postgres] Insert and Update execution fails if table column name contains Upper case
According to https://www.postgresql.org/docs/current/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS, columns are case-insensitive if created without quotes, but case-sensitive if created with quotes. I'm not entirely sure how we're handling that. It's not really a difference the table creation classes handles AFAIK, and I suspect we don't really expect case-sensitivity in PostgreSQL tables, but it's been quite a while for me, so I might remember wrong. Kasper, do you have some more insight? BR, Dennis On Fri, Nov 2, 2018 at 10:19 AM Vijay Kumar Jalagari wrote: > Hi, > > I am using Apache metamodel with data source PostgreSQL 11 and while > executing insert(InsertInto) or update statement query is failing if table > column name contains upper characters. > According to logs statement is generating properly but it seems postgresql > is converting column names to lowercases. > > Is it know issue? Is there any workaround for resolving it? > > Logs > org.apache.metamodel.jdbc.JdbcUtils Could not execute insert statement: > INSERT INTO "public"."employee" > (id,name,age,dob,mobileNo,zip,profilePicture,vendor) VALUES > (?,?,?,?,?,?,?,?): ERROR: column "mobileno" of relation "employee" does not > exist > Position: 50, Error code=0, SQL state=42703 > org.postgresql.util.PSQLException: ERROR: column "mobileno" of relation > "employee" does not exist > Position: 50 > at > org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2440) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2183) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:308) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:441) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.jdbc.PgStatement.execute(PgStatement.java:365) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.jdbc.PgPreparedStatement.executeWithFlags(PgPreparedStatement.java:143) > [org.postgresql.jdbc42:42.2.5] > at > org.postgresql.jdbc.PgPreparedStatement.executeUpdate(PgPreparedStatement.java:120) > [org.postgresql.jdbc42:42.2.5] > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown > Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > Source) > at java.lang.reflect.Method.invoke(Unknown Source) > at > org.apache.tomcat.jdbc.pool.interceptor.AbstractQueryReport$StatementProxy.invoke(AbstractQueryReport.java:235) > [org.apache.sling.datasource:1.0.2] > at com.sun.proxy.$Proxy195.executeUpdate(Unknown Source) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native > Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown > Source) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown > Source) > at java.lang.reflect.Method.invoke(Unknown Source) > at > org.apache.tomcat.jdbc.pool.interceptor.StatementDecoratorInterceptor$StatementProxy.invoke(StatementDecoratorInterceptor.java:261) > [org.apache.sling.datasource:1.0.2] > at com.sun.proxy.$Proxy195.executeUpdate(Unknown Source) > at > org.apache.metamodel.jdbc.JdbcSimpleUpdateCallback.executePreparedStatement(JdbcSimpleUpdateCallback.java:45) > [aem-dermis-core:3.0.33.SNAPSHOT] > at > org.apache.metamodel.jdbc.JdbcUpdateCallback.executePreparedStatement(JdbcUpdateCallback.java:71) > [aem-dermis-core:3.0.33.SNAPSHOT] > at > org.apache.metamodel.jdbc.JdbcUpdateCallback.executeInsert(JdbcUpdateCallback.java:272) > [aem-dermis-core:3.0.33.SNAPSHOT] > at > org.apache.metamodel.jdbc.JdbcInsertBuilder.execute(JdbcInsertBuilder.java:85) > [aem-dermis-core:3.0.33.SNAPSHOT] > > > Regards, > Vijay Kumar J > -- Med venlig hilsen, Dennis Du Krøger
Re: [VOTE] Apache Metamodel release 5.1.1
+1 On Wed, Oct 3, 2018 at 4:42 AM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > +1 from myself too :-) > > Den man. 1. okt. 2018 kl. 01.48 skrev Laxmi Lal Menaria < > menarialaxmi...@gmail.com>: > > > +1 > > > > On Mon, Oct 1, 2018 at 12:17 PM Alberto Rodriguez > > wrote: > > > > > +1 > > > > > > El lun., 1 oct. 2018 a las 8:14, Arjan Seijkens (< > > a.seijk...@quadient.com > > > >) > > > escribió: > > > > > > > +1 > > > > > > > > Kind regards, > > > > Arjan Seijkens > > > > > > > > -Original Message- > > > > From: Kasper Sørensen > > > > Sent: Monday, October 1, 2018 5:35 AM > > > > To: dev@metamodel.apache.org > > > > Subject: [VOTE] Apache Metamodel release 5.1.1 > > > > > > > > Hi All, > > > > > > > > I hope you will join this vote to release the following candidate as > > > > Apache Metamodel version 5.1.1. > > > > > > > > The Git tag to be voted on is MetaModel-5.1.1: > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h=d3db702516679ea7ee51fe4f08a9305d1ae90d7a > > > > > > > > The source artifact to be voted on is: > > > > > > > > > > > > > > http://repository.apache.org/content/repositories/orgapachemetamodel-1038/org/apache/metamodel/MetaModel/5.1.1/MetaModel-5.1.1-source-release.zip > > > > > > > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > > > > > > > > > > > > > http://repository.apache.org/content/repositories/orgapachemetamodel-1038/org/apache/metamodel/MetaModel/5.1.1/ > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/kaspersor.asc > > > > > > > > Release engineer public key id: 1FE1C2F5 > > > > > > > > The staging Maven repository for this release can be found at: > > > > > > > > > > http://repository.apache.org/content/repositories/orgapachemetamodel-1038 > > > > > > > > Please vote on releasing this package as Apache MetaModel 5.1.1. > > > > > > > > The vote is open for 72 hours. > > > > > > > > [ ] +1 Release this package as Apache MetaModel 5.1.1 [ ] -1 Do not > > > > release this package because ... > > > > > > > > Thank you in advance for participating. > > > > > > > > Regards, > > > > Kasper > > > > > > > > > > > > > -- > > > > Thanks, > > Laxmilal Menaria | +91 982 955 3793 <+91%2098295%2053793> | > http://laxmilalmenaria.com/ > > > -- Med venlig hilsen, Dennis Du Krøger
Re: [VOTE] Apache MetaModel release 5.1.0
+1 On Mon, Jun 25, 2018 at 8:04 AM Arjan Seijkens wrote: > +1 > > -Original Message- > From: Alberto Rodriguez > Sent: Monday, June 25, 2018 8:04 AM > To: dev@metamodel.apache.org > Subject: Re: [VOTE] Apache MetaModel release 5.1.0 > > +1 > > 2018-06-23 7:31 GMT+02:00 Lutzen Luinenburg : > > > +1 > > > > Van: Kasper Sørensen > > Verzonden: zaterdag 23 juni 2018 06:54:04 > > Aan: dev@metamodel.apache.org > > Onderwerp: Re: [VOTE] Apache MetaModel release 5.1.0 > > > > +1 > > > > Den fre. 22. jun. 2018 kl. 21.53 skrev Kasper Sørensen < > > i.am.kasper.soren...@gmail.com>: > > > > > Hi All, > > > Please vote on releasing the following candidate as Apache Metamodel > > > version 5.1.0. > > > > > > The Git tag to be voted on is MetaModel-5.1.0: > > > > > > https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h= > > ac37546b49d551763f63d9cd65bd664281ef0827 > > > > > > The source artifact to be voted on is: > > > > > > http://repository.apache.org/content/repositories/ > > orgapachemetamodel-1037/org/apache/metamodel/MetaModel/5. > > 1.0/MetaModel-5.1.0-source-release.zip > > > > > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > > > > > http://repository.apache.org/content/repositories/ > > orgapachemetamodel-1037/org/apache/metamodel/MetaModel/5.1.0/ > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/kaspersor.asc > > > > > > Release engineer public key id: 1FE1C2F5 > > > > > > The staging Maven repository for this release can be found at: > > > http://repository.apache.org/content/repositories/ > > orgapachemetamodel-1037 > > > > > > Please vote on releasing this package as Apache MetaModel 5.1.0. > > > > > > The vote is open for 72 hours. > > > > > > [ ] +1 Release this package as Apache MetaModel 5.1.0 [ ] -1 Do not > > > release this package because ... > > > > > > Thank you in advance for participating. > > > > > > Regards, > > > Kasper > > > > > > -- Med venlig hilsen, Dennis Du Krøger
Re: New committer: Jörg Unbehauen
Welcome, Jörg! :) On Mon, May 7, 2018 at 6:04 PM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > Hi everyone, > > I'm happy to announce that we have added another committer to the Apache > MetaModel project: Jörg Unbehauen! > > Jörg, thanks for your contributions already, and thank you for joining the > committers group. > > Best regards, > Kasper > -- Med venlig hilsen, Dennis Du Krøger
Re: [VOTE] Apache MetaModel release 5.1.0-RC1
+1 On Fri, Jan 26, 2018 at 8:20 PM Kasper Sørensen < i.am.kasper.soren...@gmail.com> wrote: > +1 > > 2018-01-25 23:25 GMT-08:00 Alberto Rodriguez : > > > +1 > > > > 2018-01-26 7:32 GMT+01:00 Lutzen Luinenburg : > > > > > +1 > > > > > > Van: Kasper S?rensen > > > Verzonden: vrijdag 26 januari 2018 07:08:59 > > > Aan: dev@metamodel.apache.org > > > Onderwerp: [VOTE] Apache MetaModel release 5.1.0-RC1 > > > > > > Hi All, > > > > > > Please vote on releasing the following candidate as Apache Metamodel > > > version 5.1.0-RC1. > > > > > > The Git tag to be voted on is MetaModel-5.1.0-RC1: > > > https://git-wip-us.apache.org/repos/asf?p=metamodel.git;a=commit;h= > > > 1969a3f13e4bde186328bebb24b6c82c79b7d90a > > > > > > The source artifact to be voted on is: > > > https://repository.apache.org/content/repositories/ > > > orgapachemetamodel-1030/org/apache/metamodel/MetaModel/5. > > > 1.0-RC1/MetaModel-5.1.0-RC1-source-release.zip > > > > > > Parent directory (including MD5, SHA1 hashes etc.) of the source is: > > > https://repository.apache.org/content/repositories/ > > > orgapachemetamodel-1030/org/apache/metamodel/ > > > > > > Release artifacts are signed with the following key: > > > https://people.apache.org/keys/committer/kaspersor.asc > > > > > > Release engineer public key id: https://people.apache.org/ > > > keys/committer/kaspersor.asc > > > > > > The staging Maven repository for this release can be found at: > > > https://repository.apache.org/content/repositories/ > > > orgapachemetamodel-1030/ > > > > > > Please vote on releasing this package as Apache MetaModel 5.1.0-RC1. > > > > > > The vote is open for 72 hours. > > > > > > [ ] +1 Release this package as Apache MetaModel 5.1.0-RC1 > > > [ ] -1 Do not release this package because ... > > > > > > Thank you in advance for participating. > > > > > > Regards, > > > Kasper > > > > > > -- Med venlig hilsen, Dennis Du Krøger
Re: Review Request 35123: METAMODEL-148: Created a HdfsResource
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35123/#review86790 --- hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java <https://reviews.apache.org/r/35123/#comment138869> If we aren't sure how to implement something, let's write that. The auto-TODO comment makes it look like it haven't been considered/looked at. hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java <https://reviews.apache.org/r/35123/#comment138870> Wouldn't it be better to use Arrays.hashCode(_filepath, _hostname, _port) instead of reimplementing it? - Dennis Krøger On June 5, 2015, 12:14 p.m., Kasper Sørensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35123/ > --- > > (Updated June 5, 2015, 12:14 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-148 > https://issues.apache.org/jira/browse/METAMODEL-148 > > > Repository: metamodel > > > Description > --- > > This more or less fixes METAMODEL-148. > > Items I am not sure about: > > * I am not sure if we can implement the isReadOnly() method in any sensible > way? > * I wanted to have as little client-side configuration as possible, so I > create the hadoop Configuration on-the-fly. Maybe it would be good also with > an option to load it from a hadoop conf XML file? > * I updated also hbase to the latest version, but that created a lot of > deprecation warnings, so I should probably rather just leave it alone :-P > > > Diffs > - > > core/src/main/java/org/apache/metamodel/util/Func.java 684411f > core/src/main/java/org/apache/metamodel/util/UncheckedFunc.java > PRE-CREATION > hadoop/.gitignore PRE-CREATION > hadoop/pom.xml PRE-CREATION > hadoop/src/main/java/org/apache/metamodel/util/HdfsResource.java > PRE-CREATION > hadoop/src/test/java/org/apache/metamodel/util/HdfsResourceTest.java > PRE-CREATION > hbase/pom.xml b3ded40 > hbase/src/main/java/org/apache/metamodel/hbase/HBaseDataContext.java > a501790 > pom.xml 5cb93f3 > > Diff: https://reviews.apache.org/r/35123/diff/ > > > Testing > --- > > Only local testing. Needs integration test. > > > Thanks, > > Kasper Sørensen > >
Re: Review Request 34401: METAMODEL-142: Create JDBC table within an UpdateScript and with connection pool returns a null table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34401/#review84286 --- Ship it! Ship It! - Dennis Krøger On May 19, 2015, 9:13 a.m., Kasper Sørensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34401/ > --- > > (Updated May 19, 2015, 9:13 a.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-142 > https://issues.apache.org/jira/browse/METAMODEL-142 > > > Repository: metamodel > > > Description > --- > > Ensured that the refreshing of schema objects inside the update callback > happens using the same JDBC connection as the running transaction is using > > > Diffs > - > > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java > c0a5999 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDropTableBuilder.java > aa3cc98 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcMetadataLoader.java > 54ad378 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcSchema.java 043e477 > jdbc/src/main/java/org/apache/metamodel/jdbc/MetadataLoader.java 3e80426 > > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/AbstractJdbIntegrationTest.java > 6faec03 > > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/SQLServerJtdsDriverTest.java > 52219c0 > > Diff: https://reviews.apache.org/r/34401/diff/ > > > Testing > --- > > Multiple unittests already around this. > Also added an integration test on SQL Server where this issue was causing > even a deadlock situation (because the JTDS driver would block the > refreshSchemas() call to wait until the transaction has finished). > > > Thanks, > > Kasper Sørensen > >
Re: Review Request 34366: METAMODEL-141: ColumnType mapping to common RDBMSes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34366/#review84284 --- Ship it! LGTM, except either a missing test, or an uneeded test method. Nothing important. jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java <https://reviews.apache.org/r/34366/#comment135504> Is this a leftover, or was there supposed to be a test here? - Dennis Krøger On May 18, 2015, 7:43 p.m., Kasper Sørensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34366/ > --- > > (Updated May 18, 2015, 7:43 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-141 > https://issues.apache.org/jira/browse/METAMODEL-141 > > > Repository: metamodel > > > Description > --- > > Made the column type rewriting also aware of column size. > Added an Oracle dialect. > Made many adjustments to column type mapping based on information (wiki, DB > manuals etc.) about which data types are missing/superceeded in various DBs. > > > Diffs > - > > CHANGES.md cff4ce4 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java > c0a5999 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java > f83057e > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java > 03e9318 > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java > 1ac72bc > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HsqldbQueryRewriter.java > cc3d202 > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java > 17140e3 > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/MysqlQueryRewriter.java > 3c0037b > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java > PRE-CREATION > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/PostgresqlQueryRewriter.java > c3fd322 > > jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java > d83d6d2 > jdbc/src/test/java/org/apache/metamodel/dialects/DB2QueryRewriterTest.java > 9108461 > > jdbc/src/test/java/org/apache/metamodel/dialects/MysqlQueryRewriterTest.java > f9aec48 > > jdbc/src/test/java/org/apache/metamodel/dialects/SQLServerQueryRewriterTest.java > fd55486 > > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java > 9794f4c > > Diff: https://reviews.apache.org/r/34366/diff/ > > > Testing > --- > > Only unittesting and some sparse manual testing in MySQL and PostgreSQL. > Not yet integration tested on MS SQL and Oracle. > > > Thanks, > > Kasper Sørensen > >
Review Request 32310: Removes ElasticSearch 1.4.x-incompatible getHeaders()
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32310/ --- Review request for MetaModel. Repository: metamodel Description --- ES 1.4.x has changed the return value of TransportMessage#getHeaders to a Set. As we only use the code for debugging in a single builder, my solution has been to just remove the headers from the delete message. Diffs - elasticsearch/pom.xml 94b36bd elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDeleteBuilder.java 3aae761 Diff: https://reviews.apache.org/r/32310/diff/ Testing --- Thanks, Dennis Krøger
Re: Review Request 31066: METAMODEL-79: Support ElasticSearch operations: insert, create table and drop table
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31066/#review75675 --- Looks good, except the noted issues. But it's a big change, so it probably needs more (and more MM experienced) eyes. elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchCreateTableBuilder.java <https://reviews.apache.org/r/31066/#comment122903> Reject mapping instead, _object_ is not useable for this purpose elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchCreateTableBuilder.java <https://reviews.apache.org/r/31066/#comment122904> Reject mapping instead, _object_ is not useable as a generic type. elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDeleteBuilder.java <https://reviews.apache.org/r/31066/#comment122900> createQueryBuilderForSimpleWhere already does this for you. No need to do it again. - Dennis Krøger On March 8, 2015, 3:12 p.m., Kasper Sørensen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31066/ > --- > > (Updated March 8, 2015, 3:12 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-79 > https://issues.apache.org/jira/browse/METAMODEL-79 > > > Repository: metamodel > > > Description > --- > > Partial fix for METAMODEL-79 - see description > > > Diffs > - > > CHANGES.md 5c2e2eb > core/src/main/java/org/apache/metamodel/MetaModelHelper.java 4ee9798 > core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java > 0eba921 > core/src/main/java/org/apache/metamodel/query/FilterClause.java fe981a1 > > core/src/test/java/org/apache/metamodel/QueryPostprocessDataContextTest.java > 3fdb711 > core/src/test/java/org/apache/metamodel/query/FilterItemTest.java 2fedfb9 > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchCreateTableBuilder.java > PRE-CREATION > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContext.java > 06353f1 > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataSet.java > e4f1054 > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDeleteBuilder.java > PRE-CREATION > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDropTableBuilder.java > PRE-CREATION > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchInsertBuilder.java > PRE-CREATION > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchUpdateCallback.java > PRE-CREATION > > elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java > 449490b > > Diff: https://reviews.apache.org/r/31066/diff/ > > > Testing > --- > > This is my initial/partial fix for METAMODEL-79. I want to share it because > 1) there's more to come but I want to confirm that I'm on the right way and > 2) I have questions for experts on E.S. :-) > > This patch adds support for the MetaModel ElasticSearch to do INSERT INTO, > CREATE TABLE and DROP TABLE statements. > > It does not (yet) have support for UPDATE or DELETE FROM statements. I wanted > to validate my initial work first. > > And I have a few questions regarding types and mappings. > > * Please check the ElasticSearchCreateTableBuilder.getType(Column) method. > Here I've attempted to convert ColumnTypes to ElasticSearch types. Are these > correct? I am not sure about generalizations such as the NUMERIC -> "double" > mapping etc. > * As a last resort I have used the type "object". But when I tried it out I > ran into the problem that "object" is not polymorphic like in Java, it is > actually the opposite of a "value type". So that means you cannot define an > "object" field and then insert a single value into it. This makes it a bad > fit for a "fallback" type. Is there a better way? Should we then simply NOT > define the field in the mapping maybe? > > > Thanks, > > Kasper Sørensen > >
