[GitHub] metron issue #943: METRON-1462: Separate ES and Kibana from Metron Mpack

2018-02-23 Thread ottobackwards 
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/943
  
I think I mentioned contrib.  They don't have to go in contrib, I think at 
the time someone mentioned not wanting to maintain them.. If we don't then I 
thought contrib would make sense.
We can keep them normal.

Metron installation artifacts ( templates, schemas, kibana objects, 
queries, and dashboards ) should be managed separate from the kibana / es / 
solr /  packs.
They are artifacts of metron and we need to support installing them on 
existing installations.
If they need to be installed in a different phase, or as their own 
component, then fine.
we need to break that down more anyway ( like package the 'demo' system + 
parser configs as optional ) maybe.






---

[GitHub] metron pull request #943: METRON-1462: Separate ES and Kibana from Metron Mp...

2018-02-23 Thread mmiklavc 
GitHub user mmiklavc opened a pull request:

https://github.com/apache/metron/pull/943

METRON-1462: Separate ES and Kibana from Metron Mpack

## Contributor Comments

This splits ES and Kibana into their own MPacks. Two comments for reviewers:
- The original discuss thread mentioned putting this in metron-contrib. Are 
we dead set on this, or is my split in metron-deployment reasonable?
- I kept the Kibana templates and associated documentation in their current 
location and migrated them with the Kibana service. This is consistent with our 
current deployment and means we don't need to add a new set of features to the 
Metron MPack to publish them. A point in favor of moving this to Metron's MPack 
would be that we think this is in the purview of Metron and would make the 
Ambari design more consistent when we introduce Solr.

**Testing**
Spin up full dev and verify the Kibana dashboard is displaying information.

## Pull Request Checklist

In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mmiklavc/metron es-mpack-split

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/943.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #943


commit f266600bf67dd11974a4c5faff7120c1b1044629
Author: Michael Miklavcic 
Date:   2018-02-21T16:58:42Z

Ready to test ES/Kibana MPack split. TODO: README updates

commit 941e767287e403873d893a304b5847033e4c9b16
Author: Michael Miklavcic 
Date:   2018-02-21T16:59:55Z

Merge branch 'master' into es-mpack-split

commit 96e4b6188b04a5518064a9a1cd59aeaf3059cdc1
Author: Michael Miklavcic 
Date:   2018-02-23T21:40:03Z

Document the ES and Kibana MPack split




---

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-23 Thread merrimanr 
Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/934#discussion_r170365518
  
--- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh 
---
@@ -0,0 +1,27 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+METRON_VERSION=${project.version}
+METRON_HOME=/usr/metron/$METRON_VERSION
+SOLR_VERSION=6.6.2
--- End diff --

Latest commit should address this.


---

[GitHub] metron pull request #942: METRON-1461: Modify the MIN, MAX Stellar methods t...

2018-02-23 Thread MohanDV 
GitHub user MohanDV opened a pull request:

https://github.com/apache/metron/pull/942

METRON-1461: Modify the MIN, MAX Stellar methods to take a stats or list 
object and return min and max


## Contributor Comments
Presently the MIN and MAX stellar function accepts only the list  as input 
and the list may only contain objects that are mutually comparable / ordinal. 
Modify the method to take a stats or list object and return min/max.

## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [ ] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [ ] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been 
executed in the root metron folder via:
  ```
  mvn -q clean integration-test install && 
dev-utilities/build-utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MohanDV/metron METRON-1461

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/942.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #942


commit 5cb3a9354efbba6c8f9b85382848152839407d68
Author: Mohan Venkateshaiah 
Date:   2018-02-23T19:59:07Z

Modify the MIN, MAX Stellar methods to take a stats or list object and 
return min/max.




---

[GitHub] metron issue #940: METRON-1460: Create a complementary non-split-join enrich...

2018-02-23 Thread cestella 
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/940
  
The current architecture is described ![Image of 
Yaktocat](https://github.com/apache/metron/raw/master/metron-platform/metron-enrichment/enrichment_arch.png)

In short, for each message each splitter will
* inspect the configs for the sensor 
* For each sensor, extract the fields required for enrichment and send them 
to the appropriate enrichment bolt (e.g. hbase, geo, stellar)
  * If one enrichment enriches k fields, then k messages will be sent to 
the enrichment bolt
  * In the case of stellar, each stellar subgroup will be a separate message
  * the original message is sent directly to the join bolt
* The enrichment bolts do the enrichment and send the additional fields and 
values to the original message
* The join bolt will asynchronously collect the subresults and join them 
with the original message
  * The join bolt has a LRU cache to hold subresults until all results 
arrive
  * Tuning performance involves tuning this cache (max size and time until 
eviction)
  * Tuning this can be complex because it has to be large enough to handle 
spikes in traffic




---

[GitHub] metron issue #933: METRON-1452 Rebase Dev Environment on Latest CentOS 6

2018-02-23 Thread cestella 
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/933
  
piling on, +1 by inspection



---

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-23 Thread merrimanr 
Github user merrimanr commented on a diff in the pull request:

https://github.com/apache/metron/pull/934#discussion_r170272344
  
--- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh 
---
@@ -0,0 +1,27 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+METRON_VERSION=${project.version}
+METRON_HOME=/usr/metron/$METRON_VERSION
+SOLR_VERSION=6.6.2
--- End diff --

Good catch and I agree they should match.  I think the mistake is actually 
the maven version.  We initially explored using HDP Search (which is version 
6.6.2) but it's not quite ready yet so we went ahead with a manual approach in 
the meantime.  The thinking was this would make it easy to switch to HDP Search 
in the future.


---

[GitHub] metron issue #934: METRON-1423: Ambari work to handle Solr configuration

2018-02-23 Thread cestella 
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/934
  
Chiming in late.  I agree that we should not have an explicit dependency on 
an indexing Mpack, even one not of our own construction.  I think people will 
have a lot of different ways to install solr and Metron's mpack should just be 
configured to point to an existing solr instance.

I would generally be in favor of adding support for:
* solr.commitPerBatch
* solr.commit.waitSearcher
* solr.commit.waitFlush
* solr.commit.soft
* solr.collection
* solr.http.config

but sensible defaults are chosen there and people can adjust them in the 
global config, so I think they can wait for a follow-on.  Some of them may be 
problematic to encode in a UI (solr.http.config is a map, for instance), but 
most of them would be pretty trivial.  Frankly, I'm a bit hesitant to give 
people the ability to screw with transactions details easily.


---

[GitHub] metron pull request #934: METRON-1423: Ambari work to handle Solr configurat...

2018-02-23 Thread cestella 
Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/934#discussion_r170269639
  
--- Diff: metron-platform/metron-solr/src/main/scripts/create_collection.sh 
---
@@ -0,0 +1,27 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+METRON_VERSION=${project.version}
+METRON_HOME=/usr/metron/$METRON_VERSION
+SOLR_VERSION=6.6.2
--- End diff --

I notice that we're depending on maven artifacts of 6.6.0 and we set the 
solr version to 6.6.2 here, is there a reason for that?  If we can align them, 
then we could replace this line with SOLR_VERSION=`${global_solr_version}`

This question applies for the rest of the shell scripts too


---