Re: [DISCUSS] Next Release - Life After 0.7.1
I also brought up https://github.com/apache/metron/pull/1282 and https://github.com/apache/metron/pull/1552 if anyone has any thoughts on them. On Fri, Dec 13, 2019 at 11:58 AM Shane Ardell wrote: > Quick update from my end: I just left a +1 on > https://github.com/apache/metron/pull/1527 and will merge it into master > shortly. We are actively looking into the cause of the bug I encountered in > https://github.com/apache/metron/pull/1533. It would be nice to have this > in the release, but I would not categorize it as critical like #1527. I'm > optimistic we will have this resolved and merged into master by this > weekend, but I'm fine reducing scope to not include it. > > On Fri, Dec 13, 2019 at 11:24 AM Nick Allen wrote: > > > Are we just waiting on the following PRs as release blockers? Any > others? > > > >- https://github.com/apache/metron/pull/1533 > >- https://github.com/apache/metron/pull/1527 > > > > Being towards the end of the year, people are going to be on holiday. It > > would be great if we could focus on reducing scope and getting a release > > cut. > > > > > > On Sat, Dec 7, 2019 at 10:04 AM Justin Leet > wrote: > > > > > https://github.com/apache/metron/pull/1568 and > > > https://github.com/apache/metron/pull/1554 are in master now. > > > > > > On Fri, Dec 6, 2019 at 7:16 PM Justin Leet > > wrote: > > > > > > > I'd like to throw https://github.com/apache/metron/pull/1552 on the > > > pile. > > > > Per https://issues.apache.org/jira/browse/LEGAL-491, we should just > > note > > > > the contribution comes from dependabot. Would someone more familiar > > with > > > > the implications of upgrading that be able to review it, or give some > > > > advice on what we should be looking for in the review? > > > > > > > > On Thu, Dec 5, 2019 at 12:06 PM Shane Ardell < > shane.m.ard...@gmail.com > > > > > > > wrote: > > > > > > > >> Speaking on the UI-related PRs that Justin mentioned, I also would > > like > > > to > > > >> see both of them merged before a release. At the moment, #1527 does > > not > > > >> address a few "stale data state" message inconsistencies that become > > > >> apparent as a result of that PR's work (you can read more about it > in > > > the > > > >> PR comments). That said, I think those inconsistencies can be > tracked > > > and > > > >> addressed separately from the current PR. > > > >> > > > >> On Thu, Dec 5, 2019 at 11:51 AM Michael Miklavcic < > > > >> michael.miklav...@gmail.com> wrote: > > > >> > > > >> > I think the junit upgrade should go in also. I'm almost finished > > > >> reviewing > > > >> > that. > > > >> > > > > >> > On Thu, Dec 5, 2019, 8:50 AM Justin Leet > > > wrote: > > > >> > > > > >> > > If we're going to do a bug fix release, I'd like to see some of > > the > > > >> low > > > >> > > hanging fix PRs get finished and merged prior to the release. > > We've > > > >> been > > > >> > > lax about getting them cleaned up, so I'd like to use a release > as > > > an > > > >> > > opportunity to whittle the PRs down and put out a really solid > > > >> release. > > > >> > > > > > >> > > https://github.com/apache/metron/pull/1568 should be in before > > > >> release. > > > >> > It > > > >> > > addresses an issue with our validation of > > dependencies_with_url.csv > > > >> and > > > >> > > it's validation. > > > >> > > Should https://github.com/apache/metron/pull/1282 be in? Seems > > like > > > >> that > > > >> > > should have been merged awhile ago. > > > >> > > > > > >> > > There's also a couple UI performance / bug fixes PRs (e.g. > > > >> > > https://github.com/apache/metron/pull/1533 and > > > >> > > https://github.com/apache/metron/pull/1527) that have been > > sitting > > > >> > awhile. > > > >> > > > > > >> > > > > > >> > > > > > >> > > On Thu, Dec 5, 2019 at 10:32 AM Nick Allen > > > >> wrote: > > > >> > > > > > >> > > > Hello Metron'ers - > > > >> > > > > > > >> > > > I would like to make the case that it is time for us to cut > the > > > next > > > >> > > Apache > > > >> > > > Metron release. > > > >> > > > > > > >> > > >- Our last release was 0.7.1 on May 15th > > > >> > > >< > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > > > https://lists.apache.org/thread.html/e2e532cbb63be757d0875718b082c069a268f57a9087510f196be09b%40%3Cdev.metron.apache.org%3E > > > >> > > > >. > > > >> > > >It has been *~6 months* since this release. > > > >> > > > > > > >> > > > > > > >> > > >- We have *102 changes* in master since the last release. > > This > > > >> > figure > > > >> > > >excludes the two feature branches currently undergoing > active > > > >> > > > development. > > > >> > > > > > > >> > > > > > > >> > > >- We should cut a release *prior to merging in any other > > > >> significant > > > >> > > >changes* from either feature branch. The two active > feature > > > >> > branches > > > >> > > >include ~47 other changes at this point in time. > > > >> > > > > > > >> > > > > > > >> > > >- These 102 change
Re: [DISCUSS] Next Release - Life After 0.7.1
Quick update from my end: I just left a +1 on https://github.com/apache/metron/pull/1527 and will merge it into master shortly. We are actively looking into the cause of the bug I encountered in https://github.com/apache/metron/pull/1533. It would be nice to have this in the release, but I would not categorize it as critical like #1527. I'm optimistic we will have this resolved and merged into master by this weekend, but I'm fine reducing scope to not include it. On Fri, Dec 13, 2019 at 11:24 AM Nick Allen wrote: > Are we just waiting on the following PRs as release blockers? Any others? > >- https://github.com/apache/metron/pull/1533 >- https://github.com/apache/metron/pull/1527 > > Being towards the end of the year, people are going to be on holiday. It > would be great if we could focus on reducing scope and getting a release > cut. > > > On Sat, Dec 7, 2019 at 10:04 AM Justin Leet wrote: > > > https://github.com/apache/metron/pull/1568 and > > https://github.com/apache/metron/pull/1554 are in master now. > > > > On Fri, Dec 6, 2019 at 7:16 PM Justin Leet > wrote: > > > > > I'd like to throw https://github.com/apache/metron/pull/1552 on the > > pile. > > > Per https://issues.apache.org/jira/browse/LEGAL-491, we should just > note > > > the contribution comes from dependabot. Would someone more familiar > with > > > the implications of upgrading that be able to review it, or give some > > > advice on what we should be looking for in the review? > > > > > > On Thu, Dec 5, 2019 at 12:06 PM Shane Ardell > > > > wrote: > > > > > >> Speaking on the UI-related PRs that Justin mentioned, I also would > like > > to > > >> see both of them merged before a release. At the moment, #1527 does > not > > >> address a few "stale data state" message inconsistencies that become > > >> apparent as a result of that PR's work (you can read more about it in > > the > > >> PR comments). That said, I think those inconsistencies can be tracked > > and > > >> addressed separately from the current PR. > > >> > > >> On Thu, Dec 5, 2019 at 11:51 AM Michael Miklavcic < > > >> michael.miklav...@gmail.com> wrote: > > >> > > >> > I think the junit upgrade should go in also. I'm almost finished > > >> reviewing > > >> > that. > > >> > > > >> > On Thu, Dec 5, 2019, 8:50 AM Justin Leet > > wrote: > > >> > > > >> > > If we're going to do a bug fix release, I'd like to see some of > the > > >> low > > >> > > hanging fix PRs get finished and merged prior to the release. > We've > > >> been > > >> > > lax about getting them cleaned up, so I'd like to use a release as > > an > > >> > > opportunity to whittle the PRs down and put out a really solid > > >> release. > > >> > > > > >> > > https://github.com/apache/metron/pull/1568 should be in before > > >> release. > > >> > It > > >> > > addresses an issue with our validation of > dependencies_with_url.csv > > >> and > > >> > > it's validation. > > >> > > Should https://github.com/apache/metron/pull/1282 be in? Seems > like > > >> that > > >> > > should have been merged awhile ago. > > >> > > > > >> > > There's also a couple UI performance / bug fixes PRs (e.g. > > >> > > https://github.com/apache/metron/pull/1533 and > > >> > > https://github.com/apache/metron/pull/1527) that have been > sitting > > >> > awhile. > > >> > > > > >> > > > > >> > > > > >> > > On Thu, Dec 5, 2019 at 10:32 AM Nick Allen > > >> wrote: > > >> > > > > >> > > > Hello Metron'ers - > > >> > > > > > >> > > > I would like to make the case that it is time for us to cut the > > next > > >> > > Apache > > >> > > > Metron release. > > >> > > > > > >> > > >- Our last release was 0.7.1 on May 15th > > >> > > >< > > >> > > > > > >> > > > > >> > > > >> > > > https://lists.apache.org/thread.html/e2e532cbb63be757d0875718b082c069a268f57a9087510f196be09b%40%3Cdev.metron.apache.org%3E > > >> > > > >. > > >> > > >It has been *~6 months* since this release. > > >> > > > > > >> > > > > > >> > > >- We have *102 changes* in master since the last release. > This > > >> > figure > > >> > > >excludes the two feature branches currently undergoing active > > >> > > > development. > > >> > > > > > >> > > > > > >> > > >- We should cut a release *prior to merging in any other > > >> significant > > >> > > >changes* from either feature branch. The two active feature > > >> > branches > > >> > > >include ~47 other changes at this point in time. > > >> > > > > > >> > > > > > >> > > >- These 102 changes include some very nice *bug fixes and > > >> usability > > >> > > >improvements*. I would propose that we treat this as a > bug-fix > > >> > release > > >> > > >and label it as *Metron 0.7.2*. > > >> > > > > > >> > > > Please let me know if you agree or disagree with this call for a > > >> > release. > > >> > > > > > >> > > > For those interested, here are the 102 unreleased changes in > > master. > > >> > > > > > >> > > > METRON-2323 Increase unit test coverage for Alerts List > (sardell) > >
Re: [DISCUSS] Next Release - Life After 0.7.1
Are we just waiting on the following PRs as release blockers? Any others? - https://github.com/apache/metron/pull/1533 - https://github.com/apache/metron/pull/1527 Being towards the end of the year, people are going to be on holiday. It would be great if we could focus on reducing scope and getting a release cut. On Sat, Dec 7, 2019 at 10:04 AM Justin Leet wrote: > https://github.com/apache/metron/pull/1568 and > https://github.com/apache/metron/pull/1554 are in master now. > > On Fri, Dec 6, 2019 at 7:16 PM Justin Leet wrote: > > > I'd like to throw https://github.com/apache/metron/pull/1552 on the > pile. > > Per https://issues.apache.org/jira/browse/LEGAL-491, we should just note > > the contribution comes from dependabot. Would someone more familiar with > > the implications of upgrading that be able to review it, or give some > > advice on what we should be looking for in the review? > > > > On Thu, Dec 5, 2019 at 12:06 PM Shane Ardell > > wrote: > > > >> Speaking on the UI-related PRs that Justin mentioned, I also would like > to > >> see both of them merged before a release. At the moment, #1527 does not > >> address a few "stale data state" message inconsistencies that become > >> apparent as a result of that PR's work (you can read more about it in > the > >> PR comments). That said, I think those inconsistencies can be tracked > and > >> addressed separately from the current PR. > >> > >> On Thu, Dec 5, 2019 at 11:51 AM Michael Miklavcic < > >> michael.miklav...@gmail.com> wrote: > >> > >> > I think the junit upgrade should go in also. I'm almost finished > >> reviewing > >> > that. > >> > > >> > On Thu, Dec 5, 2019, 8:50 AM Justin Leet > wrote: > >> > > >> > > If we're going to do a bug fix release, I'd like to see some of the > >> low > >> > > hanging fix PRs get finished and merged prior to the release. We've > >> been > >> > > lax about getting them cleaned up, so I'd like to use a release as > an > >> > > opportunity to whittle the PRs down and put out a really solid > >> release. > >> > > > >> > > https://github.com/apache/metron/pull/1568 should be in before > >> release. > >> > It > >> > > addresses an issue with our validation of dependencies_with_url.csv > >> and > >> > > it's validation. > >> > > Should https://github.com/apache/metron/pull/1282 be in? Seems like > >> that > >> > > should have been merged awhile ago. > >> > > > >> > > There's also a couple UI performance / bug fixes PRs (e.g. > >> > > https://github.com/apache/metron/pull/1533 and > >> > > https://github.com/apache/metron/pull/1527) that have been sitting > >> > awhile. > >> > > > >> > > > >> > > > >> > > On Thu, Dec 5, 2019 at 10:32 AM Nick Allen > >> wrote: > >> > > > >> > > > Hello Metron'ers - > >> > > > > >> > > > I would like to make the case that it is time for us to cut the > next > >> > > Apache > >> > > > Metron release. > >> > > > > >> > > >- Our last release was 0.7.1 on May 15th > >> > > >< > >> > > > > >> > > > >> > > >> > https://lists.apache.org/thread.html/e2e532cbb63be757d0875718b082c069a268f57a9087510f196be09b%40%3Cdev.metron.apache.org%3E > >> > > > >. > >> > > >It has been *~6 months* since this release. > >> > > > > >> > > > > >> > > >- We have *102 changes* in master since the last release. This > >> > figure > >> > > >excludes the two feature branches currently undergoing active > >> > > > development. > >> > > > > >> > > > > >> > > >- We should cut a release *prior to merging in any other > >> significant > >> > > >changes* from either feature branch. The two active feature > >> > branches > >> > > >include ~47 other changes at this point in time. > >> > > > > >> > > > > >> > > >- These 102 changes include some very nice *bug fixes and > >> usability > >> > > >improvements*. I would propose that we treat this as a bug-fix > >> > release > >> > > >and label it as *Metron 0.7.2*. > >> > > > > >> > > > Please let me know if you agree or disagree with this call for a > >> > release. > >> > > > > >> > > > For those interested, here are the 102 unreleased changes in > master. > >> > > > > >> > > > METRON-2323 Increase unit test coverage for Alerts List (sardell) > >> > closes > >> > > > apache/metron#1567 > >> > > > METRON-2208 [UI] Increase unit test coverage for Alert Details > >> > (sardell) > >> > > > closes apache/metron#1479 > >> > > > METRON-2316 [UI] Drag drop sorting for the selected fields in the > >> > Alerts > >> > > UI > >> > > > (ruffle1986 via sardell) closes apache/metron#1560 > >> > > > METRON-2326 Unable to Call ENRICHMENT_GET from Threat Triage Rule > >> > Reason > >> > > > Field (nickwallen via mmiklavc) closes apache/metron#1570 > >> > > > METRON-2285 Batch Profiler Cannot Persist Data Sketches > (nickwallen > >> via > >> > > > mmiklavc) closes apache/metron#1564 > >> > > > METRON-2321 Remove Legacy AWS Deployment Path (nickwallen) closes > >> > > > apache/metron#1565 > >> > > > METRON-2317 [UI] Delete confirmation di
