[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/709 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/709 Assuming your test in Full Dev goes smoothly, my +1 stands. It works great. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user cestella commented on the issue: https://github.com/apache/metron/pull/709 @merrimanr @nickwallen Ok, I changed the default acker executors to `1`. I'll spin up again in full-dev, let me know if there's anything else I missed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user cestella commented on the issue: https://github.com/apache/metron/pull/709 @merrimanr yeah, maybe, this was the default before for the profiler, so it stuck. Do we want to adjust this to be consistent with enrichment or indexing? I'd vote yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/709 I ran this up in full dev and it worked. However when I was looking at the Profiler tab in Ambari I noticed "Number of Acker Executors" was set to 0. Shouldn't this be set to 1, similar to enrichment and indexing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user cestella commented on the issue: https://github.com/apache/metron/pull/709 Alright, I think I've fixed the enrichment dependency issue. We should probably spin up in full-dev again to verify. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/709 I tested this in full dev again and it looks good after the recent changes. @nickwallen brings up a good point and I would prefer we fix it now because it's an easy one line change. I added a comment with my suggestion and have verified it in full dev. Pending that addition, I'm +1. Nice work @cestella. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] metron issue #709: METRON-1122: Add support for the profiler in the manageme...
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/709 I have only noticed one small problem. If I change the enrichment topic, Ambari correctly indicates that the Enrichment Topology needs restarted. But since the Enrichment topic also impacts the Profiler, the Profiler needs to be restarted. There is no indication in Ambari that the Profiler needs restarted. I don't think we even need to address this as part of this PR. As long as you validate what I am seeing and we log a JIRA, then I am good with this PR being merged. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
