[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/866 Much, much better! Thanks @nickwallen +1 ``` vagrant up 1356.81s user 192.34s system 63% cpu 40:35.63 total ``` ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/866 I'm +1 by inspection, given that @ottobackwards ran it up successfully. Good job! ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/866 Thanks @ottobackwards . I should also mention that I did run Metron up in AWS too in testing this PR, since that also depends on the changes I made here. That worked nicely also. ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/866 Ran per instructions Ran again with skip tags build Everything fine in all uis Nice work! +1 ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/866 I am on a mac, and I don't remember why I did it, but I have cowsay installed ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/866 @ottobackwards Nope, at least I don't. I assume you're not on a Mac, because I don't believe cowsay is installed by default on them. Hilariously, I just installed it via homebrew though. ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/866 Ha. Very nice @ottobackwards . I added more detailed testing steps should they be needed by anyone else. Sadly, no cows. ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/866 ok: [node1] __ < TASK [metron-builder : Build Metron] > -- \ ^__^ \ (oo)\___ (__)\ )\/\ ||w | || || ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/866 Also, keep in mind that each time you run a 'vagrant up' it will append to that ansible.log file. So that file will contain multiple deployments. ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/866 Yeah, sorry, I wasn't clear, my log sample is prior to this PR ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/866 With this PR, you should see "Build Metron" and "Build Metron RPMs" only once each. Here is the log output of what it should look-like. [ansible.example.log](https://github.com/apache/metron/files/1559425/ansible.example.log) ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/866 @ottobackwards Yes, I think you'd see it twice, looking at my logs ``` 2017-12-11 09:50:06,120 p=15256 u=jleet | TASK [metron-builder : Build Metron] *** 2017-12-11 09:56:16,676 p=15256 u=jleet | [0;33mchanged: [node1 -> localhost][0m 2017-12-11 09:56:16,682 p=15256 u=jleet | TASK [metron-builder : Build Metron RPMs] ** 2017-12-11 10:07:05,114 p=15256 u=jleet | [0;33mchanged: [node1 -> localhost][0m ``` Way down later in the build: ``` 2017-12-11 10:36:16,385 p=15256 u=jleet | TASK [metron-builder : Build Metron] *** 2017-12-11 10:46:43,988 p=15256 u=jleet | [0;33mchanged: [node1 -> localhost][0m 2017-12-11 10:46:44,014 p=15256 u=jleet | TASK [metron-builder : Build Metron RPMs] ** 2017-12-11 11:00:49,602 p=15256 u=jleet | [0;33mchanged: [node1 -> localhost][0m ... ``` @nickwallen Is this a correct assessment? ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/866 i'm on irc if you want to chat btw ;) ---
[GitHub] metron issue #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/866 How would I have known it was building twice? How do I tell if it builds only once? I usually fire and forget vagrant up ---
