[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/919
  
No, I am sorry, I thought that was understood.  I have not reviewed, but I 
would go ahead based on @cestella 


---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/919
  
@ottobackwards Any objections to having the discussion outside of this and 
merging this in as-is?


---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/metron/pull/919
  
so, I'm +1 on this and we probably want a discussion outside of this about 
where to move `platform-info.sh`


---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/metron/pull/919
  
this is a user utility though, not a dev one.  I would create a new 
support-scripts folder


---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/919
  
> Sidenote, do we want to move this script to the dev-utilities dir?

I do think it would be good to move that script.  Not sure where under 
dev-utilities though.  And we can tackle as separate PR, if you like.




---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread nickwallen
Github user nickwallen commented on the issue:

https://github.com/apache/metron/pull/919
  
+1 works great for me.  Thanks


---


[GitHub] metron issue #919: METRON-1439: Turn off git pager in platform-info script

2018-02-01 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/metron/pull/919
  
Sidenote, do we want to move this script to the dev-utilities dir?


---