[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-20 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/metron/pull/596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-19 Thread cestella 
GitHub user cestella reopened a pull request:

https://github.com/apache/metron/pull/596

METRON-965: In the case where we specify the syncpolicy in the HDFS Writer, 
we do not properly clone and end up syncing for every record

## Contributor Comments
Right now the SyncPolicy works as follows:
* If you specify the sync policy in the flux file, it will use that policy 
to determine when to sync the HDFS Writer.
* If you do not, then it will create a count sync policy based on the batch 
size.
In the first case, we are not creating the sync policy properly and end up 
sync'ing per record, which has performance impact and is incorrect.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 
count_sync_override_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #596


commit 22b4eceff5a54447d8fd9fee683ac636f0e2352f
Author: cstella 
Date:   2017-05-19T00:56:41Z

Bug with resetting the count sync handler.

commit 769c95fd6a3a57ac61c8edff513925b6c3d1d74b
Author: cstella 
Date:   2017-05-19T01:13:42Z

Properly cloning now.

commit bf9f4735a64649f58e638b7129ec0f54e969f772
Author: cstella 
Date:   2017-05-19T02:24:19Z

Explained the reasoning behind the deep clone via serialization better.

commit 97ed329cc52dcb6b9e9cd0bd8a0f3187c924437d
Author: cstella 
Date:   2017-05-19T23:19:30Z

Adding unit test.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-19 Thread cestella 
Github user cestella closed the pull request at:

https://github.com/apache/metron/pull/596


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-19 Thread cestella 
GitHub user cestella reopened a pull request:

https://github.com/apache/metron/pull/596

METRON-965: In the case where we specify the syncpolicy in the HDFS Writer, 
we do not properly clone and end up syncing for every record

## Contributor Comments
Right now the SyncPolicy works as follows:
* If you specify the sync policy in the flux file, it will use that policy 
to determine when to sync the HDFS Writer.
* If you do not, then it will create a count sync policy based on the batch 
size.
In the first case, we are not creating the sync policy properly and end up 
sync'ing per record, which has performance impact and is incorrect.


## Pull Request Checklist

Thank you for submitting a contribution to Apache Metron.  
Please refer to our [Development 
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
 for the complete guide to follow for contributions.  
Please refer also to our [Build Verification 
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
 for complete smoke testing guides.  


In order to streamline the review of the contribution we ask you follow 
these guidelines and ask you to double check the following:

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to 
be created at [Metron 
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
 
- [x] Does your PR title start with METRON- where  is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
- [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?


### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is 
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified 
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been 
executed in the root incubating-metron folder via:
  ```
  mvn -q clean integration-test install && build_utils/verify_licenses.sh 
  ```

- [x] Have you written or updated unit tests and or integration tests to 
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] Have you verified the basic functionality of the build by building 
and running locally with Vagrant full-dev environment or the equivalent?

### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in 
which it is rendered by building and verifying the site-book? If not then run 
the following commands and the verify changes via 
`site-book/target/site/index.html`:

  ```
  cd site-book
  mvn site
  ```

 Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up 
for your personal repository such that your branches are built there before 
submitting a pull request.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cestella/incubator-metron 
count_sync_override_bug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/metron/pull/596.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #596


commit 22b4eceff5a54447d8fd9fee683ac636f0e2352f
Author: cstella 
Date:   2017-05-19T00:56:41Z

Bug with resetting the count sync handler.

commit 769c95fd6a3a57ac61c8edff513925b6c3d1d74b
Author: cstella 
Date:   2017-05-19T01:13:42Z

Properly cloning now.

commit bf9f4735a64649f58e638b7129ec0f54e969f772
Author: cstella 
Date:   2017-05-19T02:24:19Z

Explained the reasoning behind the deep clone via serialization better.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-19 Thread ottobackwards 
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/596#discussion_r117447902
  
--- Diff: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java
 ---
@@ -85,7 +85,17 @@ public void init(Map stormConfig, TopologyContext 
topologyContext, WriterConfigu
 this.fileNameFormat.prepare(stormConfig,topologyContext);
 if(syncPolicy != null) {
   //if the user has specified the sync policy, we don't want to 
override their wishes.
-  syncPolicyCreator = (source,config) -> syncPolicy;
+  syncPolicyCreator = (source,config) -> {
+try {
--- End diff --

Thank you


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-18 Thread cestella 
Github user cestella commented on a diff in the pull request:

https://github.com/apache/metron/pull/596#discussion_r117392489
  
--- Diff: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java
 ---
@@ -85,7 +85,17 @@ public void init(Map stormConfig, TopologyContext 
topologyContext, WriterConfigu
 this.fileNameFormat.prepare(stormConfig,topologyContext);
 if(syncPolicy != null) {
   //if the user has specified the sync policy, we don't want to 
override their wishes.
-  syncPolicyCreator = (source,config) -> syncPolicy;
+  syncPolicyCreator = (source,config) -> {
+try {
--- End diff --

yeah, it's a bit black magicky.  I fleshed out that comment a fair amount 
more.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] metron pull request #596: METRON-965: In the case where we specify the syncp...

2017-05-18 Thread ottobackwards 
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/metron/pull/596#discussion_r117392109
  
--- Diff: 
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/hdfs/HdfsWriter.java
 ---
@@ -85,7 +85,17 @@ public void init(Map stormConfig, TopologyContext 
topologyContext, WriterConfigu
 this.fileNameFormat.prepare(stormConfig,topologyContext);
 if(syncPolicy != null) {
   //if the user has specified the sync policy, we don't want to 
override their wishes.
-  syncPolicyCreator = (source,config) -> syncPolicy;
+  syncPolicyCreator = (source,config) -> {
+try {
--- End diff --

This seems a little black magic-y.  Can we expand the comment as to why we 
need to clone?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---