[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/866 ---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156746647
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts: metron
- become: true
- roles:
-- { role: ambari_slave }
-- { role: metron-builder, tags: ['build'] }
--- End diff --
Yes
---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156737918
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts: metron
- become: true
- roles:
-- { role: ambari_slave }
-- { role: metron-builder, tags: ['build'] }
--- End diff --
Will --ansible-skip-tags="build" still keep it from building at all?
---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156726426
--- Diff: metron-deployment/playbooks/metron_install.yml ---
@@ -15,13 +15,6 @@
# limitations under the License.
#
---
-- hosts: metron
- become: true
- roles:
-- { role: ambari_slave }
-- { role: metron-builder, tags: ['build'] }
--- End diff --
This is the cause of the second build.
The process was a bit more complex when Quick Dev was around because it
would launch the Quick Dev image, then rebuild and try to push out new bits to
Quick Dev. Since we don't need that any longer, this can be simplified.
---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/866#discussion_r156725657
--- Diff: metron-deployment/roles/ambari_config/tasks/main.yml ---
@@ -26,16 +26,15 @@
retries: 5
delay: 10
-- name : check if ambari-server is up on {{ ambari_host }}:{{ambari_port}}
+- name : Wait for Ambari to start; http://{{ ambari_host }}:{{ ambari_port
}}
wait_for :
host: "{{ ambari_host }}"
port: "{{ ambari_port }}"
-delay: 120
-timeout: 300
+timeout: 600
--- End diff --
There is no need to always wait 2 minutes for Ambari to be ready. Most
often it is already up and kicking by the time we get here. Rather than have a
forced delay, I just added the delay duration to the overall timeout parameter
in case there is a delay in getting Ambari going.
---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/866#discussion_r156724938 --- Diff: metron-deployment/roles/epel/tasks/main.yml --- @@ -16,6 +16,4 @@ # --- - name: Install EPEL repository - yum: name=epel-release update_cache=yes - - + yum: name=epel-release --- End diff -- There is no need to force a cache update here. This role gets run repetitively and forcing a cache update just slows us down. ---
[GitHub] metron pull request #866: METRON-1349 Full Dev Builds Metron Twice
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/866 METRON-1349 Full Dev Builds Metron Twice Removing the "Quick Dev" environment in #852 had an unintended side effect. It caused Metron to be built twice during the Full Dev deployment process. Unless you prefer a double-build for thoroughness, this can be annoying. ## Testing Deploy Full Dev and ensure that Metron is not build twice. Once Metron is deployed, login to Ambari and run the Metron Service Check. If the service check passes, we've done a solid. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nickwallen/metron METRON-1349 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/866.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #866 commit f152326f4c401129f0b05d03045440e7cf5dda2b Author: Nick Allen Date: 2017-12-13T17:11:59Z METRON-1349 Full Dev Builds Metron Twice ---
