Re: Jira Rights

2016-10-31 Thread Otto Fowler
I am signed up, but not under my apache ID, does that matter?  I will create a 
new account with that ID if it makes it easier.
My current username in jira is ottobackwards.



On October 31, 2016 at 20:08:20, James Sirota (jsir...@apache.org) wrote:

Please sign up for the Jira and I will assign you the rights  

28.10.2016, 19:35, "Otto Fowler" :  
> How can I get rights in jira to assign issues to myself etc?  
>  
> Otto  

---   
Thank you,  

James Sirota  
PPMC- Apache Metron (Incubating)  
jsirota AT apache DOT org  


[GitHub] incubator-metron issue #276: METRON-363 Fix Cisco ASA Parser

2016-10-31 Thread kylerichardson
Github user kylerichardson commented on the issue:

https://github.com/apache/incubator-metron/pull/276
  
Rebased against master to incorporate the global junit version change. 
Should be good to go now pending Travis.

Thanks again to everyone for all of the suggestions, feedback, and testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: Jira Rights

2016-10-31 Thread Kyle Richardson
Any chance I could also get rights to assign myself issues in JIRA? If it's
for PMC and committers only I totally understand.

-Kyle


On Mon, Oct 31, 2016 at 8:08 PM, James Sirota  wrote:

> Please sign up for the Jira and I will assign you the rights
>
> 28.10.2016, 19:35, "Otto Fowler" :
> > How can I get rights in jira to assign issues to myself etc?
> >
> > Otto
>
> ---
> Thank you,
>
> James Sirota
> PPMC- Apache Metron (Incubating)
> jsirota AT apache DOT org
>


Re: Jira Rights

2016-10-31 Thread James Sirota
Please sign up for the Jira and I will assign you the rights

28.10.2016, 19:35, "Otto Fowler" :
> How can I get rights in jira to assign issues to myself etc?
>
> Otto

--- 
Thank you,

James Sirota
PPMC- Apache Metron (Incubating)
jsirota AT apache DOT org


[GitHub] incubator-metron pull request #333: METRON-249: Field Transformation functio...

2016-10-31 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/333#discussion_r85831990
  
--- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/NetworkFunctions.java
 ---
@@ -224,7 +224,12 @@ private static InternetDomainName toDomainName(Object 
dnObj) {
 if(dnObj != null) {
   if(dnObj instanceof String) {
 String dn = dnObj.toString();
-return InternetDomainName.from(dn);
+try {
+  return InternetDomainName.from(dn);
--- End diff --

The modified configuration from your test that would test this is:

` /**
   {
"fieldTransformations" : [
 {
   "transformation" : "STELLAR"
  ,"output" : [ "full_hostname", "domain_without_subdomains" ]
  ,"config" : {
 "full_hostname" : 
"URL_TO_HOST('http://1234567890123456789012345678901234567890123456789012345678901234567890/index.html')"
,"domain_without_subdomains" : 
"DOMAIN_REMOVE_SUBDOMAINS(full_hostname)"
  }
 }
  ]
   }
   */`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[ANNOUNCE] Update Quick Dev Vagrant Box

2016-10-31 Thread David Lyle
Hi,

With the merge of METRON-495, there is a new Quick Dev image. Please update
your quick dev boxes (vagrant box update).

Thanks!

-David...


[GitHub] incubator-metron pull request #333: METRON-249: Field Transformation functio...

2016-10-31 Thread cestella
Github user cestella commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/333#discussion_r85829821
  
--- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/NetworkFunctions.java
 ---
@@ -232,10 +237,15 @@ private static URL toUrl(Object urlObj) {
 if(urlObj == null) {
   return null;
 }
-try {
-  return new URL(urlObj.toString());
-} catch (MalformedURLException e) {
-  return null;
+if(urlObj instanceof String) {
+  try {
+return new URL(urlObj.toString());
+  } catch (MalformedURLException e) {
--- End diff --

Yeah, that's a good catch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #333: METRON-249: Field Transformation functions fail...

2016-10-31 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/incubator-metron/pull/333
  
@ottobackwards Yeah, I think we need better documentation and perhaps a 
rethinking of how we handle errors in stellar functions.  That is a broader 
discussion, agreed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #333: METRON-249: Field Transformation functions fail...

2016-10-31 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/333
  
That having been said, and being an issue that is greater than this pr, I'm 
+1 on this.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[DISCUSS] Search Concerns

2016-10-31 Thread zeo...@gmail.com
Hi All,

I've been doing a bit of bug hunting with bro logs within the search tier
of Metron over the last couple of weeks.  During this (in this thread I'm
primarily referring to METRON-517
) I've found a couple of
issues that I'd like to discuss with the wider population.  The primary
issue here is due to a limitation in Lucene itself, meaning we will
encounter the same problem with either Elasticsearch or Solr as far as I
can tell.

*Problems*

1. Lucene, including the latest version (6.2.1), appears to have a hard
coded maximum term length of 32766 (reference

here <%22> for

details ).  If the
indexingBolt attempts to input a non_analyzed

tuple (set via these files ) which exceeds that limit,
the entire message is rejected.
 - If you simply analyze the field it reduces the size for any individual
term, but it also throws a wrench in your queries, when you are searching
for a match of that entire field.

2. From what I can tell, failures are only logged via
/var/log/elasticsearch/metron.log and in the Storm UI under the Bolt Id's
"Last error" column.
 - It looks like this is already partially documented as METRON-307
.


>From here on out I'm going to focus on Problem 1.


*Thoughts*

1. We could use multifield

mappings to be able to do both a full and partial search for fields that
exceed 32766 length.

2. Truncate fields in the indexingBolt to keep non-analyzed values below
the 32766 limit.

3. Ensure that any field with the ability to grow beyond the 32766 limit is
analyzed, and that no single term surpasses the max term limit.

There are some other ways to fix the problem, such as to not store the field
,
not index the field
, ignore
fields larger than a set value
,
etc. but I personally see these as confusing (to the end user) and not very
helpful.  Others have brought up dynamic templates

as well, but I haven't looked into them yet.


*Concerns*

Thought #1

- My current favourite (this is also what logstash does), but it requires
that we analyze the whole message and store a truncated version of the
whole message as a single large term.  If truncation occurs we would need
to:

- Add key-value pairs to the tuple that indicates that it was
truncated, what field(s) was/were truncated, the pre-truncated size of the
field(s), hash of pre-truncated field, and a timestamp of truncation (i.e.
Data tampering).

- Provide UI elements that clearly show that a specific message was
truncated.

- May need to abstract querying in the UI.  If so, this requires a sub-task
to METRON-195 and looking into an interim solution with Kibana.

- See "Other thoughts".


Thought #2

- If we go this path we’d need to address how to do a full string match
(i.e. abstract a copy/paste of a > 32766 length URI to use as a query in
the UI).  This may or may not be possible with Kibana – if not, this needs
to be a subtask in METRON-195.

- Add key-value pairs to the tuple that indicates that it was truncated,
what field(s) was/were truncated, the pre-truncated size of the field(s),
hash of pre-truncated field, and a timestamp of truncation (i.e. Data
tampering).

- Provide UI elements that clearly show that a specific message was
truncated.

- See "Other thoughts".


Thought #3

- Not a huge fan of this solution because of how it affects whole string
matching.

- May need a custom analyzer to cut up the URI properly.  Here <%22http> are

some

relevant 
materials
 if
 we
 go
 that
 path
.


*Other thoughts*

- Maybe we can use the profiler to monitor truncated=True and watch for
people messing with this on 

[GitHub] incubator-metron issue #333: METRON-249: Field Transformation functions fail...

2016-10-31 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/incubator-metron/pull/333
  
I wanted to add, I'm just giving historical context on why decisions were 
made because recent discussions have been around what to do around error states 
in stellar functions.  Not saying that what we came up with before is right or 
wrong, just trying to provide a model for the thinking.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #333: METRON-249: Field Transformation functio...

2016-10-31 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/333#discussion_r85822162
  
--- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/NetworkFunctions.java
 ---
@@ -232,10 +237,15 @@ private static URL toUrl(Object urlObj) {
 if(urlObj == null) {
   return null;
 }
-try {
-  return new URL(urlObj.toString());
-} catch (MalformedURLException e) {
-  return null;
+if(urlObj instanceof String) {
+  try {
+return new URL(urlObj.toString());
+  } catch (MalformedURLException e) {
--- End diff --

Why would Malformed Url not be an exception as well?   It would be much 
better to get a detailed error than null.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #332: METRON-527: Connection pool shut down seen when...

2016-10-31 Thread justinleet
Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/332
  
The Taxii HttpClient closes connections in callTaxiiService as seen here:

https://github.com/TAXIIProject/java-taxii/blob/master/src/main/java/org/mitre/taxii/client/HttpClient.java#L335

Because TaxiiHandler attempted to reuse a closed connection, the error was 
seen.  The fix is just to ensure the connection is created fresh before each 
call.  Integration test is updated to just call the run() method twice without 
caring about results to ensure that the connection doesn't explode.

In addition, this was tested in quick-dev using a slightly modified version 
(to work with Vagrant) of 
https://community.hortonworks.com/articles/59698/pushing-stixtaxii-feeds-from-opentaxii-server-into.html,
 where the playbook was run with
`ansible-playbook 
--private-key=./vagrant/quick-dev-platform/.vagrant/machines/node1/virtualbox/private_key
 -i 192.168.66.121, playbooks/install-opentaxii.yml -e 
ansible_python_interpreter=python -e ansible_user=vagrant -`
with the IP being quick-dev's IP and the install-opentaxii script modified 
to reflect this.

After the change, polling continues until ended and hbase dumps grow as new 
records are added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #332: METRON-527: Connection pool shut down se...

2016-10-31 Thread justinleet
GitHub user justinleet opened a pull request:

https://github.com/apache/incubator-metron/pull/332

METRON-527: Connection pool shut down seen when running threatintel_t…

…axii_load.sh script

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/incubator-metron METRON-527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-metron/pull/332.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #332


commit ba69ceb124003b6a0d4dc4b404b4f9da48ebf52c
Author: justinjleet 
Date:   2016-10-31T16:47:09Z

METRON-527: Connection pool shut down seen when running 
threatintel_taxii_load.sh script




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #323: METRON-514: Snort kafka topic fails to g...

2016-10-31 Thread nickwallen
Github user nickwallen commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/323#discussion_r85796965
  
--- Diff: metron-deployment/roles/yaf/tasks/yaf.yml ---
@@ -48,7 +48,3 @@
 
 - name: Install init.d service script
   template: src=yaf dest=/etc/init.d/yaf mode=0755
-
--- End diff --

Sorry, late to the party. Had to expand the 'thingie' to see that prior 
conversation.   

If I remember correctly, the original reason that was added was because if 
you just deploy and then run 'service yaf start' on CentOS 7, Systemd would 
fail the service immediately.  Doing the `enable` made Systemd aware of the 
older SysV script, so that when we start it later in the deployment, it works.  

But this was probably not the best way to do it, as this has the effect of 
starting the service on boot, which is not what we want.  

I'm good with taking this out (as you have it), since your testing has been 
successful without it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #318: METRON-495: Upgrade Storm to 1.0.x

2016-10-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/318


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Consider highlighting your podling at ApacheCON in Seville

2016-10-31 Thread Roman Shaposhnik
Hi!

with ApacheCON in Seville right around the corner
chances are you've made your travel arrangements
already. If you happen to be around the conference
on Fri, November 18th, 16:30 - 17:20 why not use
that time to highlight your favorite podling?
 https://s.apache.org/aceu2016_shark_tank

Podling Shark Tank is back and it is a perfect opportunity
to give a short, 5 min pitch in a fun environment.
You don't have to be a committer on the project, or
even a developer! All you have to have is a bit of
free time and a lot of passion to let the world know
how awesome this project is!

If you feel interested -- please either sign up on the
wiki page (it also provides more details on the event)
https://wiki.apache.org/apachecon/Seville16PodlingSharkTank
or just reply to this thread.

Either way -- hope to see you at Podling Shark Tank in Seville!

Thanks,
Roman.


[GitHub] incubator-metron pull request #323: METRON-514: Snort kafka topic fails to g...

2016-10-31 Thread nickwallen
Github user nickwallen commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/323#discussion_r85773748
  
--- Diff: metron-deployment/roles/yaf/tasks/yaf.yml ---
@@ -48,7 +48,3 @@
 
 - name: Install init.d service script
   template: src=yaf dest=/etc/init.d/yaf mode=0755
-
--- End diff --

Did you intend to remove these lines related to YAF and CentOS 7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: METRON-378 - variables that don't exist with STELLAR built in arithmetic functions

2016-10-31 Thread Nick Allen
>
>  looking for some sage feedback, hopefully from someone who knows
> the reasoning behind 'return 0d if null ‘.


Doesn't this originate from the idea that a Stellar expression should not
blow-up if a message is missing a field (aka unable to resolve a
variable)?  I remember this as something that I had to get my head around
when I started playing with Stellar.

On Mon, Oct 31, 2016 at 11:16 AM, Casey Stella  wrote:

> I really don't like equating missing variable to 0 as 0 has meaning that
> does not imply it is missing.  What I'd rather see is a return of
> Double.NaN for all situations where arguments are not a number. Just my
> $0.02.
>
> On Fri, Oct 28, 2016 at 10:07 AM, Otto Fowler 
> wrote:
>
> > I was looking at METRON-378, and was wondering if we could discuss a
> little
> > bit.
> >
> > This issue, as stated is that if your stellar expression references
> > variables that are not passed in at runtime, the call still succeeds and
> > passes back a value.
> >
> > From the issue:
> >
> >   @Test(expected = ParseException.class)
> >   public void testMissingVariables() {
> > String query = "1 + cannot + add + missing + variables";
> > run(query, new HashMap<>());
> >   }
> >
> >
> > This works, because getDouble is implemented thusly:
> >
> > private Double getDouble(Token token) {
> >   Number n = (Number) token.getValue();
> >   if (n == null) {
> > return 0d;
> >   } else {
> > return n.doubleValue();
> >   }
> > }
> >
> > Is the STELLAR function suite, we have to do the work to handle missing
> > parameters and variables, but here, for things handled in the
> > StellarCompiler we do not.
> >
> > So the first question is if we want to change this behavior to be
> > consistent with the rest of the library, that is to throw an exception
> with
> > invalid parameters.
> >
> > Changing the above function to return null will accomplish that, with the
> > side effect of having to refactor the validation calls.  As we have
> > discussed before, having validation implemented by passing in a known
> > failure case and expecting an error is not really ideal, since it muddies
> > the purpose of what you are validating ( syntactical correctness of the
> > expression vs logical runtime correctness ) among other things.  With a
> > change like this, validation will get an exception, not the return we
> > currently expect in the tests etc.
> >
> > Maybe we don’t want to handle this in the Compiler at all?  Maybe
> > StellarParser’s parse() function should validate parameters?  This
> would, I
> > think, require a refactoring or new version of validate so that running
> > validate inside of parse is not expensive and uses the existing
> constructs
> > built in the call.  This would give ‘global’ validation to parameters I
> > believe, and allow for some cleanup in the existing functions, at the
> cost
> > of the a per function default handling.
> >
> > Anyways,  looking for some sage feedback, hopefully from someone who
> knows
> > the reasoning behind 'return 0d if null ‘.  Maybe this is a documentation
> > issue, or can be treated as such?
> >
>



-- 
Nick Allen 


Re: METRON-378 - variables that don't exist with STELLAR built in arithmetic functions

2016-10-31 Thread Otto Fowler
There is no difference between converting null to NaN or 0.d.  It is still
converting no value to some value right?


On October 31, 2016 at 11:40:52, Otto Fowler (ottobackwa...@gmail.com)
wrote:

@Test(expected = ParseException.class)
> public void testMissingVariables() {
> String query = "1 + cannot + add + missing + variables";
> run(query, new HashMap<>());
> }


Re: METRON-378 - variables that don't exist with STELLAR built in arithmetic functions

2016-10-31 Thread Otto Fowler
Doing that will not result in an error, it will result in NaN as the return
value.  I don’t think that is what we want either.


On October 31, 2016 at 11:16:47, Casey Stella (ceste...@gmail.com) wrote:

@Test(expected = ParseException.class)
> public void testMissingVariables() {
> String query = "1 + cannot + add + missing + variables";
> run(query, new HashMap<>());
> }


Re: METRON-378 - variables that don't exist with STELLAR built in arithmetic functions

2016-10-31 Thread Otto Fowler
Of course it is METRON-379


On October 28, 2016 at 10:07:52, Otto Fowler (ottobackwa...@gmail.com) wrote:

I was looking at METRON-378, and was wondering if we could discuss a little bit.

This issue, as stated is that if your stellar expression references variables 
that are not passed in at runtime, the call still succeeds and passes back a 
value.

From the issue: 

  @Test(expected = ParseException.class)
  public void testMissingVariables() {
String query = "1 + cannot + add + missing + variables";
run(query, new HashMap<>());
  }

This works, because getDouble is implemented thusly:
private Double getDouble(Token token) {
  Number n = (Number) token.getValue();
  if (n == null) {
return 0d;
  } else {
return n.doubleValue();
  }
}
Is the STELLAR function suite, we have to do the work to handle missing 
parameters and variables, but here, for things handled in the StellarCompiler 
we do not.

So the first question is if we want to change this behavior to be consistent 
with the rest of the library, that is to throw an exception with invalid 
parameters.

Changing the above function to return null will accomplish that, with the side 
effect of having to refactor the validation calls.  As we have discussed 
before, having validation implemented by passing in a known failure case and 
expecting an error is not really ideal, since it muddies the purpose of what 
you are validating ( syntactical correctness of the expression vs logical 
runtime correctness ) among other things.  With a change like this, validation 
will get an exception, not the return we currently expect in the tests etc.

Maybe we don’t want to handle this in the Compiler at all?  Maybe 
StellarParser’s parse() function should validate parameters?  This would, I 
think, require a refactoring or new version of validate so that running 
validate inside of parse is not expensive and uses the existing constructs 
built in the call.  This would give ‘global’ validation to parameters I 
believe, and allow for some cleanup in the existing functions, at the cost of 
the a per function default handling.

Anyways,  looking for some sage feedback, hopefully from someone who knows the 
reasoning behind 'return 0d if null ‘.  Maybe this is a documentation issue, or 
can be treated as such?


Re: METRON-378 - variables that don't exist with STELLAR built in arithmetic functions

2016-10-31 Thread Casey Stella
I really don't like equating missing variable to 0 as 0 has meaning that
does not imply it is missing.  What I'd rather see is a return of
Double.NaN for all situations where arguments are not a number. Just my
$0.02.

On Fri, Oct 28, 2016 at 10:07 AM, Otto Fowler 
wrote:

> I was looking at METRON-378, and was wondering if we could discuss a little
> bit.
>
> This issue, as stated is that if your stellar expression references
> variables that are not passed in at runtime, the call still succeeds and
> passes back a value.
>
> From the issue:
>
>   @Test(expected = ParseException.class)
>   public void testMissingVariables() {
> String query = "1 + cannot + add + missing + variables";
> run(query, new HashMap<>());
>   }
>
>
> This works, because getDouble is implemented thusly:
>
> private Double getDouble(Token token) {
>   Number n = (Number) token.getValue();
>   if (n == null) {
> return 0d;
>   } else {
> return n.doubleValue();
>   }
> }
>
> Is the STELLAR function suite, we have to do the work to handle missing
> parameters and variables, but here, for things handled in the
> StellarCompiler we do not.
>
> So the first question is if we want to change this behavior to be
> consistent with the rest of the library, that is to throw an exception with
> invalid parameters.
>
> Changing the above function to return null will accomplish that, with the
> side effect of having to refactor the validation calls.  As we have
> discussed before, having validation implemented by passing in a known
> failure case and expecting an error is not really ideal, since it muddies
> the purpose of what you are validating ( syntactical correctness of the
> expression vs logical runtime correctness ) among other things.  With a
> change like this, validation will get an exception, not the return we
> currently expect in the tests etc.
>
> Maybe we don’t want to handle this in the Compiler at all?  Maybe
> StellarParser’s parse() function should validate parameters?  This would, I
> think, require a refactoring or new version of validate so that running
> validate inside of parse is not expensive and uses the existing constructs
> built in the call.  This would give ‘global’ validation to parameters I
> believe, and allow for some cleanup in the existing functions, at the cost
> of the a per function default handling.
>
> Anyways,  looking for some sage feedback, hopefully from someone who knows
> the reasoning behind 'return 0d if null ‘.  Maybe this is a documentation
> issue, or can be treated as such?
>


[GitHub] incubator-metron issue #318: METRON-495: Upgrade Storm to 1.0.x

2016-10-31 Thread cestella
Github user cestella commented on the issue:

https://github.com/apache/incubator-metron/pull/318
  
I checked the licensing changes @mmiklavc and they look sensible to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #327: METRON-521: Stellar function documentati...

2016-10-31 Thread cestella
Github user cestella commented on a diff in the pull request:

https://github.com/apache/incubator-metron/pull/327#discussion_r85738429
  
--- Diff: 
metron-platform/metron-common/src/main/java/org/apache/metron/common/dsl/functions/DataStructureFunctions.java
 ---
@@ -138,9 +138,9 @@ public Object apply(List args) {
   }
 
   @Stellar(name="IS_EMPTY"
-  , description="Returns true if string or collection is empty and 
false otherwise"
-  , params = { "input - Object of string or collection type (e.g. 
list)"}
-  , returns = "Boolean"
+  , description="Returns true if string or collection is empty and 
false if otherwise."
+  , params = { "input - Object of string or collection type (for 
example, list)"}
+  , returns = "True if the string or collection is empty and false 
otherwise."
--- End diff --

thanks, got it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron issue #331: METRON-536 Fix apache id for Otto Fowler

2016-10-31 Thread ottobackwards
Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/331
  
I will commit to the asf site branch after this commit


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #331: METRON-536 Fix apache id for Otto Fowler

2016-10-31 Thread ottobackwards
GitHub user ottobackwards opened a pull request:

https://github.com/apache/incubator-metron/pull/331

METRON-536 Fix apache id for Otto Fowler

Sorry, my apache ID ended up being different from when I staged the PR

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ottobackwards/incubator-metron METRON-526

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-metron/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #331


commit 4b740cc77753dc6f9f817d49eb312dd8bf6815b4
Author: Otto Fowler 
Date:   2016-10-31T13:14:04Z

METRON-536 Fix apache id for Otto Fowler




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] incubator-metron pull request #330: Metron 506 - Add Otto Fowler to committe...

2016-10-31 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/330


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---