[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/incubator-metron/pull/471
  
Ok, moved it to the top.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[Matt Foley]

I feel the introductory text for the PR should be at the top.  That’s the 
interesting part.  The template checklist is to make sure the necessary got 
done; it’s important, but should come second. IMHO.


On 3/6/17, 8:01 AM, "David Lyle"  wrote:

I have a weak preference for top comments.


On Mon, Mar 6, 2017 at 10:22 AM, JonZeolla  wrote:

> Github user JonZeolla commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/471
>
> It seems that some people prefer to add their comments to the top
> instead of the bottom.  I have no preference.  Would anybody recommend we
> swap it?
>
>
> ---
> If your project is set up for it, you can reply to this email and have 
your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, 
please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[kylerichardson]

Github user kylerichardson commented on the issue:

https://github.com/apache/incubator-metron/pull/471
  
I'd prefer contributor comments at the top.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[justinleet]

Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/471
  
I prefer top, but I don't really care that much.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[David Lyle]

I have a weak preference for top comments.


On Mon, Mar 6, 2017 at 10:22 AM, JonZeolla  wrote:

> Github user JonZeolla commented on the issue:
>
> https://github.com/apache/incubator-metron/pull/471
>
> It seems that some people prefer to add their comments to the top
> instead of the bottom.  I have no preference.  Would anybody recommend we
> swap it?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[JonZeolla]

Github user JonZeolla commented on the issue:

https://github.com/apache/incubator-metron/pull/471
  
It seems that some people prefer to add their comments to the top instead 
of the bottom.  I have no preference.  Would anybody recommend we swap it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-metron issue #471: METRON-755 Update GitHub PR Template

[james-sirota]

Github user james-sirota commented on the issue:

https://github.com/apache/incubator-metron/pull/471
  
+1 i agree thats a great idea. Should this be on the wiki or version 
controlled?  The other two docs this refers to are on the wiki. we should 
probably be consistent. either transition them into github or have this be a 
part of the wiki


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---