[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/497 +1 by inspection and via vagrant. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user cestella commented on the issue: https://github.com/apache/incubator-metron/pull/497 Just a comment, METRON-797 and METRON-793 are both in master as of the time of this comment, so these docs can be done on current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Okay, try this: https://github.com/mattf-horton/incubator-metron/blob/METRON-804/metron-deployment/vagrant/Kerberos-setup.md I wasn’t able to build a PR to your branch, seems there’s a non-ff in the way the previous patch was merged. Anyway, if you just grab that file and diff against yours, you’ll see the change is small. Items 7, 8, and 20 needed to be fixed. The problem is that “a-b-c” paragraphs aren’t actually list-items, as MD only knows roman numerals for list numbering. Since they are paragraphs, the codeblocks and images under them should be at the SAME indent level, and separated by explicit blank line. This works in both Github-MD and doxia-markdown. It looks slightly better in doxia because in Github the “a-b-c” paragraphs are exdented a little. If you hate it we can try a couple other things, but I thought this was close enough. Cheers, --Matt On 3/30/17, 2:40 PM, "Matt Foley" wrote: That’s weird. Mine looks fine: https://github.com/mattf-horton/incubator-metron/blob/METRON-804-notes/METRON-804-mf.tiff But the tooling was exactly that of https://github.com/mattf-horton/incubator-metron/tree/METRON-804/site-book/bin What additional changes did you make? Oh, I just looked in github, and it’s broken there! How ironic. On your side, is it broken in Github or in the site-book? --Matt On 3/30/17, 11:15 AM, "mmiklavc" wrote: Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mattf-horton Thanks again for the patch! I made a couple more minor tweaks to get the images and indentation correct for the nested lists. I'm unable to get a nested list code block to format correctly, however. It's not bad, but it's just not quite right. If anyone has any suggestions, please chime in.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
That’s weird. Mine looks fine: https://github.com/mattf-horton/incubator-metron/blob/METRON-804-notes/METRON-804-mf.tiff But the tooling was exactly that of https://github.com/mattf-horton/incubator-metron/tree/METRON-804/site-book/bin What additional changes did you make? Oh, I just looked in github, and it’s broken there! How ironic. On your side, is it broken in Github or in the site-book? --Matt On 3/30/17, 11:15 AM, "mmiklavc" wrote: Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mattf-horton Thanks again for the patch! I made a couple more minor tweaks to get the images and indentation correct for the nested lists. I'm unable to get a nested list code block to format correctly, however. It's not bad, but it's just not quite right. If anyone has any suggestions, please chime in.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mattf-horton Thanks again for the patch! I made a couple more minor tweaks to get the images and indentation correct for the nested lists. I'm unable to get a nested list code block to format correctly, however. It's not bad, but it's just not quite right. If anyone has any suggestions, please chime in.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/497 Hi @anandsubbu - just to be clear, this doc requires METRON-793 and METRON-797. Are you running with those branches? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user mmiklavc commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mattf-horton Thanks! I will pull this in and review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user kylerichardson commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mmiklavc Nice document! Planning to run through it myself later this week. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-metron issue #497: METRON-804: Create a document to describe kerbe...
Github user mattf-horton commented on the issue: https://github.com/apache/incubator-metron/pull/497 @mmiklavc , Markdown requires you to indent a codeblock (beginning and ending triple back-ticks) if you wish it to be "under" a list item. Otherwise it interrupts the list, as you've seen, so the next list item restarts at "1". I've sent you a PR with fixes. Also substituted "a b c" for sub-item numbering, and split item 7 into sub-items to make it easier to read. You may squash without attribution. --Matt --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
