Client pipe problem (bug)

2010-05-30 Thread Doron Fediuck
Hi !
I'm implementing some basic client functionality using sshd client.
I found a case where I need to implement something of this concept:
gzip /tmp/sample.txt | ssh u...@some.host.com gunzip -c  /tmp/sample.txt

On my implementation the code (using sshd client) is running an exec channel
of the gzip command into stdout. Then I should be able to use the stdout stream
and use it to unzip the file locally.

Here's a snip of my implementation:

   // Create the GZIP output stream
   ByteArrayOutputStream baosGZipped = new ByteArrayOutputStream ();
   GZIPOutputStream gzOut = new GZIPOutputStream(baosGZipped);

   // Open the input file
   FileInputStream src = new FileInputStream(sourceFileName);

   byte[] buf = new byte[1024];
   int len;
   while ((len = src.read(buf))  0) {
gzOut.write(buf, 0, len);
   }
   src.close();

   // Complete the GZIP file
   gzOut.finish();
   gzOut.flush();
   gzOut.close();

 //create channel
ClientChannel channel = session.createExecChannel(gunzip -c  + 
destFile);

ByteArrayInputStream in = new 
ByteArrayInputStream(baosGZipped.toByteArray());
channel.setIn(in);
ByteArrayOutputStream out = new ByteArrayOutputStream();
channel.setOut(out);
ByteArrayOutputStream err = new ByteArrayOutputStream();
channel.setErr(err);

//open channel
channel.open();

//wait close
channel.waitFor(ClientChannel.CLOSED, 0);


What I discovered is that this will never end !!!
The problem is, that there's a pumpInputStream thread in 
(org/apache/sshd/client/channel/ChannelSession.java),
that will never end until closeFuture.isClosed. Since this does not happen, the 
unzip in the remote host doesn't end,
and the channel will never close. This prevents the client from a proper pipe 
implementation.

There should be a method to properly end this while-loop thus the remote side 
will be able to finish and close.
Can you please open a bug for this issue ?

Thanks !
Doron.


[jira] Created: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Bogdan Pistol (JIRA)
Bosh-0.4 - Servet + SSL + flash crossdomain
---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor


This patch implements a Servlet that acts like a BOSH handler.
The pom.xml is updated to depend on jetty-servlet.
Jetty SSL is implemented and a keystore is provided to test on HTTPS.

Because there are already 2 patches I cannot make incremental diffs against SVN 
(only a total patch that will incorporate the previous diffs/patches). So I 
used the GNU diff command to create a unified diff that is incremental to the 
other patches. First you have to apply the first patches and then this patch 
that is only incremental for easy reading. The actual command to create the 
diff is:
diff -x .svn -urN tree1 tree2
And to apply the patch from within the xep0124-xep0206-bosh folder:
patch -p1  the-patch

It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Bogdan Pistol (JIRA)

 [ 
https://issues.apache.org/jira/browse/VYSPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Pistol updated VYSPER-205:
-

Description: 
This patch implements a Servlet that acts like a BOSH handler.
The pom.xml is updated to depend on jetty-servlet.
Jetty SSL is implemented and a keystore is provided to test on HTTPS.

Because there are already 2 patches 
(https://issues.apache.org/jira/browse/VYSPER-204) I cannot make incremental 
diffs against SVN (only a total patch that will incorporate the previous 
diffs/patches). So I used the GNU diff command to create a unified diff that is 
incremental to the other patches. First you have to apply the first patches and 
then this patch that is only incremental for easy reading. The actual command 
to create the diff is:
diff -x .svn -urN tree1 tree2
And to apply the patch from within the xep0124-xep0206-bosh folder:
patch -p1  the-patch

It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
segments should be 1 in the second screen of the wizard)

  was:
This patch implements a Servlet that acts like a BOSH handler.
The pom.xml is updated to depend on jetty-servlet.
Jetty SSL is implemented and a keystore is provided to test on HTTPS.

Because there are already 2 patches I cannot make incremental diffs against SVN 
(only a total patch that will incorporate the previous diffs/patches). So I 
used the GNU diff command to create a unified diff that is incremental to the 
other patches. First you have to apply the first patches and then this patch 
that is only incremental for easy reading. The actual command to create the 
diff is:
diff -x .svn -urN tree1 tree2
And to apply the patch from within the xep0124-xep0206-bosh folder:
patch -p1  the-patch

It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
segments should be 1 in the second screen of the wizard)


 Bosh-0.4 - Servet + SSL + flash crossdomain
 ---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.4-binary.tgz, bosh-0.4.patch


 This patch implements a Servlet that acts like a BOSH handler.
 The pom.xml is updated to depend on jetty-servlet.
 Jetty SSL is implemented and a keystore is provided to test on HTTPS.
 Because there are already 2 patches 
 (https://issues.apache.org/jira/browse/VYSPER-204) I cannot make incremental 
 diffs against SVN (only a total patch that will incorporate the previous 
 diffs/patches). So I used the GNU diff command to create a unified diff that 
 is incremental to the other patches. First you have to apply the first 
 patches and then this patch that is only incremental for easy reading. The 
 actual command to create the diff is:
 diff -x .svn -urN tree1 tree2
 And to apply the patch from within the xep0124-xep0206-bosh folder:
 patch -p1  the-patch
 It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
 segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Bogdan Pistol (JIRA)

 [ 
https://issues.apache.org/jira/browse/VYSPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bogdan Pistol updated VYSPER-205:
-

Attachment: bosh-0.4.patch
bosh-0.4-binary.tgz

 Bosh-0.4 - Servet + SSL + flash crossdomain
 ---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.4-binary.tgz, bosh-0.4.patch


 This patch implements a Servlet that acts like a BOSH handler.
 The pom.xml is updated to depend on jetty-servlet.
 Jetty SSL is implemented and a keystore is provided to test on HTTPS.
 Because there are already 2 patches I cannot make incremental diffs against 
 SVN (only a total patch that will incorporate the previous diffs/patches). So 
 I used the GNU diff command to create a unified diff that is incremental to 
 the other patches. First you have to apply the first patches and then this 
 patch that is only incremental for easy reading. The actual command to create 
 the diff is:
 diff -x .svn -urN tree1 tree2
 And to apply the patch from within the xep0124-xep0206-bosh folder:
 patch -p1  the-patch
 It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
 segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



MINA coding conventions

2010-05-30 Thread Niklas Gustavsson
Hi

In our current coding conventions, we use maximum line widths of 80
chars. I personally find this somewhat limited on modern displays and
tend to prefer 120 chars. How about changing this in our coding
conventions?

/niklas


Re: MINA coding conventions

2010-05-30 Thread Maarten Bosteels
+1

On Sun, May 30, 2010 at 11:03 PM, Niklas Gustavsson nik...@protocol7.comwrote:

 Hi

 In our current coding conventions, we use maximum line widths of 80
 chars. I personally find this somewhat limited on modern displays and
 tend to prefer 120 chars. How about changing this in our coding
 conventions?

 /niklas



Re: MINA coding conventions

2010-05-30 Thread Jeff Genender
+1

Jeff

On May 30, 2010, at 3:03 PM, Niklas Gustavsson wrote:

 Hi
 
 In our current coding conventions, we use maximum line widths of 80
 chars. I personally find this somewhat limited on modern displays and
 tend to prefer 120 chars. How about changing this in our coding
 conventions?
 
 /niklas



[jira] Commented: (VYSPER-203) Record new dependencies from BOSH extension

2010-05-30 Thread Niklas Gustavsson (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873488#action_12873488
 ] 

Niklas Gustavsson commented on VYSPER-203:
--

Adding CheckPlayer, flCookie, flensedCore and SWFObject (all MIT) to the list 
to handle

 Record new dependencies from BOSH extension
 ---

 Key: VYSPER-203
 URL: https://issues.apache.org/jira/browse/VYSPER-203
 Project: VYSPER
  Issue Type: Task
Affects Versions: 0.6
Reporter: Bernd Fondermann
Priority: Blocker

 BOSH introduces new dependencies. License must be checked and records be made 
 in our release notes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (VYSPER-203) Record new dependencies from BOSH extension

2010-05-30 Thread Niklas Gustavsson (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873489#action_12873489
 ] 

Niklas Gustavsson commented on VYSPER-203:
--

And jQuery (MIT)

 Record new dependencies from BOSH extension
 ---

 Key: VYSPER-203
 URL: https://issues.apache.org/jira/browse/VYSPER-203
 Project: VYSPER
  Issue Type: Task
Affects Versions: 0.6
Reporter: Bernd Fondermann
Priority: Blocker

 BOSH introduces new dependencies. License must be checked and records be made 
 in our release notes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (VYSPER-204) Bosh-0.2, Bosh-0.3 - Strophe.js client implementation

2010-05-30 Thread Niklas Gustavsson (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873490#action_12873490
 ] 

Niklas Gustavsson commented on VYSPER-204:
--

updateplayer.swf, is that part of CheckPlayer?

 Bosh-0.2, Bosh-0.3 - Strophe.js client implementation
 -

 Key: VYSPER-204
 URL: https://issues.apache.org/jira/browse/VYSPER-204
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.2.patch, bosh-0.3-patch-libraries.tar.gz, 
 bosh-0.3.patch


 Implementation of the client that before was provided as a copy/paste example 
 from the Professional XMPP Programming with JavaScript and jQuery book.
 The implementation is my own and can be included in the tree.
 The libraries used are downloaded from their sites, and all are distributed 
 under the MIT license (strophe include BSD code and public domain code in its 
 own implementation). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[Vysper] XMPP BOSH - Week 1

2010-05-30 Thread Bogdan Ciprian Pistol
Hi all,

As I promised in the GSoC proposal I will publish weekly status reports.
For this I setup a blog at http://vysper-gsoc2010.blogspot.com/

Would be convenient also to publish the reports here on ML? (maybe for
archiving purposes and maybe you may prefer to reply in-line on my
report if you have some comments).

Bogdan


Re: MINA coding conventions

2010-05-30 Thread Bernd Fondermann
Niklas Gustavsson wrote:
 Hi
 
 In our current coding conventions, we use maximum line widths of 80
 chars. I personally find this somewhat limited on modern displays and
 tend to prefer 120 chars. How about changing this in our coding
 conventions?

+1

Also, you might want to review thread Death to TRS80 coders from
November last year for some elaborate comments on this topic. ;-)


  Bernd


[jira] Commented: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Niklas Gustavsson (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873492#action_12873492
 ] 

Niklas Gustavsson commented on VYSPER-205:
--

Patch format is just fine, thanks!

Patch applied in rev 949587. Added license header to crossdomain.xml, please 
make sure it still works with Flash. 

 Bosh-0.4 - Servet + SSL + flash crossdomain
 ---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.4-binary.tgz, bosh-0.4.patch


 This patch implements a Servlet that acts like a BOSH handler.
 The pom.xml is updated to depend on jetty-servlet.
 Jetty SSL is implemented and a keystore is provided to test on HTTPS.
 Because there are already 2 patches 
 (https://issues.apache.org/jira/browse/VYSPER-204) I cannot make incremental 
 diffs against SVN (only a total patch that will incorporate the previous 
 diffs/patches). So I used the GNU diff command to create a unified diff that 
 is incremental to the other patches. First you have to apply the first 
 patches and then this patch that is only incremental for easy reading. The 
 actual command to create the diff is:
 diff -x .svn -urN tree1 tree2
 And to apply the patch from within the xep0124-xep0206-bosh folder:
 patch -p1  the-patch
 It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
 segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Closed: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Niklas Gustavsson (JIRA)

 [ 
https://issues.apache.org/jira/browse/VYSPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Niklas Gustavsson closed VYSPER-205.


  Assignee: Niklas Gustavsson
Resolution: Fixed

 Bosh-0.4 - Servet + SSL + flash crossdomain
 ---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Assignee: Niklas Gustavsson
Priority: Minor
 Attachments: bosh-0.4-binary.tgz, bosh-0.4.patch


 This patch implements a Servlet that acts like a BOSH handler.
 The pom.xml is updated to depend on jetty-servlet.
 Jetty SSL is implemented and a keystore is provided to test on HTTPS.
 Because there are already 2 patches 
 (https://issues.apache.org/jira/browse/VYSPER-204) I cannot make incremental 
 diffs against SVN (only a total patch that will incorporate the previous 
 diffs/patches). So I used the GNU diff command to create a unified diff that 
 is incremental to the other patches. First you have to apply the first 
 patches and then this patch that is only incremental for easy reading. The 
 actual command to create the diff is:
 diff -x .svn -urN tree1 tree2
 And to apply the patch from within the xep0124-xep0206-bosh folder:
 patch -p1  the-patch
 It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
 segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (VYSPER-204) Bosh-0.2, Bosh-0.3 - Strophe.js client implementation

2010-05-30 Thread Bogdan Pistol (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873493#action_12873493
 ] 

Bogdan Pistol commented on VYSPER-204:
--

All of the libraries in the flxhr folder are from an archive 
flXHR-1.0.5.tar.gz, they come as a deployment distribution from 
http://flxhr.flensed.com/download.php#flxhr

At http://checkplayer.flensed.com/documentation.php they say that:
quote
 CheckPlayer relies on the following files being available:

* flensedCore
* swfobject.js (SWFObject 2.1)
* updateplayer.swf (if an auto-update is to occur)
/quote

So, yes, I guess that updateplayer.swf is part of CheckPlayer.

 Bosh-0.2, Bosh-0.3 - Strophe.js client implementation
 -

 Key: VYSPER-204
 URL: https://issues.apache.org/jira/browse/VYSPER-204
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.2.patch, bosh-0.3-patch-libraries.tar.gz, 
 bosh-0.3.patch


 Implementation of the client that before was provided as a copy/paste example 
 from the Professional XMPP Programming with JavaScript and jQuery book.
 The implementation is my own and can be included in the tree.
 The libraries used are downloaded from their sites, and all are distributed 
 under the MIT license (strophe include BSD code and public domain code in its 
 own implementation). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (VYSPER-204) Bosh-0.2, Bosh-0.3 - Strophe.js client implementation

2010-05-30 Thread Niklas Gustavsson (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873494#action_12873494
 ] 

Niklas Gustavsson commented on VYSPER-204:
--

Patches applied in revs 949578, 949579,  949586.

 Bosh-0.2, Bosh-0.3 - Strophe.js client implementation
 -

 Key: VYSPER-204
 URL: https://issues.apache.org/jira/browse/VYSPER-204
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Priority: Minor
 Attachments: bosh-0.2.patch, bosh-0.3-patch-libraries.tar.gz, 
 bosh-0.3.patch


 Implementation of the client that before was provided as a copy/paste example 
 from the Professional XMPP Programming with JavaScript and jQuery book.
 The implementation is my own and can be included in the tree.
 The libraries used are downloaded from their sites, and all are distributed 
 under the MIT license (strophe include BSD code and public domain code in its 
 own implementation). 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: MINA coding conventions

2010-05-30 Thread Emmanuel Lecharny

On 5/30/10 11:03 PM, Niklas Gustavsson wrote:

Hi

In our current coding conventions, we use maximum line widths of 80
chars. I personally find this somewhat limited on modern displays and
tend to prefer 120 chars. How about changing this in our coding
conventions?
   

I thought we already agreed on 128 chars per line, a while back ?


--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com




Re: MINA coding conventions

2010-05-30 Thread Bogdan Ciprian Pistol
In the http://mina.apache.org/developer-guide.data/ImprovedJavaConventions.xml
the line limit is configured at 80.
There is another more current configuration, or this one should be updated?

Thanks,

Bogdan

On Mon, May 31, 2010 at 12:45 AM, Emmanuel Lecharny elecha...@gmail.com wrote:
 On 5/30/10 11:03 PM, Niklas Gustavsson wrote:

 Hi

 In our current coding conventions, we use maximum line widths of 80
 chars. I personally find this somewhat limited on modern displays and
 tend to prefer 120 chars. How about changing this in our coding
 conventions?


 I thought we already agreed on 128 chars per line, a while back ?


 --
 Regards,
 Cordialement,
 Emmanuel Lécharny
 www.nextury.com





Re: [Vysper] XMPP BOSH - Week 1

2010-05-30 Thread Niklas Gustavsson
On Sun, May 30, 2010 at 11:28 PM, Bogdan Ciprian Pistol
bogdancipr...@gmail.com wrote:
 As I promised in the GSoC proposal I will publish weekly status reports.
 For this I setup a blog at http://vysper-gsoc2010.blogspot.com/

Great!

 Would be convenient also to publish the reports here on ML? (maybe for
 archiving purposes and maybe you may prefer to reply in-line on my
 report if you have some comments).

Having it on the ML as well would be the best thing to involve the
whole community.

/niklas


Re: [Vysper] XMPP BOSH - Week 1

2010-05-30 Thread Bogdan Ciprian Pistol
On Mon, May 31, 2010 at 12:50 AM, Niklas Gustavsson
nik...@protocol7.com wrote:
 Having it on the ML as well would be the best thing to involve the
 whole community.

Ok,

Week 1 - status report

The following tasks were scheduled until next week (June 6):

* integrating Jetty into Vysper
* implementing the parsing (reusing existing components from Vysper)
* interpreting in a Handler the session creation request and
creating a context for the session (possibly a subcass of
AbstractSessionContext)
* SSL filter handling for configured TCPEndpoints with SSL

Completed:

* Jetty integration as a servlet
* Integration of Flash cross domain policy (that simplifies cross
domain XHR with the MIT licensed flXHR library)
* SSL configuration for the endpoint
* Strophe.js based client as an example

Patches:

* https://issues.apache.org/jira/browse/VYSPER-204
* https://issues.apache.org/jira/browse/VYSPER-205


In progress:

* Parsing the XML received from the client with nbxml
* figuring out how should the parsed messages be handled

Next:

* finish implementing XML parsing
* handling the parsed messages and responding back to the client


Bogdan


[jira] Commented: (VYSPER-205) Bosh-0.4 - Servet + SSL + flash crossdomain

2010-05-30 Thread Bogdan Pistol (JIRA)

[ 
https://issues.apache.org/jira/browse/VYSPER-205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12873502#action_12873502
 ] 

Bogdan Pistol commented on VYSPER-205:
--

Ok, I verified, and it still works in Flash.

 Bosh-0.4 - Servet + SSL + flash crossdomain
 ---

 Key: VYSPER-205
 URL: https://issues.apache.org/jira/browse/VYSPER-205
 Project: VYSPER
  Issue Type: Improvement
  Components: extension
Reporter: Bogdan Pistol
Assignee: Niklas Gustavsson
Priority: Minor
 Attachments: bosh-0.4-binary.tgz, bosh-0.4.patch


 This patch implements a Servlet that acts like a BOSH handler.
 The pom.xml is updated to depend on jetty-servlet.
 Jetty SSL is implemented and a keystore is provided to test on HTTPS.
 Because there are already 2 patches 
 (https://issues.apache.org/jira/browse/VYSPER-204) I cannot make incremental 
 diffs against SVN (only a total patch that will incorporate the previous 
 diffs/patches). So I used the GNU diff command to create a unified diff that 
 is incremental to the other patches. First you have to apply the first 
 patches and then this patch that is only incremental for easy reading. The 
 actual command to create the diff is:
 diff -x .svn -urN tree1 tree2
 And to apply the patch from within the xep0124-xep0206-bosh folder:
 patch -p1  the-patch
 It also works in Eclipse from Team - Apply patch, (Ignore leading path name 
 segments should be 1 in the second screen of the wizard)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: MINA coding conventions

2010-05-30 Thread Niklas Gustavsson
On Sun, May 30, 2010 at 11:33 PM, Bernd Fondermann
bf_...@brainlounge.de wrote:
 Also, you might want to review thread Death to TRS80 coders from
 November last year for some elaborate comments on this topic. ;-)

Now I wish I worked a little bit harder on the subject of this thread
:-D Anyways, seems people agree on 120 chars (Emmanuel suggested 128
which is pretty much in the same ballpark). I'll update the
conventions file in the wiki.

/niklas


Re: MINA coding conventions

2010-05-30 Thread Emmanuel Lecharny

On 5/30/10 11:58 PM, Niklas Gustavsson wrote:

On Sun, May 30, 2010 at 11:33 PM, Bernd Fondermann
bf_...@brainlounge.de  wrote:
   

Also, you might want to review thread Death to TRS80 coders from
November last year for some elaborate comments on this topic. ;-)
 

Now I wish I worked a little bit harder on the subject of this thread
:-D Anyways, seems people agree on 120 chars (Emmanuel suggested 128
which is pretty much in the same ballpark). I'll update the
conventions file in the wiki.
   
120 is 2^6.90689059508519, which doe snot fit my own representation of 
the world, where all is either true or false.


However, here, even a 1 is not exactly 5 volts, it's sometime 4.8 volts, 
so I accept to limit my lines to 120 chars...


May I suggest 127 ? Ok, ok, you won :)

--
Regards,
Cordialement,
Emmanuel Lécharny
www.nextury.com




Build failed in Hudson: vysper-trunk- jdk1.6-ibm-ubuntu » Apache Vysper #229

2010-05-30 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/vysper-trunk-jdk1.6-ibm-ubuntu/org.apache.vysper$vysper/229/

--
[...truncated 270 lines...]
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/NamespaceHandlerDictionary.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/commandstanza/EndOfSessionCommandStanza.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/commandstanza/CommandStanza.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/AuthorizationFailedException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/TLSException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/BadXMLException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EncryptionStartedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/StartedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EndOrClosedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/AuthenticatedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EncryptedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/AbstractStateAwareProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/InboundStanzaProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/InitiatedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/UnconnectedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/ProtocolException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/QueuedStanzaProcessor.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/ServiceUnavailableStanzaErrorHandler.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/HandlerDictionary.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/SessionStateHolder.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/TrustManagerFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/BogusTrustManagerFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/AbstractTLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/TLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/FileBasedTLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/parser/io/PlainToTLSStreaming.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/parser/ParsingErrorCondition.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/server/components/ComponentStanzaHandlerLookup.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/server/components/ComponentStanzaProcessor.java
 longer than 100 characters.
[WARNING] Entry: 

Build failed in Hudson: vysper-trunk-jdk1.6-ibm-ubuntu #229

2010-05-30 Thread Apache Hudson Server
See 
http://hudson.zones.apache.org/hudson/job/vysper-trunk-jdk1.6-ibm-ubuntu/229/changes

Changes:

[ngn] Adding first stab at a BOSH servlet (VYSPER-205). By Bogdan Pistol

[ngn] Adding libraries needed for the example (VYSPER-204). By Bogdan Pistol

[ngn] Adding example (VYSPER-204). By Bogdan Pistol

[ngn] Code formatting and fixing path to keystore (VYSPER-204). By Bogdan Pistol

--
[...truncated 1712 lines...]
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/commandstanza/CommandStanza.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/AuthorizationFailedException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/TLSException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/exception/BadXMLException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/StanzaHandlerLookup.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EncryptionStartedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/StartedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EndOrClosedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/AuthenticatedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/EncryptedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/AbstractStateAwareProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/InboundStanzaProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/InitiatedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/worker/UnconnectedProtocolWorker.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/ProtocolException.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/QueuedStanzaProcessor.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/ServiceUnavailableStanzaErrorHandler.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/HandlerDictionary.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/protocol/SessionStateHolder.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/TrustManagerFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/BogusTrustManagerFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/AbstractTLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/TLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/cryptography/FileBasedTLSContextFactory.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/parser/io/PlainToTLSStreaming.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/parser/ParsingErrorCondition.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/server/components/ComponentStanzaHandlerLookup.java
 longer than 100 characters.
[WARNING] Entry: 
vysper-0.6-SNAPSHOT/server/core/src/main/java/org/apache/vysper/xmpp/server/components/ComponentStanzaProcessor.java
 longer than 100 characters.
[WARNING] Entry: