Re: [VOTE] Release SSHD 0.12.0
+1 --jamie On Wed, Jul 9, 2014 at 6:33 AM, Guillaume Nodet wrote: > Vote to release the 0.12.0 version of SSHD > > Release notes: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12326775 > Staging repository: >https://repository.apache.org/content/repositories/orgapachemina-1004 > Distributions: > > https://repository.apache.org/content/repositories/orgapachemina-1004/org/apache/sshd/apache-sshd/0.12.0/ > Tag: > > https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=tree;hb=0f76c3cafdc32f7f38b95624b06808edc5299add > > This release contains one major new feature (git command to provide access > through ssh) and a bunch some bug and improvements. > > This vote will be open for at least 72 hours. > Please review and vote. > > Cheers, > Guillaume Nodet
[jira] [Commented] (SSHD-332) Nio2 & security
[ https://issues.apache.org/jira/browse/SSHD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056214#comment-14056214 ] Gaël Lalire commented on SSHD-332: -- You added AccessController.doPrivileged that should be ok, thanks. > Nio2 & security > --- > > Key: SSHD-332 > URL: https://issues.apache.org/jira/browse/SSHD-332 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 0.11.0 > Environment: Oracle Java 8 >Reporter: Gaël Lalire >Assignee: Guillaume Nodet > Fix For: 0.12.0 > > Attachments: securesshd-0.0.1-SNAPSHOT-jar-with-dependencies.jar, > securesshd.zip > > Original Estimate: 96h > Remaining Estimate: 96h > > I don't know if it is a JVM bug or normal behavior but a ProtectionDomain > with no permission is associated with completionHandler thread by > sun.misc.InnocuousThread class. > As a result if a security manager is set all code in completionHandler has no > permission (event if policy grants all permission). > If the behavior of JVM is correct then you should add > AccessController.doPrivileged() when entering completionHandler. > You can also check if a SecurityManager is set and run without Nio2 as a > quick fix. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SSHD-332) Nio2 & security
[ https://issues.apache.org/jira/browse/SSHD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056203#comment-14056203 ] Gaël Lalire commented on SSHD-332: -- I check your code and an AsynchronousChannelGroup is used. The associated ExecutorService is a fixed thread pool and should have normal permissions. Maybe JVM issue. > Nio2 & security > --- > > Key: SSHD-332 > URL: https://issues.apache.org/jira/browse/SSHD-332 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 0.11.0 > Environment: Oracle Java 8 >Reporter: Gaël Lalire >Assignee: Guillaume Nodet > Fix For: 0.12.0 > > Attachments: securesshd-0.0.1-SNAPSHOT-jar-with-dependencies.jar, > securesshd.zip > > Original Estimate: 96h > Remaining Estimate: 96h > > I don't know if it is a JVM bug or normal behavior but a ProtectionDomain > with no permission is associated with completionHandler thread by > sun.misc.InnocuousThread class. > As a result if a security manager is set all code in completionHandler has no > permission (event if policy grants all permission). > If the behavior of JVM is correct then you should add > AccessController.doPrivileged() when entering completionHandler. > You can also check if a SecurityManager is set and run without Nio2 as a > quick fix. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (SSHD-332) Nio2 & security
[ https://issues.apache.org/jira/browse/SSHD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet resolved SSHD-332. -- Resolution: Fixed https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=commit;h=bfe6cb753a69755301e8c8d3db006f4fb436464d > Nio2 & security > --- > > Key: SSHD-332 > URL: https://issues.apache.org/jira/browse/SSHD-332 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 0.11.0 > Environment: Oracle Java 8 >Reporter: Gaël Lalire >Assignee: Guillaume Nodet > Fix For: 0.12.0 > > Attachments: securesshd-0.0.1-SNAPSHOT-jar-with-dependencies.jar, > securesshd.zip > > Original Estimate: 96h > Remaining Estimate: 96h > > I don't know if it is a JVM bug or normal behavior but a ProtectionDomain > with no permission is associated with completionHandler thread by > sun.misc.InnocuousThread class. > As a result if a security manager is set all code in completionHandler has no > permission (event if policy grants all permission). > If the behavior of JVM is correct then you should add > AccessController.doPrivileged() when entering completionHandler. > You can also check if a SecurityManager is set and run without Nio2 as a > quick fix. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Reopened] (SSHD-332) Nio2 & security
[ https://issues.apache.org/jira/browse/SSHD-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaël Lalire reopened SSHD-332: -- Sorry I get an answer from Oracle and it is expected. So you may close as "wont fix" if you doesn't want to fix it but not at resolved. > Nio2 & security > --- > > Key: SSHD-332 > URL: https://issues.apache.org/jira/browse/SSHD-332 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 0.11.0 > Environment: Oracle Java 8 >Reporter: Gaël Lalire >Assignee: Guillaume Nodet > Fix For: 0.12.0 > > Attachments: securesshd-0.0.1-SNAPSHOT-jar-with-dependencies.jar, > securesshd.zip > > Original Estimate: 96h > Remaining Estimate: 96h > > I don't know if it is a JVM bug or normal behavior but a ProtectionDomain > with no permission is associated with completionHandler thread by > sun.misc.InnocuousThread class. > As a result if a security manager is set all code in completionHandler has no > permission (event if policy grants all permission). > If the behavior of JVM is correct then you should add > AccessController.doPrivileged() when entering completionHandler. > You can also check if a SecurityManager is set and run without Nio2 as a > quick fix. > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (SSHD-333) Ephemeral port handling is faulty
[
https://issues.apache.org/jira/browse/SSHD-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056031#comment-14056031
]
Przemek Bruski commented on SSHD-333:
-
Thanks!
> Ephemeral port handling is faulty
> -
>
> Key: SSHD-333
> URL: https://issues.apache.org/jira/browse/SSHD-333
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 0.9.0
>Reporter: Przemek Bruski
>Assignee: Guillaume Nodet
> Fix For: 0.12.0
>
>
> An excerpt from org.apache.sshd.SshServer:
> {code}
> if (host != null) {
> String[] hosts = host.split(",");
> LinkedList addresses = new
> LinkedList();
> for (String host : hosts) {
> InetAddress[] inetAddresses = InetAddress.getAllByName(host);
> for (InetAddress inetAddress : inetAddresses) {
> InetSocketAddress inetSocketAddress = new
> InetSocketAddress(inetAddress, port);
> if (port == 0) {
> port = inetSocketAddress.getPort();
> }
> addresses.add(inetSocketAddress);
> }
> }
> acceptor.bind(addresses);
> }
> {code}
> The line:
> {code}
> if (port == 0) {
> port = inetSocketAddress.getPort();
> }
> {code}
> Will still retrieve 0. The ephemeral port can be determined only after the
> socket address is bound.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (SSHD-313) Avoid deadlock on input stream
[
https://issues.apache.org/jira/browse/SSHD-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated SSHD-313:
-
Fix Version/s: (was: 0.12.0)
0.13.0
> Avoid deadlock on input stream
> --
>
> Key: SSHD-313
> URL: https://issues.apache.org/jira/browse/SSHD-313
> Project: MINA SSHD
> Issue Type: Improvement
>Reporter: Guillaume Nodet
> Fix For: 0.13.0
>
>
> {code}
> Aha, my problem was that I was trying to read from stdin before returning
> from my Command.start() implementation. If I call new-connection-fn on a
> separate thread, it works.
> Would it be reasonable to either 1) throw an exception if anyone tries to
> read/write a stream before returning from start() or 2) allow reading from
> stdin rather than blocking forever? The current behavior is confusing.
> This is the fix:
> https://github.com/matvore/hesokuri/commit/5cb13e0a81d7ece6aebdf5c635d150bac1719bf1
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[VOTE] Release SSHD 0.12.0
Vote to release the 0.12.0 version of SSHD Release notes: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310849&version=12326775 Staging repository: https://repository.apache.org/content/repositories/orgapachemina-1004 Distributions: https://repository.apache.org/content/repositories/orgapachemina-1004/org/apache/sshd/apache-sshd/0.12.0/ Tag: https://git-wip-us.apache.org/repos/asf?p=mina-sshd.git;a=tree;hb=0f76c3cafdc32f7f38b95624b06808edc5299add This release contains one major new feature (git command to provide access through ssh) and a bunch some bug and improvements. This vote will be open for at least 72 hours. Please review and vote. Cheers, Guillaume Nodet
[jira] [Closed] (SSHD-325) WinSCP client against org.apache.sshd.sftp.subsystem.SftpSubsystem is not working
[ https://issues.apache.org/jira/browse/SSHD-325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed SSHD-325. Resolution: Later Assignee: Guillaume Nodet > WinSCP client against org.apache.sshd.sftp.subsystem.SftpSubsystem is not > working > - > > Key: SSHD-325 > URL: https://issues.apache.org/jira/browse/SSHD-325 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 0.11.0 >Reporter: Juanma Valero Garzon >Assignee: Guillaume Nodet > > ssh-sftp version 0.11.0 > WinSCP version 5.5.3 > ssh-sftp sever running inside eclipse, in a linux (ubuntu) operating system. > WinSCP running inside Windows XP operating system. > To start de Test case, run the main program inside de test package > org.apache.sshd.sftp.SftpTest. > After that try to connect with the WinSCP client, and you get the following > error message > --- > Error > --- > Error listing directory '//sshd-sftp'. > --- > Error decoding SFTP packet (52, 1785029492, 205). > --- > OK Help > --- > when you try to list the directory. -- This message was sent by Atlassian JIRA (v6.2#6252)
