[jira] [Updated] (SSHD-891) SSh connections gets closed for every one hour with 0.13.0 version
[ https://issues.apache.org/jira/browse/SSHD-891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anudeep updated SSHD-891: - Priority: Blocker (was: Major) > SSh connections gets closed for every one hour with 0.13.0 version > -- > > Key: SSHD-891 > URL: https://issues.apache.org/jira/browse/SSHD-891 > Project: MINA SSHD > Issue Type: Bug >Reporter: Anudeep >Priority: Blocker > > SSH connections are getting closed for every one hours after 10 mins of idle > time even though there are incoming pacets data is not being wriiten to > client for every one hour and is being idle(10 mins which is default timeout > of ssh session). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SSHD-891) SSh connections gets closed for every one hour with 0.13.0 version
Anudeep created SSHD-891: Summary: SSh connections gets closed for every one hour with 0.13.0 version Key: SSHD-891 URL: https://issues.apache.org/jira/browse/SSHD-891 Project: MINA SSHD Issue Type: Bug Reporter: Anudeep SSH connections are getting closed for every one hours after 10 mins of idle time even though there are incoming pacets data is not being wriiten to client for every one hour and is being idle(10 mins which is default timeout of ssh session). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SSHD-882) Add support for STDERR stream usage in SFTP
[
https://issues.apache.org/jira/browse/SSHD-882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Goldstein Lyor resolved SSHD-882.
-
Resolution: Fixed
Fix Version/s: 2.3.0
> Add support for STDERR stream usage in SFTP
> ---
>
> Key: SSHD-882
> URL: https://issues.apache.org/jira/browse/SSHD-882
> Project: MINA SSHD
> Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Goldstein Lyor
>Assignee: Goldstein Lyor
>Priority: Minor
> Fix For: 2.3.0
>
>
> According to [version
> 4|https://tools.ietf.org/html/draft-ietf-secsh-filexfer-04#section-3.1]:
> {quote}
> Packets are sent and received on stdout and stdin. Data sent on
> stderr by the server SHOULD be considered debug or supplemental error
> information, and MAY be displayed to the user.
> For example, during initialization, there is no client request
> active, so errors or warning information cannot be sent to the client
> as part of the SFTP protocol at this early stage. However, the
> errors or warnings MAY be sent as stderr text.
> {quote}
> We currently initialize the STDERR stream, but make no use of it. We should
> provide a *configurable* way of using this stream - provided we find a
> use-case for it and maybe some client/server(s) that make use of it. *Note:*
> by default, the {{ChannelSession}} (that we use to consume SFTP data) does
> not accept STDERR data:
> {code:java}
> @Override
> protected void doWriteExtendedData(byte[] data, int off, long len) throws
> IOException {
> throw new UnsupportedOperationException("Server channel does not
> support extended data");
> }
> {code}
> so we need to consider very carefully what such a feature would require.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SSHD-890) SFTP susbsystem implementation does not clear response buffer when sending unsupported extension status message
[ https://issues.apache.org/jira/browse/SSHD-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Goldstein Lyor resolved SSHD-890. - Resolution: Fixed > SFTP susbsystem implementation does not clear response buffer when sending > unsupported extension status message > --- > > Key: SSHD-890 > URL: https://issues.apache.org/jira/browse/SSHD-890 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 2.2.0 >Reporter: Goldstein Lyor >Assignee: Goldstein Lyor >Priority: Minor > Fix For: 2.3.0 > > > See https://github.com/apache/mina-sshd/pull/87 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work started] (SSHD-890) SFTP susbsystem implementation does not clear response buffer when sending unsupported extension status message
[ https://issues.apache.org/jira/browse/SSHD-890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on SSHD-890 started by Goldstein Lyor. --- > SFTP susbsystem implementation does not clear response buffer when sending > unsupported extension status message > --- > > Key: SSHD-890 > URL: https://issues.apache.org/jira/browse/SSHD-890 > Project: MINA SSHD > Issue Type: Bug >Affects Versions: 2.2.0 >Reporter: Goldstein Lyor >Assignee: Goldstein Lyor >Priority: Minor > Fix For: 2.3.0 > > > See https://github.com/apache/mina-sshd/pull/87 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] lgoldstein commented on issue #87: clear response buffer with unsupported extension
lgoldstein commented on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462035192 Yes you can - again, thanks for your contribution This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thefourtheye commented on issue #87: clear response buffer with unsupported extension
thefourtheye commented on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462030601 Awesome. Thank you! Now that the commit is in your fork, can we close this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lgoldstein commented on issue #87: clear response buffer with unsupported extension
lgoldstein commented on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462025659 LSRP - Least Single Responsibility Principle. >> Wouldn't this make the life of the developers a bit easier? I don't think so - my concern is not code repetition but rather unexpected code behavior - whoever invokes `sendStatus` provides a buffer that may or may not be already initialized somehow - for whatever purpose (maybe some custom feature). I would rather `sendStatus` not tinker with the input buffer beyond appending the status message parameters. Anyway, I have made a few minor changes to your code (many thanks) - you can see them [here](https://github.com/lgoldstein/mina-sshd/commit/5f49088fb7abf464ee8b2b521235340a10b70ec3). They will be merged into the _master_ version once we release 2.2.0 (which unfortunately means the fix will have to wait until we release the next version) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thefourtheye edited a comment on issue #87: clear response buffer with unsupported extension
thefourtheye edited a comment on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462024304 @lgoldstein Wouldn't this make the life of the developers a bit easier? 1. They don't have worry about clearing the buffer everywhere. Less code repetition. 2. If somebody forgets to call `send*` functions without clearing the buffer, it would break. We have to rely only on the code review process to find this. Those refactoring commits are just to make sure that we don't end up with a problem like this again. I am fine with or without them. --- PS. I went looking for the expansion of LSRP. Couldn't find a satisfactory one. Now I am curious 😜 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] thefourtheye commented on issue #87: clear response buffer with unsupported extension
thefourtheye commented on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462024304 @lgoldstein Wouldn't this make the life of the developers a bit easier? 1. They don't have worry about clearing the buffer everywhere. Less code repetition. 2. If somebody forgets to call `send*` functions without clearing the buffer, it would break. We have to rely only on the code review process to find this. Those refactoring commits are just to make sure that we don't end up with a problem like this again. I am fine with or without it. --- PS. I went looking for the expansion of LSRP. Couldn't find a satisfactory one. Now I am curious 😜 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lgoldstein commented on issue #87: clear response buffer with unsupported extension
lgoldstein commented on issue #87: clear response buffer with unsupported extension URL: https://github.com/apache/mina-sshd/pull/87#issuecomment-462023785 Good catch, but I would rather not move `prepareReply` to be part of `sendStatus` (LSRP) - whoever is invoking `sendStatus` should provide a valid buffer This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
