[jira] [Created] (SSHD-954) Improve validation of DH public key values
Lyor Goldstein created SSHD-954: --- Summary: Improve validation of DH public key values Key: SSHD-954 URL: https://issues.apache.org/jira/browse/SSHD-954 Project: MINA SSHD Issue Type: Improvement Affects Versions: 2.3.0 Reporter: Lyor Goldstein Assignee: Lyor Goldstein See [RFC 8268 section 4|https://tools.ietf.org/html/rfc8268#section-4] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (SSHD-952) What is the expected behavior of waitForSpace(long millis) method on default timeout of 30 seconds
[ https://issues.apache.org/jira/browse/SSHD-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969400#comment-16969400 ] Lyor Goldstein commented on SSHD-952: - Thx, I'll try and think about this issue some more - meanwhile, if you can somehow reproduce the behavior where the channel is not closed and provide some debugging information it would help a lot. > What is the expected behavior of waitForSpace(long millis) method on default > timeout of 30 seconds > -- > > Key: SSHD-952 > URL: https://issues.apache.org/jira/browse/SSHD-952 > Project: MINA SSHD > Issue Type: Question >Affects Versions: 2.2.0 >Reporter: Anudeep >Priority: Major > > Hi Team, > Can you please let us know the expected behavior of waitForSpace(long millis) > method of Window.java class . As per our test we see on timeout thread get > released and it spawns a new thread on timeout. Is this an expected behavior ? > 2019-10-24 12:33:26,123 DEBUG [org.apache.sshd.server.channel.ChannelSession] > (Thread-44 (HornetQ-client-global-threads-407809182)) > flush(ChannelOutputStream[ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]] > SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of > len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628])) > timeout exceeded: 2 > 2019-10-24 12:33:46,126 DEBUG [org.apache.sshd.server.channel.ChannelSession] > (Thread-44 (HornetQ-client-global-threads-407809182)) > flush(ChannelOutputStream[ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]] > SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of > len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628])) > timeout exceeded: 2 > 2019-10-24 12:34:06,129 DEBUG [org.apache.sshd.server.channel.ChannelSession] > (Thread-44 (HornetQ-client-global-threads-407809182)) > flush(ChannelOutputStream[ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]] > SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of > len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0, > recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628])) > timeout exceeded: 2 -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Comment Edited] (SSHD-952) What is the expected behavior of waitForSpace(long millis) method on default timeout of 30 seconds
[
https://issues.apache.org/jira/browse/SSHD-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969075#comment-16969075
]
Anudeep edited comment on SSHD-952 at 11/7/19 9:20 AM:
---
Hi [~lgoldstein],
We tried in a different manner this time ,instead of blocking the read
completely we added sleep while reading the data from channel on the client
side .
This time even after the timeout it was still continuing for some time and got
exited(channel got closed with an exception after some time). I suppose this
behavior might be due to sleep which we introduced at client side.
{code:java}
2019-11-07 05:42:24,630 INFO [com.ericsson.oss.itpf.EVENT_LOGGER] (EJB default
- 73) [NO USER DATA, Started BNSI NBI, COARSE, BNSI NBI Client, BNSI NBI
Server, ]
2019-11-07 05:42:26,611 DEBUG [org.apache.sshd.server.channel.ChannelSession]
(pool-7-thread-3) flush(ChannelOutputStream[ChannelSession[id=0,
recipient=43]-ServerSessi
onImpl[administrator@/192.168.0.42:49984]] SSH_MSG_CHANNEL_DATA) failed
(SocketTimeoutException) to wait for space of len=23892:
waitForCondition(Window[server/remote](
ChannelSession[id=0,
recipient=43]-ServerSessionImpl[administrator@/192.168.0.42:49984])) timeout
exceeded: 3
pStatus=0.%A
2019-11-07 05:42:33,149 DEBUG [org.apache.sshd.common.io.nio2.Nio2Session]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(Nio2Session[local=/10.247
.246.52:8345, remote=/192.168.0.42:49984]) caught
InterruptedByTimeoutException[null] - calling handler
2019-11-07 05:42:33,149 WARN
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] InterruptedByTimeoutException:
null
2019-11-07 05:42:33,150 DEBUG
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] details:
java.nio.channels.InterruptedByTimeoutException
at
sun.nio.ch.UnixAsynchronousSocketChannelImpl$1.run(UnixAsynchronousSocketChannelImpl.java:456)
[rt.jar:1.8.0_221]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[rt.jar:1.8.0_221]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[rt.jar:1.8.0_221]
:
{code}
Thanks,
Anudeep
was (Author: anudeepgangasani):
Hi [~lgoldstein],
We tried in a different manner this time ,instead of blocking the read
completely we added sleep while reading the data from channel on the client
side .
This time even after the timeout it was still continuing for some time and got
exited(channel got closed with an exception after some time). I suppose this
behavior might be due to sleep which we introduced at client side.
{code:java}
pStatus=0.%A
2019-11-07 05:42:33,149 DEBUG [org.apache.sshd.common.io.nio2.Nio2Session]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(Nio2Session[local=/10.247
.246.52:8345, remote=/192.168.0.42:49984]) caught
InterruptedByTimeoutException[null] - calling handler
2019-11-07 05:42:33,149 WARN
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] InterruptedByTimeoutException:
null
2019-11-07 05:42:33,150 DEBUG
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] details:
java.nio.channels.InterruptedByTimeoutException
at
sun.nio.ch.UnixAsynchronousSocketChannelImpl$1.run(UnixAsynchronousSocketChannelImpl.java:456)
[rt.jar:1.8.0_221]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[rt.jar:1.8.0_221]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledT
[jira] [Commented] (SSHD-952) What is the expected behavior of waitForSpace(long millis) method on default timeout of 30 seconds
[
https://issues.apache.org/jira/browse/SSHD-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969075#comment-16969075
]
Anudeep commented on SSHD-952:
--
Hi [~lgoldstein],
We tried in a different manner this time ,instead of blocking the read
completely we added sleep while reading the data from channel on the client
side .
This time even after the timeout it was still continuing for some time and got
exited(channel got closed with an exception after some time). I suppose this
behavior might be due to sleep which we introduced at client side.
{code:java}
pStatus=0.%A
2019-11-07 05:42:33,149 DEBUG [org.apache.sshd.common.io.nio2.Nio2Session]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(Nio2Session[local=/10.247
.246.52:8345, remote=/192.168.0.42:49984]) caught
InterruptedByTimeoutException[null] - calling handler
2019-11-07 05:42:33,149 WARN
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] InterruptedByTimeoutException:
null
2019-11-07 05:42:33,150 DEBUG
[org.apache.sshd.server.session.ServerSessionImpl]
(sshd-SshServer[57e76ebb](port=8345)-nio2-thread-2)
exceptionCaught(ServerSessionImpl[a
dministrator@/192.168.0.42:49984])[state=Opened] details:
java.nio.channels.InterruptedByTimeoutException
at
sun.nio.ch.UnixAsynchronousSocketChannelImpl$1.run(UnixAsynchronousSocketChannelImpl.java:456)
[rt.jar:1.8.0_221]
at
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[rt.jar:1.8.0_221]
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[rt.jar:1.8.0_221]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[rt.jar:1.8.0_221]
:
{code}
Thanks,
Anudeep
> What is the expected behavior of waitForSpace(long millis) method on default
> timeout of 30 seconds
> --
>
> Key: SSHD-952
> URL: https://issues.apache.org/jira/browse/SSHD-952
> Project: MINA SSHD
> Issue Type: Question
>Affects Versions: 2.2.0
>Reporter: Anudeep
>Priority: Major
>
> Hi Team,
> Can you please let us know the expected behavior of waitForSpace(long millis)
> method of Window.java class . As per our test we see on timeout thread get
> released and it spawns a new thread on timeout. Is this an expected behavior ?
> 2019-10-24 12:33:26,123 DEBUG [org.apache.sshd.server.channel.ChannelSession]
> (Thread-44 (HornetQ-client-global-threads-407809182))
> flush(ChannelOutputStream[ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]]
> SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of
> len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]))
> timeout exceeded: 2
> 2019-10-24 12:33:46,126 DEBUG [org.apache.sshd.server.channel.ChannelSession]
> (Thread-44 (HornetQ-client-global-threads-407809182))
> flush(ChannelOutputStream[ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]]
> SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of
> len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]))
> timeout exceeded: 2
> 2019-10-24 12:34:06,129 DEBUG [org.apache.sshd.server.channel.ChannelSession]
> (Thread-44 (HornetQ-client-global-threads-407809182))
> flush(ChannelOutputStream[ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]]
> SSH_MSG_CHANNEL_DATA) failed (SocketTimeoutException) to wait for space of
> len=1190: waitForCondition(Window[server/remote](ChannelSession[id=0,
> recipient=43]-ServerSessionImpl[administrator@/141.137.237.205:58628]))
> timeout exceeded: 2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
