[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jonathan Valliere (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445583#comment-17445583
 ] 

Jonathan Valliere commented on DIRMINA-1144:


I'm fine with this for now.  Here is the change 
[https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=f38dde9ff18843c2eaae695dc76b823637c197a8]

[~elecharny]  please update the SNAPSHOT in Maven.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445496#comment-17445496
 ] 

Emmanuel Lécharny commented on DIRMINA-1144:


Your call, Jonathan.

This is the problem with the new Java evolution scheme: if we decide to switch 
to a more recent Java version, then we are losing those who keep going with 
Java 8, but OTOH recent Java versions have brought so many good addition to the 
language that it would be a pity not to move forward...

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jonathan Valliere (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445488#comment-17445488
 ] 

Jonathan Valliere commented on DIRMINA-1144:


I have no interest in dying on this hill.  If its a simple as removing that one 
line then I'll do it.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Comment Edited] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Gregory Hoffer (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445305#comment-17445305
 ] 

Gregory Hoffer edited comment on DIRMINA-1144 at 11/17/21, 8:56 PM:


respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 (c.f. [Adopt 
OpenJDK|https://adoptopenjdk.net/support.html], [Azul 
Zulu|https://www.azul.com/products/azul-support-roadmap], [Amazon 
Corretto|https://aws.amazon.com/corretto/faqs/], et. al.).  It is simply not 
accurate that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.


was (Author: JIRAUSER280397):
respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 (c.f. [Adopt 
OpenJDK|https://adoptopenjdk.net/support.html], [Azul 
Zulu|[https://www.azul.com/products/azul-support-roadmap|https://adoptopenjdk.net/support.html,]],
 [Amazon Corretto|https://aws.amazon.com/corretto/faqs/], et. al.).  It is 
simply not accurate that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Comment Edited] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Gregory Hoffer (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445305#comment-17445305
 ] 

Gregory Hoffer edited comment on DIRMINA-1144 at 11/17/21, 8:55 PM:


respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 (c.f. [Adopt 
OpenJDK|https://adoptopenjdk.net/support.html], [Azul 
Zulu|[https://www.azul.com/products/azul-support-roadmap|https://adoptopenjdk.net/support.html,]],
 [Amazon Corretto|https://aws.amazon.com/corretto/faqs/], et. al.).  It is 
simply not accurate that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.


was (Author: JIRAUSER280397):
respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 
([[https://adoptopenjdk.net/support.html||https://adoptopenjdk.net/support.html,]
 [https://adoptopenjdk.net/support.html|https://adoptopenjdk.net/support.html,] 
[], 
[https://www.azul.com/products/azul-support-roadmap/|https://adoptopenjdk.net/support.html,]|[https://www.azul.com/products/azul-support-roadmap/]|https://adoptopenjdk.net/support.html,],
 
[[https://aws.amazon.com/corretto/faqs/||https://aws.amazon.com/corretto/faqs/] 
[https://aws.amazon.com/corretto/faqs/]], et. al.).  It is simply not accurate 
that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Comment Edited] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Gregory Hoffer (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445305#comment-17445305
 ] 

Gregory Hoffer edited comment on DIRMINA-1144 at 11/17/21, 8:53 PM:


respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 
([[https://adoptopenjdk.net/support.html||https://adoptopenjdk.net/support.html,]
 [https://adoptopenjdk.net/support.html|https://adoptopenjdk.net/support.html,] 
[], 
[https://www.azul.com/products/azul-support-roadmap/|https://adoptopenjdk.net/support.html,]|[https://www.azul.com/products/azul-support-roadmap/]|https://adoptopenjdk.net/support.html,],
 
[[https://aws.amazon.com/corretto/faqs/||https://aws.amazon.com/corretto/faqs/] 
[https://aws.amazon.com/corretto/faqs/]], et. al.).  It is simply not accurate 
that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.


was (Author: JIRAUSER280397):
respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 ([https://adoptopenjdk.net/support.html, 
https://www.azul.com/products/azul-support-roadmap/|https://adoptopenjdk.net/support.html,],
 [https://aws.amazon.com/corretto/faqs/], et. al.).  It is simply not accurate 
that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Gregory Hoffer (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445438#comment-17445438
 ] 

Gregory Hoffer commented on DIRMINA-1144:
-

I am ready willing and eager to help (my focus and contributions are centered 
on SSH/SFTP).

NOTE that  Java 8 support ends much later than 2022: support ends in 2026 for 
OpenJDK and Amazon Corretto, and 2030 for Azul, both of which are *LATER* than 
the end of support for Java 11.

I am not recommending paying for extended support.  I am not even recommending 
paying for JRE usage. I am a huge proponent of OpenJDK based JDKs/JREs.  

I am simply recommending that, unless there are compelling reasons to abandon 
Java 8 as a target runtime environment.  Please at least consider the 
trade-offs between what you are gaining by requiring Java 9 or 11 vs. the loss 
of the most recent and complete branch running on Java 8, which would still be 
the most widely utilized JVM version in production.

I am only voicing one opinion, and concede to whatever choice is made.  But I 
am hoping to help make an informed choice, with the proper facts.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: Phasing out Java 8 for MINA 2.2 and further

2021-11-17 Thread sebb
According to a comment on DIRMINA-1144 [1], Java 8 has longer support
than Java 11

So I would recommend staying with Java 8 for now.

Sebb
[1] 
https://issues.apache.org/jira/browse/DIRMINA-1144?focusedCommentId=17445305=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17445305

On Wed, 17 Nov 2021 at 13:03, Jeff MAURY  wrote:
>
> +1
>
> On Wed, Nov 17, 2021 at 2:00 PM Emmanuel Lécharny 
> wrote:
>
> > Hi !
> >
> > Jonathan has started to implement a new version of SslFilter in the
> > 2.2.0 branch, which is a good thing. However, this implementation
> > requires a newer version of Java, namely Java 9.
> >
> > I suggest we switch to Java 11 for MINA 2.2+ while we keep Java 8 for
> > the MINA 2.0 and 2.1 branches which will soon enter in maintenance mode.
> >
> > wdyt ?
> >
> > Thanks !
> >
> > --
> > *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
> > T. +33 (0)4 89 97 36 50
> > P. +33 (0)6 08 33 32 61
> > emmanuel.lecha...@busit.com https://www.busit.com/
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> > For additional commands, e-mail: dev-h...@mina.apache.org
> >
> >
>
> --
> "Legacy code" often differs from its suggested alternative by actually
> working and scaling.
>  - Bjarne Stroustrup
>
> http://www.jeffmaury.com
> http://riadiscuss.jeffmaury.com
> http://www.twitter.com/jeffmaury

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445332#comment-17445332
 ] 

Emmanuel Lécharny commented on DIRMINA-1144:


- MINA 2.0 and 2.1 are still based on Java 8
- Java 8 support will end by march, 2022
- we are an open source project, we are not going to pay for any extended 
support
- you are very welcome to give an hand supporting MINA with Java 8 if that fit 
your need.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Gregory Hoffer (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445305#comment-17445305
 ] 

Gregory Hoffer commented on DIRMINA-1144:
-

respectfully, Java 8 has the longest support life of any JDK out there right 
now – supported through at least 2026 ([https://adoptopenjdk.net/support.html, 
https://www.azul.com/products/azul-support-roadmap/|https://adoptopenjdk.net/support.html,],
 [https://aws.amazon.com/corretto/faqs/], et. al.).  It is simply not accurate 
that Java 1.8 is not being maintained anymore.

Java 11 LTS is shorter than Java 8 in many cases, which means that Java 8 is 
"guaranteed" to be supported for a long period of time than even the Java 11 
LTS (weird, but true).

I would encourage reconsidering changes that break on Java 8.  I work with many 
customers who still use Java 8 because of its LTS, and are hesitant to move 
until they see what LTS will officially be for Java 17.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: ByteBuffer (Was: Re: JIRA Emails)

2021-11-17 Thread Jonathan Valliere
Good job.   So yeah, back to adopting Java 11 moving forward.

On Wed, Nov 17, 2021 at 9:23 AM Thomas Wolf  wrote:

> On 17.11.21 14:37 , Jonathan Valliere wrote:
> > The error you posted was related to java.lang.NoSuchMethodError:
> > java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; and not the SSLFilter.
> You
> > sure there wasn’t something else
> > wrong with your env cause I’m pretty sure ByteBuffer.fip() has been
> around
> > since ByteBuffer.
>
> But there was a co-variant return type override. In Java 1.8,
> ByteBuffer.flip() is inherited from Buffer and returns a Buffer.
>
> In Java > 1.8, ByteBuffer.flip() is an override returning ByteBuffer.
>
> So when you compile with Java > 1.8 w/o --release 8 and then run on Java
> 1.8, you'll get that NoSuchMethodError.
>
> Cheers,
>
>Thomas
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> For additional commands, e-mail: dev-h...@mina.apache.org
>
>


ByteBuffer (Was: Re: JIRA Emails)

2021-11-17 Thread Thomas Wolf

On 17.11.21 14:37 , Jonathan Valliere wrote:

The error you posted was related to java.lang.NoSuchMethodError:
java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; and not the SSLFilter. You
sure there wasn’t something else
wrong with your env cause I’m pretty sure ByteBuffer.fip() has been around
since ByteBuffer.


But there was a co-variant return type override. In Java 1.8, 
ByteBuffer.flip() is inherited from Buffer and returns a Buffer.


In Java > 1.8, ByteBuffer.flip() is an override returning ByteBuffer.

So when you compile with Java > 1.8 w/o --release 8 and then run on Java 
1.8, you'll get that NoSuchMethodError.


Cheers,

  Thomas


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: JIRA Emails

2021-11-17 Thread Jonathan Valliere
 @Christoph

The error you posted was related to java.lang.NoSuchMethodError:
java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; and not the SSLFilter. You
sure there wasn’t something else
wrong with your env cause I’m pretty sure ByteBuffer.fip() has been around
since ByteBuffer.

On Nov 17, 2021 at 8:30:25 AM, Christoph John 
wrote:

> I think one is for your personal mail address, the second for the dev
> mailing list. At least that is
> the case for me.
>
> Cheers,
> Chris.
>
> On 17.11.21 14:06, Jonathan Valliere wrote:
>
> Is everyone getting the JIRA emails twice or is that just me?
>
>
>
>


Re: JIRA Emails

2021-11-17 Thread Christoph John
I think one is for your personal mail address, the second for the dev mailing list. At least that is 
the case for me.


Cheers,
Chris.

On 17.11.21 14:06, Jonathan Valliere wrote:

Is everyone getting the JIRA emails twice or is that just me?




-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



JIRA Emails

2021-11-17 Thread Jonathan Valliere
Is everyone getting the JIRA emails twice or is that just me?


[jira] [Comment Edited] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jonathan Valliere (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445145#comment-17445145
 ] 

Jonathan Valliere edited comment on DIRMINA-1144 at 11/17/21, 1:04 PM:
---

There is also another feature somewhere which requires Java 9 but I don't 
remember what.  Officially deprecating Java 8 is a good idea since it's not 
really being maintained anymore.  I'm also fairly sure there is some lambda 
code somewhere which is also incompatible with Java 8.

 

P.S. [~chrjohn] 's error is with {{ByteBufer}}
{code:java}
java.lang.NoSuchMethodError: java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer; 
{code}
{{ }}


was (Author: johnnyv):
There is also another feature somewhere which requires Java 9 but I don't 
remember what.  Officially deprecating Java 8 is a good idea since it's not 
really being maintained anymore.  I'm also fairly sure there is some lambda 
code somewhere which is also incompatible with Java 8.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: Phasing out Java 8 for MINA 2.2 and further

2021-11-17 Thread Jeff MAURY
+1

On Wed, Nov 17, 2021 at 2:00 PM Emmanuel Lécharny 
wrote:

> Hi !
>
> Jonathan has started to implement a new version of SslFilter in the
> 2.2.0 branch, which is a good thing. However, this implementation
> requires a newer version of Java, namely Java 9.
>
> I suggest we switch to Java 11 for MINA 2.2+ while we keep Java 8 for
> the MINA 2.0 and 2.1 branches which will soon enter in maintenance mode.
>
> wdyt ?
>
> Thanks !
>
> --
> *Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
> T. +33 (0)4 89 97 36 50
> P. +33 (0)6 08 33 32 61
> emmanuel.lecha...@busit.com https://www.busit.com/
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
> For additional commands, e-mail: dev-h...@mina.apache.org
>
>

-- 
"Legacy code" often differs from its suggested alternative by actually
working and scaling.
 - Bjarne Stroustrup

http://www.jeffmaury.com
http://riadiscuss.jeffmaury.com
http://www.twitter.com/jeffmaury


Phasing out Java 8 for MINA 2.2 and further

2021-11-17 Thread Emmanuel Lécharny

Hi !

Jonathan has started to implement a new version of SslFilter in the 
2.2.0 branch, which is a good thing. However, this implementation 
requires a newer version of Java, namely Java 9.


I suggest we switch to Java 11 for MINA 2.2+ while we keep Java 8 for 
the MINA 2.0 and 2.1 branches which will soon enter in maintenance mode.


wdyt ?

Thanks !

--
*Emmanuel Lécharny - CTO* 205 Promenade des Anglais – 06200 NICE
T. +33 (0)4 89 97 36 50
P. +33 (0)6 08 33 32 61
emmanuel.lecha...@busit.com https://www.busit.com/

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jonathan Valliere (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445145#comment-17445145
 ] 

Jonathan Valliere commented on DIRMINA-1144:


There is also another feature somewhere which requires Java 9 but I don't 
remember what.  Officially deprecating Java 8 is a good idea since it's not 
really being maintained anymore.  I'm also fairly sure there is some lambda 
code somewhere which is also incompatible with Java 8.

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Jira


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445141#comment-17445141
 ] 

Emmanuel Lécharny commented on DIRMINA-1144:


That won't work. The thing is that the code is dependent on a JAVA 9+ feature 
that does not exist in Java 8. The following code won't simply build in Java 8:

{code:java}
switch (result.getHandshakeStatus()) {
case NEED_UNWRAP:
case NEED_UNWRAP_AGAIN:   <<- This has been 
introduced in Java 9
...
{code}

At this point, I think we should consider releasing MINA 2.2 with Java 11.


> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Comment Edited] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Christoph John (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445126#comment-17445126
 ] 

Christoph John edited comment on DIRMINA-1144 at 11/17/21, 12:13 PM:
-

OK, should I open a PR for the "--release" option?
This problem could also happen on normal release builds, right? But up to now I 
didn't have this problem.


was (Author: chrjohn):
OK, should I open a PR for the "--release" option?

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Christoph John (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445126#comment-17445126
 ] 

Christoph John commented on DIRMINA-1144:
-

OK, should I open a PR for the "--release" option?

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy

2021-11-17 Thread Christoph John (Jira)


[ 
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17445102#comment-17445102
 ] 

Christoph John commented on DIRMINA-1144:
-

[~elecharny] thanks for deploying the snapshot. However, could it be that you 
compiled it with a JDK 9 or higher? I get errors like these when running our 
JDK8 build:

{noformat}
Error: Exception in thread "pool-15-thread-3" java.lang.NoSuchMethodError: 
java.nio.ByteBuffer.flip()Ljava/nio/ByteBuffer;
at 
org.apache.mina.core.buffer.AbstractIoBuffer.flip(AbstractIoBuffer.java:462)
at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.read(AbstractPollingIoProcessor.java:534)
at 
org.apache.mina.core.polling.AbstractPollingIoProcessor.access$1200(AbstractPollingIoProcessor.java:68)
at 
org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.process(AbstractPollingIoProcessor.java:1224)
at 
org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.process(AbstractPollingIoProcessor.java:1213)
at 
org.apache.mina.core.polling.AbstractPollingIoProcessor$Processor.run(AbstractPollingIoProcessor.java:683)
at 
org.apache.mina.util.NamePreservingRunnable.run(NamePreservingRunnable.java:64)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
{noformat}

According to this https://stackoverflow.com/a/61267496/4962355 (see approach 1) 
you should compile using the "--release" compiler option.
I think you either need to compile with JDK 7 or 8 or use a conditional profile 
which triggers the "--release" option when using JDK9+:

{noformat}

  java-8-compilation
  
  [9,)
  
  
  8
  

{noformat}

> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
>  Issue Type: Bug
>  Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that 
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4 
> and 2.1.3 versions. The 2.0.20, instead, seems to work,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org