[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy
[
https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447708#comment-17447708
]
Jonathan Valliere commented on DIRMINA-1144:
{quote}In
[https://github.com/quickfix-j/quickfixj/blob/8bee941f9d6b8b01e5231572dad3a9be4e7ea748/quickfixj-core/src/test/java/quickfix/mina/ssl/SSLCertificateTest.java#L512]
we now get an SSLPeerUnverifiedException which wasn't thrown before.
{quote}
I think you're trying to use a self-signed cert without overriding the
{{{}TrustManager{}}}. An SSL implementation should NEVER trust self-signed
certs by default. If you are running a server try setting {{NeedClientAuth}}
and {{WantClientAuth}} to {{{}false{}}}.
{quote}In other tests we are expecting an Exception but there is none thrown
anymore. E.g
[https://github.com/quickfix-j/quickfixj/blob/8bee941f9d6b8b01e5231572dad3a9be4e7ea748/quickfixj-core/src/test/java/quickfix/mina/ssl/SSLCertificateTest.java#L365]
We are trying to get the Exception via a filter as can be seen here:
[https://github.com/quickfix-j/quickfixj/blob/8bee941f9d6b8b01e5231572dad3a9be4e7ea748/quickfixj-core/src/test/java/quickfix/mina/ssl/SSLCertificateTest.java#L456]
This does not seem to be triggered anymore. I've noticed that the old SslFilter
has an exceptionCaught method:
[https://github.com/apache/mina/blob/ff39f496b746b780e4637d8e940cbfae2cdd3809/mina-core/src/main/java/org/apache/mina/filter/ssl/SslFilter.java#L577]
but even if the new filter had no such method it shouldn't prevent exceptions
from being propagated, right?
{quote}
SSLFilter extends IoFIlterAdapter which includes the standard exception handler
and calls nextFilter.exceptionCaught. I don't know why this isn't working for
you.
Email me directly and we can schedule a time to debug on Skype.
> Deadlock with SSL + Proxy
> -
>
> Key: DIRMINA-1144
> URL: https://issues.apache.org/jira/browse/DIRMINA-1144
> Project: MINA
> Issue Type: Bug
> Components: SSL
>Affects Versions: 2.1.3, 2.1.4
>Reporter: Giuseppe Persico
>Assignee: Jonathan Valliere
>Priority: Critical
> Fix For: 2.2.0
>
> Attachments: thread-dump-clean.txt
>
>
> You will find the thread dump attached. This seems to be a problem that
> occurs using SSL in combination with proxy. I found the problem in the 2.1.4
> and 2.1.3 versions. The 2.0.20, instead, seems to work,
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1144) Deadlock with SSL + Proxy
[ https://issues.apache.org/jira/browse/DIRMINA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447691#comment-17447691 ] Christoph John commented on DIRMINA-1144: - [~johnnyv] any pointer re https://issues.apache.org/jira/browse/DIRMINA-1144?focusedCommentId=1771=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1771 Otherwise I'll try to do more debugging once [~elecharny] (or someone else with access) uploads a new 2.2.0-SNAPSHOT. Thanks in advance > Deadlock with SSL + Proxy > - > > Key: DIRMINA-1144 > URL: https://issues.apache.org/jira/browse/DIRMINA-1144 > Project: MINA > Issue Type: Bug > Components: SSL >Affects Versions: 2.1.3, 2.1.4 >Reporter: Giuseppe Persico >Assignee: Jonathan Valliere >Priority: Critical > Fix For: 2.2.0 > > Attachments: thread-dump-clean.txt > > > You will find the thread dump attached. This seems to be a problem that > occurs using SSL in combination with proxy. I found the problem in the 2.1.4 > and 2.1.3 versions. The 2.0.20, instead, seems to work, -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Resolved] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
[
https://issues.apache.org/jira/browse/SSHD-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Wolf resolved SSHD-1228.
---
Fix Version/s: 2.7.1
Assignee: Thomas Wolf
Resolution: Fixed
Thanks, Samuel!
> Wrong creationTime in writeAttrs for SFTP
> -
>
> Key: SSHD-1228
> URL: https://issues.apache.org/jira/browse/SSHD-1228
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Samuel Padou
>Assignee: Thomas Wolf
>Priority: Minor
> Fix For: 2.7.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of
> the {{creationTime}}.
> {code:java}
> if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
> buffer = writeTime(buffer, version, flags, lastAccessTime);
> }
> {code}
> In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
> this cause a NPE (the flag is set because {{creationTime}} is not null but
> {{lastAccessTime}} is null when trying to write it), but this still write the
> wrong date even if both are available. Most clients seems to only show the
> {{lastModifiedTime}} though, so this is probably not very visible in most
> cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Work logged] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
[
https://issues.apache.org/jira/browse/SSHD-1228?focusedWorklogId=684771=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-684771
]
ASF GitHub Bot logged work on SSHD-1228:
Author: ASF GitHub Bot
Created on: 22/Nov/21 14:53
Start Date: 22/Nov/21 14:53
Worklog Time Spent: 10m
Work Description: tomaswolf commented on pull request #209:
URL: https://github.com/apache/mina-sshd/pull/209#issuecomment-975608389
Thanks, Samuel!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 684771)
Time Spent: 20m (was: 10m)
> Wrong creationTime in writeAttrs for SFTP
> -
>
> Key: SSHD-1228
> URL: https://issues.apache.org/jira/browse/SSHD-1228
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Samuel Padou
>Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of
> the {{creationTime}}.
> {code:java}
> if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
> buffer = writeTime(buffer, version, flags, lastAccessTime);
> }
> {code}
> In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
> this cause a NPE (the flag is set because {{creationTime}} is not null but
> {{lastAccessTime}} is null when trying to write it), but this still write the
> wrong date even if both are available. Most clients seems to only show the
> {{lastModifiedTime}} though, so this is probably not very visible in most
> cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-sshd] tomaswolf commented on pull request #209: [SSHD-1228] Wrong creationTime in writeAttrs for SFTP
tomaswolf commented on pull request #209: URL: https://github.com/apache/mina-sshd/pull/209#issuecomment-975608389 Thanks, Samuel! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Work logged] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
[
https://issues.apache.org/jira/browse/SSHD-1228?focusedWorklogId=684770=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-684770
]
ASF GitHub Bot logged work on SSHD-1228:
Author: ASF GitHub Bot
Created on: 22/Nov/21 14:52
Start Date: 22/Nov/21 14:52
Worklog Time Spent: 10m
Work Description: tomaswolf merged pull request #209:
URL: https://github.com/apache/mina-sshd/pull/209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 684770)
Remaining Estimate: 0h
Time Spent: 10m
> Wrong creationTime in writeAttrs for SFTP
> -
>
> Key: SSHD-1228
> URL: https://issues.apache.org/jira/browse/SSHD-1228
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Samuel Padou
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of
> the {{creationTime}}.
> {code:java}
> if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
> buffer = writeTime(buffer, version, flags, lastAccessTime);
> }
> {code}
> In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
> this cause a NPE (the flag is set because {{creationTime}} is not null but
> {{lastAccessTime}} is null when trying to write it), but this still write the
> wrong date even if both are available. Most clients seems to only show the
> {{lastModifiedTime}} though, so this is probably not very visible in most
> cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-sshd] tomaswolf merged pull request #209: [SSHD-1228] Wrong creationTime in writeAttrs for SFTP
tomaswolf merged pull request #209: URL: https://github.com/apache/mina-sshd/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
[
https://issues.apache.org/jira/browse/SSHD-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447430#comment-17447430
]
Samuel Padou commented on SSHD-1228:
Sure, submitted here: https://github.com/apache/mina-sshd/pull/209
> Wrong creationTime in writeAttrs for SFTP
> -
>
> Key: SSHD-1228
> URL: https://issues.apache.org/jira/browse/SSHD-1228
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Samuel Padou
>Priority: Minor
>
> In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of
> the {{creationTime}}.
> {code:java}
> if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
> buffer = writeTime(buffer, version, flags, lastAccessTime);
> }
> {code}
> In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
> this cause a NPE (the flag is set because {{creationTime}} is not null but
> {{lastAccessTime}} is null when trying to write it), but this still write the
> wrong date even if both are available. Most clients seems to only show the
> {{lastModifiedTime}} though, so this is probably not very visible in most
> cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
[
https://issues.apache.org/jira/browse/SSHD-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447371#comment-17447371
]
Thomas Wolf commented on SSHD-1228:
---
Looks like a copy-paste bug. Would you like to provide a PR on Github fixing
this?
> Wrong creationTime in writeAttrs for SFTP
> -
>
> Key: SSHD-1228
> URL: https://issues.apache.org/jira/browse/SSHD-1228
> Project: MINA SSHD
> Issue Type: Bug
>Affects Versions: 2.7.0
>Reporter: Samuel Padou
>Priority: Minor
>
> In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of
> the {{creationTime}}.
> {code:java}
> if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
> buffer = writeTime(buffer, version, flags, lastAccessTime);
> }
> {code}
> In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
> this cause a NPE (the flag is set because {{creationTime}} is not null but
> {{lastAccessTime}} is null when trying to write it), but this still write the
> wrong date even if both are available. Most clients seems to only show the
> {{lastModifiedTime}} though, so this is probably not very visible in most
> cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Created] (SSHD-1228) Wrong creationTime in writeAttrs for SFTP
Samuel Padou created SSHD-1228:
--
Summary: Wrong creationTime in writeAttrs for SFTP
Key: SSHD-1228
URL: https://issues.apache.org/jira/browse/SSHD-1228
Project: MINA SSHD
Issue Type: Bug
Affects Versions: 2.7.0
Reporter: Samuel Padou
In {{SftpHelper#writeAttrsV4}} the {{lastAccessTime}} is written instead of the
{{creationTime}}.
{code:java}
if ((flags & SftpConstants.SSH_FILEXFER_ATTR_CREATETIME) != 0) {
buffer = writeTime(buffer, version, flags, lastAccessTime);
}
{code}
In my implementation I have a {{creationTime}} but no {{lastAccessTime}} so
this cause a NPE (the flag is set because {{creationTime}} is not null but
{{lastAccessTime}} is null when trying to write it), but this still write the
wrong date even if both are available. Most clients seems to only show the
{{lastModifiedTime}} though, so this is probably not very visible in most cases.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
