Re: Q: Release SSHD 2.7.1 ?
There will be no 2.7.1 - it was just a "code" for the next release which is 2.8.0 Hi, maybe a dumb question, do we need 2.7.1 when 2.8.0 release is going to be released soon? Or would it be better to use 2.7.1 in production and rather wait with 2.8.0 production bump? Thanks, Martin
[jira] [Updated] (SSHD-1232) Use of System.inheritedChannel
[ https://issues.apache.org/jira/browse/SSHD-1232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jörg Weule updated SSHD-1232: - Affects Version/s: 2.9.0 > Use of System.inheritedChannel > -- > > Key: SSHD-1232 > URL: https://issues.apache.org/jira/browse/SSHD-1232 > Project: MINA SSHD > Issue Type: Improvement >Affects Versions: 2.9.0 >Reporter: Jörg Weule >Priority: Minor > > System.inheritedChannel should be a possible channel for sshServer. > The cannel can be opened by systemd, waiting for a connection and then > starting the service. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Resolved] (DIRMINA-1153) MINA: Exception thrown at the client side - ProtocolDecoderException:BufferDataException
[
https://issues.apache.org/jira/browse/DIRMINA-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Valliere resolved DIRMINA-1153.
Assignee: Jonathan Valliere
Resolution: Won't Fix
> MINA: Exception thrown at the client side -
> ProtocolDecoderException:BufferDataException
>
>
> Key: DIRMINA-1153
> URL: https://issues.apache.org/jira/browse/DIRMINA-1153
> Project: MINA
> Issue Type: Bug
> Components: Handler
>Affects Versions: 2.0.19
>Reporter: Saravanan
>Assignee: Jonathan Valliere
>Priority: Major
>
> Mina version:
> mina-core-2.0.19.jar
> Server code snippet:
> IoAcceptor acceptor = new NioSocketAcceptor();
> DefaultIoFilterChainBuilder chain = acceptor.getFilterChain();
> LoggingFilter loggingFilter = new LoggingFilter();
> loggingFilter.setMessageSentLogLevel(LogLevel.DEBUG);
> loggingFilter.setMessageReceivedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionClosedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionCreatedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionIdleLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionOpenedLogLevel(LogLevel.DEBUG);
> chain.addLast("logger", loggingFilter);
> MdcInjectionFilter mdcInjectionFilter = new MdcInjectionFilter();
> chain.addLast("mdc", mdcInjectionFilter);
> chain.addLast("codec", new ProtocolCodecFilter(new
> ObjectSerializationCodecFactory()));
> Client code snippet:
> NioSocketConnector connector = new NioSocketConnector();
> LoggingFilter LOGGING_FILTER = new LoggingFilter("MinaLogging");
> LOGGING_FILTER.setMessageSentLogLevel(LogLevel.DEBUG);
> LOGGING_FILTER.setMessageReceivedLogLevel(LogLevel.DEBUG);
>
> IoFilter CODEC_FILTER = new ProtocolCodecFilter(new
> ObjectSerializationCodecFactory());
> connector.getFilterChain().addLast("mdc", new MdcInjectionFilter());
> connector.getFilterChain().addLast("codec", CODEC_FILTER);
> connector.getFilterChain().addLast("logger", LOGGING_FILTER);
> Exception:
> org.apache.mina.filter.codec.ProtocolDecoderException:
> org.apache.mina.core.buffer.BufferDataException: dataLength: 1048985
> (Hexdump: XX...)
> at
> org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:262)
> [mina-core-2.0.19.jar:?]
> at
> org.apache.mina.filter.codec.CumulativeProtocolDecoder.decode(CumulativeProtocolDecoder.java:180)
> ~[mina-core-2.0.19.jar:?]
> at
> org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:253)
> ~[mina-core-2.0.19.jar:?]
> Points:
> - There is no synchronization while writing...
> - There are multiple threads parallely wirting into the tcp connection
> (around 100-200)
> - The problem is observed only when the load is high...
> I have seen similar tickets here and not sure about the RCA.
> https://issues.apache.org/jira/browse/DIRMINA-653
> Need help...
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1153) MINA: Exception thrown at the client side - ProtocolDecoderException:BufferDataException
[
https://issues.apache.org/jira/browse/DIRMINA-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452961#comment-17452961
]
Jonathan Valliere commented on DIRMINA-1153:
Prior to 2.2.X the ProtocolCodecFilter did not support concurrency. Only
SNAPSHOTS are available for 2.2.X right now.
> MINA: Exception thrown at the client side -
> ProtocolDecoderException:BufferDataException
>
>
> Key: DIRMINA-1153
> URL: https://issues.apache.org/jira/browse/DIRMINA-1153
> Project: MINA
> Issue Type: Bug
> Components: Handler
>Affects Versions: 2.0.19
>Reporter: Saravanan
>Priority: Major
>
> Mina version:
> mina-core-2.0.19.jar
> Server code snippet:
> IoAcceptor acceptor = new NioSocketAcceptor();
> DefaultIoFilterChainBuilder chain = acceptor.getFilterChain();
> LoggingFilter loggingFilter = new LoggingFilter();
> loggingFilter.setMessageSentLogLevel(LogLevel.DEBUG);
> loggingFilter.setMessageReceivedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionClosedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionCreatedLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionIdleLogLevel(LogLevel.DEBUG);
> loggingFilter.setSessionOpenedLogLevel(LogLevel.DEBUG);
> chain.addLast("logger", loggingFilter);
> MdcInjectionFilter mdcInjectionFilter = new MdcInjectionFilter();
> chain.addLast("mdc", mdcInjectionFilter);
> chain.addLast("codec", new ProtocolCodecFilter(new
> ObjectSerializationCodecFactory()));
> Client code snippet:
> NioSocketConnector connector = new NioSocketConnector();
> LoggingFilter LOGGING_FILTER = new LoggingFilter("MinaLogging");
> LOGGING_FILTER.setMessageSentLogLevel(LogLevel.DEBUG);
> LOGGING_FILTER.setMessageReceivedLogLevel(LogLevel.DEBUG);
>
> IoFilter CODEC_FILTER = new ProtocolCodecFilter(new
> ObjectSerializationCodecFactory());
> connector.getFilterChain().addLast("mdc", new MdcInjectionFilter());
> connector.getFilterChain().addLast("codec", CODEC_FILTER);
> connector.getFilterChain().addLast("logger", LOGGING_FILTER);
> Exception:
> org.apache.mina.filter.codec.ProtocolDecoderException:
> org.apache.mina.core.buffer.BufferDataException: dataLength: 1048985
> (Hexdump: XX...)
> at
> org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:262)
> [mina-core-2.0.19.jar:?]
> at
> org.apache.mina.filter.codec.CumulativeProtocolDecoder.decode(CumulativeProtocolDecoder.java:180)
> ~[mina-core-2.0.19.jar:?]
> at
> org.apache.mina.filter.codec.ProtocolCodecFilter.messageReceived(ProtocolCodecFilter.java:253)
> ~[mina-core-2.0.19.jar:?]
> Points:
> - There is no synchronization while writing...
> - There are multiple threads parallely wirting into the tcp connection
> (around 100-200)
> - The problem is observed only when the load is high...
> I have seen similar tickets here and not sure about the RCA.
> https://issues.apache.org/jira/browse/DIRMINA-653
> Need help...
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[RESULT] [VOTE] Mina SSHD 2.8.0
Closing this vote with 4 +1s and no other votes. I'll perform the required steps to upload the release. Guillaume Le mar. 30 nov. 2021 à 08:12, Guillaume Nodet a écrit : > I've staged a release candidate at >https://repository.apache.org/content/repositories/orgapachemina-1061 > GIt Tag: > https://github.com/apache/mina-sshd/releases/tag/sshd-2.8.0 > Issues solved: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SSHD%20AND%20fixVersion%20%3D%202.8.0 > > Please review and vote ! > > Cheers > Guillaume Nodet > > -- Guillaume Nodet
Re: [VOTE] Mina SSHD 2.8.0
+1 I'll let the release go with SSHD-1231 and I propose to release 2.8.1 in a few days. Le mar. 30 nov. 2021 à 08:12, Guillaume Nodet a écrit : > I've staged a release candidate at >https://repository.apache.org/content/repositories/orgapachemina-1061 > GIt Tag: > https://github.com/apache/mina-sshd/releases/tag/sshd-2.8.0 > Issues solved: > > https://issues.apache.org/jira/issues/?jql=project%20%3D%20SSHD%20AND%20fixVersion%20%3D%202.8.0 > > Please review and vote ! > > Cheers > Guillaume Nodet > > -- Guillaume Nodet
Re: Q: Release SSHD 2.7.1 ?
Hi, maybe a dumb question, do we need 2.7.1 when 2.8.0 release is going to be released soon? Or would it be better to use 2.7.1 in production and rather wait with 2.8.0 production bump? Thanks, Martin On Thu, Dec 2, 2021 at 4:56 PM Lyor Goldstein wrote: > Sorry, for some reason I missed it - I vote +1 > > >> The vote was started a few days ago: > > > http://mail-archives.apache.org/mod_mbox/mina-dev/202111.mbox/%3cCAA66TppR9cKQtWiYzmPm5hCPG=rhwugsnfhe0-jk0geryuw...@mail.gmail.com%3e > -- Martin Perina Manager, Software Engineering Red Hat Czech s.r.o.
[jira] [Work logged] (DIRMINA-1152) IoServiceStatistics introduces huge latencies
[
https://issues.apache.org/jira/browse/DIRMINA-1152?focusedWorklogId=689822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689822
]
ASF GitHub Bot logged work on DIRMINA-1152:
---
Author: ASF GitHub Bot
Created on: 03/Dec/21 08:36
Start Date: 03/Dec/21 08:36
Worklog Time Spent: 10m
Work Description: elecharny commented on pull request #30:
URL: https://github.com/apache/mina/pull/30#issuecomment-985316700
Sounds very reasonable to me !
I'll review the proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 689822)
Time Spent: 20m (was: 10m)
> IoServiceStatistics introduces huge latencies
> -
>
> Key: DIRMINA-1152
> URL: https://issues.apache.org/jira/browse/DIRMINA-1152
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Dmitrii Novikov
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Current implementation of IoServiceStatistics is blocking - it blocks on
> _throughputCalculationLock_ for almost all operations
> However, _IoServiceStatistics_ is used by all threads which writes to
> _IoSession_ and by all _NioProcessor_ threads.
> Blocking _IoServiceStatistics_ dramatically decreases performance in case of
> multithreaded writing to {_}IoSession{_}.
> Please, refer to my
> [benchmark|https://github.com/dmitriinovikov/apache-mina-benchmark] to ensure
> that it is so. The measurements are taken between the time the message was
> written to _IoSession_ by client and the time when it was actually sent to
> the server by _NioProcessor._ Latency percentiles are calculated for all
> messages except the first 20% - consider it as a warmup. You can read about
> benchmark details in the README file.
>
> My benchmark results:
> {code:java}
> # non-blocking IoServiceStatistics vs blocking IoServiceStatistics:
> p50: 85mcs vs 140mcs
> p75: 150mcs vs 400mcs
> p90: 239mcs vs 905mcs
> p95: 319mcs vs 1418mcs
> p99: 1311mcs vs 11485mcs {code}
>
> As a simple workaround solution, I would suggest to add an option to disable
> _IoServiceStatistics_ or replace it with custom implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina] elecharny commented on pull request #30: DIRMINA-1152: IoServiceStatistics introduces huge latencies
elecharny commented on pull request #30: URL: https://github.com/apache/mina/pull/30#issuecomment-985316700 Sounds very reasonable to me ! I'll review the proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Created] (SSHD-1232) Use of System.inheritedChannel
Jörg Weule created SSHD-1232: Summary: Use of System.inheritedChannel Key: SSHD-1232 URL: https://issues.apache.org/jira/browse/SSHD-1232 Project: MINA SSHD Issue Type: Improvement Reporter: Jörg Weule System.inheritedChannel should be a possible channel for sshServer. The cannel can be opened by systemd, waiting for a connection and then starting the service. -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (DIRMINA-1152) IoServiceStatistics introduces huge latencies
[
https://issues.apache.org/jira/browse/DIRMINA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17452808#comment-17452808
]
Dmitrii Novikov commented on DIRMINA-1152:
--
Hi [~johnnyv],
Could you please review PR: https://github.com/apache/mina/pull/30
> IoServiceStatistics introduces huge latencies
> -
>
> Key: DIRMINA-1152
> URL: https://issues.apache.org/jira/browse/DIRMINA-1152
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Dmitrii Novikov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current implementation of IoServiceStatistics is blocking - it blocks on
> _throughputCalculationLock_ for almost all operations
> However, _IoServiceStatistics_ is used by all threads which writes to
> _IoSession_ and by all _NioProcessor_ threads.
> Blocking _IoServiceStatistics_ dramatically decreases performance in case of
> multithreaded writing to {_}IoSession{_}.
> Please, refer to my
> [benchmark|https://github.com/dmitriinovikov/apache-mina-benchmark] to ensure
> that it is so. The measurements are taken between the time the message was
> written to _IoSession_ by client and the time when it was actually sent to
> the server by _NioProcessor._ Latency percentiles are calculated for all
> messages except the first 20% - consider it as a warmup. You can read about
> benchmark details in the README file.
>
> My benchmark results:
> {code:java}
> # non-blocking IoServiceStatistics vs blocking IoServiceStatistics:
> p50: 85mcs vs 140mcs
> p75: 150mcs vs 400mcs
> p90: 239mcs vs 905mcs
> p95: 319mcs vs 1418mcs
> p99: 1311mcs vs 11485mcs {code}
>
> As a simple workaround solution, I would suggest to add an option to disable
> _IoServiceStatistics_ or replace it with custom implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Work logged] (DIRMINA-1152) IoServiceStatistics introduces huge latencies
[
https://issues.apache.org/jira/browse/DIRMINA-1152?focusedWorklogId=689809&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-689809
]
ASF GitHub Bot logged work on DIRMINA-1152:
---
Author: ASF GitHub Bot
Created on: 03/Dec/21 08:03
Start Date: 03/Dec/21 08:03
Worklog Time Spent: 10m
Work Description: dmitriinovikov opened a new pull request #30:
URL: https://github.com/apache/mina/pull/30
DIRMINA-1152: IoServiceStatistics introduces huge latencies - make
IoServiceStatistics calculation configurable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 689809)
Remaining Estimate: 0h
Time Spent: 10m
> IoServiceStatistics introduces huge latencies
> -
>
> Key: DIRMINA-1152
> URL: https://issues.apache.org/jira/browse/DIRMINA-1152
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Dmitrii Novikov
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Current implementation of IoServiceStatistics is blocking - it blocks on
> _throughputCalculationLock_ for almost all operations
> However, _IoServiceStatistics_ is used by all threads which writes to
> _IoSession_ and by all _NioProcessor_ threads.
> Blocking _IoServiceStatistics_ dramatically decreases performance in case of
> multithreaded writing to {_}IoSession{_}.
> Please, refer to my
> [benchmark|https://github.com/dmitriinovikov/apache-mina-benchmark] to ensure
> that it is so. The measurements are taken between the time the message was
> written to _IoSession_ by client and the time when it was actually sent to
> the server by _NioProcessor._ Latency percentiles are calculated for all
> messages except the first 20% - consider it as a warmup. You can read about
> benchmark details in the README file.
>
> My benchmark results:
> {code:java}
> # non-blocking IoServiceStatistics vs blocking IoServiceStatistics:
> p50: 85mcs vs 140mcs
> p75: 150mcs vs 400mcs
> p90: 239mcs vs 905mcs
> p95: 319mcs vs 1418mcs
> p99: 1311mcs vs 11485mcs {code}
>
> As a simple workaround solution, I would suggest to add an option to disable
> _IoServiceStatistics_ or replace it with custom implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina] dmitriinovikov opened a new pull request #30: DIRMINA-1152: IoServiceStatistics introduces huge latencies
dmitriinovikov opened a new pull request #30: URL: https://github.com/apache/mina/pull/30 DIRMINA-1152: IoServiceStatistics introduces huge latencies - make IoServiceStatistics calculation configurable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
