Re: [VOTE] Release Apache MINA 2.1.6
+1 On Sun, Feb 6, 2022 at 9:18 AM Emmanuel Lecharny wrote: > Hi, > > This is a bug fix release for MINA. > > Here is the list of fixed issues : > > >* [DIRMINA-1152] IoServiceStatistics introduces huge latencies >* [DIRMINA-1156]Inconsistent worker / idleWorker in > OrderedThreadPoolExecutor > > It also contain some minor fixes (ignored tests being fixed, a minor > infinite loop fixed in the Buffer toString() method if used in some > corner case, etc) > > > Here's the Jira link for this version if you'd like to review issues > in more details: > > https://issues.apache.org/jira/projects/DIRMINA/versions/12351317 > > A temporary tag has been created (it can be removed if the vote is not > approved): > > > https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=a58e68216d492f78d0341aef997ad3c78275cb65 > > The newly approved Nexus has been used for the preparation of this > release and all final artifacts are stored > in a staging repository: > https://repository.apache.org/content/repositories/orgapachemina-1065/ > > > The distributions are available for download on : > https://dist.apache.org/repos/dist/dev/mina/mina/2.1.6/ > > Let us vote : > [ ] +1 | Release MINA 2.1.6 > [ ] +/- | Abstain > [ ] -1 | Do *NOT* release MINA 2.1.6 > > Thanks ! > > > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > -- "Legacy code" often differs from its suggested alternative by actually working and scaling. - Bjarne Stroustrup http://www.jeffmaury.com http://riadiscuss.jeffmaury.com http://www.twitter.com/jeffmaury
Re: [VOTE] Release Apache MINA 2.1.6
+1 Jeff > On Feb 6, 2022, at 1:18 AM, Emmanuel Lecharny wrote: > > Hi, > > This is a bug fix release for MINA. > > Here is the list of fixed issues : > > > * [DIRMINA-1152] IoServiceStatistics introduces huge latencies > * [DIRMINA-1156]Inconsistent worker / idleWorker in > OrderedThreadPoolExecutor > > It also contain some minor fixes (ignored tests being fixed, a minor > infinite loop fixed in the Buffer toString() method if used in some > corner case, etc) > > > Here's the Jira link for this version if you'd like to review issues > in more details: > > https://issues.apache.org/jira/projects/DIRMINA/versions/12351317 > > A temporary tag has been created (it can be removed if the vote is not > approved): > > https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=a58e68216d492f78d0341aef997ad3c78275cb65 > > The newly approved Nexus has been used for the preparation of this > release and all final artifacts are stored > in a staging repository: > https://repository.apache.org/content/repositories/orgapachemina-1065/ > > > The distributions are available for download on : > https://dist.apache.org/repos/dist/dev/mina/mina/2.1.6/ > > Let us vote : > [ ] +1 | Release MINA 2.1.6 > [ ] +/- | Abstain > [ ] -1 | Do *NOT* release MINA 2.1.6 > > Thanks ! > > > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Apache MINA 2.1.6
+1 On Sun, Feb 6, 2022 at 3:18 AM Emmanuel Lecharny wrote: > Hi, > > This is a bug fix release for MINA. > > Here is the list of fixed issues : > > >* [DIRMINA-1152] IoServiceStatistics introduces huge latencies >* [DIRMINA-1156]Inconsistent worker / idleWorker in > OrderedThreadPoolExecutor > > It also contain some minor fixes (ignored tests being fixed, a minor > infinite loop fixed in the Buffer toString() method if used in some > corner case, etc) > > > Here's the Jira link for this version if you'd like to review issues > in more details: > > https://issues.apache.org/jira/projects/DIRMINA/versions/12351317 > > A temporary tag has been created (it can be removed if the vote is not > approved): > > > https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=a58e68216d492f78d0341aef997ad3c78275cb65 > > The newly approved Nexus has been used for the preparation of this > release and all final artifacts are stored > in a staging repository: > https://repository.apache.org/content/repositories/orgapachemina-1065/ > > > The distributions are available for download on : > https://dist.apache.org/repos/dist/dev/mina/mina/2.1.6/ > > Let us vote : > [ ] +1 | Release MINA 2.1.6 > [ ] +/- | Abstain > [ ] -1 | Do *NOT* release MINA 2.1.6 > > Thanks ! > > > > -- > Regards, > Cordialement, > Emmanuel Lécharny > www.iktek.com > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > -- CONFIDENTIALITY NOTICE: The contents of this email message and any attachments are intended solely for the addressee(s) and may contain confidential and/or privileged information and may be legally protected from disclosure.
[VOTE] Release Apache MINA 2.1.6
Hi, This is a bug fix release for MINA. Here is the list of fixed issues : * [DIRMINA-1152] IoServiceStatistics introduces huge latencies * [DIRMINA-1156]Inconsistent worker / idleWorker in OrderedThreadPoolExecutor It also contain some minor fixes (ignored tests being fixed, a minor infinite loop fixed in the Buffer toString() method if used in some corner case, etc) Here's the Jira link for this version if you'd like to review issues in more details: https://issues.apache.org/jira/projects/DIRMINA/versions/12351317 A temporary tag has been created (it can be removed if the vote is not approved): https://gitbox.apache.org/repos/asf?p=mina.git;a=commit;h=a58e68216d492f78d0341aef997ad3c78275cb65 The newly approved Nexus has been used for the preparation of this release and all final artifacts are stored in a staging repository: https://repository.apache.org/content/repositories/orgapachemina-1065/ The distributions are available for download on : https://dist.apache.org/repos/dist/dev/mina/mina/2.1.6/ Let us vote : [ ] +1 | Release MINA 2.1.6 [ ] +/- | Abstain [ ] -1 | Do *NOT* release MINA 2.1.6 Thanks ! -- Regards, Cordialement, Emmanuel Lécharny www.iktek.com - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1152) IoServiceStatistics introduces huge latencies
[
https://issues.apache.org/jira/browse/DIRMINA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny updated DIRMINA-1152:
---
Fix Version/s: (was: 2.0.23, 2.1.6, 2.2.0)
> IoServiceStatistics introduces huge latencies
> -
>
> Key: DIRMINA-1152
> URL: https://issues.apache.org/jira/browse/DIRMINA-1152
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Dmitrii Novikov
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Current implementation of IoServiceStatistics is blocking - it blocks on
> _throughputCalculationLock_ for almost all operations
> However, _IoServiceStatistics_ is used by all threads which writes to
> _IoSession_ and by all _NioProcessor_ threads.
> Blocking _IoServiceStatistics_ dramatically decreases performance in case of
> multithreaded writing to {_}IoSession{_}.
> Please, refer to my
> [benchmark|https://github.com/dmitriinovikov/apache-mina-benchmark] to ensure
> that it is so. The measurements are taken between the time the message was
> written to _IoSession_ by client and the time when it was actually sent to
> the server by _NioProcessor._ Latency percentiles are calculated for all
> messages except the first 20% - consider it as a warmup. You can read about
> benchmark details in the README file.
>
> My benchmark results:
> {code:java}
> # non-blocking IoServiceStatistics vs blocking IoServiceStatistics:
> p50: 85mcs vs 140mcs
> p75: 150mcs vs 400mcs
> p90: 239mcs vs 905mcs
> p95: 319mcs vs 1418mcs
> p99: 1311mcs vs 11485mcs {code}
>
> As a simple workaround solution, I would suggest to add an option to disable
> _IoServiceStatistics_ or replace it with custom implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1156) Inconsistent worker / idleWorker in OrderedThreadPoolExecutor
[ https://issues.apache.org/jira/browse/DIRMINA-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lécharny updated DIRMINA-1156: --- Fix Version/s: 2.0.23 2.2.0 2.1.6 (was: 2.0.23, 2.1.6, 2.2.0) > Inconsistent worker / idleWorker in OrderedThreadPoolExecutor > - > > Key: DIRMINA-1156 > URL: https://issues.apache.org/jira/browse/DIRMINA-1156 > Project: MINA > Issue Type: Bug >Reporter: Guus der Kinderen >Priority: Critical > Fix For: 2.0.23, 2.2.0, 2.1.6 > > Attachments: DIRMINA1156Test.java, > OrderedThreadPoolExecutorTest.java, PriorityThreadPoolExecutorTest.java, > UnorderedThreadPoolExecutorTest.java > > > I stumbled upon this while performing analysis of heap dumps of a JVMs that > suffered from an issue where no user was able to establish a connection to > our server software anymore. > > Our application uses an ExecutorFilter. The OrderedThreadPoolExecutor of the > affected server seems to be in an inconsistent state: > * idleWorkers: 2 > * waitingSessions.count: 2293 > * workers.map.size: 0 > What strikes me as odd is: > * No workers, while there are sessions waiting to be processed > * No workers, but a non-zero idle workers count > Servers that are unaffected by the issue have an idle worker count that is > equal to the amount of workers (I assume that the snapshots were taken when > that server was not actively processing data). > We are using Apache MINA 2.1.3. I have no indication that this problem is or > is not present in other versions. > This issue has also been discussed on the Apache MINA users mailinglist, > starting with this message: > https://www.mail-archive.com/users@mina.apache.org/msg06887.html -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1152) IoServiceStatistics introduces huge latencies
[
https://issues.apache.org/jira/browse/DIRMINA-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny updated DIRMINA-1152:
---
Fix Version/s: 2.0.23
2.2.0
2.1.6
> IoServiceStatistics introduces huge latencies
> -
>
> Key: DIRMINA-1152
> URL: https://issues.apache.org/jira/browse/DIRMINA-1152
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.1.4, 2.1.5
>Reporter: Dmitrii Novikov
>Priority: Major
> Fix For: 2.0.23, 2.2.0, 2.1.6
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Current implementation of IoServiceStatistics is blocking - it blocks on
> _throughputCalculationLock_ for almost all operations
> However, _IoServiceStatistics_ is used by all threads which writes to
> _IoSession_ and by all _NioProcessor_ threads.
> Blocking _IoServiceStatistics_ dramatically decreases performance in case of
> multithreaded writing to {_}IoSession{_}.
> Please, refer to my
> [benchmark|https://github.com/dmitriinovikov/apache-mina-benchmark] to ensure
> that it is so. The measurements are taken between the time the message was
> written to _IoSession_ by client and the time when it was actually sent to
> the server by _NioProcessor._ Latency percentiles are calculated for all
> messages except the first 20% - consider it as a warmup. You can read about
> benchmark details in the README file.
>
> My benchmark results:
> {code:java}
> # non-blocking IoServiceStatistics vs blocking IoServiceStatistics:
> p50: 85mcs vs 140mcs
> p75: 150mcs vs 400mcs
> p90: 239mcs vs 905mcs
> p95: 319mcs vs 1418mcs
> p99: 1311mcs vs 11485mcs {code}
>
> As a simple workaround solution, I would suggest to add an option to disable
> _IoServiceStatistics_ or replace it with custom implementation.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (DIRMINA-1161) Accessing the session buffer of multiple decoders
[
https://issues.apache.org/jira/browse/DIRMINA-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Emmanuel Lécharny updated DIRMINA-1161:
---
Fix Version/s: 2.1.6
(was: 2.1.5)
> Accessing the session buffer of multiple decoders
> -
>
> Key: DIRMINA-1161
> URL: https://issues.apache.org/jira/browse/DIRMINA-1161
> Project: MINA
> Issue Type: Bug
> Components: Core
>Affects Versions: 2.0.22, 2.1.4
> Environment: Ubuntu 16.04.7 LTS
> Open JDK 11.0.10
> Mina 2.0.22
>Reporter: Pavel Garin
>Priority: Major
> Fix For: 2.0.23, 2.1.6
>
> Attachments: mina.png
>
>
> As of Mina 2.0.17, the line of code in CumulativeProtocolDecoder
>
> {code:java}
> private final AttributeKey BUFFER = new AttributeKey(getClass(), "buffer");
> {code}
> has been replaced with line
> {code:java}
> private static final AttributeKey BUFFER = new
> AttributeKey(CumulativeProtocolDecoder.class, "buffer");{code}
> When using an architecture where multiple decoders inherited from
> CumulativeProtocolDecoder are used, the decoders corrupt each other's data.
> The key for the attribute in line
> {code:java}
> IoBuffer buf = (IoBuffer) session.getAttribute(BUFFER);{code}
> has become the same for all decoders.
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Closed] (DIRMINA-1158) CVE-2022-23302/23305/23307 In log4j(1.x)
[ https://issues.apache.org/jira/browse/DIRMINA-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emmanuel Lécharny closed DIRMINA-1158. -- Resolution: Not A Problem We don't use Log4j in MINA > CVE-2022-23302/23305/23307 In log4j(1.x) > -- > > Key: DIRMINA-1158 > URL: https://issues.apache.org/jira/browse/DIRMINA-1158 > Project: MINA > Issue Type: Improvement > Components: Core >Affects Versions: 2.1.4, 2.1.5 >Reporter: DONG LI >Priority: Critical > > Hi > Recently，three vulnerabilities have been discovered > ：CVE-2022-23302/23305/23307 In log4j(1.x) 。 > The module “mina-core” depend on log4j 1.2.17 ， > So do we have any plans to deal with these vulnerabilities? > Thanks ：） > [https://www.cvedetails.com/cve/CVE-2022-23302] > [https://nvd.nist.gov/vuln/detail/CVE-2022-23305] > [https://nvd.nist.gov/vuln/detail/CVE-2022-23307] -- This message was sent by Atlassian Jira (v8.20.1#820001) - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
