Re: [VOTE] Release Apache Mina SSHD 2.11.0
Hi Guillaume, Did you update the site generation as well? Gary On Sat, Oct 14, 2023, 12:48 PM Guillaume Nodet wrote: > Thx for pointing out the weird sha files. I've fixed them and removed the > sha256 ones. > > Guillaume > > > Le sam. 14 oct. 2023 à 17:13, Gary D. Gregory a > écrit : > > > Hi All: > > > > +1 > > > > I am reviewing the src zip file: > > > > - ASC OK > > > > - Can't validate SHA file with: > > shasum --check apache-sshd-2.11.0-src.zip.sha512 > > This is due to non-standard format for the file. > > Eyeballing the file looks OK when compared to shasum -a 512 output. > > > > > > - IMO, the VOTE email should include a link to the KEYS file. > > The KEYS file is not even listed on > > https://mina.apache.org/sshd-project/downloads.html > > I had to go hunt for it: > > https://dist.apache.org/repos/dist/release/mina/KEYS > > > > - Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and > > SHA-256? > > > > - There is no way that I can tell if we've broken binary compatibility > (or > > source compatibility) since there is no use of japicmp (or revapi or ...) > > > > - mvn apache-rat:check OK > > > > - mvn clean install OK > > > > - Using: > > Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) > > Maven home: C:\java\apache-maven-3.9.5 > > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > > Default locale: en_US, platform encoding: Cp1252 > > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > > > Gary > > > > > > On 2023/10/12 14:33:37 Guillaume Nodet wrote: > > > I've staged a candidate release for 2.11.0 at: > > > Official staging repo: > > > https://dist.apache.org/repos/dist/dev/mina/sshd/2.11.0/ > > > Maven staging repo: > > > > https://repository.apache.org/content/repositories/orgapachemina-1089 > > > Git tag: > > > https://github.com/apache/mina-sshd/commits/sshd-2.11.0 > > > Changelog: > > > > > > > > > https://github.com/apache/mina-sshd/blob/sshd-2.11.0/docs/changes/2.11.0.md > > > > > > Please review and vote ! > > > > > > > > > -- > > > > > > Guillaume Nodet > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > > For additional commands, e-mail: dev-h...@mina.apache.org > > > > > > -- > > Guillaume Nodet >
Re: [VOTE] Release Apache Mina SSHD 2.11.0
Thx for pointing out the weird sha files. I've fixed them and removed the sha256 ones. Guillaume Le sam. 14 oct. 2023 à 17:13, Gary D. Gregory a écrit : > Hi All: > > +1 > > I am reviewing the src zip file: > > - ASC OK > > - Can't validate SHA file with: > shasum --check apache-sshd-2.11.0-src.zip.sha512 > This is due to non-standard format for the file. > Eyeballing the file looks OK when compared to shasum -a 512 output. > > - IMO, the VOTE email should include a link to the KEYS file. > The KEYS file is not even listed on > https://mina.apache.org/sshd-project/downloads.html > I had to go hunt for it: > https://dist.apache.org/repos/dist/release/mina/KEYS > > - Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and > SHA-256? > > - There is no way that I can tell if we've broken binary compatibility (or > source compatibility) since there is no use of japicmp (or revapi or ...) > > - mvn apache-rat:check OK > > - mvn clean install OK > > - Using: > Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) > Maven home: C:\java\apache-maven-3.9.5 > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Gary > > > On 2023/10/12 14:33:37 Guillaume Nodet wrote: > > I've staged a candidate release for 2.11.0 at: > > Official staging repo: > > https://dist.apache.org/repos/dist/dev/mina/sshd/2.11.0/ > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachemina-1089 > > Git tag: > > https://github.com/apache/mina-sshd/commits/sshd-2.11.0 > > Changelog: > > > > > https://github.com/apache/mina-sshd/blob/sshd-2.11.0/docs/changes/2.11.0.md > > > > Please review and vote ! > > > > > > -- > > > > Guillaume Nodet > > > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > -- Guillaume Nodet
Re: [PR] Create Nio2Session using Nio2ServiceFactory [mina-sshd]
tomaswolf merged PR #424: URL: https://github.com/apache/mina-sshd/pull/424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Apache Mina SSHD 2.11.0
Hi All: +1 I am reviewing the src zip file: - ASC OK - Can't validate SHA file with: shasum --check apache-sshd-2.11.0-src.zip.sha512 This is due to non-standard format for the file. Eyeballing the file looks OK when compared to shasum -a 512 output. - IMO, the VOTE email should include a link to the KEYS file. The KEYS file is not even listed on https://mina.apache.org/sshd-project/downloads.html I had to go hunt for it: https://dist.apache.org/repos/dist/release/mina/KEYS - Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and SHA-256? - There is no way that I can tell if we've broken binary compatibility (or source compatibility) since there is no use of japicmp (or revapi or ...) - mvn apache-rat:check OK - mvn clean install OK - Using: Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: C:\java\apache-maven-3.9.5 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On 2023/10/12 14:33:37 Guillaume Nodet wrote: > I've staged a candidate release for 2.11.0 at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.11.0/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1089 > Git tag: > https://github.com/apache/mina-sshd/commits/sshd-2.11.0 > Changelog: > > https://github.com/apache/mina-sshd/blob/sshd-2.11.0/docs/changes/2.11.0.md > > Please review and vote ! > > > -- > > Guillaume Nodet > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Apache Mina SSHD 2.9.3
Hi again: I should add that there is no way that I can tell if we've broken binary compatibility (or source compatibility) since there is no use of japicmp (or revapi or ...) Gary On 2023/10/14 14:04:07 "Gary D. Gregory" wrote: > Hi All: > > +1 > > Lots of comments on this one; I am reviewing the src zip file: > > - ASC OK > > - Can't validate SHA file with: > shasum --check apache-sshd-2.9.3-src.zip.sha512 > This is due to non-standard format for the file. > Eyeballing the file looks OK when compared to shasum -a 512 output. > > - IMO, the VOTE email should include a link to the KEYS file. > The KEYS file is not even listed on > https://mina.apache.org/sshd-project/downloads.html > I had to go hunt for it: > https://dist.apache.org/repos/dist/release/mina/KEYS > > - Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and > SHA-256? > > - mvn apache-rat:check OK > > - mvn clean install OK (but...) > > - Tests fail unless you have admin rights, this should be documented in the > README IMO: > [ERROR] Errors: > [ERROR] org.apache.sshd.common.util.io.IoUtilsTest.testCheckExists > [ERROR] Run 1: IoUtilsTest.testCheckExists:74->testCheckExists:91 » > FileSystem > C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: > A required privilege is not held by the client > [ERROR] Run 2: IoUtilsTest.testCheckExists:74->testCheckExists:91 » > FileSystem > C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: > A required privilege is not held by the client > [ERROR] Run 3: IoUtilsTest.testCheckExists:74->testCheckExists:91 » > FileSystem > C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: > A required privilege is not held by the client > > - Tests fail randomly because they do not use ephemeral ports. > IOW, don't hardwire server socket ports in tests. > The tests should report which port is in error, whether or not ephemeral > ports are in use. > In this case, I had to hunt down what was using port 8080 on my machine and > temporarily stop that service. > [INFO] > [INFO] Results: > [INFO] > [ERROR] Errors: > [ERROR] > org.apache.sshd.common.forward.PortForwardingTest.testLocalBindingOnDifferentInterfaces > [ERROR] Run 1: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 > » Bind Address already in use: bind > [ERROR] Run 2: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 > » Bind Address already in use: bind > [ERROR] Run 3: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 > » Bind Address already in use: bind > [INFO] > [INFO] > [ERROR] Tests run: 556, Failures: 0, Errors: 1, Skipped: 8 > > - Using: > Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) > Maven home: C:\java\apache-maven-3.9.5 > Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program > Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot > Default locale: en_US, platform encoding: Cp1252 > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" > > Gary > > On 2023/10/12 14:33:21 Guillaume Nodet wrote: > > I've staged a candidate release for 2.9.3 at: > > Official staging repo: > > https://dist.apache.org/repos/dist/dev/mina/sshd/2.9.3/ > > Maven staging repo: > > https://repository.apache.org/content/repositories/orgapachemina-1088 > > Git tag: > > https://github.com/apache/mina-sshd/commits/sshd-2.9.3 > > Changelog: > > https://github.com/apache/mina-sshd/blob/sshd-2.9.3/docs/changes/2.9.3.md > > > > Please review and vote ! > > > > -- > > > > Guillaume Nodet > > > > - > To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org > For additional commands, e-mail: dev-h...@mina.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
Re: [VOTE] Release Apache Mina SSHD 2.9.3
Hi All: +1 Lots of comments on this one; I am reviewing the src zip file: - ASC OK - Can't validate SHA file with: shasum --check apache-sshd-2.9.3-src.zip.sha512 This is due to non-standard format for the file. Eyeballing the file looks OK when compared to shasum -a 512 output. - IMO, the VOTE email should include a link to the KEYS file. The KEYS file is not even listed on https://mina.apache.org/sshd-project/downloads.html I had to go hunt for it: https://dist.apache.org/repos/dist/release/mina/KEYS - Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and SHA-256? - mvn apache-rat:check OK - mvn clean install OK (but...) - Tests fail unless you have admin rights, this should be documented in the README IMO: [ERROR] Errors: [ERROR] org.apache.sshd.common.util.io.IoUtilsTest.testCheckExists [ERROR] Run 1: IoUtilsTest.testCheckExists:74->testCheckExists:91 » FileSystem C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: A required privilege is not held by the client [ERROR] Run 2: IoUtilsTest.testCheckExists:74->testCheckExists:91 » FileSystem C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: A required privilege is not held by the client [ERROR] Run 3: IoUtilsTest.testCheckExists:74->testCheckExists:91 » FileSystem C:\Users\ggregory\Downloads\apache-sshd-2.9.3\sshd-common\target\IoUtilsTest\folder1\folder2\link: A required privilege is not held by the client - Tests fail randomly because they do not use ephemeral ports. IOW, don't hardwire server socket ports in tests. The tests should report which port is in error, whether or not ephemeral ports are in use. In this case, I had to hunt down what was using port 8080 on my machine and temporarily stop that service. [INFO] [INFO] Results: [INFO] [ERROR] Errors: [ERROR] org.apache.sshd.common.forward.PortForwardingTest.testLocalBindingOnDifferentInterfaces [ERROR] Run 1: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 » Bind Address already in use: bind [ERROR] Run 2: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 » Bind Address already in use: bind [ERROR] Run 3: PortForwardingTest.testLocalBindingOnDifferentInterfaces:814 » Bind Address already in use: bind [INFO] [INFO] [ERROR] Tests run: 556, Failures: 0, Errors: 1, Skipped: 8 - Using: Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546) Maven home: C:\java\apache-maven-3.9.5 Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" Gary On 2023/10/12 14:33:21 Guillaume Nodet wrote: > I've staged a candidate release for 2.9.3 at: > Official staging repo: > https://dist.apache.org/repos/dist/dev/mina/sshd/2.9.3/ > Maven staging repo: > https://repository.apache.org/content/repositories/orgapachemina-1088 > Git tag: > https://github.com/apache/mina-sshd/commits/sshd-2.9.3 > Changelog: > https://github.com/apache/mina-sshd/blob/sshd-2.9.3/docs/changes/2.9.3.md > > Please review and vote ! > > -- > > Guillaume Nodet > - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
