[jira] [Closed] (SSHD-1338) SSHD 2.12 not binary compatible with JGIT 5.13

2024-01-30 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed SSHD-1338.
-
Resolution: Fixed

> SSHD 2.12 not binary compatible with JGIT 5.13
> --
>
> Key: SSHD-1338
> URL: https://issues.apache.org/jira/browse/SSHD-1338
> Project: MINA SSHD
>  Issue Type: Improvement
>Reporter: Tomas Hofman
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 2.12.1
>
>
> Current version of SSHD still contains a dependency on JGIT 5.13. This is to 
> keep SSHD compatible with Java 1.8, as JGIT 6.x requires Java 11.
> However SSHD 2.12 is not binary compatible with 2.9.x versions, which is the 
> version that JGIT 5.13.x were build against. The result is that when SSHD 
> 2.12 and JGIT 5.13 are used together, one can get NoSuchMethodErrors like 
> here:
> {code}
> Caused by: java.lang.NoSuchMethodError: 'java.lang.Object 
> org.apache.sshd.client.future.ConnectFuture.verify()'
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:189)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:142)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSession.connect(SshdSession.java:99)
> at 
> org.eclipse.jgit@5.13.2.SP1-redhat-1//org.eclipse.jgit.transport.sshd.SshdSessionFactory.getSession(SshdSessionFactory.java:235)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [PR] Use a singleton threadpool for kex message handler flushing [mina-sshd]

2024-01-30 Thread via GitHub


gnodet merged PR #459:
URL: https://github.com/apache/mina-sshd/pull/459


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [I] KeyExchangeMessageHandler threads pilling up [mina-sshd]

2024-01-30 Thread via GitHub


gnodet closed issue #458: KeyExchangeMessageHandler threads pilling up
URL: https://github.com/apache/mina-sshd/issues/458


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[I] heartbeat timeout of a session will cause the links of other sessions to be disconnected [mina-sshd]

2024-01-30 Thread via GitHub


d9e7381f opened a new issue, #461:
URL: https://github.com/apache/mina-sshd/issues/461

   ### Version
   
   2.6.0
   
   ### Bug description
   
   In my case, 20 connections were established using the same mina ssh client, 
10 to A-server(mina ssh server) and the others to B-server(mina ssh server). 
For a period of time, the network from client to B-server was not smooth. At 
this time, we found that the session from client to A-server was also 
disconnected.
   i got some log from A-server:
   `
   INFO - sshd-SshServer[150d80c4](port=8822)-timer-thread-1 [] 
c.s.p.t.s.s.CustomServerSessionImpl []: 
Disconnecting(CustomServerSessionImpl[classic-tx-beijing-01:hybrid01.classic-tx-beijing-01.8330@/10.53.4.116:12033]):
 SSH2_DISCONNECT_PROTOCOL_ERROR - Detected IdleTimeout after PT40.068S/PT40S ms.
   `
   
   
   I checked the mina ssh code and found that the same ssh client shares a 
thread for sending heartbeats. This will cause one session to send heartbeats 
and block other sessions from sending heartbeats, causing other sessions to be 
disconnected.
   
   ### Actual behavior
   
   In my case, 20 connections were established using the same mina ssh client, 
10 to A-server(mina ssh server) and the others to B-server(mina ssh server). 
For a period of time, the network from client to B-server was not smooth. At 
this time, we found that the session from client to A-server was also 
disconnected.
   i got some log from A-server:
   `
   INFO - sshd-SshServer[150d80c4](port=8822)-timer-thread-1 [] 
c.s.p.t.s.s.CustomServerSessionImpl []: 
Disconnecting(CustomServerSessionImpl[classic-tx-beijing-01:hybrid01.classic-tx-beijing-01.8330@/10.53.4.116:12033]):
 SSH2_DISCONNECT_PROTOCOL_ERROR - Detected IdleTimeout after PT40.068S/PT40S ms.
   `
   
   
   ### Expected behavior
   
   When the network from client to B-server is not smooth, the channel from 
client to A-server should not be disconnected.
   
   ### Relevant log output
   
   ```Shell
   client to B-server log:
   WARN - sshd-timer-thread-1 [] c.SshClientCreator$4$1 []: 
sendHeartBeat(ClientSessionImpl[classic-tx-beijing-01:hybrid01.classic-tx-beijing-01.8330@aa.cloud/10.235.88.64:8800])
 failed (IOException) to send heartbeat #7 request=keepal...@tunnel.mock.cn: 
Session is closed or closing while awaiting reply for request=keepal...@mock.cn
   org.apache.sshd.common.SshException: 
DefaultConnectFuture[classic-tx-beijing-01.cloud:hybrid01.classic-tx-beijing-01.cloud.8329@aa.cloud/10.235.88.64:8800]:
 Failed to get operation result within specified timeout: 2
   
   
   A-server log:
   INFO - sshd-SshServer[150d80c4](port=8822)-timer-thread-1 [] 
c.s.p.t.s.s.CustomServerSessionImpl []: 
Disconnecting(CustomServerSessionImpl[classic-tx-beijing-01:hybrid01.classic-tx-beijing-01.8330@/10.53.4.116:12033]):
 SSH2_DISCONNECT_PROTOCOL_ERROR - Detected IdleTimeout after PT40.068S/PT40S ms.
   ```
   
   
   ### Other information
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[PR] RAIN-4910 - Removed secret keys from old archived repositories. [mina-sshd]

2024-01-30 Thread via GitHub


akhileshpatil06 opened a new pull request, #462:
URL: https://github.com/apache/mina-sshd/pull/462

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [I] heartbeat timeout of a session will cause the links of other sessions to be disconnected [mina-sshd]

2024-01-30 Thread via GitHub


gnodet commented on issue #461:
URL: https://github.com/apache/mina-sshd/issues/461#issuecomment-1917501537

   If you have a heartbeat configured, you may want to check its configuration. 
 The properties defined in 
[`CommonModuleProperties`](https://github.com/apache/mina-sshd/blob/737475319b914915306575e8b072e7ed94e94cdd/sshd-common/src/main/java/org/apache/sshd/common/CommonModuleProperties.java)
 control the heartbeat: `session-connection-heartbeat-type` seems to be set to 
40s in your case.  You may also have a connect timeout set to 20s according to 
the client error message.  You also have a custom heartbeat sender configured 
(sending `keepal...@tunnel.mock.cn`). 
   I would check this custom heartbeat, as it wonder if it does wait for a 
response, which should not be the case for a heartbeat (they usually just send 
a message without waiting for a response, just to keep things alive).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



Re: [I] Question regarding the md5-hash extension [mina-sshd]

2024-01-30 Thread via GitHub


gnodet commented on issue #450:
URL: https://github.com/apache/mina-sshd/issues/450#issuecomment-1917521356

   You can find an example of calling a client side extension at: 
 
https://github.com/apache/mina-sshd/blob/6d93af8e1f852d50849ef158ee30bebf67e46fbc/sshd-sftp/src/main/java/org/apache/sshd/sftp/client/fs/SftpFileSystemProvider.java#L777
 
 So in this case, it would look like:
   ```
   SftpClient client = ...;
   MD5FileExtension md5 = client.getExtension(MD5FileExtension.class);
   md5.getHash(...)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org