[jira] [Commented] (SSHD-1287) Use the maximum packet size of the communication partner

2022-08-07 Thread Ryosuke Kanda (Jira)


[ 
https://issues.apache.org/jira/browse/SSHD-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17576472#comment-17576472
 ] 

Ryosuke Kanda commented on SSHD-1287:
-

Thanks a lot.
I understood what you mean. I hope those will be fixed.

> Use the maximum packet size of the communication partner
> 
>
> Key: SSHD-1287
> URL: https://issues.apache.org/jira/browse/SSHD-1287
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Thomas Wolf
>Priority: Minor
> Attachments: ClientMain.java, ConsoleLog, ServerMain.java
>
>
> It appears that SSHD may use the maximum packet size presented by the 
> communicating party to request reception.
> RFC 4254 contains the following statement, where "maximum packet size" can be 
> read as "the maximum packet size that the sender is willing to accept" (as in 
> "initial window size").
> {code:java}
> Section 5.1 Opening a Channel
> The 'maximum packet size' specifies the maximum size of 
> 2an individual data packet that can be sent to the sender.{code}
> The client/server must comply with its own declared maximum packet size.
>  
> I encountered this issue when I was using "freeSSHd" as an SFTP server.
> The version of freeSSHd is 1.3.1.
> The event is confirmed by creating a server with SSHD.
> Attached are the client and server sources, as well as the client debug logs 
> (up to the first read request).
> When communicating with these, the client knows that its maximum packet size 
> is "32768" and the server's maximum packet size is "65536".
> {code:java}
> // client window
> [main] DEBUG org.apache.sshd.common.channel.Window - 
> init(Window[client/local](SftpChannelSubsystem[id=0, 
> recipient=-1]-ClientSessionImpl[user@localhost/127.0.0.1:10022][sftp])) 
> size=2097152, max=2097152, packet=32768
> // server window
> [sshd-SshClient[5702b3b1]-nio2-thread-3] DEBUG 
> org.apache.sshd.common.channel.Window - 
> init(Window[client/remote](SftpChannelSubsystem[id=0, 
> recipient=0]-ClientSessionImpl[user@localhost/127.0.0.1:10022][sftp])) 
> size=2097152, max=2097152, packet=65536 {code}
> And when requesting to receive a file, it requests to read 65536 bytes at a 
> time. This means that it attempts to receive packets that exceed 32768 bytes.
> {code:java}
> [main] TRACE org.apache.sshd.sftp.client.impl.SftpInputStreamAsync - 
> sendRequests(SftpInputStreamAsync[ClientSessionImpl[user@localhost/127.0.0.1:10022]][/data4M.txt])
>  enqueue pending ack: SftpAckData[id=103, offset=0, length=65536] {code}
>  
> I hope this report is helpful.
> I am doing machine translation, so please allow it to be unnatural.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Created] (SSHD-1287) Use the maximum packet size of the communication partner

2022-07-29 Thread Ryosuke Kanda (Jira)
Ryosuke Kanda created SSHD-1287:
---

 Summary: Use the maximum packet size of the communication partner
 Key: SSHD-1287
 URL: https://issues.apache.org/jira/browse/SSHD-1287
 Project: MINA SSHD
  Issue Type: Bug
Affects Versions: 2.8.0
Reporter: Ryosuke Kanda
 Attachments: ClientMain.java, ConsoleLog, ServerMain.java

It appears that SSHD may use the maximum packet size presented by the 
communicating party to request reception.

RFC 4254 contains the following statement, where "maximum packet size" can be 
read as "the maximum packet size that the sender is willing to accept" (as in 
"initial window size").
{code:java}
Section 5.1 Opening a Channel

The 'maximum packet size' specifies the maximum size of 
2an individual data packet that can be sent to the sender.{code}
The client/server must comply with its own declared maximum packet size.

 

I encountered this issue when I was using "freeSSHd" as an SFTP server.
The version of freeSSHd is 1.3.1.

The event is confirmed by creating a server with SSHD.

Attached are the client and server sources, as well as the client debug logs 
(up to the first read request).
When communicating with these, the client knows that its maximum packet size is 
"32768" and the server's maximum packet size is "65536".
{code:java}
// client window
[main] DEBUG org.apache.sshd.common.channel.Window - 
init(Window[client/local](SftpChannelSubsystem[id=0, 
recipient=-1]-ClientSessionImpl[user@localhost/127.0.0.1:10022][sftp])) 
size=2097152, max=2097152, packet=32768
// server window
[sshd-SshClient[5702b3b1]-nio2-thread-3] DEBUG 
org.apache.sshd.common.channel.Window - 
init(Window[client/remote](SftpChannelSubsystem[id=0, 
recipient=0]-ClientSessionImpl[user@localhost/127.0.0.1:10022][sftp])) 
size=2097152, max=2097152, packet=65536 {code}
And when requesting to receive a file, it requests to read 65536 bytes at a 
time. This means that it attempts to receive packets that exceed 32768 bytes.
{code:java}
[main] TRACE org.apache.sshd.sftp.client.impl.SftpInputStreamAsync - 
sendRequests(SftpInputStreamAsync[ClientSessionImpl[user@localhost/127.0.0.1:10022]][/data4M.txt])
 enqueue pending ack: SftpAckData[id=103, offset=0, length=65536] {code}
 

I hope this report is helpful.
I am doing machine translation, so please allow it to be unnatural.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-07 Thread Ryosuke Kanda (Jira)


[ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17488555#comment-17488555
 ] 

Ryosuke Kanda commented on SSHD-1244:
-

I'm sorry I'm late. I tried.
Window Adjust was successful and was able to send a 4GB file.

Thank you for your prompt response.

 
{code:java}
10:33:13.394 | WARN  | 8]-nio2-thread-8 | o.a.s.c.c.Window                 | 
org.apache.sshd.common.channel.Window                             143 | 
expand(Window[client/remote](SftpChannelSubsystem[id=0, 
recipient=0]-ClientSessionImpl[kada@/192.168.12.222:18022][sftp])) 
window=4294873079 - truncated expanded size (4294901929) to 2147483647{code}
 

> Client fails window adjust above Integer.MAX_VALUE
> --
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Lyor Goldstein
>Priority: Minor
> Attachments: Main.java
>
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.
>  
> I have attached the client implementation to this issue.
> (Maybe a poor implementation ...)
> The console logs, including the debug logs, were too large to attach.
> The parts that are clearly set for the SSH client are as follows.
> ServerKeyVerifier
> HostConfigEntryResolver
> KeyIdentityProvider
> In the log, the part where the error occurred is as follows.
> You can see that SSHD recognizes the new Window size as a negative value.
> {code:java}
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.sftp.client.impl.DefaultSftpClient$SftpChannelSubsystem - 
> handleWindowAdjust(SftpChannelSubsystem[id=0, 
> recipient=0]-ClientSessionImpl[kada@/192.168.12.222:18022][sftp]) 
> SSH_MSG_CHANNEL_WINDOW_ADJUST window=-94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.common.io.nio2.Nio2Session - 
> handleReadCycleFailure(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
> remote=/192.168.12.222:18022]) IllegalArgumentException after 8166700 nanos 
> at read cycle=103401: Negative window size: -94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.common.io.nio2.Nio2Session - 
> exceptionCaught(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
> remote=/192.168.12.222:18022]) caught IllegalArgumentException[Negative 
> window size: -94217] - calling handler
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.client.session.ClientSessionImpl - 
> signalAuthFailure(ClientSessionImpl[kada@/192.168.12.222:18022]) 
> type=IllegalArgumentException, signalled=false, first=false: Negative window 
> size: -94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] WARN 
> org.apache.sshd.client.session.ClientSessionImpl - 
> exceptionCaught(ClientSessionImpl[kada@/192.168.12.222:18022])[state=Opened] 
> IllegalArgumentException: Negative window size: -94217
> java.lang.IllegalArgumentException: Negative window size: -94217
>     at 
> org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)
>     at 
> org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)
>     at 
> org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:162)
>     at org.apache.sshd.common.channel.Window.expand(Window.java:123)
>     at 
> org.apache.sshd.common.channel.AbstractChannel.handleWindowAdjust(AbstractChannel.java:894)
>     at 
> org.apache.sshd.client.channel.AbstractClientChannel.handleWindowAdjust(AbstractClientChannel.java:448)
>     at 
> org.apache.sshd.common.session.helpers.AbstractConnectionService.channelWindowAdjust(AbstractConnectionService.java:614)
>     at 
> org.apache.sshd.common.session.helpers.AbstractConnectionService.process(AbstractConnectionService.java:477)
>     at 
> org.apache.sshd.common.session.helpers.AbstractSession.doHandleMessage(AbstractSession.java:526)
>     at 
> org.apache.sshd.common.session.helpers.AbstractSession.handleMessage(AbstractSession.java:452)
>     at 
> org.apache.sshd.common.session.helpers.AbstractSession.decode(AbstractSession.java:1524)
>     at 
> 

[jira] [Commented] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-03 Thread Ryosuke Kanda (Jira)


[ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486774#comment-17486774
 ] 

Ryosuke Kanda commented on SSHD-1244:
-

> Don't know what is meant by "INT_MAX", but Integer.MAX_VALUE is 2^31-1.

Thank you. Update the title.

> This seems to be a violation of [RFC4254 - section 5.2]

As mentioned above, "INT_MAX" refers to 2 ^ 31-1 which is the maximum value of 
int type that is not unsigned.
Therefore, I think it is a problem that we cannot receive a value that exceeds 
this (and does not exceed 2 ^ 32-1).


> How do you know that this is the reason for the failure ?

As added to the description.
What should I do if I need a complete debug log?

> BTW, what does ProFTPD have to do with SSHD ?

Earlier, there were reports that our product (using SSHD) could not communicate 
with ProFTPD.
This product is currently about to switch to the newer SSHD.
As a result of switching, we are checking whether the problems that occurred in 
the past will be improved.

> Client fails window adjust above Integer.MAX_VALUE
> --
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Lyor Goldstein
>Priority: Minor
> Attachments: Main.java
>
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.
>  
> I have attached the client implementation to this issue.
> (Maybe a poor implementation ...)
> The console logs, including the debug logs, were too large to attach.
> The parts that are clearly set for the SSH client are as follows.
> ServerKeyVerifier
> HostConfigEntryResolver
> KeyIdentityProvider
> In the log, the part where the error occurred is as follows.
> You can see that SSHD recognizes the new Window size as a negative value.
> {code:java}
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.sftp.client.impl.DefaultSftpClient$SftpChannelSubsystem - 
> handleWindowAdjust(SftpChannelSubsystem[id=0, 
> recipient=0]-ClientSessionImpl[kada@/192.168.12.222:18022][sftp]) 
> SSH_MSG_CHANNEL_WINDOW_ADJUST window=-94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.common.io.nio2.Nio2Session - 
> handleReadCycleFailure(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
> remote=/192.168.12.222:18022]) IllegalArgumentException after 8166700 nanos 
> at read cycle=103401: Negative window size: -94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.common.io.nio2.Nio2Session - 
> exceptionCaught(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
> remote=/192.168.12.222:18022]) caught IllegalArgumentException[Negative 
> window size: -94217] - calling handler
> [sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
> org.apache.sshd.client.session.ClientSessionImpl - 
> signalAuthFailure(ClientSessionImpl[kada@/192.168.12.222:18022]) 
> type=IllegalArgumentException, signalled=false, first=false: Negative window 
> size: -94217
> [sshd-SshClient[343f4d3d]-nio2-thread-5] WARN 
> org.apache.sshd.client.session.ClientSessionImpl - 
> exceptionCaught(ClientSessionImpl[kada@/192.168.12.222:18022])[state=Opened] 
> IllegalArgumentException: Negative window size: -94217
> java.lang.IllegalArgumentException: Negative window size: -94217
>     at 
> org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)
>     at 
> org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)
>     at 
> org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:162)
>     at org.apache.sshd.common.channel.Window.expand(Window.java:123)
>     at 
> org.apache.sshd.common.channel.AbstractChannel.handleWindowAdjust(AbstractChannel.java:894)
>     at 
> org.apache.sshd.client.channel.AbstractClientChannel.handleWindowAdjust(AbstractClientChannel.java:448)
>     at 
> org.apache.sshd.common.session.helpers.AbstractConnectionService.channelWindowAdjust(AbstractConnectionService.java:614)
>     at 
> 

[jira] [Updated] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-03 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Description: 
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.

The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window size 
by default.
I've confirmed that SSHD can handle this without any problems, so I sent a 4GB 
file to see what happens when Window Adjust is done.
As a result, a Window Adjust was done and SSHD was unable to handle this 
successfully.

 

I have attached the client implementation to this issue.
(Maybe a poor implementation ...)
The console logs, including the debug logs, were too large to attach.

The parts that are clearly set for the SSH client are as follows.
ServerKeyVerifier
HostConfigEntryResolver
KeyIdentityProvider

In the log, the part where the error occurred is as follows.
You can see that SSHD recognizes the new Window size as a negative value.
{code:java}
[sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
org.apache.sshd.sftp.client.impl.DefaultSftpClient$SftpChannelSubsystem - 
handleWindowAdjust(SftpChannelSubsystem[id=0, 
recipient=0]-ClientSessionImpl[kada@/192.168.12.222:18022][sftp]) 
SSH_MSG_CHANNEL_WINDOW_ADJUST window=-94217
[sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
org.apache.sshd.common.io.nio2.Nio2Session - 
handleReadCycleFailure(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
remote=/192.168.12.222:18022]) IllegalArgumentException after 8166700 nanos at 
read cycle=103401: Negative window size: -94217
[sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
org.apache.sshd.common.io.nio2.Nio2Session - 
exceptionCaught(Nio2Session[local=/0:0:0:0:0:0:0:0:51143, 
remote=/192.168.12.222:18022]) caught IllegalArgumentException[Negative window 
size: -94217] - calling handler
[sshd-SshClient[343f4d3d]-nio2-thread-5] DEBUG 
org.apache.sshd.client.session.ClientSessionImpl - 
signalAuthFailure(ClientSessionImpl[kada@/192.168.12.222:18022]) 
type=IllegalArgumentException, signalled=false, first=false: Negative window 
size: -94217
[sshd-SshClient[343f4d3d]-nio2-thread-5] WARN 
org.apache.sshd.client.session.ClientSessionImpl - 
exceptionCaught(ClientSessionImpl[kada@/192.168.12.222:18022])[state=Opened] 
IllegalArgumentException: Negative window size: -94217
java.lang.IllegalArgumentException: Negative window size: -94217
    at 
org.apache.sshd.common.util.ValidateUtils.createFormattedException(ValidateUtils.java:213)
    at 
org.apache.sshd.common.util.ValidateUtils.throwIllegalArgumentException(ValidateUtils.java:179)
    at 
org.apache.sshd.common.util.ValidateUtils.checkTrue(ValidateUtils.java:162)
    at org.apache.sshd.common.channel.Window.expand(Window.java:123)
    at 
org.apache.sshd.common.channel.AbstractChannel.handleWindowAdjust(AbstractChannel.java:894)
    at 
org.apache.sshd.client.channel.AbstractClientChannel.handleWindowAdjust(AbstractClientChannel.java:448)
    at 
org.apache.sshd.common.session.helpers.AbstractConnectionService.channelWindowAdjust(AbstractConnectionService.java:614)
    at 
org.apache.sshd.common.session.helpers.AbstractConnectionService.process(AbstractConnectionService.java:477)
    at 
org.apache.sshd.common.session.helpers.AbstractSession.doHandleMessage(AbstractSession.java:526)
    at 
org.apache.sshd.common.session.helpers.AbstractSession.handleMessage(AbstractSession.java:452)
    at 
org.apache.sshd.common.session.helpers.AbstractSession.decode(AbstractSession.java:1524)
    at 
org.apache.sshd.common.session.helpers.AbstractSession.messageReceived(AbstractSession.java:412)
    at 
org.apache.sshd.common.session.helpers.AbstractSessionIoHandler.messageReceived(AbstractSessionIoHandler.java:64)
    at 
org.apache.sshd.common.io.nio2.Nio2Session.handleReadCycleCompletion(Nio2Session.java:359)
    at 
org.apache.sshd.common.io.nio2.Nio2Session$1.onCompleted(Nio2Session.java:336)
    at 
org.apache.sshd.common.io.nio2.Nio2Session$1.onCompleted(Nio2Session.java:333)
    at 
org.apache.sshd.common.io.nio2.Nio2CompletionHandler.lambda$completed$0(Nio2CompletionHandler.java:38)
    at java.security.AccessController.doPrivileged(Native Method)
    at 
org.apache.sshd.common.io.nio2.Nio2CompletionHandler.completed(Nio2CompletionHandler.java:37)
    at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126)
    at sun.nio.ch.Invoker$2.run(Invoker.java:218)
    at 
sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupImpl.java:112)
    at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at 

[jira] [Updated] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-03 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Attachment: Main.java

> Client fails window adjust above Integer.MAX_VALUE
> --
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Lyor Goldstein
>Priority: Minor
> Attachments: Main.java
>
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Updated] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-03 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Description: 
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.

The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window size 
by default.
I've confirmed that SSHD can handle this without any problems, so I sent a 4GB 
file to see what happens when Window Adjust is done.
As a result, a Window Adjust was done and SSHD was unable to handle this 
successfully.

 

 

  was:
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.

The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window size 
by default.
I've confirmed that SSHD can handle this without any problems, so I sent a 4GB 
file to see what happens when Window Adjust is done.
As a result, a Window Adjust was done and SSHD was unable to handle this 
successfully.


> Client fails window adjust above Integer.MAX_VALUE
> --
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Lyor Goldstein
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Updated] (SSHD-1244) Client fails window adjust above Integer.MAX_VALUE

2022-02-03 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Summary: Client fails window adjust above Integer.MAX_VALUE  (was: Client 
fails window adjust above INT_MAX)

> Client fails window adjust above Integer.MAX_VALUE
> --
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Assignee: Lyor Goldstein
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Commented] (SSHD-1244) Client fails window adjust above INT_MAX

2022-02-02 Thread Ryosuke Kanda (Jira)


[ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17486221#comment-17486221
 ] 

Ryosuke Kanda commented on SSHD-1244:
-

Added information.

> Client fails window adjust above INT_MAX
> 
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Updated] (SSHD-1244) Client fails window adjust above INT_MAX

2022-02-02 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Description: 
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.

The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window size 
by default.
I've confirmed that SSHD can handle this without any problems, so I sent a 4GB 
file to see what happens when Window Adjust is done.
As a result, a Window Adjust was done and SSHD was unable to handle this 
successfully.

  was:
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.


> Client fails window adjust above INT_MAX
> 
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.
> The SFTP feature of ProFTPD notifies 2 ^ 32-1 bytes as the initial window 
> size by default.
> I've confirmed that SSHD can handle this without any problems, so I sent a 
> 4GB file to see what happens when Window Adjust is done.
> As a result, a Window Adjust was done and SSHD was unable to handle this 
> successfully.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Updated] (SSHD-1244) Client fails window adjust above INT_MAX

2022-02-02 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Description: 
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

 

I encountered this issue when I was using ProFTPD as an SFTP server.
The version of ProFTPD is 1.3.5e.

  was:
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.


> Client fails window adjust above INT_MAX
> 
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.
>  
> I encountered this issue when I was using ProFTPD as an SFTP server.
> The version of ProFTPD is 1.3.5e.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Updated] (SSHD-1244) Client fails window adjust above INT_MAX

2022-02-02 Thread Ryosuke Kanda (Jira)


 [ 
https://issues.apache.org/jira/browse/SSHD-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ryosuke Kanda updated SSHD-1244:

Description: 
If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
INT_MAX, it will not be recognized correctly.

I think the cause is in the following places:
org.apache.sshd.common.channel.Window.expand(int)

 

I am doing machine translation, so please allow it to be unnatural.

  was:
SSH_MSG_CHANNEL_WINDOW_ADJUSTで指定された新しいウィンドウサイズがINT_MAXを超えると、正しく認識されません。

原因は次の場所にあると思います:
org.apache.sshd.common.channel.Window.expand(int)

 

機械翻訳を行っておりますので、不自然で情報量の少ない表現にしてください。


> Client fails window adjust above INT_MAX
> 
>
> Key: SSHD-1244
> URL: https://issues.apache.org/jira/browse/SSHD-1244
> Project: MINA SSHD
>  Issue Type: Bug
>Affects Versions: 2.8.0
>Reporter: Ryosuke Kanda
>Priority: Minor
>
> If the new window size specified by SSH_MSG_CHANNEL_WINDOW_ADJUST exceeds 
> INT_MAX, it will not be recognized correctly.
> I think the cause is in the following places:
> org.apache.sshd.common.channel.Window.expand(int)
>  
> I am doing machine translation, so please allow it to be unnatural.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[jira] [Created] (SSHD-1244) Client fails window adjust above INT_MAX

2022-02-02 Thread Ryosuke Kanda (Jira)
Ryosuke Kanda created SSHD-1244:
---

 Summary: Client fails window adjust above INT_MAX
 Key: SSHD-1244
 URL: https://issues.apache.org/jira/browse/SSHD-1244
 Project: MINA SSHD
  Issue Type: Bug
Affects Versions: 2.8.0
Reporter: Ryosuke Kanda


SSH_MSG_CHANNEL_WINDOW_ADJUSTで指定された新しいウィンドウサイズがINT_MAXを超えると、正しく認識されません。

原因は次の場所にあると思います:
org.apache.sshd.common.channel.Window.expand(int)

 

機械翻訳を行っておりますので、不自然で情報量の少ない表現にしてください。



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org