[GitHub] [mina-sshd] lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies
lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies URL: https://github.com/apache/mina-sshd/pull/118#issuecomment-610987889 Merged with many thanks and acknowledgement - see [60bdb04642](https://github.com/apache/mina-sshd/commit/60bdb04642cbcb82501841b9f25601c5532d537b). Please close this PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies
lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies URL: https://github.com/apache/mina-sshd/pull/118#issuecomment-610822342 Good - I will merge it in and verify - thanks for the contribution This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies
lgoldstein commented on issue #118: [SSHD-975] Use AbstractFactoryManager's classloader for proxies URL: https://github.com/apache/mina-sshd/pull/118#issuecomment-610605866 >> Agreed, think we should just use the method without ClassLoader argument and instantiate the proxy in the classloader where the interface lives -- it's the simplest and guaranteed to work. What do you think? My thinking exactly - let me know if it fixes your problem. If so I will be more than happy to merge it to our _master_ branch. Please make sure that `mvn clean install` succeeds on the entire project. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
