Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-02 Thread Niklas Gustavsson
On Mon, Sep 27, 2010 at 10:12 PM, Niklas Gustavsson
 wrote:
> I've fixed the bug discovered by Sai and the license header reported
> by Emmanuel.

This vote passes, thanks for reviewing. Results are: 4 binding +1, 2
non-binding +1. No 0 or -1.

I'll push out the release and update the sites now.

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-01 Thread Ashish
[X ] +1, release FtpServer 1.0.5

On Tue, Sep 28, 2010 at 1:42 AM, Niklas Gustavsson  wrote:
> Hi
>
> I've fixed the bug discovered by Sai and the license header reported
> by Emmanuel. New binaries at:
>
> https://repository.apache.org/content/repositories/orgapachemina-016
>
> These are based on the source here:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
>
> The change log is here:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
>
> Let's vote, again:
> [ ] +1, release FtpServer 1.0.5
> [ ] 0
> [ ] -1, don't release because...
>
> /niklas
>



-- 
thanks
ashish

Blog: http://www.ashishpaliwal.com/blog
My Photo Galleries: http://www.pbase.com/ashishpaliwal


Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-01 Thread Emmanuel Lecharny

 On 10/1/10 10:58 PM, Alan D. Cabrera wrote:

Odd, I get

[INFO] Too many unapproved licenses: 13

but when I look at the report I see the same thing you claim.  Odd.

Not necessarily. However, the way we use rat in FtpServer is a bit basic.

If you add :


org.codehaus.mojo
rat-maven-plugin
1.0-alpha-3


**/target/**/*
**/.*
**/NOTICE.txt
**/LICENSE*.txt

false



then you will be able to run
mvn rat:check

without getting a NPE, and you'll get this result (I have removed all 
the compliant files ) :



*
Summary
---
Notes: 5
Binaries: 8
Archives: 0
Standards: 364

Apache Licensed: 364
Generated Documents: 0

JavaDocs are generated and so license header is optional
Generated files do not required license headers

0 Unknown Licenses

***

Archives (+ indicates readable, $ unreadable):


*
  Files with AL headers will be marked L
  Binary files (which do not require AL headers) will be marked B
  Compressed archives will be marked A
  Notices, licenses etc will be marked N
  B core/src/examples/resources/ftpserver.jks
  B core/src/test/resources/client.jks
  B core/src/test/resources/ftpserver.jks
  B core/src/test/resources/keymanager-test.jks
  B distribution/bin/ftpd.exe
  B distribution/bin/ftpdw.exe
  N distribution/common/lib/README.txt
  N distribution/README.txt
  N distribution/res/conf/README.txt
  B distribution/res/ftpserver.jks
  N distribution/res/home/README.txt
  N distribution/res/log/README.txt
  B 
examples/ftpserver-example-spring-war/src/main/resources/ftpserver.jks



--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com



Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-01 Thread Alan D. Cabrera
Odd, I get

[INFO] Too many unapproved licenses: 13

but when I look at the report I see the same thing you claim.  Odd.

+1 (non-binding)


Regards,
Alan

On Oct 1, 2010, at 1:32 PM, Niklas Gustavsson wrote:

> On Fri, Oct 1, 2010 at 7:44 PM, Alan D. Cabrera  wrote:
>> Rat fails on this release.
> 
> The only files I've seen RAT report are the distribution/LICENSE.*.txt
> files, which should be okay (that said, we should add them to the RAT
> exclusion list). I just double checked. Did you find anything else?
> 
> /niklas



Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-01 Thread Niklas Gustavsson
On Fri, Oct 1, 2010 at 7:44 PM, Alan D. Cabrera  wrote:
> Rat fails on this release.

The only files I've seen RAT report are the distribution/LICENSE.*.txt
files, which should be okay (that said, we should add them to the RAT
exclusion list). I just double checked. Did you find anything else?

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-10-01 Thread Alan D. Cabrera
Rat fails on this release.


Regards,
Alan

On Sep 27, 2010, at 1:12 PM, Niklas Gustavsson wrote:

> Hi
> 
> I've fixed the bug discovered by Sai and the license header reported
> by Emmanuel. New binaries at:
> 
> https://repository.apache.org/content/repositories/orgapachemina-016
> 
> These are based on the source here:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
> 
> The change log is here:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
> 
> Let's vote, again:
> [ ] +1, release FtpServer 1.0.5
> [ ] 0
> [ ] -1, don't release because...
> 
> /niklas



Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-09-30 Thread Niklas Gustavsson
On Mon, Sep 27, 2010 at 10:12 PM, Niklas Gustavsson
 wrote:
> [X] +1, release FtpServer 1.0.5

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-09-28 Thread Sai Pullabhotla
[ ] +1, release FtpServer 1.0.5


Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-09-27 Thread Emmanuel Lecharny



[X] +1, release FtpServer 1.0.5

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com



Re: [VOTE] Release Apache FtpServer 1.0.5, take 2

2010-09-27 Thread Jeff Genender
+1

Jeff

On Sep 27, 2010, at 1:12 PM, Niklas Gustavsson wrote:

> Hi
> 
> I've fixed the bug discovered by Sai and the license header reported
> by Emmanuel. New binaries at:
> 
> https://repository.apache.org/content/repositories/orgapachemina-016
> 
> These are based on the source here:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
> 
> The change log is here:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
> 
> Let's vote, again:
> [ ] +1, release FtpServer 1.0.5
> [ ] 0
> [ ] -1, don't release because...
> 
> /niklas



[VOTE] Release Apache FtpServer 1.0.5, take 2

2010-09-27 Thread Niklas Gustavsson
Hi

I've fixed the bug discovered by Sai and the license header reported
by Emmanuel. New binaries at:

https://repository.apache.org/content/repositories/orgapachemina-016

These are based on the source here:
https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/

The change log is here:
https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821

Let's vote, again:
[ ] +1, release FtpServer 1.0.5
[ ] 0
[ ] -1, don't release because...

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Niklas Gustavsson
On Sun, Sep 26, 2010 at 9:56 PM, Niklas Gustavsson  wrote:
> We've fixed quite a few bugs in FtpServer and I think we're ready for
> a new release. I've uploaded binaries at:
> https://repository.apache.org/content/repositories/orgapachemina-015/

I'm canceling this vote and will re-open a new vote thread in a few minutes.

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Niklas Gustavsson
On Mon, Sep 27, 2010 at 5:19 PM, Emmanuel Lecharny  wrote:
> Wanna fix the ASL 2.0 issue at the same time ?

Yes, I will include that as well.

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Emmanuel Lecharny

 On 9/27/10 5:11 PM, Niklas Gustavsson wrote:

On Mon, Sep 27, 2010 at 2:36 PM, Sai Pullabhotla
  wrote:

Not sure if I'm doing something wrong, but I downloaded
https://repository.apache.org/content/repositories/orgapachemina-015/org/apache/ftpserver/ftpserver/1.0.5/ftpserver-1.0.5.zip,
and extracted it, and ran the ftpd.bat. I get the following error:

C:\dev\servers\apache-ftpserver-1.0.5\bin>ftpd.bat
Using default configuration
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/ftpserver/
ipfilter/IpFilter

Oh, thanks for noticing. The OSGi package export configuration was not
correctly updated on the 1.0.x branch. Now fixed. I'll deploy a new
release later tonight.

Wanna fix the ASL 2.0 issue at the same time ?

--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com



Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Niklas Gustavsson
On Mon, Sep 27, 2010 at 2:36 PM, Sai Pullabhotla
 wrote:
> Not sure if I'm doing something wrong, but I downloaded
> https://repository.apache.org/content/repositories/orgapachemina-015/org/apache/ftpserver/ftpserver/1.0.5/ftpserver-1.0.5.zip,
> and extracted it, and ran the ftpd.bat. I get the following error:
>
> C:\dev\servers\apache-ftpserver-1.0.5\bin>ftpd.bat
> Using default configuration
> Exception in thread "main" java.lang.NoClassDefFoundError: 
> org/apache/ftpserver/
> ipfilter/IpFilter

Oh, thanks for noticing. The OSGi package export configuration was not
correctly updated on the 1.0.x branch. Now fixed. I'll deploy a new
release later tonight.

/niklas


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Sai Pullabhotla
Not sure if I'm doing something wrong, but I downloaded
https://repository.apache.org/content/repositories/orgapachemina-015/org/apache/ftpserver/ftpserver/1.0.5/ftpserver-1.0.5.zip,
and extracted it, and ran the ftpd.bat. I get the following error:

C:\dev\servers\apache-ftpserver-1.0.5\bin>ftpd.bat
Using default configuration
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/ftpserver/
ipfilter/IpFilter
at org.apache.ftpserver.listener.ListenerFactory.createListener(Listener
Factory.java:109)
at org.apache.ftpserver.impl.DefaultFtpServerContext.(DefaultFtpSe
rverContext.java:100)
at org.apache.ftpserver.FtpServerFactory.(FtpServerFactory.java:51
)
at org.apache.ftpserver.main.CommandLine.getConfiguration(CommandLine.ja
va:115)
at org.apache.ftpserver.main.CommandLine.main(CommandLine.java:56)

Please advise.

Regards,
Sai Pullabhotla

On Sun, Sep 26, 2010 at 2:56 PM, Niklas Gustavsson  wrote:
> Hi
>
> We've fixed quite a few bugs in FtpServer and I think we're ready for
> a new release. I've uploaded binaries at:
> https://repository.apache.org/content/repositories/orgapachemina-015/
>
> These are based on the source here:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
>
> The change log is here:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
>
> Let's vote:
> [ ] +1, release FtpServer 1.0.5
> [ ] 0
> [ ] -1, don't release because...
>
> /niklas
>


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-27 Thread Sergey Vladimirov
+1

--
Best regards,
Sergey

On Mon, Sep 27, 2010 at 12:29 AM, Emmanuel Lecharny wrote:

>  On 9/26/10 9:56 PM, Niklas Gustavsson wrote:
>
>> Hi
>>
>> We've fixed quite a few bugs in FtpServer and I think we're ready for
>> a new release. I've uploaded binaries at:
>> https://repository.apache.org/content/repositories/orgapachemina-015/
>>
>> These are based on the source here:
>> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
>>
>> The change log is here:
>> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
>>
>> Let's vote:
>> [ ] +1, release FtpServer 1.0.5
>> [ ] 0
>> [ ] -1, don't release because...
>>
>
> +1
>
> There is one file (core/src/main/java/org/apache/ftpserver/util/OS.java)
> which has an old ASL license header, but I don't think that is a problem.
>
> --
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>
>


-- 
Sergey Vladimirov


Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-26 Thread Emmanuel Lecharny

 On 9/26/10 9:56 PM, Niklas Gustavsson wrote:

Hi

We've fixed quite a few bugs in FtpServer and I think we're ready for
a new release. I've uploaded binaries at:
https://repository.apache.org/content/repositories/orgapachemina-015/

These are based on the source here:
https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/

The change log is here:
https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821

Let's vote:
[ ] +1, release FtpServer 1.0.5
[ ] 0
[ ] -1, don't release because...


+1

There is one file (core/src/main/java/org/apache/ftpserver/util/OS.java) 
which has an old ASL license header, but I don't think that is a problem.


--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com



Re: [VOTE] Release Apache FtpServer 1.0.5

2010-09-26 Thread Jeff Genender
+1

Jeff
Sent from my iPhone

On Sep 26, 2010, at 1:56 PM, Niklas Gustavsson  wrote:

> Hi
>
> We've fixed quite a few bugs in FtpServer and I think we're ready for
> a new release. I've uploaded binaries at:
> https://repository.apache.org/content/repositories/orgapachemina-015/
>
> These are based on the source here:
> https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/
>
> The change log is here:
> https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821
>
> Let's vote:
> [ ] +1, release FtpServer 1.0.5
> [ ] 0
> [ ] -1, don't release because...
>
> /niklas


[VOTE] Release Apache FtpServer 1.0.5

2010-09-26 Thread Niklas Gustavsson
Hi

We've fixed quite a few bugs in FtpServer and I think we're ready for
a new release. I've uploaded binaries at:
https://repository.apache.org/content/repositories/orgapachemina-015/

These are based on the source here:
https://svn.apache.org/repos/asf/mina/ftpserver/branches/1.0.5/

The change log is here:
https://issues.apache.org/jira/browse/FTPSERVER/fixforversion/12314821

Let's vote:
[ ] +1, release FtpServer 1.0.5
[ ] 0
[ ] -1, don't release because...

/niklas