[jira] Updated: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

2010-12-15 Thread Torsten Mielke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke updated SSHD-102:


Attachment: JaasPasswordAuthenticator.patch

Proposed patch added.

 Add error logging to 
 org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
 -

 Key: SSHD-102
 URL: https://issues.apache.org/jira/browse/SSHD-102
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 0.4.0, 0.5.0
 Environment: sshd JAAS used with LDAP based authentication.
Reporter: Torsten Mielke
 Attachments: JaasPasswordAuthenticator.patch


 The JaasPasswordAuthenticator.authenticate() method currently silently 
 ignores any exceptions being raised and simply returns false in case of any 
 authentication erorrs. 
 In environments where sshd is used in other frameworks like OSGi, it becomes 
 very difficult to trouble shoot the reasons for the authentication failure. 
 Rather than simply returning false, I propose to print a logging statement at 
 the least.
 catch (Exception e) {
 log.error(Authentication failed with  + 
   e.getMessage() + 
   , cause:  + 
   e.getCause() );
 return false;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

2010-12-15 Thread Torsten Mielke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke updated SSHD-102:


Description: 
The JaasPasswordAuthenticator.authenticate() method currently silently ignores 
any exceptions being raised and simply returns false in case of any 
authentication erorrs. 
In environments where sshd is used in other frameworks like OSGi, it becomes 
very difficult to trouble shoot the reasons for the authentication failure. 
Rather than simply returning false, I propose to print a logging statement at 
the least.

catch (Exception e) {
log.error(Authentication failed with  + 
  e.getMessage() + 
  , cause:  + 
  e.getCause() );
return false;
}



  was:
The JaasPasswordAuthenticator.authenticate() method currently silently ignores 
any exceptions being raised and simply returns false in case of any 
authentication erorrs. 
In environments where sshd is used in other frameworks like OSGi, it becomes 
very difficult to trouble shoot the reasons for the authentication failure. 
Rather than simply returning false, I propose to print a logging statement at 
the least.

catch (Exception e) {
log.error(Authentication failed with  + 
  e.getMessage() + 
  cause:  + 
  e.getCause() );
return false;
}




 Add error logging to 
 org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
 -

 Key: SSHD-102
 URL: https://issues.apache.org/jira/browse/SSHD-102
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 0.4.0, 0.5.0
 Environment: sshd JAAS used with LDAP based authentication.
Reporter: Torsten Mielke
 Attachments: JaasPasswordAuthenticator.patch


 The JaasPasswordAuthenticator.authenticate() method currently silently 
 ignores any exceptions being raised and simply returns false in case of any 
 authentication erorrs. 
 In environments where sshd is used in other frameworks like OSGi, it becomes 
 very difficult to trouble shoot the reasons for the authentication failure. 
 Rather than simply returning false, I propose to print a logging statement at 
 the least.
 catch (Exception e) {
 log.error(Authentication failed with  + 
   e.getMessage() + 
   , cause:  + 
   e.getCause() );
 return false;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

2010-12-15 Thread Torsten Mielke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke updated SSHD-102:


Description: 
The JaasPasswordAuthenticator.authenticate() method currently silently ignores 
any exceptions being raised and simply returns false in case of any 
authentication erorrs. 
In environments where sshd is used in other frameworks like OSGi, it becomes 
very difficult to trouble shoot the reasons for the authentication failure. 
Rather than simply returning false, I propose to print a logging statement at 
the least.

catch (Exception e) {
log.error(Authentication failed with error:  + 
  e.getMessage() + 
  , cause:  + 
  e.getCause() );
return false;
}



  was:
The JaasPasswordAuthenticator.authenticate() method currently silently ignores 
any exceptions being raised and simply returns false in case of any 
authentication erorrs. 
In environments where sshd is used in other frameworks like OSGi, it becomes 
very difficult to trouble shoot the reasons for the authentication failure. 
Rather than simply returning false, I propose to print a logging statement at 
the least.

catch (Exception e) {
log.error(Authentication failed with  + 
  e.getMessage() + 
  , cause:  + 
  e.getCause() );
return false;
}




 Add error logging to 
 org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
 -

 Key: SSHD-102
 URL: https://issues.apache.org/jira/browse/SSHD-102
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 0.4.0, 0.5.0
 Environment: sshd JAAS used with LDAP based authentication.
Reporter: Torsten Mielke
 Attachments: JaasPasswordAuthenticator.patch


 The JaasPasswordAuthenticator.authenticate() method currently silently 
 ignores any exceptions being raised and simply returns false in case of any 
 authentication erorrs. 
 In environments where sshd is used in other frameworks like OSGi, it becomes 
 very difficult to trouble shoot the reasons for the authentication failure. 
 Rather than simply returning false, I propose to print a logging statement at 
 the least.
 catch (Exception e) {
 log.error(Authentication failed with error:  + 
   e.getMessage() + 
   , cause:  + 
   e.getCause() );
 return false;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

2010-12-15 Thread Torsten Mielke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke updated SSHD-102:


Attachment: (was: JaasPasswordAuthenticator.patch)

 Add error logging to 
 org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
 -

 Key: SSHD-102
 URL: https://issues.apache.org/jira/browse/SSHD-102
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 0.4.0, 0.5.0
 Environment: sshd JAAS used with LDAP based authentication.
Reporter: Torsten Mielke
 Attachments: JaasPasswordAuthenticator.patch


 The JaasPasswordAuthenticator.authenticate() method currently silently 
 ignores any exceptions being raised and simply returns false in case of any 
 authentication erorrs. 
 In environments where sshd is used in other frameworks like OSGi, it becomes 
 very difficult to trouble shoot the reasons for the authentication failure. 
 Rather than simply returning false, I propose to print a logging statement at 
 the least.
 catch (Exception e) {
 log.error(Authentication failed with error:  + 
   e.getMessage() + 
   , cause:  + 
   e.getCause() );
 return false;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Updated: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

2010-12-15 Thread Torsten Mielke (JIRA)

 [ 
https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Torsten Mielke updated SSHD-102:


Attachment: JaasPasswordAuthenticator.patch

 Add error logging to 
 org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
 -

 Key: SSHD-102
 URL: https://issues.apache.org/jira/browse/SSHD-102
 Project: MINA SSHD
  Issue Type: Improvement
Affects Versions: 0.4.0, 0.5.0
 Environment: sshd JAAS used with LDAP based authentication.
Reporter: Torsten Mielke
 Attachments: JaasPasswordAuthenticator.patch


 The JaasPasswordAuthenticator.authenticate() method currently silently 
 ignores any exceptions being raised and simply returns false in case of any 
 authentication erorrs. 
 In environments where sshd is used in other frameworks like OSGi, it becomes 
 very difficult to trouble shoot the reasons for the authentication failure. 
 Rather than simply returning false, I propose to print a logging statement at 
 the least.
 catch (Exception e) {
 log.error(Authentication failed with error:  + 
   e.getMessage() + 
   , cause:  + 
   e.getCause() );
 return false;
 }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.