RE: call for contributions to next MXNet release

2018-03-15 Thread Zhao, Patric
MKL issues summary:

Feel free to let me know if anything I missed.

Totally, there’re 11 open issues  in the github with the label of MKL as below:
 4 Bugs issues: #10092, #10086,  #10026, #8881
 4 Building issues: #9993, #9828, #8974, #8532
 1 Flaky Tests: #9864
 2 wrong label and invalidated:  #9844, #8874

Current status. 
3 DONE, to be closed. 
4 WIP (working in progress)
2 TODO
2 are invalidated now.

Details: 
#10092, WIP, PR#10021 
#10086, TODO
#10026, WIP
#9993, DONE (need to be closed), fixed by #10075
#9864, TODO 
#9844, INVALIDED, not related w/ MKL
#9828, DONE (need to be closed), fixed by #9918 & #10115
#8974, WIP
#8881, DONE (need to be closed), fixed by #9112
#8874, INVALIDED, “I believe, we are not using MKL”
#8532, WIP, library conflict and can be resolved by environment setting

Lists:
No "full" pooling convention support with MKL-DNN Feature request MKL Operator
#10092 opened 2 days ago by marcoabreu 
https://github.com/apache/incubator-mxnet/issues/10092
 
[MXNET-84] Segfault test_autograd.test_unary_func @ Python3: MKLDNN-CPU Bug MKL 
Test
#10086 opened 3 days ago by marcoabreu 
https://github.com/apache/incubator-mxnet/issues/10086

MXNET_MKLDNN_DEBUG=1 produces errors Bug MKL
#10026 opened 8 days ago by marcoabreu 
https://github.com/apache/incubator-mxnet/issues/10026
 
cmake cannot build mxnet Bug Build MKL
#9993 opened 11 days ago by jacky4323 
https://github.com/apache/incubator-mxnet/issues/9993
 
Flaky hanging test_operator.test_laop_3 @ Python3: MKLDNN-CPU Flaky MKL Test
#9864 opened 21 days ago by marcoabreu 
https://github.com/apache/incubator-mxnet/issues/9864

Flaky test_operator_gpu.test_binary_op @ Python3: MKLDNN-GPU Flaky MKL Test
#9844 opened 23 days ago by marcoabreu 
https://github.com/apache/incubator-mxnet/issues/9844

Building with MKL fails on OSX Build MKL
#9828 opened 25 days ago by sbodenstein 
https://github.com/apache/incubator-mxnet/issues/9828

MXNET compatibility with MKL libraries bundled in Microsoft R Open MKL
#8974 opened on Dec 7, 2017 by mjmg 
https://github.com/apache/incubator-mxnet/issues/8974

Intel MKL FATAL ERROR: Cannot load libmkl_avx512_mic.so or libmkl_def.so. Bug 
Data-loading MKL
#8881 opened on Nov 30, 2017 by wuzhijiexia 
https://github.com/apache/incubator-mxnet/issues/8881

mxnet installation from source: C++ linkage error on HPC C++ Installation MKL
#8874 opened on Nov 30, 2017 by jerrin92 
https://github.com/apache/incubator-mxnet/issues/8874

mxnet-mkl (v0.12.0) crash when using (conda-installed) numpy with MKL Bug MKL
#8532 opened on Nov 3, 2017 by fhieber
https://github.com/apache/incubator-mxnet/issues/8532


> -Original Message-
> From: Zheng, Da [mailto:dzz...@amazon.com]
> Sent: Tuesday, March 13, 2018 2:06 AM
> To: Zhao, Patric ; steffenroc...@gmail.com;
> dev@mxnet.incubator.apache.org
> Cc: marco.g.ab...@googlemail.com; Ye, Jason Y 
> Subject: Re: call for contributions to next MXNet release
> 
> Patric, thanks for summarizing open issues.
> 
> Since I'm in the Palo Alto office, maybe we don't need to wait until Apr 24th?
> 
> Best,
> Da
> 
> On 3/11/18, 6:43 AM, "Zhao, Patric"  wrote:
> 
> >- should we talk about the package at the Apr 24th meetup in Seattle?
> We're based in Shanghai, China; so maybe @Da Zheng?



RE: MKLDNN Build (pre: call for contributions to next MXNet release)

2018-03-15 Thread Zhao, Patric
+source data to read clearly.

> -Original Message-
> From: Zhao, Patric [mailto:patric.z...@intel.com]
> Sent: Friday, March 16, 2018 8:29 AM
> To: 'dev@mxnet.incubator.apache.org' 
> Cc: Huang, Jin1 ; Da Zheng 
> Subject: RE: MKLDNN Build (pre: call for contributions to next MXNet release)
> 
> Hi Pedro,
> 
> 
> 
> We and Zheng Da tested the performance on Mac laptop (Intel i7 CPU) as
> below table.
> 
> The test script is example/image-classification/benchmark_score.py.
> 
> 
> 
> MKLDNN shows better performance in MAC too.
> 
> 
> topo
> 
> batch size
> 
> gcc7 MKLDNN=1
> 
> gcc7 MKLDNN=0
> 
> speedup
> 
> alexnet
> 
>  1
> 
> 38.44
> 
> 24.49
> 
> 157%
> 
>  2
> 
> 50.18
> 
> 29.62
> 
> 169%
> 
>  4
> 
> 59.54
> 
> 35.40
> 
> 168%
> 
>  8
> 
> 70.75
> 
> 32.49
> 
> 218%
> 
> 16
> 
> 73.40
> 
> 34.93
> 
> 210%
> 
> 32
> 
> 47.52
> 
> 37.19
> 
> 128%
> 
> vgg16
> 
>  1
> 
> 3.80
> 
> 2.13
> 
> 178%
> 
>  2
> 
> 3.52
> 
> 2.93
> 
> 120%
> 
>  4
> 
> 4.54
> 
> 3.01
> 
> 151%
> 
>  8
> 
> 5.12
> 
> 3.05
> 
> 168%
> 
> 16
> 
> 5.37
> 
> 3.12
> 
> 172%
> 
> 32
> 
> 5.36
> 
> 3.07
> 
> 175%
> 
> inception-bn
> 
>  1
> 
> 15.02
> 
> 14.04
> 
> 107%
> 
>  2
> 
> 25.32
> 
> 15.14
> 
> 167%
> 
>  4
> 
> 34.92
> 
> 14.97
> 
> 233%
> 
>  8
> 
> 27.96
> 
> 15.02
> 
> 186%
> 
> 16
> 
> 27.05
> 
> 15.10
> 
> 179%
> 
> 32
> 
> 32.29
> 
> 15.46
> 
> 209%
> 
> inception v3
> 
>  1
> 
> 10.03
> 
> 5.89
> 
> 170%
> 
>  2
> 
> 11.21
> 
> 5.99
> 
> 187%
> 
>  4
> 
> 13.04
> 
> 5.89
> 
> 221%
> 
>  8
> 
> 12.97
> 
> 6.01
> 
> 216%
> 
> 16
> 
> 12.55
> 
> 5.13
> 
> 245%
> 
> 32
> 
> 12.52
> 
> 5.65
> 
> 222%
> 
> resnet-50
> 
>  1
> 
> 15.53
> 
> 7.07
> 
> 220%
> 
>  2
> 
> 14.85
> 
> 7.06
> 
> 210%
> 
>  4
> 
> 17.08
> 
> 7.88
> 
> 217%
> 
>  8
> 
> 16.91
> 
> 8.97
> 
> 189%
> 
> 16
> 
> 15.55
> 
> 9.42
> 
> 165%
> 
> 32
> 
> 16.60
> 
> 7.99
> 
> 208%
> 
> resnet-152
> 
>  1
> 
> 5.90
> 
> 3.55
> 
> 166%
> 
>  2
> 
> 5.64
> 
> 3.23
> 
> 175%
> 
>  4
> 
> 6.11
> 
> 3.08
> 
> 198%
> 
>  8
> 
> 5.22
> 
> 3.58
> 
> 146%
> 
> 16
> 
> 5.28
> 
> 3.86
> 
> 137%
> 
> 32
> 
> 6.20
> 
> 3.72
> 
> 167%
> 
> 
> 
> 
> 
> 
> > -Original Message-
> 
> > From: Zhao, Patric
> 
> > Sent: Wednesday, March 14, 2018 9:33 PM
> 
> > To: dev@mxnet.incubator.apache.org
> 
> > Cc: Huang, Jin1 
> 
> > Subject: MKLDNN Build (pre: call for contributions to next MXNet release)
> 
> >
> 
> > Hi Pedro,
> 
> >
> 
> > Thanks for the good suggestions. I plan to update the install page but a 
> > slight
> 
> > delay by other things.
> 
> >
> 
> > Actually, I didn't test the performance on OSX since we're lack of Mac
> machine.
> 
> >
> 
> > I will try if I can get a Mac in the office.
> 
> >
> 
> > Thanks,
> 
> >
> 
> > --Patric
> 
> >
> 
> >
> 
> > > -Original Message-
> 
> > > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]
> 
> > > Sent: Wednesday, March 14, 2018 9:09 PM
> 
> > > To: dev@mxnet.incubator.apache.org
> 
> > > Subject: Re: call for contributions to next MXNet release
> 
> > >
> 
> > > Hi Patric
> 
> > >
> 
> > > Does it make sense to add instructions to link against mkl in the install 
> > > docs?
> 
> > >
> 
> > > For example in OSX you can use MKL by downloading
> 
> > > https://github.com/intel/mkl-dnn/releases and adding MKL_RT_LIBRARY
> 
> > > and MKL_INCLUDE_DIR plus  -DUSE_MKL_IF_AVAILABLE=ON -
> 
> > > DUSE_MKLML_MKL=ON -DUSE_MKLDNN=ON
> 
> > >
> 
> > > This is not documented in the website.
> 
> > >
> 
> > > What's the performance increase of using MKL in osx when running in
> 
> > > CPU mode?
> 
> > >
> 
> > > Pedro
> 
> > >
> 
> > > On Wed, Mar 14, 2018 at 1:54 PM, Zhao, Patric 
> 
> > > wrote:
> 
> > >
> 
> > > > My fault, typo for your name, Larroy  :(
> 
> > > >
> 
> > > > > -Original Message-
> 
> > > > > From: Zhao, Patric [mailto:patric.z...@intel.com]
> 
> > > > > Sent: Wednesday, March 14, 2018 8:40 PM
> 
> > > > > To: dev@mxnet.incubator.apache.org; Huang, Jin1
> 
> > > > > 
> 
> > > > > Subject: RE: call for contributions to next MXNet release
> 
> > > > >
> 
> > > > > Thanks, Larryo.
> 
> > > > >
> 
> > > > > This is a PR to fix this issue,
> 
> > > > > https://github.com/apache/incubator-
> 
> > > > > mxnet/pull/10075
> 
> > > > > The issue will be gone after this PR is merged.
> 
> > > > >
> 
> > > > > For the whole logic, we are investigating now and maybe propose a
> 
> > > > > new approach for Makefile and CMake.
> 
> > > > >
> 
> > > > > > -Original Message-
> 
> > > > > > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]
> 
> > > > > > Sent: Wednesday, March 14, 2018 8:31 PM
> 
> > > > > > To: dev@mxnet.incubator.apache.org
> 
> > > > > > Subject: Re: call for contributions to next MXNet release
> 
> > > > > >
> 
> > > > > > Hi
> 
> > > > > >
> 
> > > > > > Can you please fix the build logic?
> 
> > > > > > https://github.com/apache/incubator-
> 
> > > > > > mxnet/blob/master/CMakeLists.txt#L158
> 
> > > > > >
> 
> > > > > > https://github.com/apache/incubator-mx

Re: call for contributions to next MXNet release

2018-03-15 Thread Steffen Rochel
Hi Anirudh - just to clarify - April 9th as target to create 1st release
candidate to start voting process. Suggest to focus between feature freeze
on March 30th and 1st release candidate on April 9th  to address the long
list of known bugs - https://github.com/apache/incubator-mxnet/labels/Bug

Regards,
Steffen

On Thu, Mar 15, 2018 at 5:24 PM Anirudh  wrote:

> Hi all,
>
> Chris and I will be working on the 1.2.0 release. If you haven't already,
> please let me know if you have any new features that you are working on and
> would like
> to be included in the release.
>
>  Project+Proposals+for+next+MXNet+Release>
>
> The plan is to do the code freeze by March 30th with target release date
> of April 9th.
>
> Feel free to add any other comments/suggestions.
>
>
> Anirudh
>
>
> On Wed, Mar 14, 2018 at 6:09 AM, Pedro Larroy <
> pedro.larroy.li...@gmail.com>
> wrote:
>
> > Hi Patric
> >
> > Does it make sense to add instructions to link against mkl in the install
> > docs?
> >
> > For example in OSX you can use MKL by downloading
> > https://github.com/intel/mkl-dnn/releases and adding MKL_RT_LIBRARY and
> > MKL_INCLUDE_DIR plus  -DUSE_MKL_IF_AVAILABLE=ON -DUSE_MKLML_MKL=ON
> > -DUSE_MKLDNN=ON
> >
> > This is not documented in the website.
> >
> > What's the performance increase of using MKL in osx when running in CPU
> > mode?
> >
> > Pedro
> >
> > On Wed, Mar 14, 2018 at 1:54 PM, Zhao, Patric 
> > wrote:
> >
> > > My fault, typo for your name, Larroy  :(
> > >
> > > > -Original Message-
> > > > From: Zhao, Patric [mailto:patric.z...@intel.com]
> > > > Sent: Wednesday, March 14, 2018 8:40 PM
> > > > To: dev@mxnet.incubator.apache.org; Huang, Jin1 <
> jin1.hu...@intel.com>
> > > > Subject: RE: call for contributions to next MXNet release
> > > >
> > > > Thanks, Larryo.
> > > >
> > > > This is a PR to fix this issue, https://github.com/apache/incubator-
> > > > mxnet/pull/10075
> > > > The issue will be gone after this PR is merged.
> > > >
> > > > For the whole logic, we are investigating now and maybe propose a new
> > > > approach for Makefile and CMake.
> > > >
> > > > > -Original Message-
> > > > > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]
> > > > > Sent: Wednesday, March 14, 2018 8:31 PM
> > > > > To: dev@mxnet.incubator.apache.org
> > > > > Subject: Re: call for contributions to next MXNet release
> > > > >
> > > > > Hi
> > > > >
> > > > > Can you please fix the build logic?
> > > > > https://github.com/apache/incubator-
> > > > > mxnet/blob/master/CMakeLists.txt#L158
> > > > >
> > > > > https://github.com/apache/incubator-mxnet/issues/10072
> > > > >
> > > > > It wrongly assumes that you have MKL installed, MKLDNN needs to
> check
> > > > > if MKL is available before, or be disabled by default, also in non
> > > intel
> > > > platforms.
> > > > >
> > > > > Pedro
> > > > >
> > > > > On Sun, Mar 11, 2018 at 2:43 PM, Zhao, Patric <
> patric.z...@intel.com
> > >
> > > > > wrote:
> > > > >
> > > > > > Steffen, really thanks for the helps and I totally agree with you
> > > > > > and Marco's suggestions.
> > > > > > I will summarize the open issues and status for the review soon.
> > > > > >
> > > > > > > What is your github handle?
> > > > > > Github ID:  Patric Zhao, https://github.com/pengzhao-intel/
>  Da
> > > Zheng,
> > > > > > https://github.com/zheng-da/
> > > > > >
> > > > > > > - do you have design docs we can link to? Does the doc cover
> > > > > > > packaging,
> > > > > > use
> > > > > > > of MXNet with full MKL (I understand there are license issues,
> > but
> > > > > > > we do
> > > > > > have
> > > > > > > users who are or plan to use MXNet with the complete MKL
> package,
> > > > > > > not
> > > > > > just
> > > > > > > DNN subset)?
> > > > > > Design doc:  https://cwiki.apache.org/
> > confluence/display/MXNET/The+
> > > > > > design+of+MKLDNN+integration
> > > > > > It's a good suggestion for the full MKL package and we will add
> the
> > > > > > related part in the doc.
> > > > > >
> > > > > > > - do you have performance measurements (or plan to measure) to
> > > > > > > include in release notes?
> > > > > > Yes, we have tested the performance on all C4/C5 instances
> > > > > > (8x,4x,2x,xlarge,large). And the accuracy are verified as well.
> > > > > > We plan to publish these data both in the release note and mxnet
> > > > > > website ( https://mxnet.incubator.apache.org/faq/perf.html).
> > > > > >
> > > > > > > - should we talk about the package at the Apr 24th meetup in
> > > Seattle?
> > > > > > We're based in Shanghai, China; so maybe @Da Zheng?
> > > > > >
> > > > > >
> > > > > > > -Original Message-
> > > > > > > From: Steffen Rochel [mailto:steffenroc...@gmail.com]
> > > > > > > Sent: Sunday, March 11, 2018 6:11 PM
> > > > > > > To: dev@mxnet.incubator.apache.org
> > > > > > > Cc: marco.g.ab...@googlemail.com
> > > > > > > Subject: Re: call for contributions to next MXNet release
> > > > > >

RE: MKLDNN Build (pre: call for contributions to next MXNet release)

2018-03-15 Thread Zhao, Patric
Hi Pedro,



We and Zheng Da tested the performance on Mac laptop (Intel i7 CPU) as below 
table.

The test script is example/image-classification/benchmark_score.py.



MKLDNN shows better performance in MAC too.


topo

batch size

gcc7 MKLDNN=1

gcc7 MKLDNN=0

speedup

alexnet

 1

38.44

24.49

157%

 2

50.18

29.62

169%

 4

59.54

35.40

168%

 8

70.75

32.49

218%

16

73.40

34.93

210%

32

47.52

37.19

128%

vgg16

 1

3.80

2.13

178%

 2

3.52

2.93

120%

 4

4.54

3.01

151%

 8

5.12

3.05

168%

16

5.37

3.12

172%

32

5.36

3.07

175%

inception-bn

 1

15.02

14.04

107%

 2

25.32

15.14

167%

 4

34.92

14.97

233%

 8

27.96

15.02

186%

16

27.05

15.10

179%

32

32.29

15.46

209%

inception v3

 1

10.03

5.89

170%

 2

11.21

5.99

187%

 4

13.04

5.89

221%

 8

12.97

6.01

216%

16

12.55

5.13

245%

32

12.52

5.65

222%

resnet-50

 1

15.53

7.07

220%

 2

14.85

7.06

210%

 4

17.08

7.88

217%

 8

16.91

8.97

189%

16

15.55

9.42

165%

32

16.60

7.99

208%

resnet-152

 1

5.90

3.55

166%

 2

5.64

3.23

175%

 4

6.11

3.08

198%

 8

5.22

3.58

146%

16

5.28

3.86

137%

32

6.20

3.72

167%






> -Original Message-

> From: Zhao, Patric

> Sent: Wednesday, March 14, 2018 9:33 PM

> To: dev@mxnet.incubator.apache.org

> Cc: Huang, Jin1 

> Subject: MKLDNN Build (pre: call for contributions to next MXNet release)

>

> Hi Pedro,

>

> Thanks for the good suggestions. I plan to update the install page but a 
> slight

> delay by other things.

>

> Actually, I didn't test the performance on OSX since we're lack of Mac 
> machine.

>

> I will try if I can get a Mac in the office.

>

> Thanks,

>

> --Patric

>

>

> > -Original Message-

> > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]

> > Sent: Wednesday, March 14, 2018 9:09 PM

> > To: dev@mxnet.incubator.apache.org

> > Subject: Re: call for contributions to next MXNet release

> >

> > Hi Patric

> >

> > Does it make sense to add instructions to link against mkl in the install 
> > docs?

> >

> > For example in OSX you can use MKL by downloading

> > https://github.com/intel/mkl-dnn/releases and adding MKL_RT_LIBRARY

> > and MKL_INCLUDE_DIR plus  -DUSE_MKL_IF_AVAILABLE=ON -

> > DUSE_MKLML_MKL=ON -DUSE_MKLDNN=ON

> >

> > This is not documented in the website.

> >

> > What's the performance increase of using MKL in osx when running in

> > CPU mode?

> >

> > Pedro

> >

> > On Wed, Mar 14, 2018 at 1:54 PM, Zhao, Patric 

> > wrote:

> >

> > > My fault, typo for your name, Larroy  :(

> > >

> > > > -Original Message-

> > > > From: Zhao, Patric [mailto:patric.z...@intel.com]

> > > > Sent: Wednesday, March 14, 2018 8:40 PM

> > > > To: dev@mxnet.incubator.apache.org; Huang, Jin1

> > > > 

> > > > Subject: RE: call for contributions to next MXNet release

> > > >

> > > > Thanks, Larryo.

> > > >

> > > > This is a PR to fix this issue,

> > > > https://github.com/apache/incubator-

> > > > mxnet/pull/10075

> > > > The issue will be gone after this PR is merged.

> > > >

> > > > For the whole logic, we are investigating now and maybe propose a

> > > > new approach for Makefile and CMake.

> > > >

> > > > > -Original Message-

> > > > > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]

> > > > > Sent: Wednesday, March 14, 2018 8:31 PM

> > > > > To: dev@mxnet.incubator.apache.org

> > > > > Subject: Re: call for contributions to next MXNet release

> > > > >

> > > > > Hi

> > > > >

> > > > > Can you please fix the build logic?

> > > > > https://github.com/apache/incubator-

> > > > > mxnet/blob/master/CMakeLists.txt#L158

> > > > >

> > > > > https://github.com/apache/incubator-mxnet/issues/10072

> > > > >

> > > > > It wrongly assumes that you have MKL installed, MKLDNN needs to

> > > > > check if MKL is available before, or be disabled by default,

> > > > > also in non

> > > intel

> > > > platforms.

> > > > >

> > > > > Pedro

> > > > >

> > > > > On Sun, Mar 11, 2018 at 2:43 PM, Zhao, Patric

> > > > > 

> > > > > wrote:

> > > > >

> > > > > > Steffen, really thanks for the helps and I totally agree with

> > > > > > you and Marco's suggestions.

> > > > > > I will summarize the open issues and status for the review soon.

> > > > > >

> > > > > > > What is your github handle?

> > > > > > Github ID:  Patric Zhao, https://github.com/pengzhao-intel/ Da

> > > Zheng,

> > > > > > https://github.com/zheng-da/

> > > > > >

> > > > > > > - do you have design docs we can link to? Does the doc cover

> > > > > > > packaging,

> > > > > > use

> > > > > > > of MXNet with full MKL (I understand there are license

> > > > > > > issues, but we do

> > > > > > have

> > > > > > > users who are or plan to use MXNet with the complete MKL

> > > > > > > package, not

> > > > > > just

> > > > > > > DNN subset)?

> > > > > > Design doc:

> > > > > > https://cwiki.apache.org/confluence/display/MXNET/The+

> > > > > > design+of+MKLD

Re: call for contributions to next MXNet release

2018-03-15 Thread Anirudh
Hi all,

Chris and I will be working on the 1.2.0 release. If you haven't already,
please let me know if you have any new features that you are working on and
would like
to be included in the release.



The plan is to do the code freeze by March 30th with target release date
of April 9th.

Feel free to add any other comments/suggestions.


Anirudh


On Wed, Mar 14, 2018 at 6:09 AM, Pedro Larroy 
wrote:

> Hi Patric
>
> Does it make sense to add instructions to link against mkl in the install
> docs?
>
> For example in OSX you can use MKL by downloading
> https://github.com/intel/mkl-dnn/releases and adding MKL_RT_LIBRARY and
> MKL_INCLUDE_DIR plus  -DUSE_MKL_IF_AVAILABLE=ON -DUSE_MKLML_MKL=ON
> -DUSE_MKLDNN=ON
>
> This is not documented in the website.
>
> What's the performance increase of using MKL in osx when running in CPU
> mode?
>
> Pedro
>
> On Wed, Mar 14, 2018 at 1:54 PM, Zhao, Patric 
> wrote:
>
> > My fault, typo for your name, Larroy  :(
> >
> > > -Original Message-
> > > From: Zhao, Patric [mailto:patric.z...@intel.com]
> > > Sent: Wednesday, March 14, 2018 8:40 PM
> > > To: dev@mxnet.incubator.apache.org; Huang, Jin1 
> > > Subject: RE: call for contributions to next MXNet release
> > >
> > > Thanks, Larryo.
> > >
> > > This is a PR to fix this issue, https://github.com/apache/incubator-
> > > mxnet/pull/10075
> > > The issue will be gone after this PR is merged.
> > >
> > > For the whole logic, we are investigating now and maybe propose a new
> > > approach for Makefile and CMake.
> > >
> > > > -Original Message-
> > > > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com]
> > > > Sent: Wednesday, March 14, 2018 8:31 PM
> > > > To: dev@mxnet.incubator.apache.org
> > > > Subject: Re: call for contributions to next MXNet release
> > > >
> > > > Hi
> > > >
> > > > Can you please fix the build logic?
> > > > https://github.com/apache/incubator-
> > > > mxnet/blob/master/CMakeLists.txt#L158
> > > >
> > > > https://github.com/apache/incubator-mxnet/issues/10072
> > > >
> > > > It wrongly assumes that you have MKL installed, MKLDNN needs to check
> > > > if MKL is available before, or be disabled by default, also in non
> > intel
> > > platforms.
> > > >
> > > > Pedro
> > > >
> > > > On Sun, Mar 11, 2018 at 2:43 PM, Zhao, Patric  >
> > > > wrote:
> > > >
> > > > > Steffen, really thanks for the helps and I totally agree with you
> > > > > and Marco's suggestions.
> > > > > I will summarize the open issues and status for the review soon.
> > > > >
> > > > > > What is your github handle?
> > > > > Github ID:  Patric Zhao, https://github.com/pengzhao-intel/ Da
> > Zheng,
> > > > > https://github.com/zheng-da/
> > > > >
> > > > > > - do you have design docs we can link to? Does the doc cover
> > > > > > packaging,
> > > > > use
> > > > > > of MXNet with full MKL (I understand there are license issues,
> but
> > > > > > we do
> > > > > have
> > > > > > users who are or plan to use MXNet with the complete MKL package,
> > > > > > not
> > > > > just
> > > > > > DNN subset)?
> > > > > Design doc:  https://cwiki.apache.org/
> confluence/display/MXNET/The+
> > > > > design+of+MKLDNN+integration
> > > > > It's a good suggestion for the full MKL package and we will add the
> > > > > related part in the doc.
> > > > >
> > > > > > - do you have performance measurements (or plan to measure) to
> > > > > > include in release notes?
> > > > > Yes, we have tested the performance on all C4/C5 instances
> > > > > (8x,4x,2x,xlarge,large). And the accuracy are verified as well.
> > > > > We plan to publish these data both in the release note and mxnet
> > > > > website ( https://mxnet.incubator.apache.org/faq/perf.html).
> > > > >
> > > > > > - should we talk about the package at the Apr 24th meetup in
> > Seattle?
> > > > > We're based in Shanghai, China; so maybe @Da Zheng?
> > > > >
> > > > >
> > > > > > -Original Message-
> > > > > > From: Steffen Rochel [mailto:steffenroc...@gmail.com]
> > > > > > Sent: Sunday, March 11, 2018 6:11 PM
> > > > > > To: dev@mxnet.incubator.apache.org
> > > > > > Cc: marco.g.ab...@googlemail.com
> > > > > > Subject: Re: call for contributions to next MXNet release
> > > > > >
> > > > > > Patric - added MKL-DNN to the project list. What is your github
> > handle?
> > > > > > I do agree with Marco that we need to resolve disable tests,
> > > > > > broken
> > > > > features
> > > > > > etc. Jira looks like the right answer to create a list of known
> > issues.
> > > > > > Questions I do have:
> > > > > > - do you have design docs we can link to? Does the doc cover
> > > > > > packaging,
> > > > > use
> > > > > > of MXNet with full MKL (I understand there are license issues,
> but
> > > > > > we do
> > > > > have
> > > > > > users who are or plan to use MXNet with the complete MKL package,
> > > > > > not
> > > > > just
> > > > > > DNN subset)?
> > > > > > - do you h

Re: MXNet C++ package improvements

2018-03-15 Thread Anton Chernov
 I've improved the document based on recent comments, please have another
look. What has been changed so far:

* Fixed unclear formulations
* Added details about the current state of the library and why is it
complicated to use
* Improved the explanation of the piml idiom and provided a code example
* Added thread safety requirements

Thanks @chris and @naveen for your reviewing efforts!


2018-03-14 21:44 GMT+01:00 Anton Chernov :

> Sure, here we go:
> https://docs.google.com/document/d/1Xi0aU9Nks7-
> GcsJIfcXoEpgPeYnSiEtBpJlhZvMaIb8/edit?usp=sharing
>
>
> 2018-03-14 19:15 GMT+01:00 Chris Olivier :
>
>> Can you put that on google docs so that it can be commented/edited?
>>
>> On Wed, Mar 14, 2018 at 11:07 AM, Anton Chernov 
>> wrote:
>>
>> > Dear MxNet Community,
>> >
>> > please find here
>> > > pageId=75976112>
>> > the
>> > design document for the proposed MXNet C++ package improvements for
>> review
>> > and consideration.
>> >
>> > Feedback is welcome and highly appreciated. Thank you!
>> >
>> > BR
>> > Anton
>> >
>>
>
>