Re: There is a bug in shape inference of the where operator

[Zheng, Da]

Correct.

Da

On 8/23/18, 9:58 PM, "Sheng Zha"  wrote:

Correct me if I'm wrong. The bug went into the release branch so we need to
cherry-pick the fix once the patch is merged to master.

-sz

On Thu, Aug 23, 2018 at 4:14 PM Lin Yuan  wrote:

> Hi Da,
>
> I am currently running the unit test and will check in the fix once it's
> complete.
>
> Thanks,
>
> Lin
>
> On Thu, Aug 23, 2018 at 3:59 PM Zheng, Da 
> wrote:
>
> > Hello all,
> >
> > There is a little bug in shape inference of the where operator.
> Currently,
> > the where operator doesn’t work if the first input is a 1D array. Yuan
> Lin
> > will provide a patch to fix this bug.
> >
> > Best,
> > Da
> >
>

Updating MXNet's Cub

[Hagay Lupesko]

Hi all,


One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub (
https://github.com/dmlc/cub) – the snapshot is of an older version of Cub
(1.7), while the latest Nvidia Cub release is 1.8.  Note that dmlc/cub has
no customizations of the source Cub repo.


I’d like to suggest to update the existing Cub submodule to Nvidia’s Cub
repo. Instead of the snapshot, MXNet will be using Nvidia’s repo and the
latest release (both repos have the same BSD-3 license, so licensing should
not be an issue).


Wanted to get feedback from the community to make sure I'm not missing
anything.

if there are no objections I'll submit a PR for the change.


Cheers,

Hagay

Re: Updating MXNet's Cub

[Chris Olivier]

+1 for pointing to NVidia's repo for the newer Cub and subsequent versions.

On Fri, Aug 24, 2018 at 10:01 AM Hagay Lupesko  wrote:

> Hi all,
>
>
> One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub (
> https://github.com/dmlc/cub) – the snapshot is of an older version of Cub
> (1.7), while the latest Nvidia Cub release is 1.8.  Note that dmlc/cub has
> no customizations of the source Cub repo.
>
>
> I’d like to suggest to update the existing Cub submodule to Nvidia’s Cub
> repo. Instead of the snapshot, MXNet will be using Nvidia’s repo and the
> latest release (both repos have the same BSD-3 license, so licensing should
> not be an issue).
>
>
> Wanted to get feedback from the community to make sure I'm not missing
> anything.
>
> if there are no objections I'll submit a PR for the change.
>
>
> Cheers,
>
> Hagay
>