RE: Order of includes in cpplint
Ah, I see the problem. The real problem is, we shouldn't use diamond include instead of quotes include for project header, which is cheating cpplint to consider them as system header. Diamond include should only be used for system header, including OS header, STL header and host-installed library header(opencv for example). For others, quote include should be used. Thanks, Zhennan -Original Message- From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com] Sent: Wednesday, January 9, 2019 9:29 AM To: dev@mxnet.incubator.apache.org Subject: Re: Order of includes in cpplint I worked around the case, I saw several cases where project and third party headers were included with diamond includes instead of quotes. Agree I think is too much hassle to change the order of includes in the whole project anyway. But this convention can cause some headers not to be self sufficient as system headers are being included before other library headers which might be using a system header like without including it themselves. Pedro. On Wed, Jan 9, 2019 at 2:12 AM Qin, Zhennan wrote: > > Hi Pedro, > > Interesting topic. Google style does have guidance for this: > > https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_I > ncludes > > According to it, the order is, > > dir2/foo2.h. > A blank line > C system files. > C++ system files. > A blank line > Other libraries' .h files. > Your project's .h files. > > As MXNet follows this style, I guess we shouldn't break it unless we have > some problems. Do you have such a case that need the change? > > Thanks, > Zhennan > > -Original Message- > From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com] > Sent: Wednesday, January 9, 2019 6:44 AM > To: dev@mxnet.incubator.apache.org > Subject: Order of includes in cpplint > > Hi MXNet community > > cpplint seems to complain when the order of includes is not [own, > system, other] > > But the general best practice in C++ is [own, project, 3rd party, > system] for the reasons explained in this stackoverflow answer: ( > https://stackoverflow.com/questions/614302/c-header-order ) > > A contribution to cpplint could be made to make this configurable: > > https://github.com/cpplint/cpplint/blob/master/cpplint.py#L605 > > Thoughts? > > Pedro.
Re: Order of includes in cpplint
opinions vary. there’s arguments the other way, too, such as an ideal precompiled header compiler would work best with invariant headers first as well as template matching order in some cases On Tue, Jan 8, 2019 at 2:44 PM Pedro Larroy wrote: > Hi MXNet community > > cpplint seems to complain when the order of includes is not [own, > system, other] > > But the general best practice in C++ is [own, project, 3rd party, > system] for the reasons explained in this stackoverflow answer: ( > https://stackoverflow.com/questions/614302/c-header-order ) > > A contribution to cpplint could be made to make this configurable: > > https://github.com/cpplint/cpplint/blob/master/cpplint.py#L605 > > Thoughts? > > Pedro. >
RE: Order of includes in cpplint
Hi Pedro, Interesting topic. Google style does have guidance for this: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes According to it, the order is, dir2/foo2.h. A blank line C system files. C++ system files. A blank line Other libraries' .h files. Your project's .h files. As MXNet follows this style, I guess we shouldn't break it unless we have some problems. Do you have such a case that need the change? Thanks, Zhennan -Original Message- From: Pedro Larroy [mailto:pedro.larroy.li...@gmail.com] Sent: Wednesday, January 9, 2019 6:44 AM To: dev@mxnet.incubator.apache.org Subject: Order of includes in cpplint Hi MXNet community cpplint seems to complain when the order of includes is not [own, system, other] But the general best practice in C++ is [own, project, 3rd party, system] for the reasons explained in this stackoverflow answer: ( https://stackoverflow.com/questions/614302/c-header-order ) A contribution to cpplint could be made to make this configurable: https://github.com/cpplint/cpplint/blob/master/cpplint.py#L605 Thoughts? Pedro.
Re: Apache MXNet v1.4.0 release status
Hi all, I added a section F in the document that explained the current static-linked dependencies we used for official release. As there are a few licenses are under BSD3 and GPL, we need to handle them in our next release. Please take a look and leave any concerns you may have. Thanks, Qing On 1/7/19, 8:33 PM, "kellen sunderland" wrote: So I see two quick options that should cut down on the dependency licenses required for TRT in the source release. 1: We can simply remove in the release package the submodules for onnx in folder incubator-mxnet/3rdparty/onnx-tensorrt/third_party/onnx/third_party. None of those dependencies are used in the build (I've just verified locally on my machine). 2: We can make a cmake based checkout system and ensure we only checkout the required files when TRT builds are enabled (similar to the current mkl-ml setup). I'd suggest option 1 for this release, and that we support option 2 for the 1.5 release. On Mon, Jan 7, 2019 at 8:19 PM Lv, Tao A wrote: > What should I do for the double headers in 3rdparty/mkldnn/src/cpu/xbyak/? > > -tao > > -Original Message- > From: Steffen Rochel [mailto:steffenroc...@gmail.com] > Sent: Tuesday, January 8, 2019 10:51 AM > To: dev@mxnet.incubator.apache.org > Subject: Re: Apache MXNet v1.4.0 release status > > Kellen and Tao - > yes, the understanding is that dependencies need to be considered and all > licences referenced to include in top level LICENSE file. > Appreciate your help with it. > Steffen > > On Mon, Jan 7, 2019 at 6:39 PM kellen sunderland < > kellen.sunderl...@gmail.com> wrote: > > > Sorry to hear about the licensing issues. I was following the general > > vote but I'm still lacking some clarity around what licenses in the > > onnx-trt repo need to be surfaced. I believe onnx-trt is MIT > > licensed, but it includes Onnx as a third party repo which then brings > > in dependencies with a variety of licenses. The proposal is that we > > look at these on an individual basis and then add them to our top level > LICENSE file right? > > > > An alternative is that we may be able to checkout a smaller source > > code dependency tree if we remove a few unneeded ONNX's dependencies > > (pybind and google-bench). My hope is that this wouldn't affect our > > compilation process and would get us down to two licenses to report > > (just Onnx and Onnx-TRT, both MIT). > > > > On Mon, Jan 7, 2019 at 6:07 PM Meghna Baijal > > > > wrote: > > > > > Hi All, > > > For some more context, these were the last emails I sent on the dev > > > and legal lists requesting help on the open questions – > > > > > > 1. Question on legal about the CC-By-2.5 < > > > > > http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201805.mbox > > /%3CCAK1xzDe6ECToKt_2cTR_7txQQCwHeYfvxXDfmuGgfA3jaTs=j...@mail.gmail.com > > %3E > > > > > > > 2. Question on dev about googletest file < > > > > > http://mail-archives.apache.org/mod_mbox/mxnet-dev/201804.mbox/%3CCAMG > > gKDC8szdfFqQhhSNpwwT_3zi4LBS7A=u4v7kj4ule44u...@mail.gmail.com%3E > > > > > > > 3. General Request for review of the licenses wiki < > > > > > https://mail-archives.apache.org/mod_mbox/mxnet-dev/201801.mbox/%3CCAM > > GgKDCi=s933zcVWwei15i5uBC1h88VUogt3Br=Vq28=vi...@mail.gmail.com%3E > > > > > > > > > > (Note: You can click on the the “>>” next to the thread on the top > > > right to view the next responses in the email threads in the apache > > > archive. ) > > > > > > Thanks, > > > Meghna Baijal > > > > > > On Mon, Jan 7, 2019 at 4:30 PM Steffen Rochel > > > > > > wrote: > > > > > > > Dear MXNet community - > > > > as you should have seen in previous email, voting for v1.4.0.rc0 > > > > has > > been > > > > cancelled. We received a -1 vote due to outstanding license issues. > > > > Please help to update > > > > > > https://cwiki.apache.org/confluence/display/MXNET/MXNet+Source+License > > s > > > > and > > > > resolve outstanding issues. > > > > > > > > I would like to ask specifically for help from contributors to > > > > mkldnn, opemmp and onnx-tensorrt to address the feedback from > > > > Justin - see > > > > > > > > > > > > > https://lists.apache.org/thread.html/ebb8c4c00fb66dd98da13621c7dcb8753 > > fee57562a861d61379d31e9@%3Cgeneral.incubator.apache.org%3E > > > > . > > > > > > > > I suggest to fix the issues first on master, then cherry-pick and > > > > merge > > > to > > > > 1.4.x branch. > > > > > > > > I'm suggesting to exclude Julia from 1.4.0 release as integration > > > > into MXNet repo and upgrade to 0.7+ is WIP.
Re: [Announcement] New Committer - Roshani Nagmote
Congratulation Roshani! On Tue, Jan 8, 2019 at 8:53 AM Qing Lan wrote: > Congrats Roshani! Great to have you here! > > -Qing > > > > > > > Congrats Roshani. Well deserved. > > > >> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu wrote: > >> > >> Great to have you on board, Roshani! > >> > >> -Marco > >> > >> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier > >> geschrieben: > >> > >>> Please join me in welcoming Roshani Nagmote as a new committer. > >>> > >>> She has been active in the project for quite some time. She has managed > >> the > >>> 1.3.0 release as well as being involved various features including the > >> Java > >>> API and ONNX operators. > >>> > >>> We are excited to have her onboard as a committer. > >>> > >>> Github Activity > >>> > >>> > >> > https://github.com/apache/incubator-mxnet/pulls?utf8=%E2%9C%93=is%3Apr+involves%3ARoshrini > >>> + > >>> > >>> Confluence > >>> > >>> > >> > https://cwiki.apache.org/confluence/users/viewuserprofile.action?username=roshrini > >>> > >> >
Re: [Announcement] New Committer - Roshani Nagmote
Congrats Roshani! Great to have you here! -Qing > > > Congrats Roshani. Well deserved. > >> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu > >> Great to have you on board, Roshani! >> >> -Marco >> >> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier >> geschrieben: >> >>> Please join me in welcoming Roshani Nagmote as a new committer. >>> >>> She has been active in the project for quite some time. She has managed >> the >>> 1.3.0 release as well as being involved various features including the >> Java >>> API and ONNX operators. >>> >>> We are excited to have her onboard as a committer. >>> >>> Github Activity >>> >>> >> https://github.com/apache/incubator-mxnet/pulls?utf8=%E2%9C%93=is%3Apr+involves%3ARoshrini >>> + >>> >>> Confluence >>> >>> >> https://cwiki.apache.org/confluence/users/viewuserprofile.action?username=roshrini >>> >>
Re: [Announcement] New Committer - Roshani Nagmote
Congrats Roshani. Well deserved. On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu Great to have you on board, Roshani! > > -Marco > > Am Di., 8. Jan. 2019, 15:18 hat Carin Meier > geschrieben: > > > Please join me in welcoming Roshani Nagmote as a new committer. > > > > She has been active in the project for quite some time. She has managed > the > > 1.3.0 release as well as being involved various features including the > Java > > API and ONNX operators. > > > > We are excited to have her onboard as a committer. > > > > Github Activity > > > > > https://github.com/apache/incubator-mxnet/pulls?utf8=%E2%9C%93=is%3Apr+involves%3ARoshrini > > + > > > > Confluence > > > > > https://cwiki.apache.org/confluence/users/viewuserprofile.action?username=roshrini > > >
Re: [Announcement] New Committer - Roshani Nagmote
Great to have you on board, Roshani! -Marco Am Di., 8. Jan. 2019, 15:18 hat Carin Meier geschrieben: > Please join me in welcoming Roshani Nagmote as a new committer. > > She has been active in the project for quite some time. She has managed the > 1.3.0 release as well as being involved various features including the Java > API and ONNX operators. > > We are excited to have her onboard as a committer. > > Github Activity > > https://github.com/apache/incubator-mxnet/pulls?utf8=%E2%9C%93=is%3Apr+involves%3ARoshrini > + > > Confluence > > https://cwiki.apache.org/confluence/users/viewuserprofile.action?username=roshrini >
[INVITATION] 8 January 2019 / Apache MXNet (Incubating) User Group meeting
Dear MXNet community, I would like to invite you to the regular Apache MXNet (Incubating) User Group meeting on the 8th of January 2019 [1]. As usually, the meeting will have remote VC, powered by Amazon Chime. Join the meeting: https://chime.aws/4899512091 Meeting ID: 4899 51 2091 Best Anton [1] https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28Incubating%29+User+Groups+recurring+meetings
