Re: Can upgrade windows CI cmake?
i test 3.12.2 3.13.3 3.14.2 3.15.5 shiwen hu 于2019年12月7日周六 下午7:28写道： > yes. > > Lausen, Leonard 于2019年12月7日周六 下午7:20写道： > >> Do you mean starting 3.15.5 it works fine? >> The image you attached doesn't display on my end. >> >> On Dec 7, 2019 19:12, shiwen hu wrote: >> [image.png] >> >> I tested these versions. until 3.15.5 is working fine. >> >> shiwen hu mailto:yajiedes...@gmail.com>> >> 于2019年12月7日周六 下午1:24写道： >> Now, other problems are solved by modifying CMakeLists.txt.but The >> command line is too long problem must update cmake.However I don't know >> which minimum version fixed the problem.I try to do some tests to find out >> the minimum version. >> >> Pedro Larroy > pedro.larroy.li...@gmail.com>> 于2019年12月7日周六 上午3:52写道： >> CMake shipped with ubuntu has issues when compiling with CUDA on GPU >> instances. I wouldn't recommend anything older than 3.12 for Linux GPU >> >> >> https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 >> >> I don't know about windows CMake version but would make sense to require a >> newer version. >> >> On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard > > >> wrote: >> >> > Currently we declare cmake_minimum_required(VERSION 3.0.2) >> > >> > I'm in favor of updating our CMake requirement. The main question may be >> > what >> > new version to pick as minimum requirement. >> > >> > In general, there is the guideline >> > >> > > You really should at least use a version of CMake that came out after >> > your >> > > compiler, since it needs to know compiler flags, etc, for that >> version. >> > And, >> > > since CMake will dumb itself down to the minimum required version in >> your >> > > CMake file, installing a new CMake, even system wide, is pretty safe. >> You >> > > should at least install it locally. It's easy (1-2 lines in many >> cases), >> > and >> > > you'll find that 5 minutes of work will save you hundreds of lines and >> > hours >> > > of CMakeLists.txt writing, and will be much easier to maintain in the >> > long >> > > run. >> > https://cliutils.gitlab.io/modern-cmake/ >> > >> > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html >> > gives a >> > short overview of all the improvements made to CMake over the past 6 >> years. >> > >> > It's easy for users to upgrade their cmake version with pip: >> > pip install --upgrade --user cmake >> > Thus it wouldn't be overly problematic to rely on a very recent version >> of >> > cmake, if indeed it's required. >> > >> > Nevertheless, if an earlier version fixes the problems, let's rather >> pick >> > that >> > one. Did you confirm which version is required to fix the problem? >> > >> > For now you could try if the CMake version shipped in the oldest >> supported >> > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If >> > not, >> > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes >> > your >> > issue. >> > >> > Thanks >> > Leonard >> > >> > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: >> > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 >> to >> > > change windows build system.but now ci cmake version seems to be a >> bug. >> > > can't to compile.can upgrade to 3.16.0? >> > >> >>
Re: Can upgrade windows CI cmake?
yes. Lausen, Leonard 于2019年12月7日周六 下午7:20写道： > Do you mean starting 3.15.5 it works fine? > The image you attached doesn't display on my end. > > On Dec 7, 2019 19:12, shiwen hu wrote: > [image.png] > > I tested these versions. until 3.15.5 is working fine. > > shiwen hu mailto:yajiedes...@gmail.com>> > 于2019年12月7日周六 下午1:24写道： > Now, other problems are solved by modifying CMakeLists.txt.but The command > line is too long problem must update cmake.However I don't know which > minimum version fixed the problem.I try to do some tests to find out the > minimum version. > > Pedro Larroy pedro.larroy.li...@gmail.com>> 于2019年12月7日周六 上午3:52写道： > CMake shipped with ubuntu has issues when compiling with CUDA on GPU > instances. I wouldn't recommend anything older than 3.12 for Linux GPU > > > https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 > > I don't know about windows CMake version but would make sense to require a > newer version. > > On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard > wrote: > > > Currently we declare cmake_minimum_required(VERSION 3.0.2) > > > > I'm in favor of updating our CMake requirement. The main question may be > > what > > new version to pick as minimum requirement. > > > > In general, there is the guideline > > > > > You really should at least use a version of CMake that came out after > > your > > > compiler, since it needs to know compiler flags, etc, for that version. > > And, > > > since CMake will dumb itself down to the minimum required version in > your > > > CMake file, installing a new CMake, even system wide, is pretty safe. > You > > > should at least install it locally. It's easy (1-2 lines in many > cases), > > and > > > you'll find that 5 minutes of work will save you hundreds of lines and > > hours > > > of CMakeLists.txt writing, and will be much easier to maintain in the > > long > > > run. > > https://cliutils.gitlab.io/modern-cmake/ > > > > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html > > gives a > > short overview of all the improvements made to CMake over the past 6 > years. > > > > It's easy for users to upgrade their cmake version with pip: > > pip install --upgrade --user cmake > > Thus it wouldn't be overly problematic to rely on a very recent version > of > > cmake, if indeed it's required. > > > > Nevertheless, if an earlier version fixes the problems, let's rather pick > > that > > one. Did you confirm which version is required to fix the problem? > > > > For now you could try if the CMake version shipped in the oldest > supported > > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If > > not, > > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes > > your > > issue. > > > > Thanks > > Leonard > > > > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: > > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 > to > > > change windows build system.but now ci cmake version seems to be a bug. > > > can't to compile.can upgrade to 3.16.0? > > > >
Re: Can upgrade windows CI cmake?
Do you mean starting 3.15.5 it works fine? The image you attached doesn't display on my end. On Dec 7, 2019 19:12, shiwen hu wrote: [image.png] I tested these versions. until 3.15.5 is working fine. shiwen hu mailto:yajiedes...@gmail.com>> 于2019年12月7日周六 下午1:24写道： Now, other problems are solved by modifying CMakeLists.txt.but The command line is too long problem must update cmake.However I don't know which minimum version fixed the problem.I try to do some tests to find out the minimum version. Pedro Larroy mailto:pedro.larroy.li...@gmail.com>> 于2019年12月7日周六 上午3:52写道： CMake shipped with ubuntu has issues when compiling with CUDA on GPU instances. I wouldn't recommend anything older than 3.12 for Linux GPU https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 I don't know about windows CMake version but would make sense to require a newer version. On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard wrote: > Currently we declare cmake_minimum_required(VERSION 3.0.2) > > I'm in favor of updating our CMake requirement. The main question may be > what > new version to pick as minimum requirement. > > In general, there is the guideline > > > You really should at least use a version of CMake that came out after > your > > compiler, since it needs to know compiler flags, etc, for that version. > And, > > since CMake will dumb itself down to the minimum required version in your > > CMake file, installing a new CMake, even system wide, is pretty safe. You > > should at least install it locally. It's easy (1-2 lines in many cases), > and > > you'll find that 5 minutes of work will save you hundreds of lines and > hours > > of CMakeLists.txt writing, and will be much easier to maintain in the > long > > run. > https://cliutils.gitlab.io/modern-cmake/ > > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html > gives a > short overview of all the improvements made to CMake over the past 6 years. > > It's easy for users to upgrade their cmake version with pip: > pip install --upgrade --user cmake > Thus it wouldn't be overly problematic to rely on a very recent version of > cmake, if indeed it's required. > > Nevertheless, if an earlier version fixes the problems, let's rather pick > that > one. Did you confirm which version is required to fix the problem? > > For now you could try if the CMake version shipped in the oldest supported > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If > not, > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes > your > issue. > > Thanks > Leonard > > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 to > > change windows build system.but now ci cmake version seems to be a bug. > > can't to compile.can upgrade to 3.16.0? >
Re: Can upgrade windows CI cmake?
[image: image.png] I tested these versions. until 3.15.5 is working fine. shiwen hu 于2019年12月7日周六 下午1:24写道： > Now, other problems are solved by modifying CMakeLists.txt.but The command > line is too long problem must update cmake.However I don't know which > minimum version fixed the problem.I try to do some tests to find out the > minimum version. > > Pedro Larroy 于2019年12月7日周六 上午3:52写道： > >> CMake shipped with ubuntu has issues when compiling with CUDA on GPU >> instances. I wouldn't recommend anything older than 3.12 for Linux GPU >> >> >> https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 >> >> I don't know about windows CMake version but would make sense to require a >> newer version. >> >> On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard > > >> wrote: >> >> > Currently we declare cmake_minimum_required(VERSION 3.0.2) >> > >> > I'm in favor of updating our CMake requirement. The main question may be >> > what >> > new version to pick as minimum requirement. >> > >> > In general, there is the guideline >> > >> > > You really should at least use a version of CMake that came out after >> > your >> > > compiler, since it needs to know compiler flags, etc, for that >> version. >> > And, >> > > since CMake will dumb itself down to the minimum required version in >> your >> > > CMake file, installing a new CMake, even system wide, is pretty safe. >> You >> > > should at least install it locally. It's easy (1-2 lines in many >> cases), >> > and >> > > you'll find that 5 minutes of work will save you hundreds of lines and >> > hours >> > > of CMakeLists.txt writing, and will be much easier to maintain in the >> > long >> > > run. >> > https://cliutils.gitlab.io/modern-cmake/ >> > >> > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html >> > gives a >> > short overview of all the improvements made to CMake over the past 6 >> years. >> > >> > It's easy for users to upgrade their cmake version with pip: >> > pip install --upgrade --user cmake >> > Thus it wouldn't be overly problematic to rely on a very recent version >> of >> > cmake, if indeed it's required. >> > >> > Nevertheless, if an earlier version fixes the problems, let's rather >> pick >> > that >> > one. Did you confirm which version is required to fix the problem? >> > >> > For now you could try if the CMake version shipped in the oldest >> supported >> > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If >> > not, >> > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes >> > your >> > issue. >> > >> > Thanks >> > Leonard >> > >> > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: >> > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 >> to >> > > change windows build system.but now ci cmake version seems to be a >> bug. >> > > can't to compile.can upgrade to 3.16.0? >> > >> >
Re: Can upgrade windows CI cmake?
Now, other problems are solved by modifying CMakeLists.txt.but The command line is too long problem must update cmake.However I don't know which minimum version fixed the problem.I try to do some tests to find out the minimum version. Pedro Larroy 于2019年12月7日周六 上午3:52写道： > CMake shipped with ubuntu has issues when compiling with CUDA on GPU > instances. I wouldn't recommend anything older than 3.12 for Linux GPU > > > https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 > > I don't know about windows CMake version but would make sense to require a > newer version. > > On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard > wrote: > > > Currently we declare cmake_minimum_required(VERSION 3.0.2) > > > > I'm in favor of updating our CMake requirement. The main question may be > > what > > new version to pick as minimum requirement. > > > > In general, there is the guideline > > > > > You really should at least use a version of CMake that came out after > > your > > > compiler, since it needs to know compiler flags, etc, for that version. > > And, > > > since CMake will dumb itself down to the minimum required version in > your > > > CMake file, installing a new CMake, even system wide, is pretty safe. > You > > > should at least install it locally. It's easy (1-2 lines in many > cases), > > and > > > you'll find that 5 minutes of work will save you hundreds of lines and > > hours > > > of CMakeLists.txt writing, and will be much easier to maintain in the > > long > > > run. > > https://cliutils.gitlab.io/modern-cmake/ > > > > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html > > gives a > > short overview of all the improvements made to CMake over the past 6 > years. > > > > It's easy for users to upgrade their cmake version with pip: > > pip install --upgrade --user cmake > > Thus it wouldn't be overly problematic to rely on a very recent version > of > > cmake, if indeed it's required. > > > > Nevertheless, if an earlier version fixes the problems, let's rather pick > > that > > one. Did you confirm which version is required to fix the problem? > > > > For now you could try if the CMake version shipped in the oldest > supported > > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If > > not, > > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes > > your > > issue. > > > > Thanks > > Leonard > > > > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: > > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 > to > > > change windows build system.but now ci cmake version seems to be a bug. > > > can't to compile.can upgrade to 3.16.0? > > >
Re: Can upgrade windows CI cmake?
CMake shipped with ubuntu has issues when compiling with CUDA on GPU instances. I wouldn't recommend anything older than 3.12 for Linux GPU https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/ubuntu_core.sh#L63 I don't know about windows CMake version but would make sense to require a newer version. On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard wrote: > Currently we declare cmake_minimum_required(VERSION 3.0.2) > > I'm in favor of updating our CMake requirement. The main question may be > what > new version to pick as minimum requirement. > > In general, there is the guideline > > > You really should at least use a version of CMake that came out after > your > > compiler, since it needs to know compiler flags, etc, for that version. > And, > > since CMake will dumb itself down to the minimum required version in your > > CMake file, installing a new CMake, even system wide, is pretty safe. You > > should at least install it locally. It's easy (1-2 lines in many cases), > and > > you'll find that 5 minutes of work will save you hundreds of lines and > hours > > of CMakeLists.txt writing, and will be much easier to maintain in the > long > > run. > https://cliutils.gitlab.io/modern-cmake/ > > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html > gives a > short overview of all the improvements made to CMake over the past 6 years. > > It's easy for users to upgrade their cmake version with pip: > pip install --upgrade --user cmake > Thus it wouldn't be overly problematic to rely on a very recent version of > cmake, if indeed it's required. > > Nevertheless, if an earlier version fixes the problems, let's rather pick > that > one. Did you confirm which version is required to fix the problem? > > For now you could try if the CMake version shipped in the oldest supported > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If > not, > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes > your > issue. > > Thanks > Leonard > > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 to > > change windows build system.but now ci cmake version seems to be a bug. > > can't to compile.can upgrade to 3.16.0? >
Re: Can upgrade windows CI cmake?
Currently we declare cmake_minimum_required(VERSION 3.0.2) I'm in favor of updating our CMake requirement. The main question may be what new version to pick as minimum requirement. In general, there is the guideline > You really should at least use a version of CMake that came out after your > compiler, since it needs to know compiler flags, etc, for that version. And, > since CMake will dumb itself down to the minimum required version in your > CMake file, installing a new CMake, even system wide, is pretty safe. You > should at least install it locally. It's easy (1-2 lines in many cases), and > you'll find that 5 minutes of work will save you hundreds of lines and hours > of CMakeLists.txt writing, and will be much easier to maintain in the long > run. https://cliutils.gitlab.io/modern-cmake/ https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html gives a short overview of all the improvements made to CMake over the past 6 years. It's easy for users to upgrade their cmake version with pip: pip install --upgrade --user cmake Thus it wouldn't be overly problematic to rely on a very recent version of cmake, if indeed it's required. Nevertheless, if an earlier version fixes the problems, let's rather pick that one. Did you confirm which version is required to fix the problem? For now you could try if the CMake version shipped in the oldest supported Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? If not, please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixes your issue. Thanks Leonard On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 to > change windows build system.but now ci cmake version seems to be a bug. > can't to compile.can upgrade to 3.16.0?
Can upgrade windows CI cmake?
i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 to change windows build system.but now ci cmake version seems to be a bug. can't to compile.can upgrade to 3.16.0?
