[jira] Commented: (TOBAGO-197) treestate setting marker was not able to display on the selectable leafs and expand the entire leafs node

2006-11-25 Thread Sam Wong (JIRA)
[ 
http://issues.apache.org/jira/browse/TOBAGO-197?page=comments#action_12452583 ] 

Sam Wong commented on TOBAGO-197:
-

I tried to download the nightly build to test the fix.  I went to 
http://people.apache.org/builds/myfaces/nightly/ and did not find any source 
code?  am I going to wrong URL?  May I have the correct URL?  thanks again.

 treestate setting marker was not able to display on the selectable leafs and 
 expand the entire leafs node
 -

 Key: TOBAGO-197
 URL: http://issues.apache.org/jira/browse/TOBAGO-197
 Project: MyFaces Tobago
  Issue Type: Bug
Affects Versions: 1.0.8
 Environment: JBoss 4.4
 JDK 1.5
Reporter: Sam Wong
 Assigned To: Volker Weber

 I would like to display what the user has selected from the tree leafs when 
 the user has saved the tree leafs onto the database and retrieve it back
 from your examples on TobagoDemoController.java
 tree = new DefaultMutableTreeNode(
 new Node(Root Node, root));
 tree.insert(new DefaultMutableTreeNode(new Node(Sports, sports)), 0);
 tree.insert(new DefaultMutableTreeNode(new Node(Movies, movies)), 0);
 DefaultMutableTreeNode music = new DefaultMutableTreeNode(
 new Node(Music, music));
 tree.insert(music, 0);
 tree.insert(new DefaultMutableTreeNode(new Node(Games, games)), 0);
 MutableTreeNode temp = new DefaultMutableTreeNode(
 new Node(Science, science));
 temp.insert(
 new DefaultMutableTreeNode(new Node(Geography, geography)), 0);
 temp.insert(
 new DefaultMutableTreeNode(new Node(Mathematics, math)), 0);
 DefaultMutableTreeNode temp2 = new DefaultMutableTreeNode(
 new Node(Astronomy, astro));
 temp2.insert(new DefaultMutableTreeNode(new Node(Education, edu)), 0);
 temp2.insert(new DefaultMutableTreeNode(new Node(Pictures, pic)), 0);
 temp.insert(temp2, 2);
 tree.insert(temp, 2);
 treeState = new TreeState();
 treeState.addExpandState(tree);

 treeState.addSelection(temp2);
 treeState.setMarker(music);
 
 For examples
 Where I set the  treeState.setMarker(temp2); When I expand the tree, I did 
 not see the node leaf was being check?
 Also is there a way to expand a complete leafs node by default??
 Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (TOBAGO-197) treestate setting marker was not able to display on the selectable leafs and expand the entire leafs node

2006-11-25 Thread Sam Wong (JIRA)
[ 
http://issues.apache.org/jira/browse/TOBAGO-197?page=comments#action_12452584 ] 

Sam Wong commented on TOBAGO-197:
-

Am I supposed to download myfaces-tobago-1.0.9-SNAPSHOT-dist.zipat 
http://people.apache.org/builds/myfaces/nightly/  for the nightly build?  thanks



 treestate setting marker was not able to display on the selectable leafs and 
 expand the entire leafs node
 -

 Key: TOBAGO-197
 URL: http://issues.apache.org/jira/browse/TOBAGO-197
 Project: MyFaces Tobago
  Issue Type: Bug
Affects Versions: 1.0.8
 Environment: JBoss 4.4
 JDK 1.5
Reporter: Sam Wong
 Assigned To: Volker Weber

 I would like to display what the user has selected from the tree leafs when 
 the user has saved the tree leafs onto the database and retrieve it back
 from your examples on TobagoDemoController.java
 tree = new DefaultMutableTreeNode(
 new Node(Root Node, root));
 tree.insert(new DefaultMutableTreeNode(new Node(Sports, sports)), 0);
 tree.insert(new DefaultMutableTreeNode(new Node(Movies, movies)), 0);
 DefaultMutableTreeNode music = new DefaultMutableTreeNode(
 new Node(Music, music));
 tree.insert(music, 0);
 tree.insert(new DefaultMutableTreeNode(new Node(Games, games)), 0);
 MutableTreeNode temp = new DefaultMutableTreeNode(
 new Node(Science, science));
 temp.insert(
 new DefaultMutableTreeNode(new Node(Geography, geography)), 0);
 temp.insert(
 new DefaultMutableTreeNode(new Node(Mathematics, math)), 0);
 DefaultMutableTreeNode temp2 = new DefaultMutableTreeNode(
 new Node(Astronomy, astro));
 temp2.insert(new DefaultMutableTreeNode(new Node(Education, edu)), 0);
 temp2.insert(new DefaultMutableTreeNode(new Node(Pictures, pic)), 0);
 temp.insert(temp2, 2);
 tree.insert(temp, 2);
 treeState = new TreeState();
 treeState.addExpandState(tree);

 treeState.addSelection(temp2);
 treeState.setMarker(music);
 
 For examples
 Where I set the  treeState.setMarker(temp2); When I expand the tree, I did 
 not see the node leaf was being check?
 Also is there a way to expand a complete leafs node by default??
 Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (MYFACES-1409) incorrect behavior after RESTORE_VIEW responseComplete

2006-11-25 Thread Leonid Mikhailov (JIRA)
[ 
http://issues.apache.org/jira/browse/MYFACES-1409?page=comments#action_12452595 
] 

Leonid Mikhailov commented on MYFACES-1409:
---

Manfred,

I believe there is an incompaibility in the behvior between MyFaces and JSF-RI 
which the attached ajax-progress-bar sample from the Sun's blueprint catalog 
illustrates.  

Concerning the trace, it is not the same trace one gets when running this code 
against JSF-RI. I guess that is exactly why the sample does not work correctly.

Run the sample and see for yourself.

Regards, 

Leonid

 incorrect behavior after RESTORE_VIEW responseComplete
 --

 Key: MYFACES-1409
 URL: http://issues.apache.org/jira/browse/MYFACES-1409
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 1.1.5-SNAPSHOT
 Environment: Windows XP, apache-tomcat-5.5.17
Reporter: Leonid Mikhailov
 Fix For: 1.1.5-SNAPSHOT

 Attachments: ajax-progress-bar-jsf-MyFaces.war


 The following behavior appears to be incorrect in myfaces implementation of 
 JSF. 
 After FacesContext.responseComplete is issued in the afterPhase method of  
 the PhaseListener at the RESTORE_VIEW phase, myfaces implementation skips to  
 RENDER_RESPONSE phase. This appears to be incorrect, as following a call to  
 FacesContext.responseComplete JSF implementation should exit JSF lifecycle  
 completely, i.e. the next phase of the lifecycle should be again  
 RESTORE_VIEW. 
  
 This problem can be observed when running Sun's Progress Bar with JSF and  
 AJAX Sample with myfaces libraries on Tomcat. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: Commons Jsf Utils

2006-11-25 Thread Bernd Bohmann

Hello,

I like the proprosal of a commons package.
But I would prefer more separated packages(artifacts)

org.apache.myfaces.commons.util
org.apache.myfaces.commons.fileupload
org.apache.myfaces.commons.security
org.apache.myfaces.commons.security.tiger
org.apache.myfaces.commons.validator
org.apache.myfaces.commons.convert
org.apache.myfaces.commons.component
.
.

I don't like commons-jsf.
In my opinion myfaces is jsf we don't need a jsf in the name.

We should discuss the version scheme of the commons artifacts, too.

Maybe we need a

Minor.major.fixpack.point scheme

and the Minor.major version is equivalent to the jsf version

Regards


Bernd



Cagatay Civici wrote:

Yes, having separate commons packages sounds good.

Cagatay

On 11/24/06, Martin Marinschek [EMAIL PROTECTED] wrote:


+1 for starting off with commons

+1 for your first naming suggestion

regards,

Martin

On 11/24/06, Manfred Geiler [EMAIL PROTECTED] wrote:
 Important hint, thanks!
 My feeling is, we should have only one jsf-commons project and resolve
 version issues in the way springframework does support both
 hibernate2.1 and hibernate3. They have separate packages and only
 optional maven dependencies.

 So we could start like this:

  org.apache.myfaces.commons-jsf
  org.apache.myfaces.commons-jsf-1-1
  org.apache.myfaces.commons-jsf-1-2

 and have
  org.apache.myfaces.commons-jsf-2-0
 and so on
 later.

 Or alternatively:
  org.apache.myfaces.commons-jsf
  org.apache.myfaces.commons-jsf.jsf-1-1
  org.apache.myfaces.commons-jsf.jsf-1-2

 Or:
  org.apache.myfaces.commons-jsf.webapp
  org.apache.myfaces.commons-jsf.webapp.jsf-1-1
  org.apache.myfaces.commons-jsf.webapp.jsf-1-2
  org.apache.myfaces.commons-jsf.render.html
  org.apache.myfaces.commons-jsf.render.html.jsf-1-1
  org.apache.myfaces.commons-jsf.render.html.jsf-1-2

 WDYT?

 Manfred




 On 11/24/06, Bruno Aranda [EMAIL PROTECTED] wrote:
  It seems a good idea to me. But should this commons lib be jsf 
version

  independent (I mean, same jar to be used in jsf 1.1 and jsf 1.2 or
  not). There are classes, like UIComponentTagUtils, which would have a
  different implementation for jsf 1.1 and 1.2, but there are other
  (many) classes that can work for 1.1 and 1.2 out of the box. I would
  say it would be better to have a unique implementation of
  myfaces-commons and it should be jsf version independent...
 
  Cheers,
 
  Bruno
 
  On 24/11/06, Manfred Geiler [EMAIL PROTECTED] wrote:
   Hi *,
   Anyone remembering the old idea of having a separate commons jsf
   utils project?
  
   Mission:
   - provide utilities for JSF component developers as well as JSF
   application developers
   - provide a stable API
   - must not depend on a certain JSF implementation
   - own release schedule independent of core and tomahawk. Maybe
   propelled by a sister project of course... ;-)
  
   One perfect example of a jsf-commons class I just stumbled 
across is

   UIComponentTagUtils. It's the class where all those boring
   set*Property methods are implemented, that do the if value-binding
   then... else... things.
  
   Proposal:
   - Initiate a new MyFaces sub-project called commons-jsf
   (Yes! There did exist a commons in ancient times. It was the
   forerunner for our current shared project and the reason we
renamed
   commons to shared was, that we planned to create a REAL commons
   project later. Remember?)
   - We start with those obvious common jsf utils (like
UIComponentTagUtils)
   - Each (new) util class must be carefully designed to be able to
   provide a robust API
  
   Thoughts?
  
  
   Manfred
  
 



--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces







Re: panelNavigation2 icon and label issue

2006-11-25 Thread Paul Spencer

Chintan,
This may or may not help, you can use t:commandNavigation2 to display an icon 
and text.

Below is from a test program I am working on.  Based on you message, it appears 
you are dynamically
creating the menu items.  So I do not expect this to be an exact fit, but it 
may provide a clue
to another solution.
  h:form id=navForm2
t:panelNavigation2 id=pn2_list layout=list
  ...
  t:commandNavigation2 id=cn2_p2 action=page_2
h:graphicImage url=/images/icon2.jpg /
h:outputText value=Page 2 /
  /t:commandNavigation2
  ...
/t:panelNavigation2
  /h:form

Paul Spencer

chintan wrote:

Hi,

I am using panelNavigation2 tag to display panle navigation menu. This tag
uses NavigationMenuItem class of Tomahawk. My problem is, I am not able to
dispaly icon and label both together eventhough i have used
NavigationMenuItem () constructor with above parameters. At a time i can
displayd either label or icon.

Is this bug in Tomahawk implementation or I am missing something.

Pleae treat it is as an urgent. 


Thanks
Chintan




[jira] Created: (TOMAHAWK-804) SelectOneCountry validators are ignored

2006-11-25 Thread Cagatay Civici (JIRA)
SelectOneCountry validators are ignored
---

 Key: TOMAHAWK-804
 URL: http://issues.apache.org/jira/browse/TOMAHAWK-804
 Project: MyFaces Tomahawk
  Issue Type: Bug
  Components: SelectOneCountry
Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
Reporter: Cagatay Civici
 Assigned To: Cagatay Civici


Similar bug as described in TOMAHAWK-803. SelectOneCountry ignores all of it's 
validation calls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Resolved: (TOMAHAWK-804) SelectOneCountry validators are ignored

2006-11-25 Thread Cagatay Civici (JIRA)
 [ http://issues.apache.org/jira/browse/TOMAHAWK-804?page=all ]

Cagatay Civici resolved TOMAHAWK-804.
-

Fix Version/s: 1.1.4-SNAPSHOT
   1.1.5-SNAPSHOT
   Resolution: Fixed

 SelectOneCountry validators are ignored
 ---

 Key: TOMAHAWK-804
 URL: http://issues.apache.org/jira/browse/TOMAHAWK-804
 Project: MyFaces Tomahawk
  Issue Type: Bug
  Components: SelectOneCountry
Affects Versions: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT
Reporter: Cagatay Civici
 Assigned To: Cagatay Civici
 Fix For: 1.1.4-SNAPSHOT, 1.1.5-SNAPSHOT


 Similar bug as described in TOMAHAWK-803. SelectOneCountry ignores all of 
 it's validation calls.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




Re: I am working on a Selenium test suite.

2006-11-25 Thread Wendy Smoak

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


At this point I have committed none of the tests, but I would like to
commit them soon.
1) Where is the best place to add them? I suspect the best place add
this is myfaces/tomahawk/snapshot.

2) What should the artifactId be?  Currently it is myfaces-snapshot-testing.


First, thanks for taking this on!

Why not add these tests to one of the existing apps?

The word 'snapshot' has a special meaning in Maven, that doesn't seem
to apply here-- if it does have to be separate, this would be another
example app that we could ship, both to demonstrate how to use the
components and encourage this sort of testing.

--
Wendy


Re: I am working on a Selenium test suite.

2006-11-25 Thread Paul Spencer

Wendy,
Whoops, I used snapshot instead of sandbox.

While I was working on the test suite, I thought about having one test 
suite for MyFaces and one for Tomahawk instead of one in Tomahawk that 
includes MyFaces tests.  Wherever the test suite(s) end up, they should 
be a Maven project, like Tomahawk's Simple Example.


So, where should the test suite(s) be added and what should they be named?

BTW: Running the test on HostedQA is taking a while, any ideas why?

Paul Spencer

Wendy Smoak wrote:

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


At this point I have committed none of the tests, but I would like to
commit them soon.
1) Where is the best place to add them? I suspect the best place add
this is myfaces/tomahawk/snapshot.

2) What should the artifactId be?  Currently it is 
myfaces-snapshot-testing.


First, thanks for taking this on!

Why not add these tests to one of the existing apps?

The word 'snapshot' has a special meaning in Maven, that doesn't seem
to apply here-- if it does have to be separate, this would be another
example app that we could ship, both to demonstrate how to use the
components and encourage this sort of testing.

--
Wendy





Re: I am working on a Selenium test suite.

2006-11-25 Thread Wendy Smoak

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


Whoops, I used snapshot instead of sandbox.



From that I would assume that these are tests for the Tomahawk Sandbox

components, which I don't think is the case.


While I was working on the test suite, I thought about having one test
suite for MyFaces and one for Tomahawk instead of one in Tomahawk that
includes MyFaces tests.  Wherever the test suite(s) end up, they should
be a Maven project, like Tomahawk's Simple Example.

So, where should the test suite(s) be added and what should they be named?


I'm resistant to adding another webapp module, especially to Core
which doesn't currently have any.  My preference is to add these pages
and tests to the existing 'simple' app.  That said, I'm not the one
doing the work. :)


BTW: Running the test on HostedQA is taking a while, any ideas why?


They run in a virtual server, so it takes a while to set up.  If
you're going to be running them repeatedly, I think there's a way to
start the virtual server once so it will be there.  Send a note to the
support address if you have any questions, Patrick [Lightbody] will be
happy to help.

I'd suggest running the tests locally with the Selenium TestRunner
while you're working out the details.  Then we can schedule Continuum
to run them at HostedQA periodically.

--
Wendy


AW: I am working on a Selenium test suite.

2006-11-25 Thread Andreas Berger
I'm currently working on the XML files for automaticly generation of the
components and tags (JSF 1.2). Additionally I'm developing some enhancements
for the generator. Maybe It's a good idea to generate also testcases from
the XML's. I dont know the format, but if you got an example I can have a
look at what's possible.

Cheers Andreas

-Ursprüngliche Nachricht-
Von: Paul Spencer [mailto:[EMAIL PROTECTED] 
Gesendet: Samstag, 25. November 2006 23:01
An: MyFaces Development
Betreff: I am working on a Selenium test suite.

I have started writing a Selenium test suite.  I have the following goals:

1) Provide a regression test environment.
2) Further my understanding on how the JSF components work.
3) Provide a simplified set of examples.
4) Provide a platform for easily developing a test case for a bug.

Currently I have implemented only a few of the tags, like h:panelGrid and
t:panelNavigation2, but I intend on adding many more.  The test include a
jsp page that sets many of the attribute for each tag and a Selenuim script
that verifies the resulting HTML and functionality.  I have tried to
minimize the amount of java code need to implement each tag, this keeps the
test cases very simple.  Although much of this replicates what is currently
in Tomahawk Examples, it does not rely on stylesheets or dynamically
generated components.

I have run the test on HostedQA [1] so the results are publicly available.
The test are run against IE 7 and Firefox.  Currently IE7 is failing parts
of the test, I suspect the failure have to do with how the test are address
elements in the dom.

At this point I have committed none of the tests, but I would like to commit
them soon.
1) Where is the best place to add them? I suspect the best place add
this is myfaces/tomahawk/snapshot.

2) What should the artifactId be?  Currently it is myfaces-snapshot-testing.

Paul Spencer

[1] https://myfaces.hostedqa.com/project/122/session/suite/list



Re: I am working on a Selenium test suite.

2006-11-25 Thread Paul Spencer

Wendy,

See below.

Wendy Smoak wrote:

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


Whoops, I used snapshot instead of sandbox.



From that I would assume that these are tests for the Tomahawk Sandbox

components, which I don't think is the case.


While I was working on the test suite, I thought about having one test
suite for MyFaces and one for Tomahawk instead of one in Tomahawk that
includes MyFaces tests.  Wherever the test suite(s) end up, they should
be a Maven project, like Tomahawk's Simple Example.

So, where should the test suite(s) be added and what should they be 
named?


I'm resistant to adding another webapp module, especially to Core
which doesn't currently have any.  My preference is to add these pages
and tests to the existing 'simple' app.  That said, I'm not the one
doing the work. :)



Not a problem adding the test to the examples. I would prefer to group 
them in a subdirectory.  Any suggestions for a name of that 
subdirectory?  testSuite?



BTW: Running the test on HostedQA is taking a while, any ideas why?


They run in a virtual server, so it takes a while to set up.  If
you're going to be running them repeatedly, I think there's a way to
start the virtual server once so it will be there.  Send a note to the
support address if you have any questions, Patrick [Lightbody] will be
happy to help.

I'd suggest running the tests locally with the Selenium TestRunner
while you're working out the details.  Then we can schedule Continuum
to run them at HostedQA periodically.



I do run them locally.

Paul Spencer


Re: I am working on a Selenium test suite.

2006-11-25 Thread Wendy Smoak

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


Not a problem adding the test to the examples. I would prefer to group
them in a subdirectory.  Any suggestions for a name of that
subdirectory?  testSuite?


There are two parts to this, right?  The tests, and the companion JSPs.

IMO, the tests, (the html pages with tables that are the Selenium
tests,) should go under src/test/selenium.  That's how things are set
up in pom.xml now, at least.

I don't have a strong preference for where you put the JSPs (and they
can always be moved around later if anyone objects to what you pick.)

Thanks,
--
Wendy


Re: I am working on a Selenium test suite.

2006-11-25 Thread Paul Spencer

Wendy Smoak wrote:

On 11/25/06, Paul Spencer [EMAIL PROTECTED] wrote:


Not a problem adding the test to the examples. I would prefer to group
them in a subdirectory.  Any suggestions for a name of that
subdirectory?  testSuite?


There are two parts to this, right?  The tests, and the companion JSPs.

IMO, the tests, (the html pages with tables that are the Selenium
tests,) should go under src/test/selenium.  That's how things are set
up in pom.xml now, at least.


Correct, I would not change that.


I don't have a strong preference for where you put the JSPs (and they
can always be moved around later if anyone objects to what you pick.)


Fair enough.  I will create a testSuite and place the jsp file their.


Thanks,


Paul Spencer


Re: AW: I am working on a Selenium test suite.

2006-11-25 Thread Paul Spencer

Andreas,
Please refer to the file HowToAddATest.html [1].

Paul Spencer

[1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/examples/simple/src/main/webapp/testSuite/HowToAddATest.html?view=markup


Andreas Berger wrote:

I'm currently working on the XML files for automaticly generation of the
components and tags (JSF 1.2). Additionally I'm developing some enhancements
for the generator. Maybe It's a good idea to generate also testcases from
the XML's. I dont know the format, but if you got an example I can have a
look at what's possible.

Cheers Andreas

-Ursprüngliche Nachricht-
Von: Paul Spencer [mailto:[EMAIL PROTECTED] 
Gesendet: Samstag, 25. November 2006 23:01

An: MyFaces Development
Betreff: I am working on a Selenium test suite.

I have started writing a Selenium test suite.  I have the following goals:

1) Provide a regression test environment.
2) Further my understanding on how the JSF components work.
3) Provide a simplified set of examples.
4) Provide a platform for easily developing a test case for a bug.

Currently I have implemented only a few of the tags, like h:panelGrid and
t:panelNavigation2, but I intend on adding many more.  The test include a
jsp page that sets many of the attribute for each tag and a Selenuim script
that verifies the resulting HTML and functionality.  I have tried to
minimize the amount of java code need to implement each tag, this keeps the
test cases very simple.  Although much of this replicates what is currently
in Tomahawk Examples, it does not rely on stylesheets or dynamically
generated components.

I have run the test on HostedQA [1] so the results are publicly available.
The test are run against IE 7 and Firefox.  Currently IE7 is failing parts
of the test, I suspect the failure have to do with how the test are address
elements in the dom.

At this point I have committed none of the tests, but I would like to commit
them soon.
1) Where is the best place to add them? I suspect the best place add
this is myfaces/tomahawk/snapshot.

2) What should the artifactId be?  Currently it is myfaces-snapshot-testing.

Paul Spencer

[1] https://myfaces.hostedqa.com/project/122/session/suite/list