Re: hud...@myfaces
Hey Matthias, did you send me my account info? I didn't see it? Sent from my iPhone On Aug 25, 2010, at 1:31 PM, Matthias Wessendorf mat...@apache.org wrote: pretty cool stuff. Interesting option on the Apache configuration: We could also use Harmony to build our stuff :-) -Matthias On Wed, Aug 25, 2010 at 9:11 PM, Gerhard gerhard.petra...@gmail.com wrote: hi grant, it's great that you looked for the myfaces view. for the others: i created it to group all our build-jobs - see [1]. regards, gerhard [1] https://hudson.apache.org/hudson/view/MyFaces/ http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Grant Smith work.gr...@gmail.com OK, I have added a whole lot of builds. Currently testing them. All under the Myfaces view. Next I need to figure out how to copy the artifacts to the nightly builds area... On Wed, Aug 25, 2010 at 7:33 AM, Gerhard gerhard.petra...@gmail.com wrote: thx, regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Matthias Wessendorf mat...@apache.org Also, I added: -Leo -Werner -Gerhard -Matthias On Wed, Aug 25, 2010 at 9:27 AM, Matthias Wessendorf mat...@apache.org wrote: done -M On Wed, Aug 25, 2010 at 9:22 AM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, can you add me to this? I'd be willing to try the bridge stuff. Continuum has proven fairly unreliable for us. Sent from my iPhone On Aug 25, 2010, at 1:19 AM, Matthias Wessendorf mat...@apache.org wrote: Thanks Bernd! Right now the following committers have been added: -Bernd Bohmann -Grant Smith -Matthias Wessendorf -M On Wed, Aug 25, 2010 at 8:20 AM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello for trying hudson instead of continuum you need a hudson account. You can ask matthias for adding you to the hudson-jobadmin group on people.apache.org modify_appgroups.pl hudson-jobadmin --add=your apache username see: http://wiki.apache.org/general/Hudson#How_do_I_get_an_account for recommended or mandatory settings see: http://wiki.apache.org/general/Hudson#Are_there_recommended_or_mandatory_Hudson_settings_for_ASF_projects.3F Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: hud...@myfaces
nope, it's your apache user id + ldap password (same you are using for svn) -M On Thu, Aug 26, 2010 at 2:19 PM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, did you send me my account info? I didn't see it? Sent from my iPhone On Aug 25, 2010, at 1:31 PM, Matthias Wessendorf mat...@apache.org wrote: pretty cool stuff. Interesting option on the Apache configuration: We could also use Harmony to build our stuff :-) -Matthias On Wed, Aug 25, 2010 at 9:11 PM, Gerhard gerhard.petra...@gmail.com wrote: hi grant, it's great that you looked for the myfaces view. for the others: i created it to group all our build-jobs - see [1]. regards, gerhard [1] https://hudson.apache.org/hudson/view/MyFaces/ http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Grant Smith work.gr...@gmail.com OK, I have added a whole lot of builds. Currently testing them. All under the Myfaces view. Next I need to figure out how to copy the artifacts to the nightly builds area... On Wed, Aug 25, 2010 at 7:33 AM, Gerhard gerhard.petra...@gmail.com wrote: thx, regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Matthias Wessendorf mat...@apache.org Also, I added: -Leo -Werner -Gerhard -Matthias On Wed, Aug 25, 2010 at 9:27 AM, Matthias Wessendorf mat...@apache.org wrote: done -M On Wed, Aug 25, 2010 at 9:22 AM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, can you add me to this? I'd be willing to try the bridge stuff. Continuum has proven fairly unreliable for us. Sent from my iPhone On Aug 25, 2010, at 1:19 AM, Matthias Wessendorf mat...@apache.org wrote: Thanks Bernd! Right now the following committers have been added: -Bernd Bohmann -Grant Smith -Matthias Wessendorf -M On Wed, Aug 25, 2010 at 8:20 AM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello for trying hudson instead of continuum you need a hudson account. You can ask matthias for adding you to the hudson-jobadmin group on people.apache.org modify_appgroups.pl hudson-jobadmin --add=your apache username see: http://wiki.apache.org/general/Hudson#How_do_I_get_an_account for recommended or mandatory settings see: http://wiki.apache.org/general/Hudson#Are_there_recommended_or_mandatory_Hudson_settings_for_ASF_projects.3F Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Created: (TRINIDAD-1894) setting org.apache.myfaces.trinidad.DEBUG_JAVASCRIPT to false leads to exception
setting org.apache.myfaces.trinidad.DEBUG_JAVASCRIPT to false leads to exception
Key: TRINIDAD-1894
URL: https://issues.apache.org/jira/browse/TRINIDAD-1894
Project: MyFaces Trinidad
Issue Type: Bug
Affects Versions: 2.0.0.3-core
Environment: Java 6, Apache Tomcat 6/WebLogic 11
Reporter: Christoph Kainrath
Priority: Minor
context-param
param-nameorg.apache.myfaces.trinidad.DEBUG_JAVASCRIPT/param-name
param-valuefalse/param-value
/context-param
in web.xml leads to:
java.lang.NullPointerException
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.LibraryScriptlet._isDebug(LibraryScriptlet.java:223)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.LibraryScriptlet.getLibraryName(LibraryScriptlet.java:126)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.LibraryScriptlet.getLibraryURL(LibraryScriptlet.java:145)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.LibraryScriptlet.outputScriptletImpl(LibraryScriptlet.java:98)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.Scriptlet.outputScriptlet(Scriptlet.java:62)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils.addLib(XhtmlUtils.java:141)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.Scriptlet.outputDependency(Scriptlet.java:154)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.AliasedScriptlet.outputScriptletImpl(AliasedScriptlet.java:127)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.jsLibs.Scriptlet.outputScriptlet(Scriptlet.java:62)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlUtils.addLib(XhtmlUtils.java:141)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.PanelPartialRootRenderer.encodeAll(PanelPartialRootRenderer.java:108)
at
org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.BodyRenderer.encodeAll(BodyRenderer.java:81)
at
org.apache.myfaces.trinidad.render.CoreRenderer.encodeEnd(CoreRenderer.java:488)
If I remove the context-param element from my web.xml it works fine!
static private boolean _isDebug(FacesContext context)
{
if (_debugJavascript == null) {
String debugJavascript = context.
getExternalContext().getInitParameter(_DEBUG_JAVASCRIPT);
if (debugJavascript != null) {
if (debugJavascript.equalsIgnoreCase(true)) {
_debugJavascript = Boolean.TRUE;
// if Apache MyFaces Trinidad is running in production stage
// running with JavaScript debugging is not desired, therefore
// we generate a WARNING message; otherwise we just inform the user
if (context.isProjectStage(ProjectStage.Production))
{
_LOG.warning(RUNNING_DEBUG_JAVASCRIPT_IN_PRODUCTION_STAGE);
}
else
{
_LOG.info(RUNNING_DEBUG_JAVASCRIPT);
}
}
} else {
// if the _DEBUG_JAVASCRIPT parameter has NOT been specified, let us
// apply the DEFAULT values for the certain Project Stages:
// -PRODUCTION we want this value to be FALSE;
// -other stages we use TRUE
_debugJavascript = !(context.isProjectStage(ProjectStage.Production));
if (_debugJavascript)
{
_LOG.info(RUNNING_DEBUG_JAVASCRIPT);
}
}
}
return _debugJavascript.booleanValue();
}
-- _debugJavascript is only initialized if
(debugJavascript.equalsIgnoreCase(true)). Please insert something like else
_debugJavascript = Boolean.FALSE;
Thanks
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: EL method invocation performance
Gang - Kin-man opened the following issue to track this on the GF/UEL side: https://uel.dev.java.net/issues/show_bug.cgi?id=19 Andy
[jira] Resolved: (EXTVAL-115) Column of Trinidad table disappear
[ https://issues.apache.org/jira/browse/EXTVAL-115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gerhard Petracek resolved EXTVAL-115. - Resolution: Duplicate see EXTVAL-77 Column of Trinidad table disappear -- Key: EXTVAL-115 URL: https://issues.apache.org/jira/browse/EXTVAL-115 Project: MyFaces Extensions Validator Issue Type: Bug Affects Versions: 1.2.3 Environment: Ubuntu 10.04, Jetty 6.1.8 / Tomcat 6.0.26 Reporter: Walter Mourão Attachments: extvaltest.zip, screenshot_with_extval.png, screenshot_without_extval.png When I add extval to a project using Trinidad, the first column of a tr:table disappear after the first line. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: hud...@myfaces
Scott - I haven't added the Portlet Bridge yet. I got a bit confused as to which the current branch is, and what the supporting dependencies were. Actually, we could do with a Wiki page summarizing where the current development is on ALL of our projects, and what the SVN URL is for each. It's really confusing. On Thu, Aug 26, 2010 at 5:38 AM, Matthias Wessendorf mat...@apache.orgwrote: nope, it's your apache user id + ldap password (same you are using for svn) -M On Thu, Aug 26, 2010 at 2:19 PM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, did you send me my account info? I didn't see it? Sent from my iPhone On Aug 25, 2010, at 1:31 PM, Matthias Wessendorf mat...@apache.org wrote: pretty cool stuff. Interesting option on the Apache configuration: We could also use Harmony to build our stuff :-) -Matthias On Wed, Aug 25, 2010 at 9:11 PM, Gerhard gerhard.petra...@gmail.com wrote: hi grant, it's great that you looked for the myfaces view. for the others: i created it to group all our build-jobs - see [1]. regards, gerhard [1] https://hudson.apache.org/hudson/view/MyFaces/ http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Grant Smith work.gr...@gmail.com OK, I have added a whole lot of builds. Currently testing them. All under the Myfaces view. Next I need to figure out how to copy the artifacts to the nightly builds area... On Wed, Aug 25, 2010 at 7:33 AM, Gerhard gerhard.petra...@gmail.com wrote: thx, regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Matthias Wessendorf mat...@apache.org Also, I added: -Leo -Werner -Gerhard -Matthias On Wed, Aug 25, 2010 at 9:27 AM, Matthias Wessendorf mat...@apache.org wrote: done -M On Wed, Aug 25, 2010 at 9:22 AM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, can you add me to this? I'd be willing to try the bridge stuff. Continuum has proven fairly unreliable for us. Sent from my iPhone On Aug 25, 2010, at 1:19 AM, Matthias Wessendorf mat...@apache.org wrote: Thanks Bernd! Right now the following committers have been added: -Bernd Bohmann -Grant Smith -Matthias Wessendorf -M On Wed, Aug 25, 2010 at 8:20 AM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello for trying hudson instead of continuum you need a hudson account. You can ask matthias for adding you to the hudson-jobadmin group on people.apache.org modify_appgroups.pl hudson-jobadmin --add=your apache username see: http://wiki.apache.org/general/Hudson#How_do_I_get_an_account for recommended or mandatory settings see: http://wiki.apache.org/general/Hudson#Are_there_recommended_or_mandatory_Hudson_settings_for_ASF_projects.3F Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC.
Re: hud...@myfaces
I also have not added the GSOC build yet, I'll do that once I figure out why myfaces-current isnt compiling (looks like a dependency to shared-impl-2.0.12-SNAPSHOT, which for some reason is not incorporating automatically from the externs. The externs are probably wrong) On Thu, Aug 26, 2010 at 8:28 AM, Grant Smith work.gr...@gmail.com wrote: Scott - I haven't added the Portlet Bridge yet. I got a bit confused as to which the current branch is, and what the supporting dependencies were. Actually, we could do with a Wiki page summarizing where the current development is on ALL of our projects, and what the SVN URL is for each. It's really confusing. On Thu, Aug 26, 2010 at 5:38 AM, Matthias Wessendorf mat...@apache.orgwrote: nope, it's your apache user id + ldap password (same you are using for svn) -M On Thu, Aug 26, 2010 at 2:19 PM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, did you send me my account info? I didn't see it? Sent from my iPhone On Aug 25, 2010, at 1:31 PM, Matthias Wessendorf mat...@apache.org wrote: pretty cool stuff. Interesting option on the Apache configuration: We could also use Harmony to build our stuff :-) -Matthias On Wed, Aug 25, 2010 at 9:11 PM, Gerhard gerhard.petra...@gmail.com wrote: hi grant, it's great that you looked for the myfaces view. for the others: i created it to group all our build-jobs - see [1]. regards, gerhard [1] https://hudson.apache.org/hudson/view/MyFaces/ http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Grant Smith work.gr...@gmail.com OK, I have added a whole lot of builds. Currently testing them. All under the Myfaces view. Next I need to figure out how to copy the artifacts to the nightly builds area... On Wed, Aug 25, 2010 at 7:33 AM, Gerhard gerhard.petra...@gmail.com wrote: thx, regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/8/25 Matthias Wessendorf mat...@apache.org Also, I added: -Leo -Werner -Gerhard -Matthias On Wed, Aug 25, 2010 at 9:27 AM, Matthias Wessendorf mat...@apache.org wrote: done -M On Wed, Aug 25, 2010 at 9:22 AM, Scott O'Bryan darkar...@gmail.com wrote: Hey Matthias, can you add me to this? I'd be willing to try the bridge stuff. Continuum has proven fairly unreliable for us. Sent from my iPhone On Aug 25, 2010, at 1:19 AM, Matthias Wessendorf mat...@apache.org wrote: Thanks Bernd! Right now the following committers have been added: -Bernd Bohmann -Grant Smith -Matthias Wessendorf -M On Wed, Aug 25, 2010 at 8:20 AM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello for trying hudson instead of continuum you need a hudson account. You can ask matthias for adding you to the hudson-jobadmin group on people.apache.org modify_appgroups.pl hudson-jobadmin --add=your apache username see: http://wiki.apache.org/general/Hudson#How_do_I_get_an_account for recommended or mandatory settings see: http://wiki.apache.org/general/Hudson#Are_there_recommended_or_mandatory_Hudson_settings_for_ASF_projects.3F Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC.
[Trinidad] Nightly Builds... !
Hi, since of yesterday(?) most MyFaces projects are now building on our ASF Hudson machine. The new location for snapshots / nightly builds is now here: https://repository.apache.org/content/repositories/snapshots/org/apache/myfaces/trinidad/ Currently you find: -1.0.13 -1.2.15 -2.0.0.3 (all SNAPSHOT) -M -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
[jira] Created: (TRINIDAD-1895) Issue with UIXIterator visitData implementation
Issue with UIXIterator visitData implementation
---
Key: TRINIDAD-1895
URL: https://issues.apache.org/jira/browse/TRINIDAD-1895
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.0-alpha
Reporter: Kamran Kashanian
Attachments: visitdata.patch
The UIXIterator 'visitData' method is called during 'visitTree' invocation to
visit the stamped children of UIXIterator.
The implementation uses an IndexedRunner/KeyedRunner to loop over all or
some rows and visit the contents of the row. The issue is that the code skips
over direct stamped children of the UIXIterator and instead visits the
grandchildren.
Looks like the code is assuming that direct children of UIXIterator are
unstamped columns (UIXColumn) and should be skipped over during stamping-visit.
This assumption is correct for sub-classes of UIXIterator but not for
UIXIterator. UIXIterator does not have columns.
The visiting logic is already using a NoColumnFacetsVisitContext. So on
invokeVisitCallback, it skips over any columns and visits the column children.
It also handles nested columns.
So the proposal is to change the code in IndexedRunner/KeyedRunner as
follows:
Change this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (kid.getChildCount() 0)
{
for (UIComponent grandKid : kid.getChildren())
{
if (UIXComponent.visitTree(noColumnFacetContext, grandKid,
visitCallback))
{
throw new AbortProcessingException();
}
}
}
}
To this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (UIXComponent.visitTree(noColumnFacetContext, kid, visitCallback))
{
throw new AbortProcessingException();
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1895) Issue with UIXIterator visitData implementation
[
https://issues.apache.org/jira/browse/TRINIDAD-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamran Kashanian updated TRINIDAD-1895:
---
Status: Patch Available (was: Open)
Issue with UIXIterator visitData implementation
---
Key: TRINIDAD-1895
URL: https://issues.apache.org/jira/browse/TRINIDAD-1895
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.0-alpha
Reporter: Kamran Kashanian
Attachments: visitdata.patch
The UIXIterator 'visitData' method is called during 'visitTree' invocation to
visit the stamped children of UIXIterator.
The implementation uses an IndexedRunner/KeyedRunner to loop over all or
some rows and visit the contents of the row. The issue is that the code
skips over direct stamped children of the UIXIterator and instead visits the
grandchildren.
Looks like the code is assuming that direct children of UIXIterator are
unstamped columns (UIXColumn) and should be skipped over during
stamping-visit. This assumption is correct for sub-classes of UIXIterator
but not for UIXIterator. UIXIterator does not have columns.
The visiting logic is already using a NoColumnFacetsVisitContext. So on
invokeVisitCallback, it skips over any columns and visits the column
children. It also handles nested columns.
So the proposal is to change the code in IndexedRunner/KeyedRunner as
follows:
Change this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (kid.getChildCount() 0)
{
for (UIComponent grandKid : kid.getChildren())
{
if (UIXComponent.visitTree(noColumnFacetContext, grandKid,
visitCallback))
{
throw new AbortProcessingException();
}
}
}
}
To this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (UIXComponent.visitTree(noColumnFacetContext, kid,
visitCallback))
{
throw new AbortProcessingException();
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
license file question (attn: Leonardo)
Hi Leo, We are in the process of performing legal reviews for our next beta release, and we found a few license files that you committed a little while back. I missed the commit since there wasn't a JIRA issue. What was the necessity for pulling in these licenses to begin with? We didn't ship previous releases with them as far as I know. Of particular concern is that you included a glassfish license file. This is a problem since its CDDL. Do you recall why you pulled in that license file? Is someone pulling in Glassfish or Mojarra code into Myfaces? The dojo, j4fry and facelets license files are a little more self explanatory since they can be mapped to specific code changes or donations that are well known. Any info you can provide is greatly appreciated. Thanks, Mike
Re: license file question (attn: Leonardo)
Am 26.08.10 22:00, schrieb Michael Concini: Hi Leo, We are in the process of performing legal reviews for our next beta release, and we found a few license files that you committed a little while back. I missed the commit since there wasn't a JIRA issue. What was the necessity for pulling in these licenses to begin with? We didn't ship previous releases with them as far as I know. Of particular concern is that you included a glassfish license file. This is a problem since its CDDL. Do you recall why you pulled in that license file? Is someone pulling in Glassfish or Mojarra code into Myfaces? The dojo, j4fry and facelets license files are a little more self explanatory since they can be mapped to specific code changes or donations that are well known. Any info you can provide is greatly appreciated. Thanks, Mike It also has to be said CDDL as source linking from an ASF point of view is an absolute no go, from an ASF point of view only binary links with CDDL files are allowed. That has been cleared up a while ago. Just to add my 2c :-)
Re: license file question (attn: Leonardo)
Hi That license was copied from tomcat: http://svn.apache.org/repos/asf/tomcat/trunk/java/javax/servlet/resources These ones are required to allow validation of faces-config.xml files. In this case we fall on Category B: Reciprocal Licenses ...The first action that must be taken is that software under the following licenses may only be included in within an Apache product if the inclusion is appropriately labeledhttp://www.apache.org/legal/3party.html#labeling-reciprocity: - CDDL 1.0 http://opensource.org/licenses/cddl1.php - CPL 1.0 http://opensource.org/licenses/cpl1.0.php - EPL 1.0 http://opensource.org/licenses/eclipse-1.0.php - IPL 1.0 http://opensource.org/licenses/ibmpl.php - MPL 1.0 http://opensource.org/licenses/mozilla1.0.php and MPL 1.1http://opensource.org/licenses/mozilla1.1.php - SPL 1.0 ... http://opensource.org/licenses/sunpublic.php For small amounts of source that is directly consumed by the ASF product at runtime in source form, and for which that source is unlikely to be changed anyway (say, by virtue of being specified by a standard), this action is sufficient. An example of this is the web-facesconfig_1_0.dtdhttp://java.sun.com/dtd/web-facesconfig_1_0.dtd, whose inclusion is mandated by the JSR 127: JavaServer Faceshttp://jcp.org/en/jsr/detail?id=127specification See: http://www.apache.org/legal/3party.html Category B: Reciprocal Licenses Note this inclusion is also labeled on myfaces impl NOTICE.txt: *... This product includes software developed by: The Apache Software Foundation (http://www.apache.org/). See the file LICENSE.txt See licenses for accompanying products in the /licenses subdirectory. This software also includes code from Facelets ( https://facelets.dev.java.net/) for the purpose of implementing Facelets PDL for JSF 2.0 support. This product includes schema files developed for the Glassfish Java EE reference implementation (http://java.sun.com/xml/ns/j2ee/). Apache Myfaces elects to include this software in this distribution under the CDDL license. You can obtain a copy of the License at: https://glassfish.dev.java.net/public/CDDL+GPL.html The source code is available at: https://glassfish.dev.java.net/source/browse/glassfish/ The following schemas are included: === javaee_5.xsd javaee_web_services_client_1_2.xsd === ... *regards, Leonardo Uribe 2010/8/26 Werner Punz werner.p...@gmail.com Am 26.08.10 22:00, schrieb Michael Concini: Hi Leo, We are in the process of performing legal reviews for our next beta release, and we found a few license files that you committed a little while back. I missed the commit since there wasn't a JIRA issue. What was the necessity for pulling in these licenses to begin with? We didn't ship previous releases with them as far as I know. Of particular concern is that you included a glassfish license file. This is a problem since its CDDL. Do you recall why you pulled in that license file? Is someone pulling in Glassfish or Mojarra code into Myfaces? The dojo, j4fry and facelets license files are a little more self explanatory since they can be mapped to specific code changes or donations that are well known. Any info you can provide is greatly appreciated. Thanks, Mike It also has to be said CDDL as source linking from an ASF point of view is an absolute no go, from an ASF point of view only binary links with CDDL files are allowed. That has been cleared up a while ago. Just to add my 2c :-)
[jira] Updated: (TRINIDAD-1893) trh:tablelayout not a layout table in screen reader mode
[ https://issues.apache.org/jira/browse/TRINIDAD-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Cooper updated TRINIDAD-1893: -- Status: Resolved (was: Patch Available) Fix Version/s: 2.0.0.2-core Resolution: Fixed trh:tablelayout not a layout table in screen reader mode Key: TRINIDAD-1893 URL: https://issues.apache.org/jira/browse/TRINIDAD-1893 Project: MyFaces Trinidad Issue Type: Bug Reporter: Dave Robinson Assignee: Matt Cooper Fix For: 2.0.0.2-core Attachments: TRINIDAD-1893 1.2.12.3-branch.patch, TRINIDAD-1893 trunk.patch trh:tableLayout should be identified as a layout table (having role=presentation) when it is rendered in screen reader mode. TableLayoutRenderer currently calls the OutputUtils.renderDataTableAttributes method to render its table, and does not get this role assignment. The TableLayoutRenderer should be updated to call the OutputUtils.renderLayoutTableAttributes method instead, so it will get the role assignment. I'll create and upload a patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: hud...@myfaces
Hi Matthias, Can you please add an account for me too? I'd like to check the current20 build. Thanks! Jakob 2010/8/25 Matthias Wessendorf mat...@apache.org Thanks Bernd! Right now the following committers have been added: -Bernd Bohmann -Grant Smith -Matthias Wessendorf -M On Wed, Aug 25, 2010 at 8:20 AM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello for trying hudson instead of continuum you need a hudson account. You can ask matthias for adding you to the hudson-jobadmin group on people.apache.org modify_appgroups.pl hudson-jobadmin --add=your apache username see: http://wiki.apache.org/general/Hudson#How_do_I_get_an_account for recommended or mandatory settings see: http://wiki.apache.org/general/Hudson#Are_there_recommended_or_mandatory_Hudson_settings_for_ASF_projects.3F Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: hud...@myfaces
Leo, At the time I changed this shared-trunk pointed to shared 2.0.x. Later this was changed so that shared-trunk points to 4.0.x (committed by user lu4242 on revision 943327, see [1]), that's why the svn-external on current is wrong, because no-one changed this on current! Furthermore I changed this, because we have 3 folders: current, current12 and current20. With those 3 it should IMHO be JSF 1.1 on current, JSF 1.2 on current12 and JSF 2.0 on current20. However I agree that introducing a current11 folder and putting current11, current12 and current20 into the current folder would be a better option! Regards, Jakob [1] http://www.svnsearch.org/svnsearch/repos/ASF/search?from=943327to=943327 2010/8/26 Leonardo Uribe lu4...@gmail.com Hi 2010/8/26 Grant Smith work.gr...@gmail.com I also have not added the GSOC build yet, I'll do that once I figure out why myfaces-current isnt compiling (looks like a dependency to shared-impl-2.0.12-SNAPSHOT, which for some reason is not incorporating automatically from the externs. The externs are probably wrong) Yes, current folder points to shared 4.0.x but on core it points to 1.1.x ? The last time I saw that it was not working in that way. I see the following comment on the svn log by user jakobk: ...Changed core version to 1.1.x in current, because current includes shared 2.0.x and not shared 4.0.x which is needed for core 2.0 (core 2.0 can be found in current20) Current should point to myfaces core trunk (2.0.x) and myfaces shared trunk (4.0.x). It is possible orchestra could introduce a dependency to shared 2.0.x. So to solve this problem we should include on nightly build current11 and current12 folders (maybe current should point to current11, current12 and current20?). regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: hud...@myfaces
Hi Jakob 2010/8/26 Jakob Korherr jakob.korh...@gmail.com Leo, At the time I changed this shared-trunk pointed to shared 2.0.x. Later this was changed so that shared-trunk points to 4.0.x (committed by user lu4242 on revision 943327, see [1]), that's why the svn-external on current is wrong, because no-one changed this on current! Ok, I see Furthermore I changed this, because we have 3 folders: current, current12 and current20. With those 3 it should IMHO be JSF 1.1 on current, JSF 1.2 on current12 and JSF 2.0 on current20. However I agree that introducing a current11 folder and putting current11, current12 and current20 into the current folder would be a better option! Ok, I'm going to try configure a new job in hudson for current11. Thanks for the info. regards, Leonardo Regards, Jakob [1] http://www.svnsearch.org/svnsearch/repos/ASF/search?from=943327to=943327 2010/8/26 Leonardo Uribe lu4...@gmail.com Hi 2010/8/26 Grant Smith work.gr...@gmail.com I also have not added the GSOC build yet, I'll do that once I figure out why myfaces-current isnt compiling (looks like a dependency to shared-impl-2.0.12-SNAPSHOT, which for some reason is not incorporating automatically from the externs. The externs are probably wrong) Yes, current folder points to shared 4.0.x but on core it points to 1.1.x ? The last time I saw that it was not working in that way. I see the following comment on the svn log by user jakobk: ...Changed core version to 1.1.x in current, because current includes shared 2.0.x and not shared 4.0.x which is needed for core 2.0 (core 2.0 can be found in current20) Current should point to myfaces core trunk (2.0.x) and myfaces shared trunk (4.0.x). It is possible orchestra could introduce a dependency to shared 2.0.x. So to solve this problem we should include on nightly build current11 and current12 folders (maybe current should point to current11, current12 and current20?). regards, Leonardo Uribe -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
[jira] Created: (PORTLETBRIDGE-167) Portlet 2.0 Bridge: update impl to support spec change for config of defaultRenderKitId
Portlet 2.0 Bridge: update impl to support spec change for config of defaultRenderKitId --- Key: PORTLETBRIDGE-167 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-167 Project: MyFaces Portlet Bridge Issue Type: Bug Components: Impl Affects Versions: 2.0.0-beta Reporter: Michael Freedman Assignee: Michael Freedman Spec was recently updated to define support for ability of GFP to read a portlet init parameter (javax.portlet.faces.defaultrenderKitId). And as a side effect add a new public method getDefaultRenderKitId(). The GFP init() calls this method (which by default reads from the portlet.xml init param) and sets a portlet context attribute (namespaced by the portlet) so the bridge will know to override any default in the faces-config.xml. The bridge is then supposed to recognize this context attribute and on every request (if it exists) to expose the ResposneStateManger.RENDER_KIT_ID_PARAM as a parameter in the ExternalContexts param maps with the provided value. This is only done if the request doesn't already contain this parameter. Anyway -- need to update the GFP/ExternalContextImpl/Bridge impl to support this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PORTLETBRIDGE-167) Portlet 2.0 Bridge: update impl to support spec change for config of defaultRenderKitId
[ https://issues.apache.org/jira/browse/PORTLETBRIDGE-167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Freedman resolved PORTLETBRIDGE-167. Fix Version/s: 2.0.0-beta Resolution: Fixed Added the implementation Portlet 2.0 Bridge: update impl to support spec change for config of defaultRenderKitId --- Key: PORTLETBRIDGE-167 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-167 Project: MyFaces Portlet Bridge Issue Type: Bug Components: Impl Affects Versions: 2.0.0-beta Reporter: Michael Freedman Assignee: Michael Freedman Fix For: 2.0.0-beta Spec was recently updated to define support for ability of GFP to read a portlet init parameter (javax.portlet.faces.defaultrenderKitId). And as a side effect add a new public method getDefaultRenderKitId(). The GFP init() calls this method (which by default reads from the portlet.xml init param) and sets a portlet context attribute (namespaced by the portlet) so the bridge will know to override any default in the faces-config.xml. The bridge is then supposed to recognize this context attribute and on every request (if it exists) to expose the ResposneStateManger.RENDER_KIT_ID_PARAM as a parameter in the ExternalContexts param maps with the provided value. This is only done if the request doesn't already contain this parameter. Anyway -- need to update the GFP/ExternalContextImpl/Bridge impl to support this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (TRINIDAD-1895) Issue with UIXIterator visitData implementation
[
https://issues.apache.org/jira/browse/TRINIDAD-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Cooper updated TRINIDAD-1895:
--
Status: Resolved (was: Patch Available)
Fix Version/s: 2.0.0.2-core
Resolution: Fixed
Issue with UIXIterator visitData implementation
---
Key: TRINIDAD-1895
URL: https://issues.apache.org/jira/browse/TRINIDAD-1895
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.0-alpha
Reporter: Kamran Kashanian
Assignee: Matt Cooper
Fix For: 2.0.0.2-core
Attachments: visitdata.patch
The UIXIterator 'visitData' method is called during 'visitTree' invocation to
visit the stamped children of UIXIterator.
The implementation uses an IndexedRunner/KeyedRunner to loop over all or
some rows and visit the contents of the row. The issue is that the code
skips over direct stamped children of the UIXIterator and instead visits the
grandchildren.
Looks like the code is assuming that direct children of UIXIterator are
unstamped columns (UIXColumn) and should be skipped over during
stamping-visit. This assumption is correct for sub-classes of UIXIterator
but not for UIXIterator. UIXIterator does not have columns.
The visiting logic is already using a NoColumnFacetsVisitContext. So on
invokeVisitCallback, it skips over any columns and visits the column
children. It also handles nested columns.
So the proposal is to change the code in IndexedRunner/KeyedRunner as
follows:
Change this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (kid.getChildCount() 0)
{
for (UIComponent grandKid : kid.getChildren())
{
if (UIXComponent.visitTree(noColumnFacetContext, grandKid,
visitCallback))
{
throw new AbortProcessingException();
}
}
}
}
To this:
@Override
protected void process(UIComponent kid, ComponentProcessingContext
cpContext)
{
if (UIXComponent.visitTree(noColumnFacetContext, kid,
visitCallback))
{
throw new AbortProcessingException();
}
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (TRINIDAD-1896) in some cases custom hints not available for number converter
in some cases custom hints not available for number converter - Key: TRINIDAD-1896 URL: https://issues.apache.org/jira/browse/TRINIDAD-1896 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 2.0.0-alpha-2 Reporter: Gabrielle Crawford The fix for this issue wasn't quite right, it's not sending down any client converter when it's not a type that can be converted on the client. https://issues.apache.org/jira/browse/TRINIDAD-1683 When you can't convert on the client, you still need to send down the converter so that the custom hints will be sent down. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
