Re: Result (was: [VOTE] release for myfaces core 2.0.3)
Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe
Re: [VOTE] Trinidad core: 1.0.13
3 Months on and still no 1.0.13. the 1.2 branch also hasn't moved of 1.2.13. Is Trinidad dead? -- View this message in context: http://old.nabble.com/-VOTE--Trinidad-core%3A-1.0.13-tp29661082p30479925.html Sent from the My Faces - Dev mailing list archive at Nabble.com.
Re: [VOTE] Trinidad core: 1.0.13
Well, this vote was canceled: http://permalink.gmane.org/gmane.comp.jakarta.myfaces.devel/46418 However, there was a recent vote on 1.0.13, and almost nobody did bother to vote. Afterwards we discussed what's happening with Trinidad 1.0.x and decided that there will be re-vote which is the LAST release of Trinidad 1.0.x Trinidad 1.2. and 2.0. still owe the community another release, yes. (there are folks committing stuff, but we haven't done the voting and release preparation yet) -Matthias On Fri, Dec 17, 2010 at 12:07 PM, Paul Mander paul.s.man...@gmail.com wrote: 3 Months on and still no 1.0.13. the 1.2 branch also hasn't moved of 1.2.13. Is Trinidad dead? -- View this message in context: http://old.nabble.com/-VOTE--Trinidad-core%3A-1.0.13-tp29661082p30479925.html Sent from the My Faces - Dev mailing list archive at Nabble.com. -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punz werner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorf mat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punz werner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
yes +1, maybe do just stabilising in the next few weeks and postpone all new features / performance tuning after this 2.0.4 release. LieGrue, strub --- On Fri, 12/17/10, Jakob Korherr jakob.korh...@gmail.com wrote: From: Jakob Korherr jakob.korh...@gmail.com Subject: Re: Result (was: [VOTE] release for myfaces core 2.0.3) To: MyFaces Development dev@myfaces.apache.org Date: Friday, December 17, 2010, 12:28 PM IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorf mat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punz werner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: problems with f:viewParam in myfaces-2.0.3
Hi Leo, all! After setting up 2 parallel debugging systems with an internal released 2.0.2-tiss-1 (from ~3 weeks before 2.0.2 went final) and the latest trunk, I figured that the problem is in restoring the old viewParams from the ViewRoot ViewMetadata #46 UIComponent metadataFacet = root.getFacet (UIViewRoot.METADATA_FACET_NAME); returns null in 2.0.3, whereas I got the correctly filled metadataFacet back in 2.0.2 (containing my UIViewParameter as children). LieGrue, strub --- On Thu, 12/16/10, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: problems with f:viewParam in myfaces-2.0.3 To: MyFaces Development dev@myfaces.apache.org Date: Thursday, December 16, 2010, 11:27 PM Hi Mark I think the change you are looking for is MYFACES-2985 Viewscoped bean does not get destroyed when navigating with faces-redirect to a non-jsf-page. regards, Leonardo Uribe 2010/12/16 Mark Struberg strub...@yahoo.de oki, a bit more information: this happens with @ViewScoped beans (which use the JSF ViewMap). Maybe the ViewMap gets cleaned too early in the NavigationHandlerImpl? LieGrue, strub --- On Thu, 12/16/10, Mark Struberg strub...@yahoo.de wrote: From: Mark Struberg strub...@yahoo.de Subject: problems with f:viewParam in myfaces-2.0.3 To: dev@myfaces.apache.org Date: Thursday, December 16, 2010, 8:41 PM hi! I experience a problem with f:viewParam if destinationPage.xhtml?faces-redirect=trueincludeViewParams=true gets returned in an action. Die anything in this area got changed lately? Would make it easier for me to dig into the problem... LieGrue, strub
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
Ok +1 we can do that, the new release infrastructure really is cheap for rolling a release. Werner Am 17.12.10 14:07, schrieb Mark Struberg: yes +1, maybe do just stabilising in the next few weeks and postpone all new features / performance tuning after this 2.0.4 release. LieGrue, strub --- On Fri, 12/17/10, Jakob Korherrjakob.korh...@gmail.com wrote: From: Jakob Korherrjakob.korh...@gmail.com Subject: Re: Result (was: [VOTE] release for myfaces core 2.0.3) To: MyFaces Developmentdev@myfaces.apache.org Date: Friday, December 17, 2010, 12:28 PM IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorfmat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punzwerner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
[jira] Commented: (TOBAGO-953) f:selectItem itemValue= itemLabel=All / item no longer NULL
[
https://issues.apache.org/jira/browse/TOBAGO-953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972504#action_12972504
]
Guido Dubois commented on TOBAGO-953:
-
I'm thinking about going back to version 1.0.32 because in this state version
1.5.0 (alpha-2) is unuseable...
f:selectItem itemValue= itemLabel=All / item no longer NULL
-
Key: TOBAGO-953
URL: https://issues.apache.org/jira/browse/TOBAGO-953
Project: MyFaces Tobago
Issue Type: Bug
Components: Core
Affects Versions: 1.5.0-alpha-2
Environment: Facelets
Reporter: Guido Dubois
The value of tx:selectOneChoice gets 0 selecting the first item... The
first select item has to return NULL. In version 1.0.x this behaviour works
correctly...
tx:selectOneChoice
value=#{tableofproductsController.filterSelectedNorm}
label=#{bundle.popupFilterNormFilter} labelWidth=225px
f:selectItem itemValue= itemLabel=#{bundle.itemAll} /
f:selectItems
value=#{tableofproductsController.filterNormSelectItems} /
/tx:selectOneChoice
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.3, 2.0.2 Reporter: Mark Struberg This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: problems with f:viewParam in myfaces-2.0.3
Hi, see MYFACES-3002 for details! Regards, Jakob 2010/12/17 Mark Struberg strub...@yahoo.de: Hi Leo, all! After setting up 2 parallel debugging systems with an internal released 2.0.2-tiss-1 (from ~3 weeks before 2.0.2 went final) and the latest trunk, I figured that the problem is in restoring the old viewParams from the ViewRoot ViewMetadata #46 UIComponent metadataFacet = root.getFacet (UIViewRoot.METADATA_FACET_NAME); returns null in 2.0.3, whereas I got the correctly filled metadataFacet back in 2.0.2 (containing my UIViewParameter as children). LieGrue, strub --- On Thu, 12/16/10, Leonardo Uribe lu4...@gmail.com wrote: From: Leonardo Uribe lu4...@gmail.com Subject: Re: problems with f:viewParam in myfaces-2.0.3 To: MyFaces Development dev@myfaces.apache.org Date: Thursday, December 16, 2010, 11:27 PM Hi Mark I think the change you are looking for is MYFACES-2985 Viewscoped bean does not get destroyed when navigating with faces-redirect to a non-jsf-page. regards, Leonardo Uribe 2010/12/16 Mark Struberg strub...@yahoo.de oki, a bit more information: this happens with @ViewScoped beans (which use the JSF ViewMap). Maybe the ViewMap gets cleaned too early in the NavigationHandlerImpl? LieGrue, strub --- On Thu, 12/16/10, Mark Struberg strub...@yahoo.de wrote: From: Mark Struberg strub...@yahoo.de Subject: problems with f:viewParam in myfaces-2.0.3 To: dev@myfaces.apache.org Date: Thursday, December 16, 2010, 8:41 PM hi! I experience a problem with f:viewParam if destinationPage.xhtml?faces-redirect=trueincludeViewParams=true gets returned in an action. Die anything in this area got changed lately? Would make it easier for me to dig into the problem... LieGrue, strub -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
Hi +1 on release in January. regards, Leonardo 2010/12/17 Werner Punz werner.p...@gmail.com Ok +1 we can do that, the new release infrastructure really is cheap for rolling a release. Werner Am 17.12.10 14:07, schrieb Mark Struberg: yes +1, maybe do just stabilising in the next few weeks and postpone all new features / performance tuning after this 2.0.4 release. LieGrue, strub --- On Fri, 12/17/10, Jakob Korherrjakob.korh...@gmail.com wrote: From: Jakob Korherrjakob.korh...@gmail.com Subject: Re: Result (was: [VOTE] release for myfaces core 2.0.3) To: MyFaces Developmentdev@myfaces.apache.org Date: Friday, December 17, 2010, 12:28 PM IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorfmat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punzwerner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
+1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/12/17 Leonardo Uribe lu4...@gmail.com Hi +1 on release in January. regards, Leonardo 2010/12/17 Werner Punz werner.p...@gmail.com Ok +1 we can do that, the new release infrastructure really is cheap for rolling a release. Werner Am 17.12.10 14:07, schrieb Mark Struberg: yes +1, maybe do just stabilising in the next few weeks and postpone all new features / performance tuning after this 2.0.4 release. LieGrue, strub --- On Fri, 12/17/10, Jakob Korherrjakob.korh...@gmail.com wrote: From: Jakob Korherrjakob.korh...@gmail.com Subject: Re: Result (was: [VOTE] release for myfaces core 2.0.3) To: MyFaces Developmentdev@myfaces.apache.org Date: Friday, December 17, 2010, 12:28 PM IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorfmat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punzwerner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[
https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972563#action_12972563
]
Jakob Korherr commented on MYFACES-3002:
The code committed on MYFACES-2774 causes the f:metadata facet beeing removed
from UIViewRoot on vdl.buildView(), because
FaceletViewDeclarationLanguage.isBuildingViewMetadata(ctx.getFacesContext()) is
false and thus f:metadata is not processed in DefaultFacelet.apply(). As a
result of this, myFaceletContext.finalizeForDeletion(parent); removes the
f:metadata facet and all metadata information (including view-parameters) is
lost.
Unfortunately this has a lot of side effects. Apart from the problems Mark is
having, very basic examples do not work any more since MYFACES-2774 (which is
actually funny, because no-one discovered it for months...).
For example if you have a f:viewParam which stores its value in a
@RequestScoped managed bean (e.g. #{requestBean.input}} you will loose the
value of the view-parameter immediatly when doing a post-back, because its
value is 1) never stored in the state and 2) wouldn't even get picked up if it
was in the state.
This means in MyFaces core 2.0.2 and 2.0.3 view-parameters rely on the fact
that their value is still available from the model in the next request. If it
is not available in the model in the next request (e.g. when using a
@RequestScoped managed bean), it will be lost.
FaceletComponsitionContextImpl drops viewParams
---
Key: MYFACES-3002
URL: https://issues.apache.org/jira/browse/MYFACES-3002
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.2, 2.0.3
Reporter: Mark Struberg
Assignee: Jakob Korherr
This is related to MYFACES-2774
FaceletComponsitionContextImpl#finalizeForDeletion drops the
'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old'
viewParams are not available for propagation to the next view anymore.
This situation happens if an action returns something like
return nextPage.xhtml??faces-redirect=trueincludeViewParams=true;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972571#action_12972571 ] Leonardo Uribe commented on MYFACES-3002: - I don't think this one is related to the changes done on MYFACES-2774. Instead, I think this one is an use case not considered. Could you provide an example for this one, so I can check it and see how we can solve it? FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972581#action_12972581 ] Mark Struberg commented on MYFACES-3002: It most probably is, because our internally released version is from 29. august 2010 and 2.0.2 already crashed for me (and had a few other bugs which got fixed in the meantime too). I debugged into it and the problem is really that FaceletCompositionContextImpl#finalizeForDeletion() drops the javax_faces_metadata from the ViewRoots _facetMap. After that the viewParam information from the restoreView phase is gone... FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972596#action_12972596 ] Jakob Korherr commented on MYFACES-3002: IMHO (and after a lot of debugging) it really comes from MYFACES-2774. However, I commited an example that shows this issue to the test-webapp (viewparam.xhtml). Instructions are included. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972629#action_12972629 ] Leonardo Uribe commented on MYFACES-3002: - I committed an alternative fix. I'm still not convinced about this issue is related to MYFACES-2774, because there is only circunstancial evidence. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972645#action_12972645 ] Mark Struberg commented on MYFACES-3002: sorry Leo, your commit breaks the behaviour again. You can simply check this with the test application Jakob did provide. It now also crashes again in my real world project. But I agree that there might be better ways to solve that than the quick-fix. So I'll revert your patch and go with that for now. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Re: Result (was: [VOTE] release for myfaces core 2.0.3)
+1 on a bugfix release in January /JK On 17 Dec 2010 18:08, Gerhard gerhard.petra...@gmail.com wrote: +1 regards, gerhard http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces 2010/12/17 Leonardo Uribe lu4...@gmail.com Hi +1 on release in January. regards, Leonardo 2010/12/17 Werner Punz werner.p...@gmail.com Ok +1 we can do that, the new release infrastructure really is cheap for rolling a release. Werner Am 17.12.10 14:07, schrieb Mark Struberg: yes +1, maybe do just stabilising in the next few weeks and postpone all new features / performance tuning after this 2.0.4 release. LieGrue, strub --- On Fri, 12/17/10, Jakob Korherrjakob.korh...@gmail.com wrote: From: Jakob Korherrjakob.korh...@gmail.com Subject: Re: Result (was: [VOTE] release for myfaces core 2.0.3) To: MyFaces Developmentdev@myfaces.apache.org Date: Friday, December 17, 2010, 12:28 PM IMO we can have 2.0.4 out early January +1 on that. We should roll out the 2.0.3 release, because we already have a pretty big gap between 2.0.2 and 2.0.3. Regards, Jakob 2010/12/17 Matthias Wessendorfmat...@apache.org: with the new infrastructure, votes/releases are cheap. release often, release early... IMO we can have 2.0.4 out early January On Fri, Dec 17, 2010 at 11:03 AM, Werner Punzwerner.p...@gmail.com wrote: Hi Leo, I know the vote has passed but is the problem Marc Encountered with f:viewParams not serious enough to stop the release and redo another vote after it is fixed? Sorry to intercept here, but I think we should not do a release until this is cleared up especially since 2.0.2 was not affected by it. Werner Am 17.12.10 04:10, schrieb Leonardo Uribe: Hi Thanks to all people who vote We have 9 +1 Grant Smith Jakob Korherr Werner Punz Mark Struberg Bruno Aranda Jan-Kees van Andel Gerhard Petracek Matthias Wessendorf Leonardo Uribe so we can continue with the necessary steps to release myfaces core 2.0.3 regards, Leonardo Uribe -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972650#action_12972650 ] Leonardo Uribe commented on MYFACES-3002: - I checked it and the test Jakob provide works correctly. I commit a variant to check the case with redirect: return viewparam.xhtml?faces-redirect=trueincludeViewParams=true; It works, I don't see any problem. The idea is simple: just let the algorithm be executed on build view time form tags inside f:metadata, and handle f:event because it is an special case. Note Jakob provided a JUnit test for this one, so if there is something wrong, that test should fail and prevent myfaces from compile. It could be good if you can check if you are using the latest myfaces version from trunk. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972651#action_12972651 ] Mark Struberg commented on MYFACES-3002: yup I always compile it myself. now I need to check why the test works and my real world app crashes... But it definitly crashes currently. Will give your new version a try now. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972662#action_12972662 ] Mark Struberg commented on MYFACES-3002: Leo, I don't see any new commit still. Jakobs sample is a standalone webapp and not a junit test afaik... Please start it manually - txs. FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972665#action_12972665 ] Mark Struberg commented on MYFACES-3002: btw, the whole sample project is not really well placed under current20 (which is usually only a svn link ref collection) and the repository section to java.net should also be avoided FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[
https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972670#action_12972670
]
Leonardo Uribe commented on MYFACES-3002:
-
The example is here:
http://svn.apache.org/repos/asf/myfaces/current20/test-webapp/webapp/src/main/webapp/viewparam.xhtml
The latest code has this code:
h:commandButton value=Postback /
h:commandButton value=Postback Redirect
action=#{requestViewParamBean.doRedirect} /
Maybe I should say a variant of the example. The solution proposed is the
same.
FaceletComponsitionContextImpl drops viewParams
---
Key: MYFACES-3002
URL: https://issues.apache.org/jira/browse/MYFACES-3002
Project: MyFaces Core
Issue Type: Bug
Components: JSR-314
Affects Versions: 2.0.2, 2.0.3
Reporter: Mark Struberg
Assignee: Jakob Korherr
Priority: Critical
This is related to MYFACES-2774
FaceletComponsitionContextImpl#finalizeForDeletion drops the
'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old'
viewParams are not available for propagation to the next view anymore.
This situation happens if an action returns something like
return nextPage.xhtml??faces-redirect=trueincludeViewParams=true;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972689#action_12972689 ] Mark Struberg commented on MYFACES-3002: Leo, I've debugged through and it seems that ViewMetadataHandler#apply is not even called for my fragment. Please note that my xhtml consists of ui:composition and the action is in a ui:fragment. This might change the flow? FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3002) FaceletComponsitionContextImpl drops viewParams
[ https://issues.apache.org/jira/browse/MYFACES-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972697#action_12972697 ] Mark Struberg commented on MYFACES-3002: Leo, it seems all work fine if the f:metadata and f:view (which I need to set the proper locale) is on the topmost layer in the view tree. The remaining question is if we should log a big fat warning if the f:view is somewhere deeper in the tree? FaceletComponsitionContextImpl drops viewParams --- Key: MYFACES-3002 URL: https://issues.apache.org/jira/browse/MYFACES-3002 Project: MyFaces Core Issue Type: Bug Components: JSR-314 Affects Versions: 2.0.2, 2.0.3 Reporter: Mark Struberg Assignee: Jakob Korherr Priority: Critical This is related to MYFACES-2774 FaceletComponsitionContextImpl#finalizeForDeletion drops the 'javax_faces_metadata' from the UIViewRoot s _facetMap. Thus all 'old' viewParams are not available for propagation to the next view anymore. This situation happens if an action returns something like return nextPage.xhtml??faces-redirect=trueincludeViewParams=true; -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (MYFACES-3003) Cleanup and refactor poms
Cleanup and refactor poms - Key: MYFACES-3003 URL: https://issues.apache.org/jira/browse/MYFACES-3003 Project: MyFaces Core Issue Type: Task Components: build process Affects Versions: 2.0.3 Reporter: Jakob Korherr Assignee: Jakob Korherr Our pom.xml files grew over time and are on some parts really messy by now. Things which should be changed: - there is no clear structure in the pom files. we should have 4-space indenting, but currently we have 2 and 4-space mixed all over the files. - get rid of javax.* dependencies and use Apache Geronimo specs instead (thus avoiding java.net or jboss repos) - get rid of unused repositories - use dependencyManagement in myfaces-core-project to manage the dependencies of all our modules by version and scope and thus avoiding using multiple versions in different modules - use pluginManagement for plugin versions - check for duplicate definitions (e.g. Apache snapshot repo already comes from apache-parent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (MYFACES-3003) Cleanup and refactor poms
[ https://issues.apache.org/jira/browse/MYFACES-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972717#action_12972717 ] Mark Struberg commented on MYFACES-3003: + use versions-maven-plugin to detect potentially old plugins and 3rd-party jars mvn versions:display-dependency-updates mvn versions:display-plugin-updates Cleanup and refactor poms - Key: MYFACES-3003 URL: https://issues.apache.org/jira/browse/MYFACES-3003 Project: MyFaces Core Issue Type: Task Components: build process Affects Versions: 2.0.3 Reporter: Jakob Korherr Assignee: Jakob Korherr Our pom.xml files grew over time and are on some parts really messy by now. Things which should be changed: - there is no clear structure in the pom files. we should have 4-space indenting, but currently we have 2 and 4-space mixed all over the files. - get rid of javax.* dependencies and use Apache Geronimo specs instead (thus avoiding java.net or jboss repos) - get rid of unused repositories - use dependencyManagement in myfaces-core-project to manage the dependencies of all our modules by version and scope and thus avoiding using multiple versions in different modules - use pluginManagement for plugin versions - check for duplicate definitions (e.g. Apache snapshot repo already comes from apache-parent) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
