[jira] [Created] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Gerhard Petracek (JIRA)
DebugPhaseListener shouldn't be active by default
-

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.1.1, 2.0.7
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor


this phase-listener leads to a different behaviour in project-stage development 
- it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054909#comment-13054909
 ] 

Martin Kočí commented on MYFACES-3187:
--

Is MYFACES-3033 same problem?

 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor

 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Leonardo Uribe (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054912#comment-13054912
 ] 

Leonardo Uribe commented on MYFACES-3187:
-

Probably this is a side effect caused because DebugPhaseListener evaluates EL 
expressions that activates session or makes some scopes behave different. Is it 
the case Gerhard?

 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor

 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054913#comment-13054913
 ] 

Gerhard Petracek edited comment on MYFACES-3187 at 6/25/11 2:47 PM:


there are several possible problems caused by this phase-listener. it depends 
on the additional libs and/or your pages.

@leo:
yes that's ony of the problems.

however, in any case the debug project-stage shouldn't change the behaviour.

  was (Author: gpetracek):
there are several possible problems caused by this phase-listener. it 
depends on the additional libs and/or your pages.
  
 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor

 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054913#comment-13054913
 ] 

Gerhard Petracek commented on MYFACES-3187:
---

there are several possible problems caused by this phase-listener. it depends 
on the additional libs and/or your pages.

 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor

 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054913#comment-13054913
 ] 

Gerhard Petracek edited comment on MYFACES-3187 at 6/25/11 2:48 PM:


there are several possible problems caused by this phase-listener. it depends 
on the additional libs and/or your pages.

@leo:
yes that's one of the problems.

however, in any case the debug project-stage shouldn't change the behaviour.

  was (Author: gpetracek):
there are several possible problems caused by this phase-listener. it 
depends on the additional libs and/or your pages.

@leo:
yes that's ony of the problems.

however, in any case the debug project-stage shouldn't change the behaviour.
  
 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Jakob Korherr
Priority: Minor

 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (MYFACES-3188) NPE in org.apache.myfaces.lifecycle.RenderResponseExecutor.execute

2011-06-25 Thread JIRA
NPE in org.apache.myfaces.lifecycle.RenderResponseExecutor.execute
--

 Key: MYFACES-3188
 URL: https://issues.apache.org/jira/browse/MYFACES-3188
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.8-SNAPSHOT, 2.1.2-SNAPSHOT
Reporter: Martin Kočí
Priority: Minor


Caused by: java.lang.NullPointerException
at 
org.apache.myfaces.lifecycle.RenderResponseExecutor.execute(RenderResponseExecutor.java:60)
at 
org.apache.myfaces.lifecycle.LifecycleImpl.render(LifecycleImpl.java:239)

NPE ocurres in situation:
1) ViewExpiredException
2) Navigate to viewExpired.xhtml in ExpcetionHandler
3) but viewExpired.xhtml does not exists as resource


(In previous situation, navigationHandler should stay on current view (mojarra 
does it) - I'll create separate issue for that.)

improve RenderResponseExecutor: provide useful log instead of cryptic NPE.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (EXTCDI-118) Could not serialize state: org.jboss.weld.bean.ManagedBean

2011-06-25 Thread Thomas Andraschko (JIRA)

[ 
https://issues.apache.org/jira/browse/EXTCDI-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054919#comment-13054919
 ] 

Thomas Andraschko commented on EXTCDI-118:
--

It does not work with Weld 1.1.2-SNAPSHOT! (I don't use codi in this project, i 
just commented this issue to get more information)

 Could not serialize state: org.jboss.weld.bean.ManagedBean
 --

 Key: EXTCDI-118
 URL: https://issues.apache.org/jira/browse/EXTCDI-118
 Project: MyFaces CODI
  Issue Type: Bug
Affects Versions: 0.9.1, 0.9.2
 Environment: JbossAS6Final, MyFaces2, 
 jdk1.6_21, win7 64bit
Reporter: Michael Schuetz
Priority: Minor

 Having MyFaces configured now.
 Getting following error:
 09:58:21,068 INFO  [org.apache.myfaces.util.ExternalSpecifications] MyFaces 
 Unified EL support enabled
 09:58:21,209 INFO  
 [org.apache.catalina.core.ContainerBase.[jboss.web].[localhost].[/myfaces-cdi-1.0.2-SNAPSHOT]]
  No state saving method defined, assuming default server state saving
 09:58:28,820 SCHWERWIEGEND 
 [org.apache.myfaces.view.facelets.DefaultFaceletsStateManagementHelper] 
 Exiting serializeView - Could not serialize state: 
 org.jboss.weld.bean.ManagedBean: java.io.NotSerializableException: 
 org.jboss.weld.bean.ManagedBean
 at 
 java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1156) 
 [:1.6.0_21]
 at 
 java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:326) 
 [:1.6.0_21]
 at 
 java.util.concurrent.ConcurrentHashMap.writeObject(ConcurrentHashMap.java:1246)
  [:1.6.0_21]
 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
 [:1.6.0_21]
 at 
 sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) 
 [:1.6.0_21]
 at 
 sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  [:1.6.0_21]
 at java.lang.reflect.Method.invoke(Method.java:597) [:1.6.0_21]
 at 
 java.io.ObjectStreamClass.invokeWriteObject(ObjectStreamClass.java:945) 
 [:1.6.0_21]
 at 
 java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1461) 
 [:1.6.0_21]
 at 
 java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1392) 
 [:1.6.0_21]
 at 
 java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150) 
 [:1.6.0_21]
 at 
 java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:326) 
 [:1.6.0_21]
 at java.util.HashMap.writeObject(HashMap.java:1001) [:1.6.0_21]
 at sun.reflect.GeneratedMethodAccessor270.invoke(Unknown Source) 
 [:1.6.0_21]

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (MYFACES-3189) NavigationHandler: navigation to non-exixtent view after ViewExpired

2011-06-25 Thread JIRA
NavigationHandler: navigation to non-exixtent view after ViewExpired


 Key: MYFACES-3189
 URL: https://issues.apache.org/jira/browse/MYFACES-3189
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.8-SNAPSHOT, 2.1.2-SNAPSHOT
Reporter: Martin Kočí


see 
http://weblogs.java.net/blog/edburns/archive/2009/09/03/dealing-gracefully-viewexpiredexception-jsf2

If user provides non-existent viewId, NPE occurs: MYFACES-3188

navigation in this situation leads to facesContext.viewRoot = null. I don't 
know what spec says about it but mojarra stays on current view in this case 
(navigate?) - on that view, where VVE is. 

We should also provide a warning about this situation.



--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (MYFACES-3189) NavigationHandler: navigation to nonexistent view after ViewExpired throws NPE

2011-06-25 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MYFACES-3189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054930#comment-13054930
 ] 

Martin Kočí commented on MYFACES-3189:
--

NavigationHandlerImpl.getNavigationCase already provides a info No navigation 
case match for viewId ... but it is not sufficient in this situation because 
it creates a facesMessage - but there is no view for rendering.

 NavigationHandler: navigation to nonexistent view after ViewExpired throws NPE
 --

 Key: MYFACES-3189
 URL: https://issues.apache.org/jira/browse/MYFACES-3189
 Project: MyFaces Core
  Issue Type: Bug
Affects Versions: 2.0.8-SNAPSHOT, 2.1.2-SNAPSHOT
Reporter: Martin Kočí

 see 
 http://weblogs.java.net/blog/edburns/archive/2009/09/03/dealing-gracefully-viewexpiredexception-jsf2
 If user provides nonexistent viewId, NPE occurs: MYFACES-3188
 navigation in this situation leads to facesContext.viewRoot = null. I don't 
 know what spec says about it but mojarra stays on current view in this case 
 (navigate?) - on that view, where VVE is. 
 We should also provide a warning about this situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[core] three issues with ViewExpiredException navigation

2011-06-25 Thread Martin Koci
Hi,

please take a look at:


https://issues.apache.org/jira/browse/MYFACES-3189
https://issues.apache.org/jira/browse/MYFACES-3188
https://issues.apache.org/jira/browse/MYFACES-3105

I'm not very familiar with navigation implementation - I cannot provide
meaningful patches here.


Thanks,


Kočičák



Re: [core] three issues with ViewExpiredException navigation

2011-06-25 Thread Leonardo Uribe
Hi

I have tried to reproduce them without success. I know the navigation code
and everything seems to be correct. Do you have a test case for this one? I
tried the bundled sample from mojarra and it works.

regards,

Leonardo Uribe

2011/6/25 Martin Koci martin.kocicak.k...@gmail.com

 Hi,

 please take a look at:


 https://issues.apache.org/jira/browse/MYFACES-3189
 https://issues.apache.org/jira/browse/MYFACES-3188
 https://issues.apache.org/jira/browse/MYFACES-3105

 I'm not very familiar with navigation implementation - I cannot provide
 meaningful patches here.


 Thanks,


 Kočičák




[jira] [Resolved] (MYFACES-3186) ui:repeat can lose dynamically added grandchild components

2011-06-25 Thread Leonardo Uribe (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYFACES-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe resolved MYFACES-3186.
-

   Resolution: Fixed
Fix Version/s: 2.1.2
   2.0.8
 Assignee: Leonardo Uribe

Thanks for the example. I checked it and it is a problem with 
UIRepeat.invokeOnComponent. It assume child client ids without index should not 
be resolved, but partial state saving needs it, so any programatically added 
component will not be restored. The fix is do something similar to t:dataList 
does.

 ui:repeat can lose dynamically added grandchild components
 --

 Key: MYFACES-3186
 URL: https://issues.apache.org/jira/browse/MYFACES-3186
 Project: MyFaces Core
  Issue Type: Bug
  Components: General
Affects Versions: 2.1.1, 2.1.2-SNAPSHOT
Reporter: Matt Benson
Assignee: Leonardo Uribe
 Fix For: 2.0.8, 2.1.2

 Attachments: MF-3186.tar.gz


 Somewhat complicated to explain... myfaces-extval, for example, can make 
 changes to components by intercepting Renderer.encodeBegin().  My experience 
 is this:
 I have a ui:repeat, in which I nest an h:selectOneMenu.  If I add its child 
 elements using a renderer interceptor approach like that of extval, these are 
 lost after the view is rendered, so that the form submit fails due to the 
 h:selectOneMenu having no selectItems available.  Other h:selectOneMenu 
 components in the tree work properly when I add children in the same way, 
 thus I believe that ui:repeat is where the problem arises.  I am attaching a 
 project demonstrating the situation.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Resolved] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Leonardo Uribe (JIRA)

 [ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Leonardo Uribe resolved MYFACES-3187.
-

   Resolution: Fixed
Fix Version/s: 2.1.2
   2.0.8
 Assignee: Leonardo Uribe  (was: Jakob Korherr)

I remember a discussion with Jakob about this specific problem, and specially 
on make DebugPhaseListener enabled by default. It is true that 
DebugPhaseListener does not cause any problems in most cases, but the fact that 
could break orchestra 'access' scope and other CODI scopes, makes necessary 
disable this by default. There is no viable solution to enable it by default 
and keep code working in all situations, just because there is no way to detect 
when it is valid or not evaluate the expressions. This problem is to annoying 
to let it pass.

 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Leonardo Uribe
Priority: Minor
 Fix For: 2.0.8, 2.1.2


 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (MYFACES-3187) DebugPhaseListener shouldn't be active by default

2011-06-25 Thread Gerhard Petracek (JIRA)

[ 
https://issues.apache.org/jira/browse/MYFACES-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054913#comment-13054913
 ] 

Gerhard Petracek edited comment on MYFACES-3187 at 6/25/11 8:07 PM:


there are several possible problems caused by this phase-listener. it depends 
on the additional libs and/or your pages.

@leo:
yes that's one of the problems.

however, in any case the debug project-stage shouldn't change the behaviour.
e.g. if users set breakpoints to check if a specific getter gets called, they 
shouldn't have to be aware that something like our listener calls it.
they might wonder why the value isn't used even though the getter gets called 
during the request.

  was (Author: gpetracek):
there are several possible problems caused by this phase-listener. it 
depends on the additional libs and/or your pages.

@leo:
yes that's one of the problems.

however, in any case the debug project-stage shouldn't change the behaviour.
  
 DebugPhaseListener shouldn't be active by default
 -

 Key: MYFACES-3187
 URL: https://issues.apache.org/jira/browse/MYFACES-3187
 Project: MyFaces Core
  Issue Type: Improvement
  Components: JSR-314
Affects Versions: 2.0.7, 2.1.1
Reporter: Gerhard Petracek
Assignee: Leonardo Uribe
Priority: Minor
 Fix For: 2.0.8, 2.1.2


 this phase-listener leads to a different behaviour in project-stage 
 development - it shouldn't be active by default

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira