Re: [VOTE] Release Tobago 1.0.39
Here is my +1 Regards Bernd On Thu, Feb 16, 2012 at 7:13 PM, Volker Weber v.we...@inexso.de wrote: +1 Regards, Volker Am 16. Februar 2012 16:46 schrieb Grant Smith work.gr...@gmail.com: +1 On Thu, Feb 16, 2012 at 7:07 AM, Matthias Wessendorf mat...@apache.org wrote: +1 On Tue, Feb 14, 2012 at 8:37 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, I would like to release Tobago 1.0.39. For a detail list please consult the release notes: http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273styleName=Htmlversion=12319455 The version is available at the nexus staging repository. Staging repository: https://repository.apache.org/content/repositories/orgapachemyfaces-231/ The Vote is open for 72h. [ ] +1 [ ] +0 [ ] -1 Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- inexso - information exchange solutions GmbH Ofener Str. 30 | 26121 Oldenburg Tel.: +49 441 219 730 56 | FAX: +49 441 219 730 66 | eMail: volker.we...@inexso.de Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 Geschäftsführer: Stefan Schulte, Michael Terschüren
[RESULT] [VOTE] Release Tobago 1.0.39
The vote has passed with the following results: +1 matzew (binding) grantsmith (binding) weber (binding) bommel (binding) I will proceed with the next steps. Regards, Bernd On Sun, Feb 19, 2012 at 12:36 PM, Bernd Bohmann bernd.bohm...@googlemail.com wrote: Here is my +1 Regards Bernd On Thu, Feb 16, 2012 at 7:13 PM, Volker Weber v.we...@inexso.de wrote: +1 Regards, Volker Am 16. Februar 2012 16:46 schrieb Grant Smith work.gr...@gmail.com: +1 On Thu, Feb 16, 2012 at 7:07 AM, Matthias Wessendorf mat...@apache.org wrote: +1 On Tue, Feb 14, 2012 at 8:37 PM, Bernd Bohmann bernd.bohm...@atanion.com wrote: Hello, I would like to release Tobago 1.0.39. For a detail list please consult the release notes: http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310273styleName=Htmlversion=12319455 The version is available at the nexus staging repository. Staging repository: https://repository.apache.org/content/repositories/orgapachemyfaces-231/ The Vote is open for 72h. [ ] +1 [ ] +0 [ ] -1 Regards Bernd -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf -- Grant Smith - V.P. Information Technology Marathon Computer Systems, LLC. -- inexso - information exchange solutions GmbH Ofener Str. 30 | 26121 Oldenburg Tel.: +49 441 219 730 56 | FAX: +49 441 219 730 66 | eMail: volker.we...@inexso.de Firmensitz: Oldenburg | Amtsgericht Oldenburg HRB 205251 Geschäftsführer: Stefan Schulte, Michael Terschüren
[jira] [Created] (MYFACES-3468) [PERF] Avoid unnecessary _ComponentFacetMap instances
[PERF] Avoid unnecessary _ComponentFacetMap instances - Key: MYFACES-3468 URL: https://issues.apache.org/jira/browse/MYFACES-3468 Project: MyFaces Core Issue Type: New Feature Reporter: Martin Kočí Assignee: Martin Kočí Priority: Trivial this is mostly done with if (component.getFacetCount() 0) check, but few places are not optimized -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3468) [PERF] Avoid unnecessary _ComponentFacetMap instances
[ https://issues.apache.org/jira/browse/MYFACES-3468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Kočí updated MYFACES-3468: - Status: Patch Available (was: Open) [PERF] Avoid unnecessary _ComponentFacetMap instances - Key: MYFACES-3468 URL: https://issues.apache.org/jira/browse/MYFACES-3468 Project: MyFaces Core Issue Type: New Feature Reporter: Martin Kočí Assignee: Martin Kočí Priority: Trivial Attachments: DefaultFacelet.patch, DefaultFaceletsStateManagementStrategy.patch, FaceletCompositionContextImpl.patch, FaceletViewDeclarationLanguage.patch this is mostly done with if (component.getFacetCount() 0) check, but few places are not optimized -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MYFACES-3469) [PERF] Avoid unnecessary AbstractList$Itr instances - do not use java.util.Collections.emptyList()
[PERF] Avoid unnecessary AbstractList$Itr instances - do not use java.util.Collections.emptyList() -- Key: MYFACES-3469 URL: https://issues.apache.org/jira/browse/MYFACES-3469 Project: MyFaces Core Issue Type: Improvement Reporter: Martin Kočí Priority: Trivial java.util.Collections.emptyList() is singleton instance of java.util.Collections.EmptyList class, but this class inherits from java.util.AbstractList and creates new garbage iterator java.util.AbstractList.Itr instance in every foreach loop. It is better to use own singleton instance (similar as google guava has) same for java.util.Collections.emptySet() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MYFACES-3470) [perf] review markCreated, markForDeletion, finalizeForDeletion algorithm
[perf] review markCreated, markForDeletion, finalizeForDeletion algorithm - Key: MYFACES-3470 URL: https://issues.apache.org/jira/browse/MYFACES-3470 Project: MyFaces Core Issue Type: Improvement Reporter: Martin Kočí Priority: Minor Whe using PPS, ComponentTagHandlerDelegate.apply: 1) generates a unique id: String id = ctx.generateUniqueId(_delegate.getTagId()); 2) stores it in component.attributes under key MARK_CREATED c.getAttributes().put(ComponentSupport.MARK_CREATED, id) both steps creates new instances (StringBuilder, HashMap.Entry). But is seems, that this MARK_CREATED is used only in case of RefreshingTransientBuild = true and it is probably not necessary create and store that id for every component. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MYFACES-3471) [PERF] Do not call setRendererType(null) in constructors
[PERF] Do not call setRendererType(null) in constructors Key: MYFACES-3471 URL: https://issues.apache.org/jira/browse/MYFACES-3471 Project: MyFaces Core Issue Type: Improvement Reporter: Martin Kočí Priority: Trivial It initializes StateHelper Map and creates new HashMap$Entry instance for .put(rendererType, null) operation. ComponentResourceContainer HtmlColumn UIDebug UINamingContainer UIPanel UIParameter UISelectItem UISelectItems UIViewParameter UIViewRoot (needs modification of myfaces maven build plugin) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MYFACES-3463) Refactor UIRepeat code to implement PSS algorithm like UIData and fix state behavior
[ https://issues.apache.org/jira/browse/MYFACES-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonardo Uribe updated MYFACES-3463: Status: Patch Available (was: Open) Refactor UIRepeat code to implement PSS algorithm like UIData and fix state behavior Key: MYFACES-3463 URL: https://issues.apache.org/jira/browse/MYFACES-3463 Project: MyFaces Core Issue Type: Improvement Components: JSR-314 Affects Versions: 2.0.12, 2.1.6 Reporter: Leonardo Uribe Assignee: Leonardo Uribe Attachments: MYFACES-3463-1.patch Right now, the code in org.apache.myfaces.view.facelets.component.UIRepeat has not been reviewed more than to fix issues related to JSF 2 spec. It works, but it can be done better. The code has the following opportunities: - Implement PSS algorithm, to prevent store data in the state. - The algorithm used in UIData to handle state is better. - Fix MYFACES-3415 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3463) Refactor UIRepeat code to implement PSS algorithm like UIData and fix state behavior
[ https://issues.apache.org/jira/browse/MYFACES-3463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13211632#comment-13211632 ] Leonardo Uribe commented on MYFACES-3463: - I reviewed the code and created a patch, taking what's necessary from UIData. At the end the code has two differences: - State for rows (rowState) was saved into the state. This is not necessary because the information for EditableValueHolder is usually send to the client and then go back to the server. UIData do that and there is no reason why UIRepeat cannot do it. - The condition for reset model if a validation occur is based only on the messages related to components in UIRepeat. In UIData, the condition is different. To solve MYFACES-3415 it is preferred to do the same as UIData does. Anyway, this should be discussed on the EG, because the condition is not very clear and there is other issue (MYFACES-3326) that suggest this condition should be enhanced. If no objections I'll commit the code soon (on 2.0.x and 2.1.x branches) Refactor UIRepeat code to implement PSS algorithm like UIData and fix state behavior Key: MYFACES-3463 URL: https://issues.apache.org/jira/browse/MYFACES-3463 Project: MyFaces Core Issue Type: Improvement Components: JSR-314 Affects Versions: 2.0.12, 2.1.6 Reporter: Leonardo Uribe Assignee: Leonardo Uribe Attachments: MYFACES-3463-1.patch Right now, the code in org.apache.myfaces.view.facelets.component.UIRepeat has not been reviewed more than to fix issues related to JSF 2 spec. It works, but it can be done better. The code has the following opportunities: - Implement PSS algorithm, to prevent store data in the state. - The algorithm used in UIData to handle state is better. - Fix MYFACES-3415 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MYFACES-3472) NavigationHandler throws a NPE if current viewId is null
NavigationHandler throws a NPE if current viewId is null Key: MYFACES-3472 URL: https://issues.apache.org/jira/browse/MYFACES-3472 Project: MyFaces Core Issue Type: Bug Affects Versions: 2.1.6 Reporter: Marcus Büttner patch attached -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
