[jira] [Resolved] (MYFACES-3619) Define a special property to specify when a component is created by facelets ( oam.vf.addedByHandler )
[
https://issues.apache.org/jira/browse/MYFACES-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe resolved MYFACES-3619.
-
Resolution: Fixed
> Define a special property to specify when a component is created by facelets
> ( oam.vf.addedByHandler )
> ---
>
> Key: MYFACES-3619
> URL: https://issues.apache.org/jira/browse/MYFACES-3619
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
>Reporter: Leonardo Uribe
>Assignee: Leonardo Uribe
> Fix For: 2.0.16, 2.1.10
>
>
> I have notice the need to define a special property or attribute to indicate
> PSS algorithm when a component has been created by facelets. In practice we
> use the following fragment in DefaultFaceletsStateManagementStrategy:
> if (!isRefreshOnTransientBuildPreserveState() &&
>
> FaceletCompositionContext.getCurrentInstance(_facesContext) != null &&
>
> (component.getAttributes().containsKey(ComponentSupport.MARK_CREATED) ||
>
> component.getAttributes().containsKey(ComponentSupport.FACET_CREATED_UIPANEL_MARKER))
> ||
> (component.getId() != null && component.getId().length()
> > 16 &&
>
> component.getId().startsWith(UIViewRoot.UNIQUE_ID_PREFIX) &&
> component.getId().endsWith("__f_cc_facet") )
> )
> It is a complex check for something that should be simple. The idea is reduce
> that to something like this:
> if (!isRefreshOnTransientBuildPreserveState() &&
>
> FaceletCompositionContext.getCurrentInstance(_facesContext) != null &&
>
> (component.getAttributes().containsKey(ComponentSupport.MARK_CREATED) ||
>
> component.getAttributes().containsKey(ComponentSupport.COMPONENT_ADDED_BY_HANDLER_MARKER))
> )
> and create oam.vf.addedByHandler as special facelets attribute just like
> oam.vf.MARK_ID or MARK_CREATED is, to make facelets refreshTransientBuild
> faster.
> It is required to do some changes in some locations, specially when
> ComponentSupport.FACET_CREATED_UIPANEL_MARKER is used, to set that one and
> ComponentSupport.COMPONENT_ADDED_BY_HANDLER_MARKER together. It is not
> conveniento to mix both because both are used in different situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (MYFACES-3619) Define a special property to specify when a component is created by facelets ( oam.vf.addedByHandler )
[
https://issues.apache.org/jira/browse/MYFACES-3619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonardo Uribe reopened MYFACES-3619:
-
Checking some code I notice an small bug introduced in this improvement. In
UIComponentBase.saveState one line should be changed to restore full state
properly. Fortunately the fix is very simple to do, just update one number.
> Define a special property to specify when a component is created by facelets
> ( oam.vf.addedByHandler )
> ---
>
> Key: MYFACES-3619
> URL: https://issues.apache.org/jira/browse/MYFACES-3619
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
>Reporter: Leonardo Uribe
>Assignee: Leonardo Uribe
> Fix For: 2.0.16, 2.1.10
>
>
> I have notice the need to define a special property or attribute to indicate
> PSS algorithm when a component has been created by facelets. In practice we
> use the following fragment in DefaultFaceletsStateManagementStrategy:
> if (!isRefreshOnTransientBuildPreserveState() &&
>
> FaceletCompositionContext.getCurrentInstance(_facesContext) != null &&
>
> (component.getAttributes().containsKey(ComponentSupport.MARK_CREATED) ||
>
> component.getAttributes().containsKey(ComponentSupport.FACET_CREATED_UIPANEL_MARKER))
> ||
> (component.getId() != null && component.getId().length()
> > 16 &&
>
> component.getId().startsWith(UIViewRoot.UNIQUE_ID_PREFIX) &&
> component.getId().endsWith("__f_cc_facet") )
> )
> It is a complex check for something that should be simple. The idea is reduce
> that to something like this:
> if (!isRefreshOnTransientBuildPreserveState() &&
>
> FaceletCompositionContext.getCurrentInstance(_facesContext) != null &&
>
> (component.getAttributes().containsKey(ComponentSupport.MARK_CREATED) ||
>
> component.getAttributes().containsKey(ComponentSupport.COMPONENT_ADDED_BY_HANDLER_MARKER))
> )
> and create oam.vf.addedByHandler as special facelets attribute just like
> oam.vf.MARK_ID or MARK_CREATED is, to make facelets refreshTransientBuild
> faster.
> It is required to do some changes in some locations, specially when
> ComponentSupport.FACET_CREATED_UIPANEL_MARKER is used, to set that one and
> ComponentSupport.COMPONENT_ADDED_BY_HANDLER_MARKER together. It is not
> conveniento to mix both because both are used in different situations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3104) MyFaces 2 with EL 2.2 in Websphere 7
[
https://issues.apache.org/jira/browse/MYFACES-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489711#comment-13489711
]
Jesse Collins commented on MYFACES-3104:
Thank you Mark and Leonardo.
Mark, we do not have any other ResourceHandler registered in my
faces-config.xml but we are using Primefaces which has
org.primefaces.application.PrimeResourceHandler
in its faces-config.xml. But, we were getting the "WARNING: Cannot set
header. Response already committed." message before we started using Primefaces.
I've opened MYFACES-3636 and attached a patch for ResourceHandlerImpl.java
which resolves the "WARNING: Cannot set header. Response already committed."
message issue for us.
> MyFaces 2 with EL 2.2 in Websphere 7
>
>
> Key: MYFACES-3104
> URL: https://issues.apache.org/jira/browse/MYFACES-3104
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
>Affects Versions: 2.0.4
> Environment: WebSphere Platform 7.0.0.13
> Host Operating System is Windows XP, version 5.1 build 2600 Service Pack 3
> Java version = 1.6.0, Java Compiler = j9jit24, Java VM name = IBM J9 VM
> Servlet API : 2.5
> JSP API : 2.1
>Reporter: mansour
> Attachments: MyFacesEL2Sample_was7.zip
>
>
> We have followed your documentation on the wiki in order to enable EL 2.2
> (http://wiki.apache.org/myfaces/HowToEnableEl22), it doesn't work on
> Websphere 7.
> - we have added the 2 jars (el-api-2.2.jar and el-impl-2.2.jar from Glassfish
> implementation) in th classpath of the web application
> - we have configured the web.xml like this :
>
> org.apache.myfaces.EXPRESSION_FACTORY
> com.sun.el.ExpressionFactoryImpl
>
> [...]
>
>
> org.apache.myfaces.webapp.StartupServletContextListener
>
> The web application starts without errors,
> Problem :
> 1) When the web application starts we have this first exception :
> [04/04/11 11:24:39:136 CEST] 000a DefaultFacesC I Reading standard
> config META-INF/standard-faces-config.xml
> [04/04/11 11:24:39:277 CEST] 000a DefaultFacesC I Reading config
> /WEB-INF/faces-config.xml
> [04/04/11 11:24:39:823 CEST] 000a ExternalSpeci I MyFaces Bean
> Validation support disabled
> [04/04/11 11:24:39:855 CEST] 000a ApplicationIm I Couldn't discover the
> current project stage, using Production
> [04/04/11 11:24:39:855 CEST] 000a FacesConfigur I Serialization
> provider : class
> org.apache.myfaces.shared_impl.util.serial.DefaultSerialFactory
> [04/04/11 11:24:39:855 CEST] 000a DefaultLifecy I Using
> LifecycleProvider
> org.apache.myfaces.config.annotation.AllAnnotationLifecycleProvider
> [04/04/11 11:24:39:933 CEST] 000a FfdcProvider W
> com.ibm.ws.ffdc.impl.FfdcProvider logIncident FFDC1003I: Incident FFDC émis
> sur
> C:\IBM\SDP75\runtimes\base_v7\profiles\was70profile2\logs\ffdc\server1_48704870_11.04.04_11.24.39.8706071861720806063404.txt
> com.ibm.ws.webcontainer.webapp.WebApp.notifyServletContextCreated 1341
> [04/04/11 11:24:39:933 CEST] 000a webappE
> com.ibm.ws.webcontainer.webapp.WebApp notifyServletContextCreated SRVE0283E:
> Exception interceptée lors de l''initialisation du contexte : {0}
> java.lang.VerifyError:
> javax/servlet/jsp/JspApplicationContext.addELResolver(Ljavax/el/ELResolver;)V
> at
> org.apache.myfaces.webapp.Jsp21FacesInitializer.configureResolverForJSP(Jsp21FacesInitializer.java:123)
> at
> org.apache.myfaces.webapp.Jsp21FacesInitializer.initContainerIntegration(Jsp21FacesInitializer.java:77)
> at
> org.apache.myfaces.webapp.AbstractFacesInitializer.initFaces(AbstractFacesInitializer.java:126)
> at
> org.apache.myfaces.webapp.StartupServletContextListener.contextInitialized(StartupServletContextListener.java:111)
> at
> com.ibm.ws.webcontainer.webapp.WebApp.notifyServletContextCreated(WebApp.java:1681)
> at
> com.ibm.ws.webcontainer.webapp.WebApp.commonInitializationFinish(WebApp.java:374)
> at
> com.ibm.ws.webcontainer.webapp.WebAppImpl.initialize(WebAppImpl.java:299)
> at
> com.ibm.ws.webcontainer.webapp.WebGroupImpl.addWebApplication(WebGroupImpl.java:100)
> at
> com.ibm.ws.webcontainer.VirtualHostImpl.addWebApplication(VirtualHostImpl.java:166)
> at
> com.ibm.ws.webcontainer.WSWebContainer.addWebApp(WSWebContainer.java:731)
> at
> com.ibm.ws.webcontainer.WSWebContainer.addWebApplication(WSWebContainer.java:616)
> at
> com.ibm.ws.webcontainer.component.WebContainerImpl.install(WebContainerImpl.java:376)
> at
> com.ibm.ws.webcontainer.component.WebContainerImpl.start(WebContainerImpl.java:668)
> at
> com.ibm.ws.runtime.component.Appl
[jira] [Comment Edited] (MYFACES-3636) Add new Web Context Parameter to set Resource Buffer Size
[ https://issues.apache.org/jira/browse/MYFACES-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489701#comment-13489701 ] Jesse Collins edited comment on MYFACES-3636 at 11/2/12 7:57 PM: - When using the patched ResourceHandlerImpl.java with a value for org.apache.myfaces.RESOURCE_BUFFER_SIZE of 32768, the message "WARNING: Cannot set header. Response already committed." is no longer in the logs for WebSphere 7. org.apache.myfaces.RESOURCE_BUFFER_SIZE 32768 was (Author: jessecollins): Using the patched ResourceHandlerImpl.java with a value for org.apache.myfaces.RESOURCE_BUFFER_SIZE of 32768 suppresses the "WARNING: Cannot set header. Response already committed." for WebSphere 7. org.apache.myfaces.RESOURCE_BUFFER_SIZE 32768 > Add new Web Context Parameter to set Resource Buffer Size > - > > Key: MYFACES-3636 > URL: https://issues.apache.org/jira/browse/MYFACES-3636 > Project: MyFaces Core > Issue Type: New Feature > Components: JSR-314 >Affects Versions: 2.0.15 > Environment: WebSphere 7.0.0.17 > Windows XP Pro, SP3, Intel Core 2 Duo CPU 3.00GHz, 4GB RAM and > IBM AIX 6.1.0.0 >Reporter: Jesse Collins >Priority: Minor > Attachments: ResourceHandlerImpl.java > > > Add new Web Context Parameter to set Resource Buffer Size to prevent the > "WARNING: Cannot set header. Response already committed." message for JSF > resources. This message in the log is known to occur on WebSphere 7 but may > also occur on other application servers. > For more information see MYFACES-3104. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3636) Add new Web Context Parameter to set Resource Buffer Size
[ https://issues.apache.org/jira/browse/MYFACES-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489701#comment-13489701 ] Jesse Collins commented on MYFACES-3636: Using the patched ResourceHandlerImpl.java with a value for org.apache.myfaces.RESOURCE_BUFFER_SIZE of 32768 suppresses the "WARNING: Cannot set header. Response already committed." for WebSphere 7. org.apache.myfaces.RESOURCE_BUFFER_SIZE 32768 > Add new Web Context Parameter to set Resource Buffer Size > - > > Key: MYFACES-3636 > URL: https://issues.apache.org/jira/browse/MYFACES-3636 > Project: MyFaces Core > Issue Type: New Feature > Components: JSR-314 >Affects Versions: 2.0.15 > Environment: WebSphere 7.0.0.17 > Windows XP Pro, SP3, Intel Core 2 Duo CPU 3.00GHz, 4GB RAM and > IBM AIX 6.1.0.0 >Reporter: Jesse Collins >Priority: Minor > Attachments: ResourceHandlerImpl.java > > > Add new Web Context Parameter to set Resource Buffer Size to prevent the > "WARNING: Cannot set header. Response already committed." message for JSF > resources. This message in the log is known to occur on WebSphere 7 but may > also occur on other application servers. > For more information see MYFACES-3104. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (MYFACES-3636) Add new Web Context Parameter to set Resource Buffer Size
[ https://issues.apache.org/jira/browse/MYFACES-3636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13489699#comment-13489699 ] Jesse Collins edited comment on MYFACES-3636 at 11/2/12 7:46 PM: - Patch to ResourceHandlerImpl.java has been attached which allows resource buffer size to be specified with Web Context Parameter org.apache.myfaces.RESOURCE_BUFFER_SIZE and defaults to 2048. was (Author: jessecollins): Patch to ResourceHandlerImpl.java which allows resource buffer size to be specified with Web Context Parameter org.apache.myfaces.RESOURCE_BUFFER_SIZE and defaults to 2048. > Add new Web Context Parameter to set Resource Buffer Size > - > > Key: MYFACES-3636 > URL: https://issues.apache.org/jira/browse/MYFACES-3636 > Project: MyFaces Core > Issue Type: New Feature > Components: JSR-314 >Affects Versions: 2.0.15 > Environment: WebSphere 7.0.0.17 > Windows XP Pro, SP3, Intel Core 2 Duo CPU 3.00GHz, 4GB RAM and > IBM AIX 6.1.0.0 >Reporter: Jesse Collins >Priority: Minor > Attachments: ResourceHandlerImpl.java > > > Add new Web Context Parameter to set Resource Buffer Size to prevent the > "WARNING: Cannot set header. Response already committed." message for JSF > resources. This message in the log is known to occur on WebSphere 7 but may > also occur on other application servers. > For more information see MYFACES-3104. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (MYFACES-3636) Add new Web Context Parameter to set Resource Buffer Size
Jesse Collins created MYFACES-3636: -- Summary: Add new Web Context Parameter to set Resource Buffer Size Key: MYFACES-3636 URL: https://issues.apache.org/jira/browse/MYFACES-3636 Project: MyFaces Core Issue Type: New Feature Components: JSR-314 Affects Versions: 2.0.15 Environment: WebSphere 7.0.0.17 Windows XP Pro, SP3, Intel Core 2 Duo CPU 3.00GHz, 4GB RAM and IBM AIX 6.1.0.0 Reporter: Jesse Collins Priority: Minor Add new Web Context Parameter to set Resource Buffer Size to prevent the "WARNING: Cannot set header. Response already committed." message for JSF resources. This message in the log is known to occur on WebSphere 7 but may also occur on other application servers. For more information see MYFACES-3104. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
