[jira] [Created] (TOMAHAWK-1661) dataTable value evaluated if parent component not rendered if preserveDataModel is true
John Smith created TOMAHAWK-1661:
Summary: dataTable value evaluated if parent component not
rendered if preserveDataModel is true
Key: TOMAHAWK-1661
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1661
Project: MyFaces Tomahawk
Issue Type: Bug
Affects Versions: 1.1.14
Reporter: John Smith
If a t:dataTable's parent component's rendered attribute evaluates to false,
the dataTable's value attribute is still evaluated if the dataTable has the
preserveDataModel attribute set to true.
While I don't think this strictly violates the spec (it says under 2.2.6: 'If
the isRendered() method of a component returns false, the renderer for that
component must not generate any markup, and none of its facets or children (if
any) should be rendered.'), it is at the very least inconsistent with other JSF
components, which do not evaluate the value if not rendered
Example:
html xmlns=http://www.w3.org/1999/xhtml;
xmlns:h=http://java.sun.com/jsf/html;
xmlns:t=http://myfaces.apache.org/tomahawk;
h:head /
h:body
h:form
h:panelGroup rendered=false
t:dataTable value=#{bean.list} var=list
preserveDataModel=true
h:column#{list}/h:column
/t:dataTable
/h:panelGroup
/h:form
/h:body
/html
-
@RequestScoped
@ManagedBean
public class Bean {
public ListString getList(){
throw new RuntimeException(this should not be called);
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[VOTE] release of MyFaces Core 2.0.17
Hi, I was running the needed tasks to get the 2.0.17 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.0.17 [1] 2. Maven artifact group org.apache.myfaces.core v2.0.17 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.0.17 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-028/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces2017binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12323554
Re: [VOTE] release of MyFaces Core 2.0.17
+1 2013/3/28 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.0.17 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.0.17 [1] 2. Maven artifact group org.apache.myfaces.core v2.0.17 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.0.17 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-028/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces2017binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12323554
[VOTE] release of MyFaces Core 2.1.11
Hi, I was running the needed tasks to get the 2.1.11 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.1.9 [1] 2. Maven artifact group org.apache.myfaces.core v2.1.11 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.1.11 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-029/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces2111binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12323553
Re: [VOTE] release of MyFaces Core 2.1.11
+1 2013/3/28 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.1.11 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.1.9 [1] 2. Maven artifact group org.apache.myfaces.core v2.1.11 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.1.11 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-029/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces2111binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12323553
Re: [VOTE] release of MyFaces Core 2.0.17
+1 On Thu, Mar 28, 2013 at 6:41 PM, Leonardo Uribe lu4...@gmail.com wrote: +1 2013/3/28 Leonardo Uribe lu4...@gmail.com: Hi, I was running the needed tasks to get the 2.0.17 release of Apache MyFaces core out. The artifacts passed all TCK tests. Please note that this vote concerns all of the following parts: 1. Maven artifact group org.apache.myfaces.shared v4.0.17 [1] 2. Maven artifact group org.apache.myfaces.core v2.0.17 [1] The artifacts were deployed on nexus repo [1] and to my private Apache account [3] for binary and source packages. The release notes could be found at [4]. Also the clirr test does not show binary incompatibilities with myfaces-api. Please take a look at the 2.0.17 artifacts and vote! Please note: This vote is majority approval with a minimum of three +1 votes (see [3]). [ ] +1 for community members who have reviewed the bits [ ] +0 [ ] -1 for fatal flaws that should cause these bits not to be released, and why.. Thanks, Leonardo Uribe [1] https://repository.apache.org/content/repositories/orgapachemyfaces-028/org/apache/myfaces/ [2] http://www.apache.org/foundation/voting.html#ReleaseVotes [3] http://people.apache.org/~lu4242/myfaces2017binsrc [4] https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600version=12323554 -- Hazem Ahmed Saleh Ahmed Author of JavaScript Unit Testing book: http://www.amazon.com/dp/1782160620/ Co-author of (The Definitive Guide to Apache MyFaces and Facelets) book: http://www.amazon.com/-/e/B002M052KY DeveloperWorks Contributing Author https://www.ibm.com/developerworks/mydeveloperworks/blogs/hazem/entry/ibm_developerworks_contributing_author?lang=en_us An Apache committer, IBMer, and a technical speaker Twitter: http://www.twitter.com/hazems
[jira] [Commented] (TOMAHAWK-1661) dataTable value evaluated if parent component not rendered if preserveDataModel is true
[
https://issues.apache.org/jira/browse/TOMAHAWK-1661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616480#comment-13616480
]
Leonardo Uribe commented on TOMAHAWK-1661:
--
preserveDataModel forces save the dataModel into the state, and in that way,
getValue() must be called. There is no way to avoid this, because rendered
attribute has nothing to do with the state saving algorithm.
I can see the logic behind this. If the component is not rendered, there should
not be dataModel to store and in that way getValue() does not need to be
called. Only if there is a dataModel before save state, it has sense to save it.
I think the solution could be check if there is a dataModel and
preserveDataModel is active save it, otherwise do not do nothing.
Thinking about this, I realized that in case of a nested dataTable with
preserveDataModel set to true, it is better that the inner declaration does not
have any effect, because the top level dataModel contains the information of
the inner dataModel too.
dataTable value evaluated if parent component not rendered if
preserveDataModel is true
---
Key: TOMAHAWK-1661
URL: https://issues.apache.org/jira/browse/TOMAHAWK-1661
Project: MyFaces Tomahawk
Issue Type: Bug
Affects Versions: 1.1.14
Reporter: John Smith
If a t:dataTable's parent component's rendered attribute evaluates to false,
the dataTable's value attribute is still evaluated if the dataTable has the
preserveDataModel attribute set to true.
While I don't think this strictly violates the spec (it says under 2.2.6: 'If
the isRendered() method of a component returns false, the renderer for that
component must not generate any markup, and none of its facets or children
(if any) should be rendered.'), it is at the very least inconsistent with
other JSF components, which do not evaluate the value if not rendered
Example:
html xmlns=http://www.w3.org/1999/xhtml;
xmlns:h=http://java.sun.com/jsf/html;
xmlns:t=http://myfaces.apache.org/tomahawk;
h:head /
h:body
h:form
h:panelGroup rendered=false
t:dataTable value=#{bean.list} var=list
preserveDataModel=true
h:column#{list}/h:column
/t:dataTable
/h:panelGroup
/h:form
/h:body
/html
-
@RequestScoped
@ManagedBean
public class Bean {
public ListString getList(){
throw new RuntimeException(this should not be called);
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MYFACES-3704) Unable to find component when deployed on /demo/faces context
[ https://issues.apache.org/jira/browse/MYFACES-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616857#comment-13616857 ] Manfred Riem commented on MYFACES-3704: --- So you want me to file an issue with TomEE? Unable to find component when deployed on /demo/faces context - Key: MYFACES-3704 URL: https://issues.apache.org/jira/browse/MYFACES-3704 Project: MyFaces Core Issue Type: Bug Reporter: Manfred Riem To reproduce: 1. Download http://www.manorrock.com/repo/org/manorrock/faces/org-manorrock-faces-demo/2.1.1.0.0/ 2. Deploy to /demo/faces on Tomcat It throws an exception. It should work. If you need more information please let me know! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (MYFACES-3704) Unable to find component when deployed on /demo/faces context
[ https://issues.apache.org/jira/browse/MYFACES-3704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616857#comment-13616857 ] Manfred Riem edited comment on MYFACES-3704 at 3/29/13 12:03 AM: - So you want me to file an issue with TomEE? I think this is a problem that would require your expertise and the TomEE crowd as well was (Author: mriem): So you want me to file an issue with TomEE? Unable to find component when deployed on /demo/faces context - Key: MYFACES-3704 URL: https://issues.apache.org/jira/browse/MYFACES-3704 Project: MyFaces Core Issue Type: Bug Reporter: Manfred Riem To reproduce: 1. Download http://www.manorrock.com/repo/org/manorrock/faces/org-manorrock-faces-demo/2.1.1.0.0/ 2. Deploy to /demo/faces on Tomcat It throws an exception. It should work. If you need more information please let me know! -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2324) File uploads are very slow
[ https://issues.apache.org/jira/browse/TRINIDAD-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616991#comment-13616991 ] Gabrielle Crawford commented on TRINIDAD-2324: -- 2.0.0.x At revision: 1462377 File uploads are very slow -- Key: TRINIDAD-2324 URL: https://issues.apache.org/jira/browse/TRINIDAD-2324 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 2.0.2-core Reporter: Kentaro Kinebuchi Attachments: TRINIDAD-2324.patch File uploads using the Trinidad File Upload Framework are very slow with uploads typically taking several minutes for files on the order of 100MB. It is substantially slower than FTPing an equivalent file. After profiling the application, most of the sloweness is from inefficiencies in MultipartFormHandler.java. After making a few changes to the method _readline() and also using a BufferedInputStream, the performance was doubled. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2282) In validateLength, a default hintRange message is displayed instead of hintMaximum even when minimum value is not set
[
https://issues.apache.org/jira/browse/TRINIDAD-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617011#comment-13617011
]
Gabrielle Crawford commented on TRINIDAD-2282:
--
2.0.0.x Completed: At revision: 1462382
In validateLength, a default hintRange message is displayed instead of
hintMaximum even when minimum value is not set
-
Key: TRINIDAD-2282
URL: https://issues.apache.org/jira/browse/TRINIDAD-2282
Project: MyFaces Trinidad
Issue Type: Bug
Components: Components
Affects Versions: 2.0.0-beta-2
Environment: JDeveloper 11.1.2.0.0
Reporter: Anshu Jain
Assignee: Scott O'Bryan
Fix For: 2.1.0-core
Attachments: TRINIDAD-2282_2.0.0.x, TrinidadBug2282_2.0.x.patch,
TrinidadBug2282.patch
af:validateLength is used for a input text box. The maximum value is set and
minimum value is not set. Which means by default minimum is 0.
The hintMaximum is set to {0} is maximum allowed and hintRange is set to
{0} is minimum, {1} is maximum
When the user clicks on the the given text box, hintMaximum should be
displayed.
Instead a default message: Enter between 0 and 3 characters. is displayed.
hintMaximum should be displayed in this scenario.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TRINIDAD-2333) When date format is set as Day of Year, only a text (Day of Year) is returned
[ https://issues.apache.org/jira/browse/TRINIDAD-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617013#comment-13617013 ] Gabrielle Crawford commented on TRINIDAD-2333: -- At revision: 1462383 When date format is set as Day of Year, only a text (Day of Year) is returned --- Key: TRINIDAD-2333 URL: https://issues.apache.org/jira/browse/TRINIDAD-2333 Project: MyFaces Trinidad Issue Type: Bug Components: Components Affects Versions: 2.0.0-core, 2.0.1-core Environment: Issue occurs on all platforms Reporter: Anshu Jain Assignee: Gabrielle Crawford Fix For: 2.1.0-core Attachments: TRINIDAD-2333_2.0.0.x, TRINIDAD-2333.patch, TRINIDAD-2333.patch The Trinidad client-side pattern output formatting support for convertDateTime does not have logic for the 'D' character (day in year). If the date format is set to Day of Year for a Date component, whatever date is selected, it is replaced by the text (Day of Year). Actual day of year is not displayed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
